12628 Commits

Author SHA1 Message Date
Tong Mu
c82c399eb7
[DataTable] Hide arrow padding when not sorting (#51667)
* Change onSort and add tests

* Add doc

* Regression test

* Remove if (true)

* Make test clearer

* Clearer comment
2020-03-12 18:20:15 -07:00
Tong Mu
b2d53f60e7
Tap gesture no longer add pointer after resetting (#52450)
* TapGestureRecognizer no longer adds the pointer after it resets.

* Adds an assertion to make sure TapGestureRecognizer.startTrackingPointer is never called when _down is null
2020-03-12 18:19:19 -07:00
Jonah Williams
1e8c4572ec
Revert "[flutter_tools] remove globals in AndroidDevices (#52505)" (#52515)
This reverts commit 1bf9d6f4f75f97aa78488298c1337a7d3787fe84.
2020-03-12 18:14:32 -07:00
Christopher Fujino
14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Dan Field
73b2895ff1
Add errorBuilder to Image widget (#52481) 2020-03-12 16:21:01 -07:00
Jonah Williams
1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson
0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Shi-Hao Hong
183da8f837
[gen_l10n] Fix suppportedLocales list (#52448)
* Fix suppportedLocales list

* Refactor integration tests for gen_l10n tool to catch exceptions
2020-03-12 12:58:13 -07:00
Jonah Williams
d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Dan Field
02769001d3
Android SDK test fixes (#52144) 2020-03-12 10:53:23 -07:00
Finn
9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino
38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Wu Zhong
db6e2061aa
Fixes typo in comments (#52408) 2020-03-12 09:31:01 -07:00
Dmitry Ratushnyy
1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson
04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af856a794255763cb31b003886ff821e0.
2020-03-12 09:02:31 -07:00
Greg Spencer
7c9f95ac0a
Minor doc changes (#52433)
Just some very minor doc changes: an adjustment of my comments in #51495, and a typo fix.
2020-03-11 16:57:06 -07:00
Gary Qian
fed6ce17f8
Directionality formatter to move whitespace bidi handling into framework (#51964) 2020-03-11 16:25:12 -07:00
Jonah Williams
edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Gary Qian
d56266375b
Reland "Improve text formatter repeat filter logic (#52055)" (#52366) 2020-03-11 13:36:43 -07:00
Justin McCandless
4841a7ed6f
Text Selection Overflow (Android) (#49391)
Adds an overflow menu to the text selection menu on Android when the items overflow.
2020-03-11 13:36:10 -07:00
Greg Spencer
210f4d8313
Convert Diagnosticable to a mixin (#51495)
This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class.

It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
2020-03-11 10:03:05 -07:00
Jonah Williams
6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia
4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams
ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson
53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Greg Spencer
d19c44344b
Add sample for InheritedNotifier, convert two others to DartPa… (#52349)
This adds a sample for InheritedNotifier, and converts a couple of other samples to be DartPad samples. I also added a new sample template stateful_widget_material_ticker, which adds a TickerProviderStateMixin to the state object so that animation controllers can be created there easily.
2020-03-10 15:23:45 -07:00
Zachary Anderson
78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson
7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams
5d289721fc
[flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson
605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Gary Qian
ac6ea52b37
Revert "Add missing features to DefaultTextStyleTransition and AnimatedDefaultTextStyle (#51517)" (#52352) 2020-03-10 14:11:03 -07:00
Ben Konyi
66b978a197
Update pub dependencies to roll forward package:test (#52273) 2020-03-10 13:26:02 -07:00
Michael Goderbauer
ade6a1b3c5
Fix a11y scrolling for reversed lists (#52332) 2020-03-10 13:04:22 -07:00
Zachary Anderson
733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams
fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams
2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams
377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder
fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams
60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams
3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams
88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Francisco Magdaleno
e9905b6ad8
[Keyboard] Collects windows key data (#52265) 2020-03-09 17:21:02 -07:00
Jonah Williams
bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
George Wright
084a7077ce
Revert "Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)" (#52277)
This reverts commit ffcc7765133be806e4f8f87e052469252e955c65.
2020-03-09 16:55:58 -07:00
renyou
847280f72f
Revert "Improve text formatter repeat filter logic (#52055)" (#52274)
This reverts commit 91b0bcf1a8a192e8135a9289310d81deba5824ec.
2020-03-09 16:26:48 -07:00
George Wright
ffcc776513
Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)
This worksaround an issue with the latest version of package_config which doesn't handle
multiple dart packages sharing the same source directory. In this case, the fuchsia dart_tool
targets were sharing a directory with their dependency, :flutter_tools
2020-03-09 15:08:57 -07:00
Gary Qian
91b0bcf1a8
Improve text formatter repeat filter logic (#52055) 2020-03-09 13:05:07 -07:00
Angjie Li
665d380f81
Add Android Chrome support to Flutter Web Driver. (#51677)
* Support Android Chrome for Flutter Web Driver.
2020-03-09 13:01:07 -07:00
Per Classon
1546f41ec1
Add width constraints for FlexibleSpaceBar.title in its expanded state, so that overflow of long titles can be handled (#51335) 2020-03-09 12:06:01 -07:00
Chad Nehemiah
31df1d459e
made builder required (#51993) 2020-03-09 12:01:01 -07:00