Gary Qian
0941abe84c
Disable flaky LineMetrics test ( #49364 )
2020-01-23 12:57:33 -08:00
Maurice Parrish
52c665d23f
Revert "Do not rebuild Routes when a new opaque Route is pushed on top ( #48900 )" ( #49366 )
...
This reverts commit 8eecdbe823ea09dd723a8af34c7c275e5536d728.
2020-01-23 11:32:04 -08:00
Alexandre Ardhuin
4fd19aa189
fix multiline FlutterError ( #49280 )
2020-01-22 13:03:03 -08:00
Gary Qian
3b1ad168c9
Add additional expects to check if LineMetrics flake is a race ( #49261 )
2020-01-22 13:00:22 -08:00
chunhtai
14fc0e5ca8
soft transition for the mustcallsuper in Element forgetChild ( #49246 )
2020-01-22 11:03:01 -08:00
Pierre-Louis
0fffa510fd
Add very large text scale support for time picker ( #48837 )
2020-01-22 10:58:02 -08:00
shihchanghsiungsonos
379c3f4652
Fix the issue of TextSelection could misbehave inside a Nested Overlay ( #49257 )
2020-01-22 10:54:22 -08:00
LongCatIsLooong
a499e05f5a
Let material ThemeData dictate brightness if cupertinoOverrideTheme.brightness is null ( #47249 )
2020-01-22 10:53:02 -08:00
Dan Field
f8d361eb5e
contains ( #49247 )
2020-01-21 16:58:01 -08:00
Alexandre Ardhuin
3800bb7b10
fix missing spaces in adjacent strings ( #49159 )
2020-01-21 16:43:03 -08:00
David Shuckerow
4c32ae8e91
Grammar fix: "it's" -> "its" ( #48913 )
2020-01-21 16:33:02 -08:00
Michael Goderbauer
c3684d8064
remove an unnecessary import ( #49231 )
2020-01-21 16:24:51 -08:00
Michael Goderbauer
8eecdbe823
Do not rebuild Routes when a new opaque Route is pushed on top ( #48900 )
2020-01-21 16:24:17 -08:00
Wu Zhong
b5a23fdf5b
Fix comment typo ( #49129 )
2020-01-21 10:11:09 -08:00
chunhtai
ec1044a877
Revert "reland add lifecycle enum and remove workaround ( #48460 )" ( #49098 )
...
This reverts commit d372814f78ec131270cfb5d5fb6f9308fbe136fd.
2020-01-17 19:19:33 -08:00
Dan Field
1a061dd8e5
Avoid runtimeType.toString in describeIdentity ( #49087 )
2020-01-17 15:23:01 -08:00
Anthony
b67d5ec6e9
[a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set ( #48985 )
2020-01-17 15:13:01 -08:00
Justin McCandless
8fbc77e24e
Cupertino(Sliding)SegmentedControl docs reference ( #48925 )
2020-01-17 12:53:01 -08:00
Justin McCandless
c61e55ad6b
Selection menu not showing when selection is 0,0 ( #49000 )
2020-01-17 10:58:01 -08:00
Greg Spencer
f013b25b9c
Add TargetPlatform.macOS tests to the widgets library. ( #48997 )
2020-01-17 10:51:38 -08:00
Greg Spencer
3dbe90e1fd
Add TargetPlatform.macOS tests to the material library ( #48996 )
...
This contains the test changes for adding TargetPlatform.macOS, which was done in #43457 .
The main goal of this PR is to enable tests in the material library that are currently running only on iOS to also run on macOS, but only for the tests where that makes sense. For instance, we don't run any of the haptic feedback tests on macOS.
2020-01-17 10:51:11 -08:00
Greg Spencer
bf1d822198
Add TargetPlatform.macOS tests to cupertino, foundation, rendering, and services libraries. ( #45644 )
2020-01-16 19:38:01 -08:00
Michael Goderbauer
cb5918f626
Doc fixes in Image related docs ( #48994 )
2020-01-16 17:18:02 -08:00
rami-a
d016146439
Allow for cupertino modal popups to be dismissed with semantics ( #48915 )
2020-01-16 12:58:01 -08:00
Alexandre Ardhuin
003541499b
use isA<Xxx>() matcher ( #48482 )
2020-01-16 12:43:03 -08:00
rami-a
91f8d3da32
Prevent disabled cupertino textfield from being edited with voiceover/talkback ( #48902 )
2020-01-16 18:21:16 +00:00
suragch
4c1d79f42f
Update assert message for AnimatedContainer ( #48962 )
...
The error message was misleading because BoxDecoration does not have a `backgroundColor` parameter. Instead it has a `color` parameter, which sets the background color. I also removed the optional `new` keyword.
2020-01-16 10:03:43 -08:00
Hans Muller
6006c23757
Step 2 of 2: Remove Flutter's FloatingActionButton dependency on ThemeData accent properties ( #46923 )
2020-01-16 07:21:25 -08:00
Josh Burton
6852605c4f
Adds floatLabelBehavior to InputDecoration ( #46115 )
2020-01-15 18:53:01 -08:00
Alexandre Ardhuin
c195b771cc
replace runtimeType.toString() ( #48892 )
2020-01-15 16:58:02 -08:00
Konstantin Scheglov
5a072a9365
Add missing type arguments to fix implicit dynamic. ( #48853 )
2020-01-15 16:53:02 -08:00
Per Classon
a752435fac
Exclude modal barrier Container in Drawer from Semantics on Android ( #48841 )
2020-01-15 16:48:02 -08:00
Anthony
aeb12144e6
Use a separately focusable semantics node for the chip delete icon ( #48740 )
2020-01-15 16:38:04 -08:00
chunhtai
d372814f78
reland add lifecycle enum and remove workaround ( #48460 )
2020-01-15 16:33:01 -08:00
Tianguang
c88320458e
Allow IconButton to have smaller sizes ( #47457 )
2020-01-15 08:38:02 -08:00
Shi-Hao Hong
0174267316
ButtonBar.verticalDirection and AlertDialog.actionsVerticalDirection ( #48728 )
2020-01-14 16:48:02 -08:00
Dan Field
3e63411256
Avoid runtimeType.toString in toString overrides/debugLabels ( #48607 )
2020-01-14 16:43:01 -08:00
Kate Lovett
5ca4cc8852
Restored change ( #48529 )
2020-01-14 09:38:02 -08:00
rami-a
68d0c89ffc
Return the correct number of semantic children for the ListView.separated constructor ( #48741 )
2020-01-14 16:18:48 +00:00
Michel Feinstein
9585acd478
Fixing AutomaticKeepAlive Docs ( #48575 )
2020-01-13 17:18:02 -08:00
Prerak Mann
8b6b3b62c1
Passes scrollPhysics ( #48342 )
2020-01-13 17:08:01 -08:00
Tianguang
d7d642653a
Add asserts requiring BoxConstraints' parameters to be non-null ( #48295 )
2020-01-13 21:34:30 +01:00
Kate Lovett
8f92cb710e
Fixing PageScrollPhysics to get along with NestedScrollView ( #48457 )
2020-01-13 11:58:03 -08:00
Greg Spencer
6495d3775d
Allow requestFocus on an unattached FocusNode to create a deferred focus request ( #48589 )
...
This changes the behavior of requestFocus when it is called on a FocusNode that does not yet have a parent, so that it defers requesting focus until it receives a parent. Before this change, calling requestFocus before it had a parent was a no-op.
This allows scenarios where a widget is newly added and wishes to immediately request the focus. Previously, it was very hard to make that work because requesting focus before the widget's focus node had a parent was ignored, so the developer had to wait until two frames later to request focus (one for the widget's node to be added to the focus tree, and one to request the focus).
Now, in order to have a widget be focused when initially added, you just need to call requestFocus on its node when you create it, and as soon as it is added, it will automatically request focus.
This is different from the autofocus attribute on the Focus widget, because it unconditionally requests focus when added (autofocus will only request focus if nothing else in the scope has focus).
2020-01-13 11:56:47 -08:00
Michael Goderbauer
6a5964d89c
Make ParentDataWidget usable with different ancestor RenderObjectWidget types ( #48541 )
2020-01-13 10:08:01 -08:00
Ian Hickson
e2b169ebd3
Apply void_checks lint. ( #48267 )
2020-01-13 10:03:01 -08:00
Dan Field
5129c2d295
Fix typo ( #48385 )
2020-01-10 17:06:16 -08:00
Chris Yang
7dba0da277
Fix platform view pointer event global route position detection ( #48459 )
2020-01-10 16:52:22 -08:00
Maya
c90b118247
Add padEnds option to SliverFillViewport ( #48207 )
2020-01-10 14:33:02 -08:00
LongCatIsLooong
02db6a8052
DiagnosticsTreeStyle.oneLine for CupertinoThemeData ( #48084 )
2020-01-10 14:23:02 -08:00
