6903 Commits

Author SHA1 Message Date
Dan Field
b61dec79c7
Start fixing docs (#45977) 2019-12-03 13:59:19 -08:00
Sahand Akbarzadeh
f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
Alexandre Ardhuin
1ae5d676e5
implicit-casts:false in flutter/lib/src/scheduler (#45721) 2019-12-03 09:32:03 +01:00
XinLei
9d574d2c22 Remove canTransitionFrom override from Material/CupertinoPageRoute (#45750) 2019-12-02 23:23:53 -08:00
Dan Field
c0283d85f5 Deprecate UpdateLiveRegionEvent (#45940) 2019-12-02 19:08:01 -08:00
Greg Spencer
37f86c3195
Clean up some things I noticed while doing another change (#45658)
This fixes some minor things I noticed while doing another change.

- Uncomments an old test that wants to be run, but can't be, and marked it as "skipped", so that the code won't rot anymore.
- Added the focus state to the short string version of a FocusNode
- Added a missing piece of information to findAncestorWidgetOfExactType
2019-12-02 17:10:09 -08:00
Kate Lovett
2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Kate Lovett
cd052a56cb
Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939)
This reverts commit c59151b1cdb70c77368c04aaed39ca4791cad539.
2019-12-02 15:08:35 -08:00
Michael Goderbauer
c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Tong Mu
afb8f38211
Improve MouseTracker lifecycle: Move checks to post-frame (#44631)
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
2019-12-02 13:00:48 -08:00
Michael Goderbauer
8954ee85dd
Add Sliver video to RenderSliver (#45708) 2019-12-02 12:58:04 -08:00
Gary Qian
d345a3b303
Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" (#45698)
This reverts commit 6b66d794360bb7d3ff7bf2f6dfbcbd58516c3f20.
2019-11-28 19:42:06 +09:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Chris Bracken
dc49fa2140
Eliminate commented-out code (#45726)
This appears to have been inadvertently added in #37497 (333c961).

The code in question already exists in `_PlatformViewGestureMixin`, which
`PlatformViewRenderBox` (where it was added) mixes in.
2019-11-27 14:50:15 -08:00
Ian Hickson
f87c5102af
Add more documentation around layers. (#45648) 2019-11-27 14:22:48 -08:00
Chris Bracken
b39949ff09
Fix parameter name: handlePointerEvent (#45717)
Removes an unnecessary leading underscore from a parameter name. The
parameter type is library private, but parameters cannot be 'private'.
2019-11-27 12:48:43 -08:00
liyuqian
264082f34f
Print clipBehavior while debugging ClipXXXLayer (#45716)
Fixes https://github.com/flutter/flutter/issues/45587
2019-11-27 12:48:03 -08:00
Alexandre Ardhuin
5ccd4f3430
implicit-casts:false in flutter/lib/src/physics (#45622) 2019-11-27 21:28:45 +01:00
LongCatIsLooong
37f9c54116
Use RenderSliverPadding to inset SliverFillViewport (#45432) 2019-11-27 11:33:38 -08:00
Takeshi Tsukamoto
876303b3f9 Fix comment (#45325) 2019-11-27 10:01:57 -08:00
Greg Spencer
245d1b51ce
Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
Dan Field
2d3d220988
Implicit scrolling for pageview (#45598) 2019-11-26 14:12:34 -08:00
Albertus Angga Raharja
e1512b4dd7
Add additional properties callback in Inspector Serialization Delegate (#45531)
* Add additional properties callback in Inspector Serialization Delegate

* Rename _SerializationDelegate to InspectorSerializationDelegate and add test

* Fix indentation

* Remove trailing whitespace

* Handle case when addAdditionalPropertiesCallback returns null

* Improve docs and minor renames

* Improve docs

* Improve documentation
2019-11-26 13:57:41 -08:00
Greg Spencer
0190e40457
Keyboard scrolling of Scrollable (#45019)
This adds the ability to scroll and page up/down in a Scrollable using the keyboard. Currently, the macOS bindings use Platform.isMacOS as a check, but we'll switch that to be defaultTargetPlatform == TargetPlatform.macOS once that exists.
2019-11-26 09:56:25 -08:00
Kate Lovett
8a48a27847
Performance Improvement for SliverFillRemaining (#44471) 2019-11-26 08:04:22 -08:00
Kate Lovett
cd94cd886a
SliverOffstage Fix (#45580) 2019-11-26 08:01:03 -08:00
Alexandre Ardhuin
a2c3f6c567
implicit-casts:false in flutter/lib/src/animation (#45501) 2019-11-26 16:53:14 +01:00
Alexandre Ardhuin
4055e19680
implicit-casts:false in flutter/lib/src/foundation (#45503) 2019-11-26 16:52:37 +01:00
Alexandre Ardhuin
f6dc4db2e0
implicit-casts:false in flutter/lib/src/gestures (#45504)
* implicit-casts:false in flutter/lib/src/gestures

* address review comments
2019-11-26 07:03:34 +01:00
Dan Field
e766ae740e
Automatically caching viewport (#45327) 2019-11-25 21:05:46 -08:00
Greg Spencer
46632f9edc
Handle bare modifier flags on macOS (#45438)
This fixes an unreported bug in the macOS key handling where for some remote access situations, the modifier mask is set to the "any modifier" mask without any side specified (e.g. modifierShift bit is specified and not modifierLeftShift bit).
2019-11-25 17:06:16 -08:00
Kate Lovett
d0ea9ed244
SliverOffstage (#45128) 2019-11-25 12:49:10 -08:00
Kate Lovett
1160c8fd29
Re-Staged: Fixing ContinuousRectangleBorder bottom radius (#45304) 2019-11-25 12:43:58 -08:00
Jonah Williams
cf37c2cd07
Add assert for negative child count in ListView.builder (#45506) 2019-11-25 12:04:30 -08:00
Takeshi Tsukamoto
a3eeb51a1b Fix draggable scrollable sheet scroll notification (#45083) 2019-11-22 21:48:38 -08:00
chunhtai
f15f69a8b8
Drops detached message until we can handle it properly (#45430) 2019-11-22 16:10:46 -08:00
Kate Lovett
e2cf2f0fa2
SliverOpacity (#44289) 2019-11-22 11:12:09 -08:00
Kate Lovett
9f17a43ebe
SliverIgnorePointer (#45127) 2019-11-22 09:54:09 -08:00
Greg Spencer
a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin
fcb40a05bb
make some BuildContext methods generics (#44189)
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic

* make BuildContext.inheritFromWidgetOfExactType generic

* make BuildContext.ancestorInheritedElementForWidgetOfExactType generic

* make BuildContext.ancestorWidgetOfExactType generic

* fix snippet

* bump scoped_model on temp version

* update names

* Revert "bump scoped_model on temp version"

This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.

* address review comments

* fix ci

* address review comments

* repeat the deprecation notice

* fix uppercase

* use of recommanded deprecation syntax

* address review comment
2019-11-22 17:35:20 +01:00
Todd Volkert
4c64b715d9
Revert "Add option to delay rendering the first frame (#45135)" (#45385)
This reverts commit d285b8843fce6cf039eb197a09b01ca5cc00d92b.
2019-11-21 22:12:24 -08:00
Todd Volkert
cb35c88b34
Add widget of the week video embeddings (#45362) 2019-11-21 22:07:03 -08:00
Kaushik Iska
1fae83cf2c
[fuchsia] Reland use sky_engine from Topaz (#45282)
Testes on the Fuchsia tree by reverting it locally.

This reverts commit f45bd48ccae69efeafc6da8864b385d0b7b72533.
2019-11-21 12:48:32 -08:00
Michael Goderbauer
d285b8843f
Add option to delay rendering the first frame (#45135) 2019-11-21 12:13:45 -08:00
Gary Qian
6b66d79436
Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622) 2019-11-20 16:37:10 -08:00
chunhtai
314eb3bae3
Moving pointer event sanitizing to engine. (#44217) 2019-11-20 13:04:29 -08:00
Todd Volkert
ce8e2bb7cf
Revert "[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)" (#45268)
This reverts commit 421bf64703b5c0fae7196923da0561f6a4c6ec79.

Was causing severe breakages in Google.
2019-11-20 10:42:23 -08:00
Jonah Williams
f20471d081 Revert "reland add lifecycle enum and fix the scheduleforcedframe (#45133)" (#45260)
This reverts commit 99324105da695ed55d322a039cf5349a7b2ab45b.

It was implicated in https://github.com/flutter/flutter/issues/45258
2019-11-20 09:43:15 -08:00
Anthony
421bf64703
[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)
Update the Slider and RangeSlider to the latest Material spec. This introduces an updated track, updated thumbs, updated tick marks, and a new value indicator shape. The old paddle value indicator shape is also updated so that text scaling works consistently.
2019-11-20 18:18:40 +01:00
Ian Hickson
b75abd9f7e
Try a mildly prettier FlutterError and make it less drastic in release mode. (#44967) 2019-11-19 17:35:47 -08:00