11730 Commits

Author SHA1 Message Date
Todd Volkert
4c64b715d9
Revert "Add option to delay rendering the first frame (#45135)" (#45385)
This reverts commit d285b8843fce6cf039eb197a09b01ca5cc00d92b.
2019-11-21 22:12:24 -08:00
Todd Volkert
cb35c88b34
Add widget of the week video embeddings (#45362) 2019-11-21 22:07:03 -08:00
Amir Hardon
e43a69a9fe
Allow a no-op default_package key for a plugin platform (#45364) 2019-11-21 16:37:34 -08:00
Zachary Anderson
05226d2a61
Reland: [flutter_tool] Fuchsia AOT builds (#45350)
* Reland: [flutter_tool] Fuchsia AOT builds

* Fixes
2019-11-21 12:55:39 -08:00
Jonah Williams
785e557a43
remove Flags (#45320) 2019-11-21 12:52:52 -08:00
Kaushik Iska
1fae83cf2c
[fuchsia] Reland use sky_engine from Topaz (#45282)
Testes on the Fuchsia tree by reverting it locally.

This reverts commit f45bd48ccae69efeafc6da8864b385d0b7b72533.
2019-11-21 12:48:32 -08:00
Michael Goderbauer
d285b8843f
Add option to delay rendering the first frame (#45135) 2019-11-21 12:13:45 -08:00
Zachary Anderson
0216953674
Revert "[flutter_tool] Fuchsia AOT builds (#45187)" (#45349)
This reverts commit a57dddd217bc22f4a18198d750f59aa4add8e08a.
2019-11-21 09:41:46 -08:00
Alexandre Ardhuin
1f3ff5ca42
implicit-casts:false in flutter_goldens and flutter_goldens_client (#45249)
* implicit-casts:false in flutter_goldens and flutter_goldens_client

* fix type
2019-11-21 17:46:37 +01:00
Zachary Anderson
a57dddd217
[flutter_tool] Fuchsia AOT builds (#45187) 2019-11-21 08:32:58 -08:00
Alexandre Ardhuin
9efaa784ad
implicit-casts:false in flutter_web_plugins (#45240) 2019-11-21 11:22:01 +01:00
Emmanuel Garcia
5df4b7db23
Reland: Attach looks at future observatory URIs (#45307) 2019-11-20 18:51:25 -08:00
Amir Hardon
53c7ca7d5a
Allow unknown fields in pubspec plugin section (#45303) 2019-11-20 17:00:46 -08:00
Gary Qian
6b66d79436
Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622) 2019-11-20 16:37:10 -08:00
Jonah Williams
106b8eb9c0
Revert "Reduce some direct package:archive usage (#44608)" (#45291)
This reverts commit 6b5634fed35cb0d818e99de9f8c66586ed1b27a7.
2019-11-20 14:45:32 -08:00
Jonah Williams
6b5634fed3
Reduce some direct package:archive usage (#44608) 2019-11-20 13:32:14 -08:00
chunhtai
314eb3bae3
Moving pointer event sanitizing to engine. (#44217) 2019-11-20 13:04:29 -08:00
Todd Volkert
ce8e2bb7cf
Revert "[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)" (#45268)
This reverts commit 421bf64703b5c0fae7196923da0561f6a4c6ec79.

Was causing severe breakages in Google.
2019-11-20 10:42:23 -08:00
Jonah Williams
f20471d081 Revert "reland add lifecycle enum and fix the scheduleforcedframe (#45133)" (#45260)
This reverts commit 99324105da695ed55d322a039cf5349a7b2ab45b.

It was implicated in https://github.com/flutter/flutter/issues/45258
2019-11-20 09:43:15 -08:00
Anthony
421bf64703
[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)
Update the Slider and RangeSlider to the latest Material spec. This introduces an updated track, updated thumbs, updated tick marks, and a new value indicator shape. The old paddle value indicator shape is also updated so that text scaling works consistently.
2019-11-20 18:18:40 +01:00
Danny Tuppeny
73c32545b7
Fix device daemon test when desktop or web are enabled (#45172) 2019-11-20 11:02:35 +00:00
Emmanuel Garcia
fb5e49082b
Revert "Attach looks at future observatory URIs (#45228)" (#45237)
This reverts commit 2135e9fb1e7829fb6d627e4cd1ddbeafd4f272b3.
2019-11-19 23:14:25 -08:00
Emmanuel Garcia
2135e9fb1e
Reland: Attach looks at future observatory URIs (#45228) 2019-11-19 21:43:52 -08:00
Jonah Williams
c724504142
Update Android CPU device detection (#45139) 2019-11-19 19:04:17 -08:00
Ian Hickson
b75abd9f7e
Try a mildly prettier FlutterError and make it less drastic in release mode. (#44967) 2019-11-19 17:35:47 -08:00
Greg Spencer
0d27fdced9
Scroll scrollable to keep focused control visible. (#44965)
Before this change, it was possible to move the focus onto a control that was no longer in the view using focus traversal. This changes that, so that when a control is focused, it makes sure that if it is the child of a scrollable, that the scrollable attempts to keep it in view. If it is already in view, then nothing scrolls.

When asked to move in a direction, the focus traversal code tries to find a control to move to inside the scrollable first, and then looks for things outside of the scrollable only once the scrollable has reached its limit in that direction.
2019-11-19 17:10:34 -08:00
Emmanuel Garcia
7a0911b47a
Revert "Attach looks at future observatory URIs (#44637)" (#45211)
This reverts commit 6d77996d6a760f53649603f45b2f94ccba7ef936.
2019-11-19 16:47:39 -08:00
chunhtai
99324105da
reland add lifecycle enum and fix the scheduleforcedframe (#45133)
* reland add lifecycle enum and fix the scheduleforcedframe
2019-11-19 15:45:37 -08:00
Greg Spencer
a3186fbaa1
Analyze dartpad (#45124)
This fixes the sample code analysis to treat dartpad snippets in the same way as snippet snippets, which it wasn't until now (the snippet generator was treating them as "samples"), and some errors crept in. This PR also fixes those errors.

Also, added a --verbose option to the sample analyzer.
2019-11-19 15:16:12 -08:00
Jenn Magder
1f296ad78c
Remove chmod to make Flutter framework headers unwritable (#45189) 2019-11-19 15:13:33 -08:00
Emmanuel Garcia
6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Danny Tuppeny
37eec86294
Allow web server device to use extension if started with --start-paused (#44263)
* Allow web server device to use extension if started with --start-paused

* Fix comment

* Remove browser-launch option that allowed using Chrome without launching Chrome

The web-server device should now be used if you don't want to launch a browser.

* Add tests for WebServerDevice with --start-paused

* Fixes from rebase

* More fixes from rebase

* Fix from rebase

* Fix condition for page refresh in non-debug builds

* Make dwds conditions match with a new getter

* Add missing .device
2019-11-19 20:11:53 +00:00
Jonah Williams
df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jonah Williams
e236196037
cache sdkNameAndVersion logic for web devices (#45145) 2019-11-19 09:36:24 -08:00
Alexandre Ardhuin
0df8812681
fix type errors (#45151) 2019-11-19 09:28:24 +01:00
Alexandre Ardhuin
4bf03c6cf8
implicit-casts:false in flutter_test (#44996) 2019-11-19 08:10:24 +01:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib (#44447)
* implicit-casts:false on flutter_tools/lib

* address review comments

* use castStringKeyedMap

* introduce {bool,string,strings}Arg

* fix ci
2019-11-19 07:57:42 +01:00
Kaushik Iska
f45bd48cca
Revert "[flutter_runner] Use sky_engine from the topaz tree (#44935)" (#45141)
This reverts commit f48f4573500e44a6a225dc994344a616a62cac5d.
2019-11-18 19:36:50 -08:00
Greg Spencer
6e10719dc5
FocusableActionDetector widget (#44867)
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms.

I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it.

Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
2019-11-18 17:23:30 -08:00
Jonah Williams
58438fca3f Provide specific field to accept depfiles in target class (#44481)
* add depfile slot to Target class

* Update source.dart

* Update source.dart
2019-11-18 14:09:40 -08:00
Greg Spencer
d026f2d948
Properly interpret modifiers on GLFW key events (#44844)
GLFW key events set modifier flags based on what the modifier state was before the event, unlike every other platform. This modifies the GLFW key support to take that into account.

As a small cleanup, I fixed a documentation macro reference for the modifier flags that was duplicate
2019-11-18 14:07:08 -08:00
Greg Spencer
21158d8337
Add command key bindings to macOS text editing and fix selection. (#44130)
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android.

There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
2019-11-18 14:06:37 -08:00
Jonah Williams
a7367b650b
Don't log stack traces to console on build failures (#44966) 2019-11-18 14:04:11 -08:00
Christopher Fujino
ff84b3e66d catch IOSDeviceNotFoundError in IOSDevice.startApp() (#45011) 2019-11-18 13:53:55 -08:00
chunhtai
7e1920b817
revert added lifecycle enum (#45119) 2019-11-18 13:38:47 -08:00
Danny Tuppeny
81f6ba84b9
Switch from using app.progress to app.webLaunchUrl for passing web launch urls (#44268)
* Switch from using app.progress to app.url for passing web launch urls

* Update daemon.md

* Change app.url -> app.webLaunchUrl

* Add tests for app.webLaunchUrl event

* Update tests with recent changes after rebasing
2019-11-18 18:10:15 +00:00
chunhtai
af48f71497
reland add new enum change (#45012)
This reverts commit 75f310791f154f9f416d9ce137e83478ccc3f112.
2019-11-18 10:04:09 -08:00
Bartosz Wiśniewski
5c15b270b3 Remove duplicated expect from text field test (#45081) 2019-11-18 09:51:16 -08:00
Ian Hickson
62e4ab87b3
Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00
Jonah Williams
2a576b774c
remove no-gen-bytecode flag (#43908) 2019-11-15 13:15:05 -08:00