6843 Commits

Author SHA1 Message Date
Ian Hickson
62e4ab87b3
Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00
Kate Lovett
ae62a3cf1b
Error Message for createState assertion (#44610)
* Init

* Added error message to assert

* Removing unrelated changes
2019-11-15 13:05:18 -08:00
Ben Konyi
e3ae7fab62
Manual engine roll to b2640d97e7e8034f28b4e7b92c15b0824e433897 (#45000)
Fixes failures in some tests which used regular expressions to compare
stack traces which had instances of "<asynchronous suspension>".
2019-11-15 12:13:59 -08:00
LongCatIsLooong
851d6996e7
Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" (#44778)
* Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)"

This reverts commit 9aea03f4afb1c616dd98c2b328032af7849f99cc.
2019-11-14 17:14:26 -08:00
Kaushik Iska
f48f457350
[flutter_runner] Use sky_engine from the topaz tree (#44935) 2019-11-14 17:09:45 -08:00
Kaushik Iska
75f310791f Revert "reland add new enum change (#44281) (#44487)" (#44947)
This reverts commit f0794917fc69f7bcf65e193c8d95643d23127198.
2019-11-14 16:49:43 -08:00
chunhtai
f0794917fc
reland add new enum change (#44281) (#44487)
* reland add new enum change (#44281)

This reverts commit ed82bb821cd7c62315ec5973e36855ca75f17350.
2019-11-14 13:27:38 -08:00
Ian Hickson
96fbbdc3e0
Fix "node._relayoutBoundary == _relayoutBoundary" crash (#44490) 2019-11-14 13:19:55 -08:00
Casey Hillers
5506cc5b15
Remove no longer needed clean up code (#44408) 2019-11-14 09:38:12 -08:00
Jonah Williams
e77c24ef91
Update package test (#44882) 2019-11-14 09:31:36 -08:00
Michael Goderbauer
bcc93bca23
Make disposing a ScrollPosition with pixels=null legal (#44617) 2019-11-13 11:31:20 -08:00
Tong Mu
01f4f1ac55
ModalBarrier and Drawer barrier prevents mouse events (#44296)
* Add opaque to barriers
* Detect opaque and test
2019-11-12 18:25:53 -08:00
Jonah Williams
a901b650b6
Update meta to 1.1.8 (#44584) 2019-11-12 13:48:42 -08:00
Mouad Debbar
9307a83f7c
Changing RenderEditable.textAlign doesn't break hot reload anymore (#44605) 2019-11-11 14:35:15 -08:00
Greg Spencer
23d1ae0ff7
Convert to TextPosition for getWordBoundary (#44611)
Convert the call to getWordBoundary to use a TextPosition, in preparation for landing flutter/engine#13727, which switches the desired API to the final desired API.
2019-11-11 14:27:06 -08:00
Sam Rawlins
86c91b12d8 Remove new unused elements (#44551) 2019-11-11 13:29:46 -08:00
Alex Fourman
924ab725d9 Fix AboutListTile having an empty icon placeholder when no icon set. (#43422) 2019-11-08 19:33:44 -08:00
Taufiq Rahman
8ad7456cd4 Adjust and refactor all OutlineButton tests into its respective file (#44328) 2019-11-08 19:32:16 -08:00
Greg Spencer
dd90ff429d
Remove TextRange, export it from dart:ui (#44422)
This removes TextRange from the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, and updates the APIs that use Paragraph.getWordBoundary (there was only one) to expect a TextRange or  a pair of ints temporarily until the engine side returns TextRanges, so that I can convert over without breaking the builds.
2019-11-08 18:57:44 -08:00
Greg Spencer
c921c5ae67
Add macOS fn key support. (#44410)
This adds support for the fn key on macOS. It adds it to the key mappings as a supplemental mapping that overwrites the one from the Chrome headers, since the chrome headers have a TODO, but no implementation of the key.

Also, ignore the fn key entirely on macOS. This is because On macOS laptop keyboards, the fn key is used to generate home/end and f1-f12, but it ALSO generates a separate down/up event for the fn key itself. Other platforms hide the fn key, and just produce the key that it is combined with, so to keep it possible to write cross platform code that looks at which keys are pressed, the fn key is ignored.
2019-11-08 16:30:38 -08:00
LongCatIsLooong
09c80aa45a
Segmented control quick double tap fix (#44391) 2019-11-08 10:05:53 -08:00
Luiz França
d961ae85b5 Adding subtitle to ExpansionTile (#43946)
* Adding subtitle to expansion_tile
2019-11-08 10:04:49 -08:00
Greg Spencer
19778f9e33
Make selected item get focus when dropdown is opened (#43722)
As it stands, dropdowns currently do not focus the item that is selected, so if you select something on a dropdown, and then close it, and re-open it, then the new item is not auto-focused. This PR changes that so that selected value is focused by default when the dropdown is re-opened.
2019-11-08 08:58:37 -08:00
liyuqian
cc9e9ce2ce
Remove TODO that's done (#44318)
See https://github.com/flutter/engine/pull/13728
2019-11-07 14:06:07 -08:00
LongCatIsLooong
62db22d152
CupertinoDynamicColor improvements (#44317) 2019-11-07 13:14:08 -08:00
Greg Spencer
028ed7122a
Synchronize modifier keys in RawKeyboard.keysPressed with modifier flags on events. (#43948)
Currently, we listen to keyboard events to find out which keys should be represented in RawKeyboard.instance.keysPressed, but that's not sufficient to represent the physical state of the keys, since modifier keys could have been pressed when the overall app did not have keyboard focus (especially on desktop platforms).

This PR synchronizes the list of modifier keys in keysPressed with the modifier key flags that are present in the raw key event so that they can be relied upon to represent the current state of the keyboard. When synchronizing these states, we don't send any new key events, since they didn't happen when the app had keyboard focus, but if you ask "is this key down", we'll give the right answer
2019-11-06 14:52:55 -08:00
Taufiq Rahman
3243ebe3ee Tap.dart: Fixes the spacing to the right side of reason (#43246) 2019-11-06 14:48:43 -08:00
chunhtai
ed82bb821c
revert add new enum change (#44281) 2019-11-06 11:07:24 -08:00
Gary Qian
8cd892b39b
Use alphabetic baselines for layout of InputDecorator (#44029) 2019-11-06 10:50:16 -08:00
Jonah Williams
2110dfe0f5
remove yield from inherited model (#44233) 2019-11-06 10:38:56 -08:00
chunhtai
7aebde1904
added new lifecycle state (#39945)
* added new lfecycle state

* update

* update
2019-11-05 20:03:09 -08:00
LongCatIsLooong
a9fc9e561a
Apply minimumDate & maximumDate constraints in CupertinoDatePicker date mode (#44149) 2019-11-05 14:16:55 -08:00
Shi-Hao Hong
1663fde347
Wire selectedItemBuilder through DropdownButtonFormField (#44160) 2019-11-05 12:32:03 -08:00
Taufiq Rahman
4bf2e55790 Adjust and refactor all RaisedButton tests into its respective file (#44169) 2019-11-05 12:29:39 -08:00
Yegor
f6eb129597
fix text tests on the web (#44021) 2019-11-05 10:05:16 -08:00
Justin McCandless
9734754aad
CupertinoContextMenu (iOS 13) (#43918)
Adds the CupertinoContextMenu widget for iOS 13 support.
2019-11-05 07:55:54 -08:00
Edman P. Anjos
28b5cc3825
Pad CupertinoAlertDialog with MediaQuery viewInsets (#42967)
Fixes #42049.
2019-11-05 11:50:30 +01:00
Taufiq Rahman
3390e162cf Adjust and refactor all FlatButton tests into its respective file (#43742)
* Adjust and refactor all FlatButton tests into its respective file
2019-11-04 18:22:01 -08:00
umevoshi
d96afee888 Fix comment typo in tabs.dart (#44068) 2019-11-04 17:33:23 -08:00
Thalles Santos
0431c8a64d Typo in TextFormField comments (#44076)
initalValue should be initialValue
2019-11-04 17:32:41 -08:00
Kate Lovett
11e1c24069
SliverAppBar - Configurable overscroll stretch with callback feature & FlexibleSpaceBar support (#42250) 2019-11-04 17:10:26 -08:00
LongCatIsLooong
bbb2a0f837
Update cupertino demos in gallery (#43841) 2019-11-04 16:31:52 -08:00
Dan Field
7957c56997
Respond to TextInputClient.reattach messages. (#43959) 2019-11-04 16:28:03 -08:00
Nurhan Turgut
97cf355b9d
Adding handling of TextInputClient.onConnectionClosed messages handli… (#43466)
* Adding handling of TextInputClient.onConnectionClosed messages handling to Framework

* Adding more test cases for closing connection to editable_text_test

* fixing analyze error.

* Fixing analyze error in the test file

* Fixing comments on the new method

* Adding more closing connection examples.

* Indentation change

* Remove auto-add white space

* Changing the oncloseconnection behaviour to stop editing. Updating the tests

* Addressing PR comments. Added explicit log for method channnels to the tests. Added comments to the interfaces.

* add more documentation
2019-11-04 13:35:18 -08:00
NikitaZhelonkin
fbabb264e0 Add enableFeedback param to MaterialButton, RawMaterialButton and IconButton (#41972)
* Wire enableFeedback parameter through MaterialButton, RawMaterialButton, and IconButton.

Co-Authored-By: Shi-Hao Hong <shihaohong@google.com>
2019-11-01 15:36:07 -07:00
Shi-Hao Hong
bf45897f13
Revert "Implement AlertDialog title/content overflow scroll #43226" (#44003) 2019-11-01 11:30:58 -07:00
Brian Egan
2e41483384 Add "navigator" option to "showDialog" and "showGeneralDialog" (#42842) 2019-11-01 11:16:32 -07:00
creativecreatorormaybenot
8d5caf3df2 Fix typo in app_bar.dart comment (#43981) 2019-11-01 10:16:11 -07:00
Justin McCandless
924e48eeb9
Increase TextField's minimum height from 40 to 48 (#42449)
This is being done to match the Material spec. It will likely break many visual diff tests.
2019-11-01 12:36:15 -04:00
LongCatIsLooong
3cd8c3142c
Update CupertinoSlidingSegmentedControl control/feedback mechanism (#43932) 2019-10-31 19:35:52 -07:00