5489 Commits

Author SHA1 Message Date
Jonah Williams
4cd87705b7
Revert "Adds support for floating cursor (#24761)" (#25352)
This reverts commit 46878d848566769e51f21407de2fead528c1d2c4.
2018-12-13 20:36:08 -08:00
jslavitz
46878d8485
Adds support for floating cursor (#24761)
* Adds support for floating cursor!
2018-12-13 20:14:27 -08:00
Jasper van Riet
01694ab62d Allow detection of taps on TabBar (#23919) 2018-12-13 13:01:34 -08:00
Justin McCandless
c5457068df
Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)
This reverts commit f8f5953d8002cb17b861486dff93e5456ca54efd.
2018-12-13 11:58:37 -08:00
Justin McCandless
f8f5953d80
obscureText and enableInteractiveSelection defaults (#24527)
* obscureText true defaults to disabling selection

* Tests and comments for selectable text field

* Improve selection docs

* Refactor so that all enableInteractiveSelection params are null by default, delegate to selectionEnabled

* Fix selection param macros
2018-12-13 11:09:13 -08:00
Justin McCandless
952d24bf1e
Text field style merge (#24449)
* Merge TextField style with global style so that style changes don't override unspecified fields

* Test that a style param is merged with the theme

* Test a few more style properties

* Analysis fix
2018-12-13 08:32:55 -08:00
MH Johnson
92efec3998
[Material] Theme-able elevation on dialogs. (#24169)
* Themable elevation on dialogs.

* Added `BackgroundColor` in widget + theme

* Addressing Comments

* Fix test name

* Add debugFillProperties test
2018-12-13 09:11:01 -05:00
Michael Goderbauer
5c1f1d7618
Call mark* methods before attaching child (#25239) 2018-12-12 16:45:51 -08:00
Justin McCandless
9a8e2f0c4b
Validate style in TextField (#24587)
* Validate style in TextField

* Fix analyze problems

* Use assert and move to top

* Simplified assertion
2018-12-12 09:44:43 -08:00
Trevor Wang
114335dff0 Support TextField multi-line hint text #20941 (#24976) 2018-12-11 22:46:05 -08:00
xster
65df90d8b5
Add navigatorKey to CupertinoTabView (#25183) 2018-12-11 19:29:13 -08:00
Michael Goderbauer
8ca8dbf062
Do not fade out text for pinned & floating AppBar (#25051) 2018-12-11 19:24:00 -08:00
Hans Muller
234855ca3d
Handle a TabBarView special case: last tab deleted before animation ends (#24892) 2018-12-11 14:22:27 -08:00
Jimmy Casey
3cca1a2ec3 Fixed Spelling. (#25217) 2018-12-11 10:50:51 -08:00
Justin McCandless
6901cd4625
TextFormField cursor params (#24635)
* cursor fields on textformfield

* Test pass-through of cursor properties
2018-12-11 10:42:10 -08:00
Hans Muller
f14055529b
Fixed an InheritedWidget doc typo (#25168) 2018-12-11 09:53:45 -08:00
Hans Muller
f8a7abb6b8
Add a check for build methods that return context.widget (#25046) 2018-12-11 08:59:28 -08:00
Michael Goderbauer
7120dab553
Don't crash if pinned & floating AppBar has less than minExtent remainingPaintExtent (#25048)
Fixes https://github.com/flutter/flutter/issues/21887
2018-12-11 07:18:53 -08:00
Michael Goderbauer
b023a57483
Fix debugPrint(null) to not crash (#24942) 2018-12-11 00:16:43 -08:00
Michael Goderbauer
46599167d5
Remove offstage wording from KeepAlive (#24881)
What KeepAlive does is different from the Offstage widget. Let's not confuse these two and be more speicific in the wording for KeepAlive.
2018-12-10 22:37:46 -08:00
Hans Muller
e7a4e7c3b6
Update Switch doc: disabled state (#24941) 2018-12-10 11:21:28 -08:00
Patrice Chalin
ab36f05474 Replace deprecated link in docs (#25120)
Followup to https://github.com/flutter/website/pull/1949, as requested by @Hixie in https://github.com/flutter/website/issues/1634.

cc @kwalrath
2018-12-10 10:51:41 -08:00
liyuqian
06ffbbfd4a
Change network image URL in doc (#25096)
This fixes https://github.com/flutter/flutter/issues/25092
2018-12-10 09:55:07 -08:00
Michael Goderbauer
8d249c25ea
Fix semantics compiler for offstage children (#24862)
Fixes #20313.
2018-12-10 08:58:14 -08:00
Michael Goderbauer
d74b1c2051
Add animations to SliverAppBar doc (#25091) 2018-12-07 14:19:09 -08:00
Gary Qian
27c8ffa06c
Fix typo in documentation (#25003) 2018-12-05 14:50:59 -08:00
Ian Hickson
5391447fae Clarify dart:ui dependencies in foundation library (#24868) 2018-11-29 19:41:26 -08:00
Ian Hickson
f683e4c4b4
Improve CircleAvatar documentation (#24729) 2018-11-27 11:29:00 -08:00
Ian Hickson
c00a794f56
Some more documentation around WidgetBuilder and close friends. (#24731) 2018-11-27 11:28:31 -08:00
Ian Hickson
aae968cd45
Improve StreamBuilder documentation (#23713) 2018-11-26 12:17:57 -08:00
liyuqian
d9ad220bbb
Explain why Opacity could be slow (#24255) 2018-11-20 15:27:21 -08:00
Dan Field
19b97ae515
Doc clarifications for semantics properties (#24544)
* update semantics properties doc
2018-11-19 23:14:04 -08:00
Hans Muller
94dab8fe91
Added TextField.onTap() (#24536) 2018-11-19 18:06:44 -08:00
Gary Qian
d3377c4ab9
Fix documentation for supportedLocales (#24547) 2018-11-19 17:26:31 -08:00
Noor Dawod
9d2037e9a8 Check for empty and null preferredLocales before passing to 'localeResolutionCallback'. (#24481) 2018-11-19 14:17:47 -08:00
Hans Muller
ec4f22c17b
Revert "Restore Flutter Gallery Shrine Demo, again (round 3) (#24531)" (#24538)
This reverts commit 4ec8883b83c94a7ba55cdf94af18830074dc24f2.
2018-11-19 13:02:18 -08:00
Hans Muller
4ec8883b83
Restore Flutter Gallery Shrine Demo, again (round 3) (#24531) 2018-11-19 12:21:49 -08:00
jslavitz
743960df27
Cupertino picker null color fix (#24529)
*null fix and test
2018-11-19 12:00:21 -08:00
Jonah Williams
9d81c67a3f
Pass correct physics instance to Scrollable semantics (#24416) 2018-11-19 10:31:02 -08:00
Alexandre Ardhuin
79b5e5bc8a
Add missing lints (#24381)
* update lint list

* enable sort_pub_dependencies

* enable avoid_returning_null_for_void

* enable flutter_style_todos
2018-11-19 10:37:55 +01:00
jslavitz
5385132c6b
Separate keep alive logic from SliverMultiBox classes (#24192)
* sliver separation and test
2018-11-16 16:53:59 -08:00
Justin McCandless
a8552ca7ec
Switch list tile adaptive (#24437)
* SwitchListTile.adaptive for wrapping an adaptive Switch

* Test SwitchListTile.adaptive same as Switch.adaptive

* Remove TODO

* Comment and switch statement cleanup
2018-11-16 14:50:17 -08:00
jslavitz
265485033b
Fixes navigation page back drag area for iPhone X (#24375)
* nav fix and test
2018-11-16 12:47:50 -08:00
jslavitz
b3d9fb4dee
Scaffold Drawer pull out area fix for notched devices (#24367)
* Adds fix and test
2018-11-16 12:47:34 -08:00
Justin McCandless
c8ff617fd8
Text field border radius bug fix (#24414)
* Fix radius glitch by carrying over border when lerping outline borders

* Test that border doesn't change

* Regression comment
2018-11-16 09:32:24 -08:00
xster
988bfc166d
iOS tap handling on CupertinoTextField (#24034) 2018-11-15 18:07:17 -08:00
Dan Field
78c5bb2a8e
Make progress indicators accessible (#24275)
* Make progress indicators accessible
2018-11-15 15:54:56 -08:00
Justin McCandless
f9bccb0280
Handle a missing ListView separator as an error (#24312)
* Handle a missing ListView separator as an error

* Handle missing item, and errors in itemBuilder and separatorBuilder

* CR fixes and move error handling into sliver.dart to handle all ListView constructors

* Only show an error for null separatorBuilder value in debug mode
2018-11-15 14:40:13 -08:00
Diego Tori
9447be7370 Added support for passing in velocity and offset into Draggable.onDragCompleted (#22267)
* Added support for passing in velocity and offset into Draggable.onDragCompleted.

* Fixed documentation of DragCompletedCallback.

* Spun off previous onDragCompleted breaking changes into new callback called Draggable.onDragEnd.

* Revert "Fixed documentation of DragCompletedCallback."

This reverts commit 069051f5be0d4ec6a1f4b3f072e535ca87e5d740.

* Revert "Added support for passing in velocity and offset into Draggable.onDragCompleted."

This reverts commit 7ef744aa5645429b7bc92527226203ee8bff68ec.

* DraggableDetails constructor is now declared first as per Flutter code style.

* Draggable.onDragEnd will only call back if its widget is currently mounted to the tree.

* Moved "});" in DraggableDetails constructor to new line, vertically aligned with the constructor name, as per Flutter code style.

* Added space between if statement in drag_target.dart.

* widget.onDragEnd call is now formated as per flutter code style.

* Added more details to DraggableDetails documentation.

* Added brackets to if statement block as per Flutter code style.

* Fixed minor nits in DraggableDetails documentation.

* Made DraggableDetails constructor public. Also added documentation for its constructor.
2018-11-15 09:11:04 -08:00
S McDowall
87156df6d9 Optionally show the text field length but not the max (#24183)
If maxLength is set to TextField.noMaxLength then continue to show the character counter but do not display the max input length value.
2018-11-14 16:04:39 -08:00