4850 Commits

Author SHA1 Message Date
fmatosqg
7d25378932 Make image resolution more strict, clean gallery pubspec.yaml (#17241) (#17322) 2018-05-26 08:33:13 -07:00
Jonah Williams
b6ceff552b
re-add semantic service events for tap and longPress (#17918) 2018-05-25 18:42:02 -07:00
Todd Volkert
bae78a6f73
Fix RenderListTile actual baseline computation (#17915)
It should be calling `tile.getDistanceToActualBaseline()` rather than
`tile.getDistanceToBaseline()`.  This is causing us to hit assertions
`getDistanceToBaseline()`
2018-05-25 13:15:34 -07:00
Michael Goderbauer
1361071a21
Don't crash when TextField w/ explicit controller is activated via a11y (#17892)
Fixes #17801.
2018-05-25 09:56:24 -07:00
Emmanuel Garcia
c4d6311a29
Fix #16464
* Fix #16464: Pass hit test when a big child is inside RenderFittedBox, RenderTransform, RenderFractionalTranslation, or RenderFollowerLayer

* Override `hitTestChildren`

* RenderTransform and RenderFollowerLayer shouldn't check if they are hit
themselves

* Test the hit test for translated child into translated box

* Add hit test for `FractionalTranslation`

* Don't check if RenderFractionalTranslation is hit themself

* Add hit test for FractionalTranslation

* Add test for FractionalTranslation
2018-05-24 23:16:16 -07:00
Michael Goderbauer
d5a103402c
Expandable Search (#17629) 2018-05-24 09:30:37 -07:00
Michael Goderbauer
bf0f4e6b2e
Document defaults of GestureDetector.behavior and link to debugging options (#17785) 2018-05-23 17:01:19 -07:00
Hans Muller
14cce38668
Remove built-in right-edge appbar padding (#17852) 2018-05-23 13:14:12 -07:00
Collin Jackson
66b50ed02b
Default toggleableActiveColor to accentColor if not set (#17848) 2018-05-23 12:56:28 -07:00
Hans Muller
41fb069cb7
Prevent Switch from looping on and off (#17821) 2018-05-23 09:49:14 -07:00
Todd Volkert
9471e4e216
Ensure that VM service extension handlers are run on outer event loop. (#17812)
Fixes https://github.com/flutter/flutter/issues/17597
2018-05-22 11:55:46 -07:00
Hans Muller
0a383fce36
Fix InkRipple.cancel(), added paints..everything (#17787) 2018-05-22 07:46:57 -07:00
Yegor
4beb57c324
Roll engine; pass semantics child orders (#16970)
* pass semantics children in traversal and hit test orders

* explain why we are inverting _children

* Roll engine
2018-05-21 20:55:28 -07:00
Michael Goderbauer
7471ff8c89
showOnScreen doesn't trigger scroll if item is already fully on screen (#17729) 2018-05-21 16:33:47 -07:00
ng1905
eda3167ac6 Fix ScrollOffset calculation when childCount is null (#17722) 2018-05-21 15:39:09 -07:00
Hans Muller
12bab13429
Handle the case where InputDecorator is constrained to 0x0 (#17777) 2018-05-21 13:11:02 -07:00
Victor Choueiri
8717a5e6f7 Fix Scaffold.endDrawer dartDoc to mention openEndDrawer (#17719) 2018-05-18 17:19:35 -07:00
Greg Spencer
1f5fcb7432
Speed up AnimatedSwitcher. (#17265)
This optimizes the AnimatedSwitcher so that it tags the right widget with its keyed subtree, and avoids rebuilding the transition unnecessarily.

This significantly improves the performance of Chips (which uses AnimatedSwitcher to swap out it's avatar and delete icon children).
2018-05-18 16:27:19 -07:00
Christopher Araüjo
8a4db32bb8 Added onChangeStart and onChangeEnd to CupertinoSlider (#17535)
This is a follow up on issue #17169 and the pull request #17298

This pull request adds the onChangeStart and onChangeEnd callbacks for CupertinoSlider. These are called when a user starts and ends a change respectively.

Pushing for @dcaraujo0872, the PR author.
2018-05-18 14:52:46 -07:00
xster
ef25052c51
Let scrollOffsetCorrection on small lists not leave the list stuck in overscroll (#17599) 2018-05-18 14:40:39 -07:00
Greg Spencer
3c5a7a3005
Make non-global constants have consistent naming (with just _ instead of _k) (#17584)
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this.

Only naming changes to private vars: no logic changes.
2018-05-17 23:04:41 -07:00
Greg Spencer
e4b574d3d3
Cupertino Dialog Changes (#17676)
This replaces abandoned PR #14824 by @ekbiker, and gives it some love.
2018-05-17 22:36:16 -07:00
Noam Drong
fd55c4ec5b Add glyph references for Cupertino-style icons (#16605) 2018-05-17 12:42:49 -07:00
Ryan Macnak
2e24351fb1
Roll engine to 4374ccc1be46f0f5e0d86b44a76cc3e1f1af8bb0. (#17669) 2018-05-17 10:53:00 -07:00
Greg Spencer
ac67efbc83
Moving API doc asset URLs to point to the new location. (#17697)
I'm moving the assets in the assets-for-api-docs repo to a slightly different location to help with organization in that repo, so this PR points the doc URLs to the new location. The old assets won't be removed until this PR makes its way to the API docs website.

No documentation or code changes here, other than changing doc image URLs.
2018-05-17 09:53:06 -07:00
Dan Field
85cb38e71a
Fix consolidate HTTP response and add test (#17082)
* Fix consolidate response and add test

* Update AUTHORS

* ignore content-length

* fix formatting/update comment

* more commas

* Fix consolidate response and add test

* Update AUTHORS

* ignore content-length

* fix formatting/update comment

* more commas

* remove extra newline
2018-05-17 07:04:05 -04:00
Michael Goderbauer
6c9a7c5803
fixes (#17624) 2018-05-16 14:20:16 -07:00
Hans Muller
60272ee5bd
Restore the ListTile layout updates (#17661)
restored https://github.com/flutter/flutter/pull/17496
restored https://github.com/flutter/flutter/pull/17580
2018-05-16 12:33:07 -07:00
Sam Rawlins
1f76f7f9d2 Migrate to Mockito 3's anyNamed (#17632) 2018-05-16 10:19:05 -07:00
Jason Simmons
bb35bc3627
Add a background paint property to TextStyle (#17586)
See https://github.com/flutter/flutter/issues/11961
2018-05-16 09:19:28 -07:00
Greg Spencer
f38743593d
Add Spacer Widget (#16642)
This adds a simple spacer widget first suggested by Scott Stoll (@ScottS2017) in the abandoned PR #15802

This PR replaces that one, cleans it up, and adds a test.
2018-05-15 19:37:21 -07:00
Jonah Williams
ebd9a9621d
Increase contrast of Checkbox, Radio, And Switch widgets (#17637) 2018-05-15 17:55:45 -07:00
Hans Muller
6dcb0d62c3
Change kRadialReactionRadius from 24 to 20 (#17620) 2018-05-15 15:06:03 -07:00
Hans Muller
b7fc015f0a
Revert "Updated ListTile layout" (#17612)
This reverts commit ee019c0bca05c9d2293599e88aa2da0fdb9a76ce.
2018-05-15 14:08:13 -07:00
Hans Muller
c169136eff
Revert "Fixing list tile size in the presence of a large subtitle" (#17611) 2018-05-15 11:52:34 -07:00
David Shuckerow
5159ab3513
Add the ability to limit Draggables to a single axis (#17587)
* Add a draggable axis restrictor and tests
2018-05-15 10:09:25 -07:00
Todd Volkert
c4cb0ecff3
Updates to debugDisableShadows (#17577)
1. Make CupertinoSwitch use BoxShadow.toPaint() so that it respects
   the `debugDisableShadows` flag.
2. Increase blue radius on debug banner
3. Only stroke "synthetic shadow" borders if elevation is positive.
2018-05-15 08:55:42 -07:00
Ian Hickson
8be2682ee4
Trivial cleanup of layer debugging flags (#17411)
In theory, this should aid with tree shaking and minutely optimize the code in release builds.
2018-05-14 23:23:55 -07:00
Greg Spencer
a25bbc7bfc
Fixing list tile size in the presence of a large subtitle (#17580)
Take into account the subtitle height when adjusting the height of the widget. Added a test.
2018-05-14 15:51:12 -07:00
Hans Muller
ee019c0bca
Updated ListTile layout (#17496) 2018-05-14 08:18:17 -07:00
Sam Rawlins
5fafface34 Bump mockito to 3.0.0-alpha+5 (#17487) 2018-05-11 15:27:15 -07:00
Jason Simmons
2f122f7d2a
Add a golden image test for centered text (#17517) 2018-05-11 12:17:18 -07:00
Hans Muller
674e44f361
Correct a typo in InputDecorator, affects computeMinIntrinsicHeight() (#17512) 2018-05-11 10:14:32 -07:00
Konstantin Scheglov
9b65fc6529
Rebase after package:isolate fixes. (#17289) 2018-05-10 18:52:33 -07:00
xster
e42c50cf20
Post libtxt/post iOS 11 fidelity fine tuning (#17366) 2018-05-10 17:35:18 -07:00
Greg Spencer
c2c64a5a4c
Add onChangeStart and onChangeEnd to slider. (#17298)
This fixes #17169 by adding onChangeStart and onChangeEnd to the slider. These will be called when the user starts a change, and when they end a change, regardless of whether that change is a tap or a drag.

These differ from onChanged, in that they only report when the user starts and ends an interaction, not at every slight change.
2018-05-10 17:29:43 -07:00
Greg Spencer
a365c41cb5
Fix handling of null body2 text style for chip and slider (#17311)
Before this change, if you specified a non-null textTheme, but the theme you specified didn't have a body2 defined, then creating a ChipTheme would assert (which means creating a ThemeData would fail).

This adds handling for this corner case to default to reasonable values in that case. The slider had the same problem, but for accentTextTheme, so I fixed that too.

While I had the patient open, Hans and I noticed that TextTheme.merge wasn't doing the right thing in the case where some members were null either, so I fixed that, and added some examples, since merge/copyWith are common operations that are not always well understood.

Fixes #17251
2018-05-10 14:37:14 -07:00
Zachary Anderson
bb4afb0472 Roll engine to 37e20af6a324cd4cfa1324b8c644712ef8224359 (#17481) 2018-05-10 14:36:54 -07:00
Devon Carew
d427d26d1b
Unpin analyzer - no longer use the version from the sdk (#17479)
* no longer use the analyzer version shipped in the sdk

* update all package versions to the latest
2018-05-10 13:31:54 -07:00
Devon Carew
09dec7f508
re-write flutter analyze to use the analysis server (#16979)
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
2018-05-10 09:48:40 -07:00