4810 Commits

Author SHA1 Message Date
Sam Rawlins
5fafface34 Bump mockito to 3.0.0-alpha+5 (#17487) 2018-05-11 15:27:15 -07:00
Jason Simmons
2f122f7d2a
Add a golden image test for centered text (#17517) 2018-05-11 12:17:18 -07:00
Hans Muller
674e44f361
Correct a typo in InputDecorator, affects computeMinIntrinsicHeight() (#17512) 2018-05-11 10:14:32 -07:00
Konstantin Scheglov
9b65fc6529
Rebase after package:isolate fixes. (#17289) 2018-05-10 18:52:33 -07:00
xster
e42c50cf20
Post libtxt/post iOS 11 fidelity fine tuning (#17366) 2018-05-10 17:35:18 -07:00
Greg Spencer
c2c64a5a4c
Add onChangeStart and onChangeEnd to slider. (#17298)
This fixes #17169 by adding onChangeStart and onChangeEnd to the slider. These will be called when the user starts a change, and when they end a change, regardless of whether that change is a tap or a drag.

These differ from onChanged, in that they only report when the user starts and ends an interaction, not at every slight change.
2018-05-10 17:29:43 -07:00
Greg Spencer
a365c41cb5
Fix handling of null body2 text style for chip and slider (#17311)
Before this change, if you specified a non-null textTheme, but the theme you specified didn't have a body2 defined, then creating a ChipTheme would assert (which means creating a ThemeData would fail).

This adds handling for this corner case to default to reasonable values in that case. The slider had the same problem, but for accentTextTheme, so I fixed that too.

While I had the patient open, Hans and I noticed that TextTheme.merge wasn't doing the right thing in the case where some members were null either, so I fixed that, and added some examples, since merge/copyWith are common operations that are not always well understood.

Fixes #17251
2018-05-10 14:37:14 -07:00
Zachary Anderson
bb4afb0472 Roll engine to 37e20af6a324cd4cfa1324b8c644712ef8224359 (#17481) 2018-05-10 14:36:54 -07:00
Devon Carew
d427d26d1b
Unpin analyzer - no longer use the version from the sdk (#17479)
* no longer use the analyzer version shipped in the sdk

* update all package versions to the latest
2018-05-10 13:31:54 -07:00
Devon Carew
09dec7f508
re-write flutter analyze to use the analysis server (#16979)
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
2018-05-10 09:48:40 -07:00
Ian Hickson
ca94bfdfc6 Factor our common Paint-building code used with BoxShadow (#17363) 2018-05-09 22:42:38 -07:00
Jonah Williams
5732219500
Extend SystemUiOverlayStyle with additonal values for each platform (#17171) 2018-05-09 19:30:17 -07:00
Hans Muller
a02568b3ca
Added MediaQuery.textScaleFactorOf() (#17450) 2018-05-09 17:08:22 -07:00
Michael Goderbauer
7809651c74
Put cursor at end of field if textfield is focused (#17367) 2018-05-09 16:05:47 -07:00
Michael Goderbauer
dcb47f62ec
A11y fixes and tests for PopUpMenu (#17446) 2018-05-09 16:05:20 -07:00
Jason Simmons
4b6e574466
Use unselected styles for the tabs adjacent to the selected tab (#17397)
Fixes https://github.com/flutter/flutter/issues/16169
2018-05-09 09:56:35 -07:00
Anatoly Pulyaevskiy
50a1d91ff3 Allow customization of TextSpan in EditableText (#16909)
* Allow customization of TextSpan in EditableText

* Addressed PR comments

* Added test with custom-styled EditableText subclass

* More code style fixes
2018-05-08 17:40:54 -07:00
Peter Etelej
e54887fb12 Fix minor dartdoc typo (#17381)
Minor typo fix for BottomAppBar doc
2018-05-08 08:17:44 -07:00
Jonah Williams
cb7afc4a63
Roll engine to 57f53b98a482c6f7f921f06f974c4d199097bfa1 (#17362) 2018-05-07 18:24:29 -07:00
Hans Muller
f8d0d877f5
Textfield InputDecorator height can grow to accomodate error text (#17292) 2018-05-04 13:26:46 -07:00
Michael Goderbauer
7984f6e043
Implicit a11y scrolling for iOS (and caching in Viewports) (#17021) 2018-05-04 10:48:06 -07:00
Chris Bracken
322eb81a79
Revert longPress/Tap and Gallery changes (#17269)
Revert longPress/Tap and Gallery changes
2018-05-03 16:51:45 -07:00
Jonah Williams
50bd39a913
Add longPress/Tap event to SemanticService (#16945) 2018-05-03 11:04:43 -07:00
Ian Hickson
57dd51a301
Fix documentation for UnconstrainedBox and code cleanup (#17249) 2018-05-03 10:56:35 -07:00
Konstantin Scheglov
9fe53b0d2b
Export @required from src/widgets/framework.dart (#17208) 2018-05-03 08:50:40 -07:00
Todd Volkert
65079ad5f2
Add Flutter-repo-specific golden comparator (#17205)
In order to avoid checking binaries into flutter/flutter,
this comparator can be used to retrieve golden files from
a sibling flutter/goldens repository.

https://github.com/flutter/flutter/issues/16859
2018-05-03 07:39:41 -07:00
xster
4e6045883c
Fix front layer can be tapped through bug on gallery (#17181) 2018-05-02 14:31:59 -07:00
Adrian Secord
1680e55c02 Updated links to Material design guidelines to use short links. (#17077) 2018-04-30 20:29:46 -07:00
Todd Volkert
b2c67e88d4
Make Layer.toImage() accept bounds rather than size (#17129)
It allows callers to account for things like shadows that paint
outside the bounds of the widget.

https://github.com/flutter/flutter/issues/16859
2018-04-30 15:26:17 -07:00
Todd Volkert
5972fdb7aa
Fix RenderView.paintBounds (#17126)
It should account for the device pixel ratio

https://github.com/flutter/flutter/issues/16859
2018-04-30 13:48:42 -07:00
Todd Volkert
a5a33325ef
Move toImage() impl from RepaintRenderBoundary to OffsetLayer (#17060)
https://github.com/flutter/flutter/issues/16859
2018-04-27 21:19:24 -07:00
Jonah Williams
f0c4bc30c6
Add SemanticService.tooltip method for Android tooltips (#16978) 2018-04-27 20:02:11 -07:00
Hans Muller
6334da0109
Assert that required dialog context args are non-null (#16890) 2018-04-27 16:33:38 -07:00
xster
f8fe5e3cba
Fix some glyph codes that pointed to the wrong places in CupertinoIcons (#16916) 2018-04-27 16:25:14 -07:00
Hans Muller
bf3bd7667f
New Gallery UI reprise (#17031) 2018-04-27 08:11:20 -07:00
Ian Hickson
c482cc4bb3
Add some suggestions for using Column with a SingleChildScrollView (#16500) 2018-04-26 16:06:39 -07:00
Ian Hickson
ca35ddd439
Add some Transform constructors (#16553)
See https://github.com/flutter/flutter/pull/15383
2018-04-26 16:06:17 -07:00
Hans Muller
e62a6451f7
Fixed (#17010) 2018-04-26 10:29:44 -07:00
Jason Simmons
d8f2f36935
Use a space instead of a zero-width space to calculate the preferred height of a line of text (#16972)
The zero-width space character may not be supported by the font requested in
the text style.  If that happens, then libtxt will fall back to another font
to render that character, resulting in text metrics that do not match the
intended font.

Fixes https://github.com/flutter/flutter/issues/16257
2018-04-26 09:42:26 -07:00
Jason Simmons
e06f69e1cd
Remove an obsolete workaround for Blink's calculation of baselines (#16966) 2018-04-25 14:24:07 -07:00
Yegor
a7d7652a5f
Set text direction in semantics along with Directionality (#16907)
* Set text direction in semantics along with Directionality

* update tests for the extra SemanticsNode
2018-04-24 18:29:26 -07:00
Yegor
d354096299
a11y traversal: sort locally; use new sorting algorithm (#16253)
New a11y traversal:

- sort direct sibling SemanticsNodes only
- use new sorting algorithm
- implement RTL
- test semantics in traversal order by default
- add AppBar traversal test
- breaking: remove nextNodeId/previousNodeId from the framework
- breaking: remove DebugSemanticsDumpOrder.geometricOrder
2018-04-23 14:23:49 -07:00
Hans Muller
d3d4976f63
InputDecorator input and hint widgets have the same width (#16894) 2018-04-23 13:53:15 -07:00
debuggerx01
ff58db4ac3 Fix hue to 0.0 when red == green == blue. (#16872)
When passing a Color object with same R/G/B code ( e.g. [new Color.fromRGBO(100, 100, 100, 1.0)] ) to HSVColor.fromColor(Color color) , the hue in return will be NaN .
2018-04-23 13:47:47 -07:00
Emmanuel Garcia
d43b4d0ad8 Fix #16247: SizeTransition clamps negative size factors (#16579)
As pointed out in the bug, the issue is fixed by just clamping sizeFactor.value.

Fixes #16247
2018-04-23 13:47:07 -07:00
Greg Spencer
a043ac41f6
Adding an API for capturing an image of a RenderRepaintBoundary. (#16758)
This adds a toImage function to RenderRepaintBoundary that returns an uncompressed raw image of the RenderRepaintBoundary and its children. A device pixel ratio different from the physical ratio may be specified for the captured image. A value of 1.0 will give an image in logical pixels.
2018-04-23 12:28:17 -07:00
Greg Spencer
037df5f2ff
Remove unneeded assert in UnconstrainedBox (#16778)
This addresses #16593 by removing the unneeded assert in the setter for constrainedAxis. Null was meant to be allowed there.

This replaces #16599 and fixes #16593, reported by @maksimr
2018-04-23 12:27:33 -07:00
Todd Volkert
a742b11a50
Roll engine to cb3376c5dedb71cec7a88b8a8904acc5dd6c6ba1 (#16841)
This contains the following commit:

flutter/engine@cb3376c Support different encodings in Image.toByteData() (#16635)
2018-04-21 16:10:39 -07:00
xster
90ca815242
Make bottom app bar safe area friendly (#16820) 2018-04-20 17:14:03 -07:00
Michael Goderbauer
2eb290e718
Wire up SemanticsFlag.isHidden (#16772) 2018-04-20 17:10:40 -07:00