4791 Commits

Author SHA1 Message Date
Hans Muller
f8d0d877f5
Textfield InputDecorator height can grow to accomodate error text (#17292) 2018-05-04 13:26:46 -07:00
Michael Goderbauer
7984f6e043
Implicit a11y scrolling for iOS (and caching in Viewports) (#17021) 2018-05-04 10:48:06 -07:00
Chris Bracken
322eb81a79
Revert longPress/Tap and Gallery changes (#17269)
Revert longPress/Tap and Gallery changes
2018-05-03 16:51:45 -07:00
Jonah Williams
50bd39a913
Add longPress/Tap event to SemanticService (#16945) 2018-05-03 11:04:43 -07:00
Ian Hickson
57dd51a301
Fix documentation for UnconstrainedBox and code cleanup (#17249) 2018-05-03 10:56:35 -07:00
Konstantin Scheglov
9fe53b0d2b
Export @required from src/widgets/framework.dart (#17208) 2018-05-03 08:50:40 -07:00
Todd Volkert
65079ad5f2
Add Flutter-repo-specific golden comparator (#17205)
In order to avoid checking binaries into flutter/flutter,
this comparator can be used to retrieve golden files from
a sibling flutter/goldens repository.

https://github.com/flutter/flutter/issues/16859
2018-05-03 07:39:41 -07:00
xster
4e6045883c
Fix front layer can be tapped through bug on gallery (#17181) 2018-05-02 14:31:59 -07:00
Adrian Secord
1680e55c02 Updated links to Material design guidelines to use short links. (#17077) 2018-04-30 20:29:46 -07:00
Todd Volkert
b2c67e88d4
Make Layer.toImage() accept bounds rather than size (#17129)
It allows callers to account for things like shadows that paint
outside the bounds of the widget.

https://github.com/flutter/flutter/issues/16859
2018-04-30 15:26:17 -07:00
Todd Volkert
5972fdb7aa
Fix RenderView.paintBounds (#17126)
It should account for the device pixel ratio

https://github.com/flutter/flutter/issues/16859
2018-04-30 13:48:42 -07:00
Todd Volkert
a5a33325ef
Move toImage() impl from RepaintRenderBoundary to OffsetLayer (#17060)
https://github.com/flutter/flutter/issues/16859
2018-04-27 21:19:24 -07:00
Jonah Williams
f0c4bc30c6
Add SemanticService.tooltip method for Android tooltips (#16978) 2018-04-27 20:02:11 -07:00
Hans Muller
6334da0109
Assert that required dialog context args are non-null (#16890) 2018-04-27 16:33:38 -07:00
xster
f8fe5e3cba
Fix some glyph codes that pointed to the wrong places in CupertinoIcons (#16916) 2018-04-27 16:25:14 -07:00
Hans Muller
bf3bd7667f
New Gallery UI reprise (#17031) 2018-04-27 08:11:20 -07:00
Ian Hickson
c482cc4bb3
Add some suggestions for using Column with a SingleChildScrollView (#16500) 2018-04-26 16:06:39 -07:00
Ian Hickson
ca35ddd439
Add some Transform constructors (#16553)
See https://github.com/flutter/flutter/pull/15383
2018-04-26 16:06:17 -07:00
Hans Muller
e62a6451f7
Fixed (#17010) 2018-04-26 10:29:44 -07:00
Jason Simmons
d8f2f36935
Use a space instead of a zero-width space to calculate the preferred height of a line of text (#16972)
The zero-width space character may not be supported by the font requested in
the text style.  If that happens, then libtxt will fall back to another font
to render that character, resulting in text metrics that do not match the
intended font.

Fixes https://github.com/flutter/flutter/issues/16257
2018-04-26 09:42:26 -07:00
Jason Simmons
e06f69e1cd
Remove an obsolete workaround for Blink's calculation of baselines (#16966) 2018-04-25 14:24:07 -07:00
Yegor
a7d7652a5f
Set text direction in semantics along with Directionality (#16907)
* Set text direction in semantics along with Directionality

* update tests for the extra SemanticsNode
2018-04-24 18:29:26 -07:00
Yegor
d354096299
a11y traversal: sort locally; use new sorting algorithm (#16253)
New a11y traversal:

- sort direct sibling SemanticsNodes only
- use new sorting algorithm
- implement RTL
- test semantics in traversal order by default
- add AppBar traversal test
- breaking: remove nextNodeId/previousNodeId from the framework
- breaking: remove DebugSemanticsDumpOrder.geometricOrder
2018-04-23 14:23:49 -07:00
Hans Muller
d3d4976f63
InputDecorator input and hint widgets have the same width (#16894) 2018-04-23 13:53:15 -07:00
debuggerx01
ff58db4ac3 Fix hue to 0.0 when red == green == blue. (#16872)
When passing a Color object with same R/G/B code ( e.g. [new Color.fromRGBO(100, 100, 100, 1.0)] ) to HSVColor.fromColor(Color color) , the hue in return will be NaN .
2018-04-23 13:47:47 -07:00
Emmanuel Garcia
d43b4d0ad8 Fix #16247: SizeTransition clamps negative size factors (#16579)
As pointed out in the bug, the issue is fixed by just clamping sizeFactor.value.

Fixes #16247
2018-04-23 13:47:07 -07:00
Greg Spencer
a043ac41f6
Adding an API for capturing an image of a RenderRepaintBoundary. (#16758)
This adds a toImage function to RenderRepaintBoundary that returns an uncompressed raw image of the RenderRepaintBoundary and its children. A device pixel ratio different from the physical ratio may be specified for the captured image. A value of 1.0 will give an image in logical pixels.
2018-04-23 12:28:17 -07:00
Greg Spencer
037df5f2ff
Remove unneeded assert in UnconstrainedBox (#16778)
This addresses #16593 by removing the unneeded assert in the setter for constrainedAxis. Null was meant to be allowed there.

This replaces #16599 and fixes #16593, reported by @maksimr
2018-04-23 12:27:33 -07:00
Todd Volkert
a742b11a50
Roll engine to cb3376c5dedb71cec7a88b8a8904acc5dd6c6ba1 (#16841)
This contains the following commit:

flutter/engine@cb3376c Support different encodings in Image.toByteData() (#16635)
2018-04-21 16:10:39 -07:00
xster
90ca815242
Make bottom app bar safe area friendly (#16820) 2018-04-20 17:14:03 -07:00
Michael Goderbauer
2eb290e718
Wire up SemanticsFlag.isHidden (#16772) 2018-04-20 17:10:40 -07:00
Jonah Williams
e7cd5d3867
Throw FlutterError when calling setState in State constructor (#16759)
* log error when calling setState in constructor
2018-04-19 18:00:38 -07:00
Jonah Williams
034a663d33
Semantics object support for edge triggered semantics (#16081)
Semantics object support for edge triggered semantics
2018-04-19 17:59:19 -07:00
Greg Spencer
b83eb465fd
Updating the Chip demo in the Gallery to include all the new types of chips. (#16522)
This chip demo is more interactive than the last one, trying to exercise all of the types of chips for a demo that lets you select different types of "chips" (like tortilla, wood, micro, etc.), and then filter them and select an action on them.
2018-04-19 16:43:22 -07:00
xster
133c98a85b
Fine-tune iOS's scroll start feel (#16721)
* Fine-tune iOS's scroll start feel

* remove negations in doc

* Our own dart-side gesture arena also contributes to the 'jerk'. Make sure that snap is accounted as well.

* Added more code comments from review.
2018-04-19 16:17:44 -07:00
Michael Goderbauer
1ba99b94f2
SliverList works with changing children that are keyed (#16724)
Fixes #14590.
2018-04-19 16:05:41 -07:00
Greg Spencer
0b389fc92e
Change CircleAvatar to use BoxFit.cover for images (#16649)
This is a PR giving some love to the abandoned PR #16263 by @harrisonturton

I've added a test, and formatted it to be readable.

Currently the CircleAvatar does not set a fit property on the DecorationImage it uses to paint images. This causes non-square images to not fully cover the circle, which looks pretty bad. This PR sets it to BoxFix.cover.

Fixes #13478.
2018-04-19 15:52:40 -07:00
Jonah Williams
eb1fd78601
Roll engine to 3405e23a32af4ea3655e5d1a78955066b2573331 (#16755)
* update engine version, ignore scopesRoute and namesRoute flags until framework support is added
2018-04-19 12:35:24 -07:00
Jacob Richman
044dfdb446
Tweak theme_test so it passes when --track-widget-creation is used. (#16717) 2018-04-18 17:46:20 -07:00
Greg Spencer
e6b62a3a30
Adding some tests for onTapDown and onTapCancel (#16682)
Adding some tests for onTapDown and onTapCancel for the InkWell, as suggested in post-submission comments by @Hixie in #16190.

Also, added those to the diagnostic output.
2018-04-18 11:27:55 -07:00
Jacob Richman
928c41e9a7
Support summary-details tree view (#16638)
Support summary-details tree view.
2018-04-18 09:09:34 -07:00
Chinmay Garde
e9177ba3d1 Roll engine to 0c09bf03d. (#16668)
This roll includes the following engine commits:

* flutter/engine@0c09bf03: In the service protocol, if no view is specified to flush tasks on, pick the first one. (#5028)
* flutter/engine@ecaefd7a: Roll src/third_party/skia/ 276886160..1cd6098d5 (50 commits) (#5026)
* flutter/engine@e6545573: Enable 'Speak Screen' and 'Switch Control' for iOS (#5016)
* flutter/engine@3393c179: Fix Android platform channels (#5025)
* flutter/engine@1bc0e1bb: On windows, refer to Dart snapshot directly executable. (#5024)
* flutter/engine@cf6ca32d: Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" (#5023)
* flutter/engine@4b45a53e: Only make ERROR and FATAL log levels visible by default. (#5022)
* flutter/engine@98f6c2d5: Fix shell launcher test (dart2 compliant and stop polling) (#5009)
* flutter/engine@75851f08: Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 (#5020)
* flutter/engine@9495a52d: On iOS, try to use ES3, then fall back to ES2. (#5006)
* flutter/engine@d6d4eec2: Fix broken Linux build (#5019)
* flutter/engine@d15dc76e: Fix broken Chromebot build (#5018)
* flutter/engine@c17a6290: Breadcrumbs to the wiki (#5017)
* flutter/engine@4eaf2c2f: Return raw (unencoded) bytes in Image.toByteData() (#5008)
* flutter/engine@d812a617: Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) (#5014)
* flutter/engine@62aeab72: Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. (#5012)
* flutter/engine@f4ebb180: Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) (#5007)
* flutter/engine@0b7d6be9: Re-land "do not pause rendering when android view loses focus" (#5004)
* flutter/engine@91dee598: If the rasterizer has a valid surface context, use that to create a snapshotting render target. (#4979)
* flutter/engine@570231b7: Specify the packages file path when running engine dart tests. (#5005)
* flutter/engine@0b9cef5a: Minor update to README (#5003)
* flutter/engine@c386418f: Promote line height in text style created from paragraph style (#4995)
* flutter/engine@4e0fbb6f: If the test specifies a .dill file, dont make the engine interpret is as source. (#5002)
* flutter/engine@58e84c8b: Re-land "Support multiple shells in a single process. (#4932)" (#4998)
* flutter/engine@37e5df05: Remove only use of SkPaint::kGenA8FromLCD (#4994)
* flutter/engine@b7358b33: libtxt: cache font families that are remapped to the default font family (#4990)
* flutter/engine@a530035b: libtxt: fix leaks in Skia object reference counting (#4988)
* flutter/engine@0c74fc93: [fuchsia] Fix use-after-free (#4987)
* flutter/engine@b6d2dde9: [fuchsia] Fix build (#4986)
* flutter/engine@1dd12649: [async] Adapt to libasync API changes. (#4980)
2018-04-17 13:41:18 -07:00
Greg Spencer
824b806bfc
Add missing docs to public function. (#16651)
Adding missing docs to the forceRebuild function in the widget inspector.
2018-04-17 12:19:15 -07:00
Mikkel Nygaard Ravn
10cf0cedad
Revert "Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 (#16643)" (#16661) 2018-04-17 12:40:02 +02:00
Todd Volkert
dd32d1b179 Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 (#16643)
* Roll engine to d6d4eec24c38bb06a9b1aef4e70c321d447ba762

Contains the following engine commits:

flutter/engine@1bc0e1b On windows, refer to Dart snapshot directly executable.
flutter/engine@cf6ca32 Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79"
flutter/engine@4b45a53 Only make ERROR and FATAL log levels visible by default.
flutter/engine@98f6c2d Fix shell launcher test (dart2 compliant and stop polling)
flutter/engine@75851f0 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79
flutter/engine@9495a52 On iOS, try to use ES3, then fall back to ES2.
flutter/engine@d6d4eec Fix broken Linux build
flutter/engine@d15dc76 Fix broken Chromebot build
flutter/engine@c17a629 Breadcrumbs to the wiki
flutter/engine@4eaf2c2 Return raw (unencoded) bytes in Image.toByteData()
flutter/engine@d812a61 Roll src/third_party/skia/ e669bdfad..276886160 (9 commits)
flutter/engine@62aeab7 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain.
flutter/engine@f4ebb18 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits)
flutter/engine@0b7d6be Re-land "do not pause rendering when android view loses focus"
flutter/engine@91dee59 If the rasterizer has a valid surface context, use that to create a snapshotting render target.
flutter/engine@570231b Specify the packages file path when running engine dart tests.
flutter/engine@0b9cef5 Minor update to README
flutter/engine@c386418 Promote line height in text style created from paragraph style
flutter/engine@4e0fbb6 If the test specifies a .dill file, dont make the engine interpret is as source.
flutter/engine@58e84c8 Re-land "Support multiple shells in a single process.
flutter/engine@37e5df0 Remove only use of SkPaint::kGenA8FromLCD
flutter/engine@b7358b3 libtxt: cache font families that are remapped to the default font family
flutter/engine@a530035 libtxt: fix leaks in Skia object reference counting
flutter/engine@0c74fc9 [fuchsia] Fix use-after-free
flutter/engine@b6d2dde [fuchsia] Fix build
flutter/engine@1dd1264 [async] Adapt to libasync API changes.

* Run test platform finalizers in reverse order to ensure that shell is shutdown before trying to delete any temporary files or directories. This fixes "Access Denied" error on Windows (see #16657).
2018-04-17 11:52:00 +02:00
Michael Goderbauer
f049f436c8
Update AppBar docs to analyze sample code (#16634) 2018-04-16 14:17:55 -07:00
Jonah Williams
b1ecf1ea9a
Add localizations for navigation menu, popup menu, dialog, and alert (#16633)
* add localizations for navigation menu, popup menu, dialog, and alert
2018-04-16 14:09:20 -07:00
Jacob Richman
ab9ba3f909
Support exposing the InspectorService over the Flutterservice extension protocol as well as the observatory protocol. (#15876)
* Support exposing the InspectorService over the Flutter
service extension protocol as well as the observatory protocol.

We will probably remove most of the observatory protocol support once a
couple versions of the Flutter IntelliJ plugin have shipped that use the
Flutter service extension protocol. The only reason to continue supporting
the observatory protocol is it will allow using the inspector when paused
at a breakpoint.
2018-04-16 10:04:40 -07:00
Greg Spencer
6c049ec286
Rename AnimatedChildSwitcher to AnimatedSwitcher (#16551)
We don't really like the name AnimatedChildSwitcher, and we think that AnimatedSwitcher might be better (since the Child part is redundant). We also considered AnimatedChild, AnimatedTransition and AnimatedReplacement (among others).

Nothing in here besides a rename.
2018-04-15 19:24:49 -07:00
Ian Hickson
1c3f6a851f
Fix formatting of Flex error message (#16498) 2018-04-12 21:16:39 -07:00