4637 Commits

Author SHA1 Message Date
Greg Spencer
d28e9aa5c9
Add slider minimum interaction time (#15358)
This change makes the discrete slider show the value indicator for a minimum amount of time for any interaction (tap, drag).
2018-03-13 09:41:49 -07:00
Greg Spencer
fc96326b9c
Add neck stretch (#15445)
During the review, we determined that it would be good for the value indicator to stretch when the text scale was smaller, and the shrink when it was larger, to keep the value visible over the finger at small sizes, and closer to the finger at large sizes. This implements that change.
2018-03-12 20:28:34 -07:00
Chris Bracken
dc03398bc3
Avoid NPE in InkDecoration dispose (#15473)
Avoids a null pointer exception if dispose() is called on an
already-disposed InkDecoration.
2018-03-12 19:05:55 -07:00
Alexander Aprelev
e23a658685
Rev dependencies up and regenerate stock_messages. (#15469)
This fixes https://github.com/flutter/flutter/issues/15458.
2018-03-12 17:46:26 -07:00
Alexander Aprelev
2f8474f9aa
Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f. (#15444)
* Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f.

Changes since last roll:
```
b6df7a637 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771)
a6764dbd5 Add sources for Fuchsia target. (#4763)
2d5900615 [fuchsia] Remove unused header file. (#4769)
9717063b7 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768)
9a9814312 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)
e74e8b35c [async] Update includes of async headers to new path (#4760)
e2c4b2760 Use Dart 2 camel case constants in the engine Dart libraries (#4766)
9c1e48434 Updates for Fuchsia roll. (#4765)
14c940e27 Switch from fxl::Mutex to std::mutex (#4764)
debf82c0b Roll Garnet (#4759)
5bffdefbb Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761)
```
2018-03-12 15:44:25 -07:00
Jason Simmons
466d15433f
Use Dart 2 camel case constants (#15360) 2018-03-12 11:06:32 -07:00
Hans Muller
33f9afd99c
Updated the BottomNavigationBar class doc (#15347) 2018-03-12 10:27:20 -07:00
P.Y. Laligand
c0118ea4b9
Leave source list empty for Fuchsia targets. (#15337) 2018-03-12 15:38:32 +01:00
Ian Hickson
7865d319ba
Factor out BorderSide creation for dividers (#15403)
This allows other code to get the same style without having to know exactly it is computed.
2018-03-11 13:01:00 -07:00
Ian Hickson
ded3905102
Various documentation improvements. (#15071)
For example, mention the icon used for the drawer menu in the docs (this helps people writing unit tests); add DefaultAssetBundle sample code.
2018-03-11 03:19:18 -07:00
Ian Hickson
48bb5b7926
Include opacity in FadeTransition logging (#15073) 2018-03-09 22:49:19 -08:00
Jason Simmons
4b56ba17d5 More fixes for the prefer_const_literals_to_create_immutables analyzer check (#15363)
See 3961306bad
2018-03-09 16:47:56 -08:00
Alexandre Ardhuin
3961306bad enable lints prefer_const_declarations and prefer_const_literals_to_create_immutables (#14848) 2018-03-09 14:37:06 -08:00
Greg Spencer
7fab7f6d02
Adding edge avoidance, painting tests, general cleanup (#15078)
Fixed the real repaint problem the Slider had (missing addListener), and added tests for it.

Added GlobalKey reparenting test.

Added the ability for the value indicator to slide left and right to avoid falling off the edge of the screen.
It only shifts as much as it can without deforming, but even at large text scales, that is enough to keep the text on the screen.

Updated the formatting on theme_data.dart and others to use longer line length.

Also, removed a color tween that faded the value indicator in as it scaled, since that wasn't to spec.
2018-03-09 14:04:58 -08:00
Michael Goderbauer
3a40d0ee4e
Support SemanticsFlag for Header (#15255) 2018-03-09 13:32:01 -08:00
Alexander Aprelev
ded538a1bb
Update dependencies with forced upgrade. (#15344)
* Update dependencies with forced upgrade.

Now that https://github.com/flutter/flutter/issues/15261 is fixed, do the update with upgrade.

* Update test package use following upgrade

* Replace addOption(allowMultiple) with addMultiOption
2018-03-09 10:38:54 -08:00
Michael Goderbauer
5d03a59379
Allow wrapping CheckBox in Semantics (#15259) 2018-03-09 10:37:59 -08:00
Jonah Williams
7d1ceb4080
Add Text.rich constructor to Text widget (#15317)
* add fromSpan constructor to Text widget and simple smoke test:

* change fromSpan to rich, clean up comments

* 'directly from' to 'with'

* make sure text styles are applied to either data or textspan. add diagnostic properties for span

* add expectation for text style to test case

* some work on diagnostics and docs
2018-03-09 09:57:17 -08:00
Jacob Richman
046c6d5f7f
Track which Widget objects were created by the local project. (#15041)
Make flutter test support the --track-widget-creation flag.
Add widget creation location tests. Tests are skipped when
--track-widget-creation flag is not passed.
2018-03-09 08:09:49 -08:00
Michael Goderbauer
a9e2781132
Do not do semantics for detached objects (#15320) 2018-03-08 22:33:46 -08:00
Michael Goderbauer
f002839d44
Better print-out of semantics tree (#15302) 2018-03-08 19:14:43 -08:00
Jason Simmons
6f5bcb97a4
Do not add spacing to the first child's width in RenderWrap line wrapping (#15272)
The first child fits on the line if the line can accomodate its width.
After the first child the line needs room for the child's width plus spacing.
2018-03-08 15:01:37 -08:00
Todd Volkert
d996ab921c
Rename "slow mode" to be "debug mode" (#15205)
This moves toward more consistency in our messaging. Apps are
launched using --debug, so the banner will reflect the build
mode.
2018-03-08 12:54:06 -08:00
Alexander Aprelev
1a3c9b83c0
Step process, boolean_selector, collection deps up. (#15262)
This is needed to fix 'flutter test --preview-dart-2 test/all.dart' in dev/devicelab
2018-03-08 11:07:03 -08:00
Stefano Rodriguez
b944cd7187 Plug TextDirection into box_decoration background gradient (#14810)
* Plug TextDirection into box_decoration background gradient

* Add test
2018-03-08 11:00:21 -08:00
Jason Simmons
7358d59036
Dart2 typesafe invocation of IsolateConfiguration callback (#15267) 2018-03-08 10:08:59 -08:00
Jonah Williams
27df288568
RenderWrap.performLayout should take spacing into consideration (#15256)
* RenderWrap.performLayout takes should take spacing into consideration when deciding to move to next row/axis

* fix spacing in text

* remove dart:developer import

* remove extra line
2018-03-07 13:00:14 -08:00
xster
c2261a3a2c
Remove a mixin from RenderListWheelViewport that was never used (#14900) 2018-03-07 11:56:36 -08:00
Josh Soref
c5a5945e92 Spelling (#15229)
* spelling: accommodate

* spelling: allotted

* spelling: anonymous

* spelling: artificial

* spelling: associated

* spelling: asset

* spelling: button

* spelling: canvas

* spelling: compatibility

* spelling: coverage

* spelling: condition

* spelling: decoration

* spelling: deferring

* spelling: diameter

* spelling: direction

* spelling: displacement

* spelling: dropdown

* spelling: needing

* spelling: environment

* spelling: exited

* spelling: expansion

* spelling: explore

* spelling: families

* spelling: horizontal

* spelling: increment

* spelling: indices

* spelling: internationalization

* spelling: labrador

* spelling: localizations

* spelling: midflight

* spelling: milliseconds

* spelling: minimum

* spelling: multiple

* spelling: multiplication

* spelling: navigator

* spelling: overridden

* spelling: package

* spelling: performance

* spelling: platform

* spelling: porsche

* spelling: position

* spelling: preceded

* spelling: precede

* spelling: precedence

* spelling: print

* spelling: property

* spelling: readily

* spelling: reproducibility

* spelling: rounded

* spelling: scroll

* spelling: separate

* spelling: separator

* spelling: services

* spelling: specific

* spelling: specify

* spelling: synchronously

* spelling: through

* spelling: timeout

* spelling: triangle

* spelling: trivial

* spelling: unusual

* spelling: then

* spelling: vertically

* spelling: visible

* spelling: visited

* spelling: voice
2018-03-06 21:36:03 -08:00
Hans Muller
e1c38aa024
Enable aligning a dropdown button's width with its menu's width (#14849) 2018-03-06 17:37:27 -08:00
xster
f048023638
Cupertino picker haptic (#14831)
* Add selection haptic feedback to Cupertino Pickers

* review

* don't haptic on android
2018-03-06 15:38:00 -08:00
Michael Goderbauer
86be138d9c
Make BottomNavBar accessible (#15211) 2018-03-06 15:08:39 -08:00
Sarah Zakarias
3ecc2a4ed2
Url encode asset lookup key (#15171) 2018-03-06 09:24:31 +01:00
P.Y. Laligand
8709e5e71f
[fuchsia] Add explicit sources to a few targets. (#15182) 2018-03-05 18:03:09 -08:00
Yegor
e9c982c39f
[semantics]: minor docs & style clean-up (#15181)
* [semantics]: minor docs & style clean-up

* remove a
2018-03-05 17:01:42 -08:00
Jonah Williams
419fef3f8b
Check that State.initState and State.didUpdateWidget don't return Futures (#15183)
* add a debug check that the returned Type of State.initState and State.didUpdateWidget are not Futures

* add test to verify that async lifecycles throw FlutterErrors

* address some feedback, match implementation of setState check

* address feedback from hixie

* fix odd spacing in test
2018-03-05 15:59:18 -08:00
Alexander Aprelev
70f60b17d7
Run dev/bots/test's flutter drive test in preview-dart-2 (#15090)
* Run dev/bots/test's flutter drive test in preview-dart-2

* Fix extension callback type

* More type fixes
2018-03-05 08:55:10 -08:00
Hans Muller
6e13128f45
OutlineButton doc fixes (#15092) 2018-03-02 17:43:22 -08:00
Siva
beffcf1ba1
Fix incorrect generic type specification, causes a compilation error (#15049)
when a hot reload is done after modifying a component in the flutter
package.
2018-03-02 15:43:40 -08:00
Alexander Aprelev
65731f75bd
Attempt to fix flutter drive --preview-dart-2 errors. (#14897) 2018-03-02 15:16:46 -08:00
Hans Muller
c4e8438046
Added Material OutlineButton (#14939) 2018-03-02 08:26:23 -08:00
Chris Bracken
73a1a74ba1
Eliminate RenderView orientation, timeForRotation (#15044)
Orientation, and by extension time for rotation between orientations,
was aspirational and never used.

While this is technically a breaking change, this code never actually
did anything. If you were setting either orientation or timeForRotation,
simply delete those parameters and the code will continue to behave
identically to how it had been.
2018-03-01 18:34:15 -08:00
Greg Spencer
a1d2443e7b
Fix render problem on Slider (#15039)
Fixes a small rendering problem when dragging the slider, as well as a couple of small bugs (de-duping of value changes, and actually using a parameter passed to _unlerp).
2018-03-01 16:25:21 -08:00
Greg Spencer
701eff4ac5
Slider Visual Update (#14901)
This implements an update to the look of the Slider widget.

Specifically, it does the following:

* Adds the ability to customize the colors of all components of the slider
* Adds the ability to customize the shape of the slider thumb and value indicator
* Adds the ability to show the value indicator on continuous sliders
* Updates the default value indicator to be a "paddle" shape with new animations.
* Changes the tick marks to be visible all the time on discrete sliders
* Fixes a memory leak of an animation controller.
* Removes "thumbOpenAtMin" flag, which is no longer needed, and can be emulated by the
custom thumb shape support. It was not widely used.
* Adds tests for all of the new features.
2018-03-01 13:03:20 -08:00
Ian Hickson
b9a7f1b915
Add a hasListeners to ChangeNotifier (#14946)
I found that some ValueListeners want to know when they should start
doing work (e.g. if the value comes from polling a network resource).
2018-02-28 16:37:36 -08:00
xster
265d0d3c29
Add more haptic feedback varieties (#14829)
* Add more haptic feedback varieties

* tests

* un-meta-ify the test
2018-02-28 16:20:27 -08:00
Phil Quitslund
a3f520e488
Add ‘name’s to widget location Json. (#14993) 2018-02-28 15:33:56 -08:00
najeira
e0956cbdb7 remove "the" duplications (#14952) 2018-02-28 12:21:13 -08:00
Siva
fbf68bbc6d
Roll engine to version b05efc204090f430387398d3c35589571a2fe16b (#14969)
* roll engine version in flutter/flutter to b05efc204090f430387398d3c35589571a2fe16b

* Fix analyzer warnings.
2018-02-28 11:00:37 -08:00
amirh
6993b203c0
Allow changing a clipper's type (ShapeBorderClipper,_BottomAppBarClipper). (#14937)
The downcast was crashing when toggling hasNotch for BottomAppBar.
2018-02-27 17:39:49 -08:00