5424 Commits

Author SHA1 Message Date
Stanislav Baranov
e32cd85446
Clean up PointerEvent documentation. (#24002) 2018-11-09 14:26:21 -08:00
Gary Qian
dfd0229560
New locale resolution algorithm to use full preferred locale list, include scriptCode in Locale. (#23583) 2018-11-09 11:33:42 -08:00
Gary Qian
5071657e8e
Add docs to explain cursor drawing behavior. (#24135) 2018-11-09 11:32:46 -08:00
Todd Volkert
95c9ae451e
Update packages --force-upgrade (#24126) 2018-11-08 22:31:22 -08:00
TL Lee
94d0b2ffc2 [Material] Add API for an unpainted input border (#21289)
* Introduce a rounded InputBorder with no paint

* Update documentation for API

* Change name of Widget to NoStrokeInputBorder and updated documentation

* [FilledInputBorder] PR feedback.

* [FilledInputBorder] typo correction.

* [FilledInputBorder] Removing news.

* [FilledInputBorder] PR feedback.

* [FilledInputBorder] Removing use of borderSide.

* [FilledInputBorder] Adding tests for hashcode.

* [FilledInputBorder] Comments.

* [TextFields] Input decoration feature parity.

* [TextFields] Making floating of placeholder optional.

* [TextFields] Cleanup

* [TextFields] Removing unused isAnimated.

* [TextFields] Cleanup.

* [TextFields] Correcting border.

* [TextFields] Correcting comment.

* [TextFields] Comment.

* [TextFields] Corrections for tests.

* [TextFields] Cleanup.

* [TextFields] Cleanup.

* [TextFields] Tests.

* [TextFields] Cleanup.

* [TextFields] Cleanup.

* [TextFields] Formatting.

* [TextFields] PR feedback.

* [TextFields] PR feedback.

* [TextFields] PR feedback.
2018-11-08 22:00:50 -05:00
Amir Hardon
903c5f8d29
Add DartDoc for UiKitViewController#acceptGesture (#24127) 2018-11-08 16:16:24 -08:00
jslavitz
75ca39f8c3
Animate user account drawer header arrow (#24023)
* Adds user account header arrow animation and test
2018-11-08 12:16:09 -08:00
Amir Hardon
dc4bf652cc
Make UiKitViews participate in gesture arenas (#24027) 2018-11-08 12:11:57 -08:00
Dan Field
9430906e77
clarify widgetsapp docs (#24090)
* clarify widgetsapp docs

* Rename shadowed param, update doc

* pageContentBuilder
2018-11-08 10:46:11 -08:00
Greg Spencer
a6e901130e
Convert existing '## Sample code' samples to '{@tool sample}...{@end-tool}' form. (#24077)
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form.

Also:
1. Fixed a minor bug in analyze-sample-code.dart
2. Made the snippet tool only insert descriptions if the description is non-empty.
3. Moved the Card diagram to before the code sample.
2018-11-07 20:35:10 -08:00
Ian Hickson
f9374fe071
Update the URL to the recommend bug report (#23708)
We have templates now.
2018-11-07 17:12:35 -08:00
Hans Muller
4bb62b4348
Stop TextFields from wobbling within scrollables (#24015) 2018-11-07 14:27:25 -08:00
jslavitz
7342816084
Adds fix for double comparison error (#24026)
* adds fix for rounding error
2018-11-07 12:27:08 -08:00
Dan Field
3d01e89e7a
Unbreak WidgetsApp when only a builder specified (#23976)
* update assert add test

* update docs
2018-11-07 12:16:35 -08:00
Michael Beckler
9abce96e8e BottomNavigationBar: bug fix for dealing with animations with shifting tabs (#22264)
Should fix #22226.

Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.

The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
2018-11-07 09:20:27 -08:00
Dan Field
220cceedb5
Fix heroes transition when initial route is not '/' (#24039)
* early return for initialRoute + test
2018-11-07 00:06:34 -08:00
Jonah Williams
a43e3a4a2f
Retry remove package:test from flutter (#24007) 2018-11-06 10:48:34 -08:00
Jonah Williams
23a7535a39
Revert "Remove package:test dependency from flutter_test (#23755)" (#24004)
This reverts commit 71e9bd6f25125112473d5a094ee77fadaf7c259e.
2018-11-06 09:12:48 -08:00
Jonah Williams
71e9bd6f25
Remove package:test dependency from flutter_test (#23755) 2018-11-06 08:39:27 -08:00
Stanislav Baranov
ba4cf054bd
Propagate positions of secondary pointers in UP events on Android (#23797) 2018-11-05 12:43:00 -08:00
Hans Muller
7245c4a6f6
Warn about supported locales that lack localizations (#23850) 2018-11-05 12:39:31 -08:00
Florian Huonder
02355d4c19 Added the DialogTheme to the material exports so that it is accessible. (#23858) 2018-11-05 09:34:05 -08:00
Alexandre Ardhuin
344ebe02ff
avoid returning null for Future (#23784) 2018-11-05 16:38:23 +01:00
Greg Spencer
202b045b50
Rewrite the analyze-sample-code script to also analyze snippets (#23893)
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.

It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.

I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.

For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
2018-11-05 07:31:35 -08:00
sjindel-google
db9fe3f827
Fix text field clipping when erasing rapidly. (#23894)
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.

This fixes #22288 and #14121
2018-11-04 03:20:44 +01:00
jslavitz
a4a0ff9ab4
Makes FlexibleSpaceBarSettings public (#23803)
* Makes FlexibleSpaceSettingsPublic and adds a test
2018-11-02 17:38:38 -07:00
Yegor
f03b00706f
code readability: fix awkward variable shadowing (#23886) 2018-11-02 17:07:00 -07:00
Hans Muller
dd30efa190
Revert "Restore "Flutter gallery: updated Shrine demo" (#23878)" (#23888)
This reverts commit 76a1abd4c779a3f54f6a6a49340eca03a99d522c.
2018-11-02 15:32:02 -07:00
Hans Muller
76a1abd4c7
Restore "Flutter gallery: updated Shrine demo" (#23878) 2018-11-02 14:33:10 -07:00
Jason Simmons
36b9983212
Dartdoc comment for FontLoader.loadFont (#23882) 2018-11-02 13:22:09 -07:00
jslavitz
3aa104fe60
Allows progress indicator height to be controlled by parent (#23540)
* Adds functionality for progress indicator height to be controlled by the parent.
2018-11-02 09:50:14 -07:00
Jason Simmons
00565c2dda
An API for dynamically loading fonts (#23595)
See https://github.com/flutter/flutter/issues/17910
2018-11-02 09:44:26 -07:00
liyuqian
744b872f65
Add unit tests to mutate layer fields (#23599)
So we're sure that:
1. We won't break the API by not allowing to mutate fields
2. We won't forget to markNeedsAddToScene after mutation
2018-11-02 08:02:22 -07:00
Alexandre Ardhuin
6c32c15f3c
add some const classes (#21954) 2018-11-02 14:25:06 +01:00
Jonah Williams
0b35937b13
Revert "Flutter gallery: updated Shrine demo (#23539)" (#23848)
This reverts commit 949cfcf172cce8a714719765b2e79039c5eb8200.
2018-11-01 19:30:11 -07:00
Hans Muller
949cfcf172
Flutter gallery: updated Shrine demo (#23539) 2018-11-01 12:48:24 -07:00
Amir Hardon
fe503dc4ba
Add creation parameters to UiKitView. (#23800) 2018-11-01 11:14:43 -07:00
Yegor
072cd94839
call hapticFunction directly (#23830) 2018-11-01 10:35:09 -07:00
Jonah Williams
aac5b04858
CupertinoPicker semantics (#23551) 2018-11-01 10:20:19 -07:00
Stefano Rodriguez
a9b8796a60 Use maybePop in place of pop in ModalBarrier dismiss interaction (#22023)
* Use maybePop in place of pop in ModalBarrier
2018-11-01 09:45:13 -07:00
jslavitz
0d68fccc1e
Add DropDownButtonFormField convenience class (#23611)
* Adds DropDownFormField Convenience Class
2018-10-31 17:14:25 -07:00
Michael Goderbauer
fab109cef5
endTemplate -> endtemplate (#23785) 2018-10-31 16:26:01 -07:00
Michael Goderbauer
5a57d80cb7
Simple doc fix (#23753) 2018-10-31 16:24:59 -07:00
jslavitz
a63ed4e391
Scaffold drawer fix (#23689)
* Adds drawer state query functions
2018-10-31 16:23:44 -07:00
Amir Hardon
8de86d412e
Re-land "Initial framework support for iOS platform views." (#23781)
Re-landing #23412 with a fix to the PlatformLayer's addToScene signature.

#23412 was broken by the change to Layer done in #23434.

It seemed green as the presubmits were done before #23434 was landed, and when #23412 landed it broke the build.

Reverts #23779
2018-10-31 15:07:09 -07:00
Amir Hardon
b20e7a2671
Revert "Initial framework support for iOS platform views. (#23412)" (#23779)
This reverts commit 67ffe1c2cbc15243e6535e7f70c0e637dc9125f1.
2018-10-31 07:06:05 -07:00
Amir Hardon
67ffe1c2cb
Initial framework support for iOS platform views. (#23412)
This PR adds the full framework stack (layer->render object->widget, and
service) for embedding iOS views with minimal functionality.

I allowed myself to throw the entire framework stack in one PR since we're mostly
mirroring the structure we already established for embedded Android views, so this PR
is a little bigger than usual. I'm happy to break it down to the
different pieces of the stack if reviewers prefer.

Specifically this PR adds:
* A UiKitView widget for embedding a UIView in the widget tree.
* A RenderUiKitView which is the render object for showing a
  UIView.
* A PlatformViewLayer which denotes the position of a UIView in the
  layer tree.
* The iOS platform_views system channel client code in services/platform_views.dart
* Splits the fake platform views controller to an Android and iOS
  controllers.

TBD in following PRs:
* Plumb the layout direction all the way to the platform view (currently
  there is still no engine support for it).
* Integrate with gesture arenas (engine support is still missing as
  well).
2018-10-31 06:01:28 -07:00
MH Johnson
50098f149d
[Material] Theme for Dialogs (#23569)
* [Material] Add dialog theme.

* Address Hans' first round comments.

* Address Hans' Second round comments.

* Fix theme tests

* Address Will's comments, add golden test

* Update goldens

* Custom Border radius 16.0

* Address Hans' Comments

* Second round comments

* fix imports
2018-10-30 22:54:49 -04:00
MH Johnson
b8c3e0dbae
[Material] Create TabBarTheme.of constructor (#23702)
* Create TabBarTheme of(...) constructor

* First round comments

* fix imports
2018-10-30 19:13:16 -04:00
jslavitz
be7226f08e
Adds sample code to TextFormField (#23680)
* Adds sample code to TextFormField
2018-10-30 13:54:19 -07:00