4489 Commits

Author SHA1 Message Date
amirh
2e449f06f0
import all generated files in animated_icons_private_test (#14329) 2018-01-29 14:26:51 -08:00
amirh
85b5b88e0b
Add more animated icon assets (#14328) 2018-01-29 10:36:59 -08:00
Ian Hickson
7701127bdd
Fix shadows in NestedScrollView (#14279)
* Fix shadows in NestedScrollView

The previous logic (and especially the previous test) wasn't quite right.

* Update nested_scroll_view.dart
2018-01-26 22:36:00 -08:00
amirh
ae1f65ebd6
Re-organize the Material widget's documentation. (#14303)
This widget evolved over time by multiple people, I'm just trying to explain
in a more direct way what the widget is currently doing.
2018-01-26 20:09:11 -08:00
Ian Hickson
d6f006db1e
Rename a test that wasn't running (#14278) 2018-01-26 17:00:06 -08:00
Michael Goderbauer
c9215e6be6
Wiring for semantic actions copy, cut, paste (#14295)
* Roll engine to 6921873c71e700235c0f68f0359be2332f93c8bc
2018-01-26 15:44:34 -08:00
Michael Goderbauer
671c1101a4
Change text selection (or cursor position) via a11y (#14275)
Roll engine to 7c34dfafc9acece1a9438f206bfbb0a9bedba3bf
2018-01-26 10:44:41 -08:00
Vyacheslav Egorov
c23509e9fd
Unpin test and upgrade packages (#14282)
* Unpin package:test and upgrade packages

* Update packages/flutter/test/foundation/stack_trace_test.dart

* Also add packages/flutter_tools/test/data/asset_test/font/.dartignore to ensure that update-packages --force-upgrade does not crash.
2018-01-26 10:40:03 -08:00
xster
667f478506
CupertinoPicker part 4 - create CupertinoPicker and add gallery demo (#14091)
* controller, position and test

* Make controllers swappable

* WIP

* Create a ListWheelScrollPhysics

* Created picker and gallery demo and testing now

* Works. Ready to document and test.

* Document and add tests. Make the scroll controller more generic.

* minor cleanup

* review

* review

* fix tests

* stop using TransformLayers for now
2018-01-25 16:31:43 -08:00
Ian Hickson
b6c6e36589
Move UTF-8 decoding off the main thread. (#14206)
This reduces the jank of bringing up the license screen further.
The remaining lost frame or two are caused by Dart itself, see:

   https://github.com/dart-lang/sdk/issues/31954
   https://github.com/dart-lang/sdk/issues/31959
   https://github.com/dart-lang/sdk/issues/31960

Fixes https://github.com/flutter/flutter/issues/5187
2018-01-25 13:51:49 -08:00
Alexandre Ardhuin
10f721c8a5
use const instead of final with const declarations (#14253) 2018-01-25 19:28:22 +01:00
Michael Goderbauer
34ff00a752
Add a11y support for selected text (#14254)
Framework side for https://github.com/flutter/engine/pull/4584 & https://github.com/flutter/engine/pull/4587.

Also rolls engine to 4c82c566edf394a5cfc237a266aea5bd37a6c172.
2018-01-25 10:12:02 -08:00
Ian Hickson
97b9579e55
Random cleanup across the tree (#14221) 2018-01-25 09:46:48 -08:00
Vyacheslav Egorov
a5b3139126 Use void as type argument instead of Null where appropriate 2018-01-24 15:25:29 -08:00
Sam Rawlins
5ae770345a Self-execute closure passed to assert (#14235) 2018-01-23 13:46:14 -08:00
Michael Goderbauer
8059aea365
TextFields should only have one SemanticsNode (#14219)
* scrolling node eleminated

* remove second node

* fix ids
2018-01-22 18:12:39 -08:00
Hans Muller
773902c59d
Fix _RenderDecoration.debugDescribeChildren() (#14217) 2018-01-22 17:14:44 -08:00
xster
e64d44ca78
CupertinoPicker part 1 - create a generic ListWheelScrollView (#13783)
* Create ListWheelScrollView

* fix missing doc

* tweak docs a bit

* fix imports

* Add some tests

* review

* review and transform tests

* fix test

* repatch lost 977701cf69

* review

* Review
2018-01-22 12:02:32 -08:00
Tan Jay Jun
de023bc6f4 Improve SystemChrome documentation (#14181) 2018-01-22 11:08:17 -08:00
Ian Hickson
a29d723c59
[H] Move the splitting of licenses to an isolate (#14160)
* Move the splitting of licenses to an isolate

This improves (from horrific to terrible) the performance of the
license screen. It also introduces a feature in the foundation layer
to make using isolates for one-off computations easier.

The real problem that remains with this, though, is that transfering
data between isolates is a stop-the-world operation and can take an
absurd amount of time (far more than a few milliseconds), so we still
skip frames.

More work thus remains to be done.

* - Add profile instrumentation to the isolate compute() method
- Add profile instrumentation to the LicensePage
- Add profile instrumentation to the scheduleTask method
- Make scheduleTask support returning a value
- Make the license page builder logic use scheduled tasks so that it doesn't blow the frame budget
2018-01-20 01:42:55 -08:00
Hans Muller
677f218ef6
Added InputDecorationTheme (#14177) 2018-01-19 22:53:29 -08:00
Sam Rawlins
7ffcce84a2 Bump async, http, and vm_service_client packages (#14136) 2018-01-19 14:59:16 -08:00
Ian Hickson
bed71b9a15
Make FadeTransition more efficient (#14155)
* Make FadeTransition more efficient

* Update fade_transition_test.dart

* Update proxy_box.dart
2018-01-18 20:22:22 -08:00
Ian Hickson
3ac9449ad4
Fix the confusing-zero case with NestedScrollView. (#14133)
* Fix the confusing-zero case with NestedScrollView.

* Update mock_canvas.dart

* Update tabs_demo.dart

* more tweaks
2018-01-18 20:21:15 -08:00
Hans Muller
629d325284
Fix: InputDecorator fails with null border, non-null labelText (#14166) 2018-01-18 17:15:43 -08:00
Jacob Richman
2e4522f7ec
Inspector robustness fixes. (#14154)
* Inspector robustness fixes.
Avoid cases where setState was called on disposed object.
Avoid cases where the inspector wouldn't render as it was called
after the first frame rendered and no other frames were rendered.
2018-01-18 16:19:31 -08:00
Ian Hickson
9e42e4b88f
New release process (#14061)
Generate the "version" file from git tags.
Remove the old VERSION file and mentions of versions in pubspec.yaml files.
Replace the old update_versions.dart script with a new roll_dev.dart script.
Update "flutter channel".
Update "flutter upgrade", including making it transition from alpha to dev.
Update "flutter --version" and "flutter doctor".
2018-01-18 07:59:06 -08:00
Ian Hickson
521bdaea05
Specify what image formats are supported in the API docs. (#13717)
Depends on https://github.com/flutter/engine/pull/4483
2018-01-17 17:47:47 -08:00
Jason Simmons
0434ae22ec
Do not apply the canvas bounds as a cull rectangle when recording a Skia picture (#14027)
The picture may need to draw outside the bounds (specifically for shadows)

Fixes https://github.com/flutter/flutter/issues/12618
2018-01-17 16:30:17 -08:00
Ian Hickson
6da8ec6bd0
Skip a test that fails on Windows for weird reasons (#14145)
Trying to get the build green. We will have to go through skipped tests as a more long-term task.
2018-01-17 15:39:51 -08:00
Michael Goderbauer
15af86459d
Identify CheckBox and RadioButton as such (#14087)
* Identify CHeckBox and RadioButton as such

* review feedback
2018-01-17 10:23:36 -08:00
Hans Muller
7b6af52c92
Improve TextField splash management: cancel() ... confirm() (#14130) 2018-01-17 09:27:22 -08:00
Hans Muller
b94f757d77
Small simplification in RenderEditable (#14119) 2018-01-17 09:14:30 -08:00
Ian Hickson
b0d5d2d928
Escape path separator in regexps (#14122)
* Escape path separator in regexps

* Update platform_helper.dart

* Update stack_trace_test.dart

* Update stack_trace_test.dart
2018-01-17 09:09:00 -08:00
Hans Muller
e63a63784c
Fix dartdoc errors in generated localization code and RenderEditable (#14132) 2018-01-17 08:37:02 -08:00
Michael Goderbauer
37e1684825
Document Android's SemanticsAction.tap behavior (#14031)
* Document Android's SemanticsAction.tap behavior

Fixes https://github.com/flutter/flutter/issues/13219.

* review comment
2018-01-16 23:19:40 -08:00
Ian Hickson
f98b4863a7
Make debugCheckHasMaterial more useful (#14101)
Fixes https://github.com/flutter/flutter/issues/2877
2018-01-16 20:31:21 -08:00
Dwayne Slater
4488f58acf Set _imageInfo to null BEFORE adding listener to new ImageStream (#13825)
* Set _imageInfo to null before adding listener to new ImageStream

Fixes an edge case where switching the ImageStream to an already completed ImageStream caused the Image widget to show nothing. ImageStreamCompleter calls the listener during addListener if their image is already loaded.

* Fix whitespace

* Add test to verify correct behavior

* Added test from mravn-google's PR
2018-01-16 10:14:01 -08:00
Ian Hickson
c5050bc8a9
Prepare for running tests on Windows (#14112)
Seems like we don't yet run the flutter tests on Windows, but we're
close to being able to. This makes some minor changes to make that
more possible:

 - fix the stack parsing code to support Windows paths
 - fix the tests for the stack error handling code to handle Windows paths
 - skip some tests that rely on Ahem font metrics
2018-01-16 10:11:13 -08:00
Michael Goderbauer
0efc8cde1f
Fix SemanticsData hashode and equals (#14079) 2018-01-16 09:44:56 -08:00
Vyacheslav Egorov
b47a25cea7
Strong mode fix in Table._updateRenderObjectChildren (#14108)
renderObject.setFlatChildren expects List<RenderBox>, not List<RenderObject>.
2018-01-16 16:46:32 +01:00
Ian Hickson
299ddb4320
Add some color to the ShapeDecoration.shape docs (#14100)
...especially about TextDirection.
2018-01-15 12:43:43 -08:00
Vyacheslav Egorov
6e38b42919
Fix a couple of strong mode issues. (#14070)
* JSON.decode produces Map<String, dynamic> and List<dynamic>
objects. If a more tight type is required then object needs to
be converted explicitly (see dart-lang/sdk#31876);
* Completer<dynamic> produces Future<dynamic>. In Dart 2 it is
runtime error to assign Future<dynamic> to variable of type Future<T>;
2018-01-13 09:18:12 +01:00
Hans Muller
27eeb9722f
TextField splash integration (#14055) 2018-01-12 17:40:53 -08:00
amirh
0230a87476
Add a PhysicalShape widget and a render object for it. (#13682)
This CL also refactors common logic for RenderPhysicalModel and
RenderPhysicalShape into a base class _RenderPhysicalModelBase.
2018-01-12 15:56:01 -08:00
Ian Hickson
80d6095d98
Fix ShapeDecoration (#14009)
And add a test that catches these problems.
2018-01-12 15:03:51 -08:00
Sam Rawlins
e8b666249a Bump collection dependency to 1.14.5 (#14048) 2018-01-12 14:33:26 -08:00
Ian Hickson
8cf109d20f
Reland #14054 after having landed all the engine commits in between (#14064)
This gets us back to where we were a few minutes ago.
2018-01-11 23:21:53 -08:00
Ian Hickson
78dcc0e685
Revert "Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)" (#14063)
This reverts commit 592f297922270c0c338b0048d37a510c9c16db14.
2018-01-11 22:27:11 -08:00
amirh
592f297922
Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)
* Revive "Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942)"

That commit was reverted due to a performance problem which has now been
fixed.

* Roll engine 05fe72d068e19c7886e8d27f9b004201d5ad1300
2018-01-11 18:54:12 -08:00