Victoria Ashworth
2f708eb839
[CP] Wait for CONFIGURATION_BUILD_DIR to update when debugging with Xcode ( #135609 )
...
Original PR: https://github.com/flutter/flutter/pull/135444
2023-10-09 14:58:08 +00:00
Victoria Ashworth
0776843125
[CP 3.13] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device ( #134824 )
...
Original PR: https://github.com/flutter/flutter/pull/134493
2023-09-15 22:26:18 +00:00
Tess Strickland
a625ad4ea9
[CP] Update vm_snapshot_analysis to 0.7.6 on stable ( #133657 )
...
Partially cherry picks 3b8f6c4020 , in particular it only performs the update of `vm_snapshot_analysis` to 0.7.6.
Issues fixed:
* https://github.com/flutter/flutter/issues/132695
2023-09-10 00:15:21 +00:00
Andrew Kolos
d5623b520e
[CP] handle exceptions raised while searching for configured android studio ( #133602 )
...
cherry-pick for https://github.com/flutter/flutter/pull/133180
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
Co-authored-by: Xilai Zhang <xilaizhang@google.com>
2023-09-06 12:10:14 -07:00
David Iglesias
ad5235b4e4
[CP] Migrate web-only initialization APIs ( #133891 )
...
This CP lands PR https://github.com/flutter/flutter/pull/129856 into `stable`.
The PR above was part of a engine+framework change that got split in half during the stable cut, so now users are seeing some warnings that they can't act on.
(Those warnings were only intended for people who were using our methods manually, rather than using normal flutter tooling).
## Issues
Fixes https://github.com/flutter/flutter/issues/133069
2023-09-06 01:44:49 +00:00
Kate Lovett
441432b5be
[CP] Fix visual overflow for SliverMainAxisGroup ( #132989 ) ( #133057 )
...
Cherry picks https://github.com/flutter/flutter/pull/132989 which fixes
https://github.com/flutter/flutter/issues/132788
Fixes https://github.com/flutter/flutter/issues/133058
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-05 09:51:37 -07:00
Christopher Fujino
bb77eff18b
[CP] Fix flutter upgrade failing with "Unknown Flutter tag" to 3.13 ( #133818 )
...
Fixes `flutter upgrade` which would fail with "Unknown flutter tag" because it would call `git` commands in the user's current working directory instead of the Flutter SDK.
Fixes https://github.com/flutter/flutter/issues/133819 .
2023-09-01 00:07:04 +00:00
Kate Lovett
ff5b5b5fa6
[CP] Fix lower bound of children from TwoDimensionalChildBuilderDelegate ( #132764 )
...
Found in https://github.com/flutter/packages/pull/4536
The max x and max y index should allow for a case where there are no children in the viewport. This should be CP'd into stable once it lands.
2023-08-24 13:12:28 +00:00
Jackson Gardner
e1e47221e8
[CP] Space character should be optional when tree shaking fonts ( #132882 )
...
This is the cherry-pick for https://github.com/flutter/flutter/pull/132880
2023-08-23 04:43:18 +00:00
Victoria Ashworth
ce2fa57e45
[CP - 3.13] Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR ( #132958 )
...
Original PR: https://github.com/flutter/flutter/pull/132803
2023-08-22 21:04:11 +00:00
Christopher Fujino
53841b2cc1
[CP] Fix #132160 RPCError during web debugging ( #132356 )
...
Upstream issue: https://github.com/flutter/flutter/issues/132160
Upstream (DWDS) fix PR: https://github.com/dart-lang/webdev/pull/2188
Beta 3.13 beta CP request: https://github.com/flutter/flutter/issues/132358
2023-08-14 21:22:12 +00:00
Victoria Ashworth
ff8ade8b77
[CP] Print pretty error when xcodebuild fails due to missing simulator ( #132235 )
...
Original PR: https://github.com/flutter/flutter/pull/130506
Note:
I added a commit to fix a name discrepancy.
[A commit on master](https://github.com/flutter/flutter/pull/130156/files#diff-157aa748cf5e84d2d03141150ddf4136e24635f1a1d50fc52e1da2354a70ac83L1043 ), that was added prior to the CP PR, renamed a variable from `_xcBundleFilePath` -> `_xcBundleDirectoryPath`. The CP PR uses the new name since it came after the first commit, so I added a commit to this PR to use the old variable name.
2023-08-14 21:04:09 +00:00
Victoria Ashworth
54040e6041
[CP] New tooling for iOS 17 physical devices ( #132283 )
...
Two CP commits in a single PR.
Original PRs:
https://github.com/flutter/flutter/pull/131865
https://github.com/flutter/flutter/pull/132491
2023-08-14 19:52:45 +00:00
Victoria Ashworth
0ea0979cc2
[CP] Check for iOS simulator runtime in flutter doctor for Xcode 15 ( #132230 )
...
Original PR: #131795
2023-08-14 17:07:40 +00:00
LongCatIsLooong
95b3a3ed98
[CP] Constrain _RenderScaledInlineWidget child size in computeDryLayout #131765 ( #132096 )
...
CP request: https://github.com/flutter/flutter/issues/132095
2023-08-08 17:57:04 +00:00
LongCatIsLooong
85127f4f94
[Cp] Fix Tooltip crash when selected in a SelectableRegion ( #130181 ) ( #131288 )
...
CP: https://github.com/flutter/flutter/issues/131005
2023-08-07 22:25:45 +00:00
LongCatIsLooong
f4c42610bb
[CP] _RenderScaledInlineWidget constrains child size ( #130648 ) ( #131289 )
...
CP: https://github.com/flutter/flutter/issues/131004
2023-08-07 22:23:17 +00:00
LongCatIsLooong
5c4bfbcc85
[CP] Allow OverlayPortal to be added/removed from the tree in a layout callback ( #130670 ) ( #131290 )
...
CP https://github.com/flutter/flutter/issues/131002
2023-08-07 22:23:16 +00:00
Kate Lovett
945b12da6a
[CP] Minor adjustments on 2D APIs ( #131358 ) ( #131436 )
...
These tweaks came from https://github.com/flutter/packages/pull/4536
- The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0
- The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate
I'd like to cherry pick this so https://github.com/flutter/packages/pull/4536 will not have to wait for it to reach stable.
2023-08-01 19:34:22 +00:00
Christopher Fujino
1dc07d26fc
[CP] Fix ConcurrentModificationError in DDS ( #130740 )
...
Fixes https://github.com/flutter/flutter/issues/130739
2023-07-18 17:16:23 +00:00
Jesús S Guerrero
257a29931c
Revert "[a11y] CupertinoSwitch On/Off labels" ( #130166 ) ( #130172 )
...
Reverts flutter/flutter#127776
Currently breaking google testing
2023-07-07 14:25:30 -06:00
Jesús S Guerrero
761810a0bf
Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..… ( #130155 )
...
…." (#130144 )
Reverts flutter/flutter#114303
The breaking API change in flutter/flutter#114303 broke internal
tests/apps (Google internal link b/290154304) as well as external
dependents: https://github.com/flutter/flutter/issues/130062 .
Co-authored-by: Hans Muller <hans.muller@gmail.com>
2023-07-07 10:06:18 -07:00
Polina Cherkasova
bff6b93683
Next attempt to make inspector weakly referencing the inspected objects. ( #129962 )
2023-07-06 12:19:18 -07:00
Gil Nobrega
4f6c887751
[a11y] CupertinoSwitch On/Off labels ( #127776 )
...
Adds optional visual labels to Cupertino's on/off switch for accessibility.
2023-07-06 11:18:13 -07:00
Henrique Nascimento
eebb1d6ddf
Add option for flexible space on material SearchDelegate ( #128132 )
...
This pull request introduces the `buildFlexibleSpace` method to the `SearchDelegate` class in the material library.
It allows users to add a flexible space widget to the `AppBar` in a `_SearchPage`, providing more customization options.
This PR does not fix any specific issue as there are no open issues related to this feature.
2023-07-06 17:52:58 +00:00
luckysmg
e0ad12969f
[framework] Add textField OCR support for framework side ( #96637 )
...
iOS OCR keyboard input support.
2023-07-06 08:51:06 -07:00
fabiancrx
2f7614a818
[flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder ( #128810 )
...
Replaces AnimatedBuilder for ListenableBuilder in the skeleton template
Fixes https://github.com/flutter/flutter/issues/128801
No tests needed
2023-07-06 15:14:51 +00:00
Ian Hickson
bc49cd1bca
Allow long-press gestures to continue even if buttons change. ( #127877 )
...
Previously, if you changed buttons during a long-press gesture, if it was before the gesture was accepted we would discard it, and if it was after the gesture was accepted we would silently end it without firing any of the relevant events.
This silent cancelation behavior is terrible because it means there's no way for consumers to know what state they're in, so you end up with widgets that thing they're still being long-pressed even though nothing is happening.
We could change the behavior in three ways, as far as I can tell:
- we could send a cancel event when you change buttons. This would introduce a new kind of transition (start->cancel) which I don't think we currently require people to support. This would therefore not fix existing code and would make future code more complicated to handle a really obscure user action that it seems unlikely anyone cares about.
- we could send an end event when you change buttons. This would mean the action commits, even though the user is still holding the mouse button down. This seems slightly better than the previous option but still not ideal as it means nudging the mouse button commits you even though you're still holding the button down.
- we could ignore button changes after the long-press has been accepted.
I implemented the last one in this PR.
2023-07-06 00:42:57 +00:00
Michael Goderbauer
55b6f049a6
Enable unreachable_from_main lint - it is stable now!!1 ( #129854 )
...
PLUS: clean-up of all the unreachable stuff.
2023-07-06 00:09:01 +00:00
Snonky
e0a9ad15b9
MergeableMaterial: Fix adding a slice and separating it ( #128804 )
2023-07-05 16:58:28 -07:00
Hans Muller
14f1e13edb
Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 ( #129860 )
...
Reland https://github.com/flutter/flutter/pull/129556/ which had failed
an internal test (see Google internal link b/288993600) and was reverted
in https://github.com/flutter/flutter/pull/129645 .
This PR must be landed with G3 Fix cl/543755631
2023-07-05 15:41:13 -07:00
pdblasi-google
e1702a96f6
Removes deprecated APIs from v2.6 in binding.dart and widget_tester.dart ( #129663 )
...
Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart`
Resolves #129654
2023-07-05 19:26:24 +00:00
Helin Shiah
0b44577f16
Add new hot reload case string ( #130008 )
...
This change is for an internal IDE client to send a custom hot reload
request, as custom requests from the client must start with `$/`.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above. (this PR is linked internally)
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-05 15:16:33 -04:00
Myles Moylan
ec72610378
Add simple unit tests for annotations.dart file ( #128902 )
...
This PR is adding a file of two simple unit tests in order to improve code coverage (covering two simple classes within the annotations.dart file).
The issue this is fixing is the lack of complete test coverage for the annotations.dart file.
2023-07-05 17:21:28 +00:00
ipcjs
aaaea51dd2
fix a bug when android uses CupertinoPageTransitionsBuilder... ( #114303 )
...
When android uses iOS style `PageTransitionsBuilder` and iOS uses android style `PageTransitionsBuilder`, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem.
#99919 introduced a breaking change, the pr re-implemented it <del>without introducing a breaking change.**</del>
2023-07-05 16:41:32 +00:00
Piotr FLEURY
168d807734
Add .env file support for option --dart-define-from-file ( #128668 )
...
# Proposal
I suggest to make possible to specify .env files to the --dart-define-from-file in addition to the Json format.
# Issue
Close #128667
2023-07-05 16:35:08 +00:00
Pierre-Louis
35085c394d
Improve documentation for ColorSheme.fromImageProvider ( #129952 )
...
Sample code is added, documentation condensed, and links to guidelines updated.
For b/258360306
2023-07-05 15:47:57 +00:00
Polina Cherkasova
5b12b7467f
Cleanup: stop accepting DiagnosticsNode as input from DevTools. ( #129302 )
2023-07-04 10:12:49 -07:00
Parker Lougheed
63a8298d4b
Update links to old linter site to dart.dev ( #129866 )
...
Removes the remaining links to the old linter site, to the guaranteed dart.dev/lints redirect.
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
2023-07-01 18:36:10 +00:00
Qun Cheng
9249dcc283
Update SwitchTheme tests for M2/M3 ( #129811 )
2023-06-30 16:29:02 -07:00
Greg Price
1153371a56
Fix NetworkImage causing spurious warning in tests ( #129537 )
...
Fixes #129532 .
This ensures that when a test properly uses `debugNetworkImageHttpClientProvider` to tell `NetworkImage` to use a fake `HttpClient`, we don't go ahead and try to instantiate `HttpClient` anyway and generate a misleading warning.
2023-06-30 22:25:52 +00:00
Hans Muller
26ad4a4a79
Updated some golden image tests for M2/M3 ( #129794 )
...
Updated some of the golden image tests that were temporarily changed in https://github.com/flutter/flutter/pull/128914 to have M2 and M3 versions.
Updated the linear_gradient_0 example to M3 (which will require updating its golden image as well).
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 18:09:56 +00:00
Nate Bosch
34c092f2b3
Remove an unnecessary assert ( #129796 )
...
The type variable `T`, when used as an expression, will always be a
`Type`. The type test `T is! List` is always true (as is `T is Type`).
This expression will become a warning in the analyzer in some upcoming
release of the Dart SDK.
This `assert` was added in a PR which reapplied an earlier PR, however
the earlier PR did not include this assert. I do not see any discussion
indicating the intent of this assert.
The impact of testing this `T` in any way is low - this is a private
class so we can see all the uses and know that the only type bound to
`T` is `Uri`. Avoid the upcoming diagnostic and remove the assert
entirely. This maintains existing behavior but ignores the potential
intent for the check.
2023-06-30 18:07:54 +00:00
Qun Cheng
1ed54f8ec0
Update Radio tests for M2/M3 ( #129814 )
...
Updated unit tests for `Radio` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 18:06:25 +00:00
Qun Cheng
0bb9409fd0
Update Switch tests for M2/M3 ( #129810 )
...
Updated and reorganized unit tests for `Switch` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 18:06:23 +00:00
Qun Cheng
2e4122cc61
Update SwitchListTile tests for M2/M3 ( #129809 )
...
Updated and reorganized unit tests for `SwitchListTile` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 09:05:48 +00:00
Taha Tesser
7cef966147
Fix NavigationDrawer selected item has wrong icon color ( #129625 )
...
fixes [NavigationDrawer selected item has wrong icon color [Material3 spec]](https://github.com/flutter/flutter/issues/129572 )
### Description
This PR fixes a mistake in the `NavigationDrawer` defaults, where generated token value returns a `null`.
This issue can be detected when you want to customize the selected icon color for `NavigationDrawerDestination` using a custom color scheme.
### Code sample
<details>
<summary>expanded to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
themeMode: ThemeMode.light,
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue).copyWith(
onSecondaryContainer: Colors.red,
),
useMaterial3: true,
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('NavigationDrawer Sample'),
),
drawer: const NavigationDrawer(
children: <Widget>[
NavigationDrawerDestination(
icon: Icon(Icons.favorite_outline_rounded),
label: Text('Favorite'),
selectedIcon: Icon(Icons.favorite_rounded),
),
NavigationDrawerDestination(
icon: Icon(Icons.favorite_outline_rounded),
label: Text('Favorite'),
),
],
),
);
}
}
```
</details>
### Before
<img width="1053" alt="Screenshot 2023-06-27 at 13 24 38" src="https://github.com/flutter/flutter/assets/48603081/18c13a73-688f-4586-bb60-bddef45d173f ">
### After
<img width="1053" alt="Screenshot 2023-06-27 at 13 24 25" src="https://github.com/flutter/flutter/assets/48603081/8a1427c6-517f-424a-b0bd-24bad7c5fbb0 ">
2023-06-30 08:58:14 +00:00
Bruno Leroux
3a6d661587
Update basic_test.dart for M3 compliance ( #129714 )
...
## Description
This PR fixes two test failures in `basic_test.dart` which surfaced when switching to M3 (see https://github.com/flutter/flutter/pull/127501 )
Those failures are related to M3 typography which sets line height to 1.43.
Forcing line height to 1.0 seems reasonable for these particular tests. With this change these two test are successful for both M2 and M3.
## Related Issue
fixes https://github.com/flutter/flutter/issues/129713
## Tests
Updates 2 tests.
2023-06-30 08:56:16 +00:00
Qun Cheng
91cb2618c3
Make DropdownMenu be able to scroll to the highlighted item when searching. ( #129740 )
...
Fixes #120349
This PR enables `DropdownMenu` to automatically scroll to the first matching item when `enableSearch` is true.
<details><summary>video example</summary>
https://github.com/flutter/flutter/assets/36861262/1a7a956c-c186-44ca-9a52-d94dc21cac8a
</details>
2023-06-30 01:48:05 +00:00
fzyzcjy
92969ba8ca
Remove @NonNull to avoid warning ( #129472 )
...
Otherwise android studio complains:
> Do not use @NonNull in Kotlin; the nullability is already implied by the Kotlin type MethodCall not ending with ?

2023-06-29 21:34:31 +00:00