4328 Commits

Author SHA1 Message Date
Collin Jackson
fd7853faad
Release 0.0.19 (#13365) 2017-12-05 16:12:55 -08:00
xster
9db8966f94
Make drawer demo header not scroll away (#13337)
* Make drawer demo header not scroll

* Add test for gallery drawer demo and fix user accounts drawer header overflow
2017-12-05 11:58:03 -08:00
Yegor
ffb24eda56
Accessibility API for CustomPainter (#13313)
Summary:

- Add `key` field to `SemanticsNode`, while moving key into `foundation` library so it can be used by the render layer.
- Introduce `SemanticsProperties` and move many of the `Semantics` fields into it.
- Introduce `CustomPaintSemantics` - a `SemanticsNode` prototype created by `CustomPainter`.
- Introduce `semanticsBuilder` and `shouldRebuildSemantics` in `CustomerPainter`

**Breaking change**

The default `Semantics` constructor becomes non-const (due to https://github.com/dart-lang/sdk/issues/20962). However, a new `const Semantics.fromProperties` is added that still allowed creating constant `Semantics` widgets ([mailing list announcement](https://groups.google.com/forum/#!topic/flutter-dev/KQXBl2_1sws)).

Fixes https://github.com/flutter/flutter/issues/11791
Fixes https://github.com/flutter/flutter/issues/1666
2017-12-04 19:49:14 -08:00
krisgiesing
898646f0f0
Separate focus management by build owner (#13334)
Separate focus management by build owner

Currently the focus manager is held by the singleton WidgetBinding.
This change places a focus manager in each build owner object,
which allows clients to run offscreen pipelines without disturbing
focus management for the main UI.
2017-12-04 15:04:41 -08:00
Ian Hickson
c44f15e6e9
Add a showBottomSheet for consistency with showModalBottomSheet. (#13314)
Also, extra docs.

Fixes https://github.com/flutter/flutter/issues/13279
Fixes https://github.com/flutter/flutter/issues/2115
2017-12-04 13:43:09 -08:00
Ian Hickson
d6f496cab8
Localize the Chip delete button's default tooltip (#13312)
...and document what I did.
2017-12-04 12:59:48 -08:00
xster
2d6f268df6 Revert "Let translucent Cupertino bars have its scaffold children automatically pad their heights (#13194)" (#13317)
This reverts commit 5c4ffa13a6c4f00ea6f752866e9393ee6395d469.
2017-12-01 21:18:36 -08:00
Hans Muller
8ebd45d3bd
Workaround for TextPainter.computeDistanceToActualBaseline when the text is empty (#13305) 2017-12-01 15:06:03 -08:00
Chris Bracken
1d6bb3ccbf
Update quiver dependency to 0.26.2 (#13299)
Updates quiver from 0.26.0 to 0.26.2 to pick up strong-mode fixes.
2017-12-01 10:28:59 -08:00
Mikkel Nygaard Ravn
19136c283e
Bump versions following alpha roll (#13284) 2017-12-01 06:20:05 +01:00
Chris Bracken
3efbe00fa6
Correct handling for alwaysUse24HourFormat in MediaQuery (#13287)
1. Ensure that this value is defaulted to the value associated with the
   context rather than re-defaulted to false.
2. Add this value to operator==, hashCode, toString methods.
2017-11-30 18:26:07 -08:00
Chris Bracken
a1b22b17de
Don't remove view insets in removePadding ctor (#13286)
This will be followed by a patch that supports independently removing
padding and view insets.
2017-11-30 17:41:09 -08:00
xster
5c4ffa13a6
Let translucent Cupertino bars have its scaffold children automatically pad their heights (#13194)
* Let lists automatically add sliver padding from media query. Translucent nav and tab bars leave behind media query paddings in scaffolds.

* tests

* const lint

* Rename base abstract class to generalized ObstructingPreferredSizeWidget
2017-11-30 13:55:30 -08:00
Chris Bracken
d957c8f040
Add EdgeInsets, MediaQuery support for view insets (#13272)
* Add MediaQuery support for view insets

Also updates EdgeInsets documentation to reflect WindowPadding's use for
both padding and view insets.

See engine commits:
  flutter/engine#4403
  flutter/engine#4406
2017-11-30 13:29:59 -08:00
Ian Hickson
4a4fa2a7c7
Cupertino RTL (#13273)
Fixes the remaining known issues with widgets supporting RTL.
2017-11-30 12:24:40 -08:00
Michael Goderbauer
6493c8b43d
Adapt markNeedsSemanticsUpdate algorithm to new semantics tree compiler (#13274)
* ensures that only semantics boundaries will be added to owner._nodesNeedingSemantics as expected by compiler.
* no longer throws assert if markNeedsSemanticsUpdate is called on non-semantic-boundary render object with a non-semantic-boundary parent.
* Fixes #13109.
* removes onlyLocalUpdates from markNeedsSemanticsUpdate as its no longer needed.
2017-11-30 12:18:33 -08:00
Yegor
a78c9f70da
remove the unused dispatchDidChangeDependencies (#13224) 2017-11-30 12:17:25 -08:00
xster
738e62cb2e
Let iOS have a minimum scroll movement threshold to break before motion starts (#13166)
* Add a minimum distance that needs breaking on iOS each time scrolls stopped.

* Testing and tests

* tweak docs

* review
2017-11-30 11:11:52 -08:00
Alexandre Ardhuin
c358898a76
try lint avoid_unused_constructor_parameters (#13250) 2017-11-30 09:20:53 +01:00
Yusuke Konishi
a46679f758 Implements FlatButton debugFillProperties (#13217)
* Implements FlatButton debugFillDescription

* Fix doc comment

* Override debugFillProperties instead of debugFillDescription

* Remove child debug property
2017-11-29 15:35:37 -08:00
Alexandre Ardhuin
1d7a22fba0
sort lints to make maintenance easier (#13231) 2017-11-29 07:54:44 +01:00
Greg Spencer
909406ba25
Consolidating .gitignore files. (#13002)
This consolidates all of the non-template .gitignore rules into the top level .gitignore, to ignore common things more broadly, with less maintenance needed for the .gitignore files. Does not touch the templates, so that they still produce needed .gitignores as part of flutter create.
2017-11-28 17:06:57 -08:00
Greg Spencer
02517b8b13
Fix some minor typos/grammar issues (#13230) 2017-11-28 16:27:26 -08:00
Jacob Richman
277001d1a8
Inspector JSON protocol to support Flutter IntelliJ Plugin tree view. (#12932) 2017-11-28 15:06:16 -08:00
Devon Carew
792e7ce872
add an assert to validate the RefreshIndicator.onRefresh result (#13198)
* add an assert to validate the RefreshIndicator.onRefresh result

* add a test for RefreshIndicator.onRefresh assert

* switch to using FlutterError.reportError, FlutterErrorDetails, and FlutterError
2017-11-28 11:00:36 -08:00
Devon Carew
bdbe53be01
remove unused constants (#13199) 2017-11-24 19:13:18 -08:00
Ian Hickson
4c9013b71b
BottomNavigationBar RTL (#13167) 2017-11-22 18:55:07 -08:00
Ian Hickson
9afc853f75
Revert "Reenable fade transition for Material page transition (#13048)" (#13172)
This reverts commit e73d406106aefb5b1d4d06bb209d19618bd0e6ac.

It caused major performance regressions.
2017-11-22 18:54:15 -08:00
Ian Hickson
2bda59a1fe
TabBar RTL (#13164) 2017-11-22 18:53:42 -08:00
amirh
78e044f5ec
Cancel the animated image stream timer if all listeners were removed. (#13158)
This is a bug in my previous CL: instead of cancelling the timer if
there are no more listeners, I canceled it if there were listeners (I
can claim I just missed a not :) ).

Not cancelling the timer when removing the last listener was not that bad, as
the timer callback is guarded by a check to see if there are listeners.
So the animation will not continue.

But in the case there were multiple listeners on the same stream, and
one of them is removed, this bug will stop the animation for all other
listeners.
I added a test case for this scenario.
2017-11-22 15:27:26 -08:00
Ian Hickson
2db0c25f82
Dismissible RTL (#13137)
Fix the dismissible demo in the gallery (make it actuall update when you pick something from its menu; give it a better affordance for resetting once you've dismissed everything).

Improve some docs.

Fix various flinging bugs with dismissible. Add tests for those cases.

Add a feature to flutter_test to support a drag-then-fling gesture (used by the flinging tests).
2017-11-22 15:20:15 -08:00
Alex
e6119282b7 feat: add optional headers param to network image (#13128)
* feat: add optional headers params to network image

* fix: addressed comments

* feat: add test

* style: format code
2017-11-22 15:19:52 -08:00
Pascal Welsch
891a218002 Add missing onDragCompleted to LongPressDraggable (#13119)
* Add missing onDragCompleted to LongPressDraggable

* Add test for LongPressDraggable onDragStarted and onDragCompleted
2017-11-22 15:18:28 -08:00
Leonardo Bispo de Oliveira
b3fa055894 ExpansionTile opened - initial state (#13115)
Changed the ExpansionTile widget to have an optional value to
initialize the widget as collapsed or expanded.

The widget will be collapsed by default.
2017-11-22 15:16:27 -08:00
Ian Hickson
34ba6be93a
Popup menus RTL (#13110)
This fixes the popup menu code to do a better job of expanding
smoothly regardless of which side of the screen it's on. It still
results in a bidirection growth when positioned at the bottom of the
screen, so maybe we'll need to animate menus differently, but that's
a problem for another patch.

Also, improve some docs and provide RelativeRect.toSize which I needed
at one point while building this patch (though it didn't survive all
the way to the end).
2017-11-22 15:15:21 -08:00
Pascal Welsch
e73d406106 Reenable fade transition for Material page transition (#13048)
Fixes #12877 by reverting #9472
2017-11-22 15:07:41 -08:00
Kyle Bradshaw
3dc32873bf AnimationController reset() method (#13044)
* AnimationController reset() method

Just a simple convenience method to fix #13039

* Added `reset()` test

* More test expectations

Per feedback.

* Removed test print

* Improved documentation of reset()

* Add controller.reverse to test
2017-11-22 15:06:43 -08:00
amirh
155a4cab18
Don't keep image stream listeners when TickerMode is disabled. (#13106)
This makes sure that we don't decode frames when we don't need to run
the animation.

For example, prior to this CL: an animated image in a page that is not
currently at the top of the page stack (it is covered by another page),
will keep the the image stream listener, and thus frames will still be
decoded.
2017-11-22 13:45:55 -08:00
xster
765dd80e8b
Add caching detail in doc (#13112)
* Add caching detail in doc

* review
2017-11-22 12:03:43 -08:00
Levin Rickert
396142b669 Fixed broken links to apple human interface guidelines (#13132) 2017-11-22 10:30:52 +01:00
xster
5fe32098b5
reverse doc from image providers back to image shorthands (#13074) 2017-11-20 10:34:48 -08:00
Mikkel Nygaard Ravn
9186ba0f89
Alpha pre roll (#13096) 2017-11-20 14:14:01 +01:00
amirh
cd54bd39ab
Fix table formatting in MultiFrameImageStreamCompleter doc - 2nd attempt (#13052) 2017-11-17 13:51:08 -08:00
amirh
5fc8eb8263
Use MultiFrameImageStreamProvider in the various image providers. (#12997) 2017-11-17 13:48:28 -08:00
Chris Bracken
86e23bdb64
Verify microtasks are flushed with each event loop (#13073)
Adds a test that verifies that the microtask queue is flushed between
engine event loop iterations.

Related issue: https://github.com/flutter/flutter/issues/9998
2017-11-17 12:05:39 -08:00
Greg Spencer
0259be90b8
Fix spelling errors in all the dartdocs. (#13061)
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.

This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
2017-11-17 10:05:21 -08:00
Ian Hickson
8b15b537b3
DropdownButton RTL (#13040)
This fixes DropdownButtons to align their popups correctly in RTL as well.

Also while I was there I fixed the issue with text scale factor in the gallery.
2017-11-16 17:57:50 -08:00
amirh
4cbe279d7b
Fix table formatting in MultiFrameImageStreamCompleter doc. (#13050) 2017-11-16 11:22:58 -08:00
amirh
bdbe3a153d
Add an accessibility service with an announce method. (#12594) 2017-11-16 11:01:37 -08:00
Ian Hickson
c97fc2063f
ExpansionPanel animation fixes (#13032)
Previously, ExpansionPanel would do weird things if interacted with
when it was already animating. This is fixed and there's now a test.

Also:

 * Minor fixes to make the gallery work in RTL, not that there's
   any way to see that without hard-coding the framework to RTL.
   But at least I'll be less annoyed when doing that.

 * Some trivial code and documentation cleanup.
2017-11-16 10:22:50 -08:00