4001 Commits

Author SHA1 Message Date
Collin Jackson
1c372c6803 Roll alpha (#11874) 2017-08-31 15:54:45 -07:00
Jason Simmons
d77955fb1a Pass the width constraint to the text layout engine if ellipsizing is enabled (#11877) 2017-08-31 14:51:11 -07:00
Devon Carew
8c36ccf534 More frame events (#11747)
* Revert "Revert "fire service protocol events for frames (#11565)" (#11727)"

This reverts commit f25e2f5213b064edc1fa71bb2326a3e1e15fcbd6.

* move the postEvent() call into a separate method
2017-08-31 11:38:21 -07:00
Adam Barth
ff3acad1ad Fix build 2017-08-31 10:39:09 -07:00
Adam Barth
145f3894e5 Add RTL support to ListTile (#11838)
Fixes #11373
2017-08-31 09:55:52 -07:00
Adam Barth
15bf91fb3d Add RTL support to scrolling (#11842)
This patch includes:

 * SliverPadding
 * ScrollView
 * PageView

Fixes #11764
Fixes #11836
2017-08-31 09:55:42 -07:00
Yegor
76f245156c fix typo in State.didUpdateWidget dartdoc (#11863)
* fix typo in State.didUpdateWidget

* rephrase
2017-08-31 08:54:46 -07:00
Hans Muller
541afae45b Localizations for Material (#11832) 2017-08-31 07:45:30 -07:00
xster
0323f2ddd2 Address comments (#11620) 2017-08-31 02:20:28 -07:00
Alexandre Ardhuin
bb4f4070f9 Prefer const constructors (#11853)
* upgrade to linter-0.1.35

* re-enable lint prefer_const_constructors

* address review comments
2017-08-31 08:55:21 +02:00
Adam Barth
4a18cbdf2c Add RTL support to progress indicators (#11840)
Fixes #11374
2017-08-30 10:05:53 -07:00
Adam Barth
d4e52ccb7e Add RTL support to Scrollbar (#11843)
When scrolling vertically, the scrollbar is on the left in RTL.
2017-08-30 10:04:07 -07:00
Michael Goderbauer
268ec4b374 ensureVisible works with viewports that have a center child (#11835)
* ensureVisible works with viewports that have a center child

* review feedback
2017-08-30 09:41:21 -07:00
Adam Barth
def0b4203a Add RTL support to Scaffold (#11833)
Fixes #11369
2017-08-29 20:34:30 -07:00
Adam Barth
7b549def56 Add RTL support to Slider and CupertinoSlider (#11822)
Fixes #11358
2017-08-29 20:34:17 -07:00
Adam Barth
3437b77007 Add support for RTL to Wrap (#11809)
Fixes #11389
2017-08-29 20:34:06 -07:00
Jason Simmons
d3415137af Temporarily show the latest entered character in an obscured text field (#11830)
Fixes https://github.com/flutter/flutter/issues/11817
2017-08-29 17:31:53 -07:00
Michael Goderbauer
bfa788512e Exclude SemanticNodes that are fully covered by an overlapping sliver (#11826)
* Exclude SemanticNodes that are fully covered by an overlapping sliver

* simplification

* formatting

* nits

* add test for center widget
2017-08-29 14:57:35 -07:00
Adam Barth
98c8366bba Add RTL support to Positioned (#11810)
This patch adds Positioned.directional and PositionedDirectional. The
former is useful when you already know the TextDirection. The latter is
useful when you want to use the ambeient Directionality.

Fixes #11390
2017-08-29 14:54:41 -07:00
Mehmet Fidanboylu
a7d2f8359f Notify the completer after the close animation completes on the snackbar (#11688)
* Notify the completer after the close animation completes on the snackbar

* Review comments

* Fix tests and analyzer warnings

* Fix analyzer warnings
2017-08-29 09:39:54 -07:00
Ian Hickson
6aae676441 Avoid returning null from debugDescribeChildren (#11806)
In some cases, the element tree is not clean but we are required to dump the tree anyway.
To avoid crashing in those cases, we return an explicit null node.
2017-08-29 09:14:12 -07:00
Michael Goderbauer
2a01097a23 Fix crash in debugDumpSemanticsTree when transform == null (#11807) 2017-08-28 17:16:42 -07:00
Michael Goderbauer
8ecf19d8a0 Semantic hit test order for Slivers (#11792)
* Semantic hit test order for Slivers

* ++

* fix double space

* refactoring

* fix test

* comment fix

* tests

* remove accidental debugDumpSemanticsTree

* review comments

* fix button
2017-08-28 15:49:16 -07:00
Ian Hickson
f235a2c104 RTL: Padding, Flex (#11709)
* Introduce a Directionality inherited widget which sets the ambient LTR vs RTL mode (defaulting to null, which means you cannot use directionality-influenced values).

* Make it possible to configure Padding (including Container.padding and Container.margin) using a directionality-agnostic EdgeInsets variant.

* Provide textDirection and verticalDirection controls on Row and Column to make them RTL-aware.

* Introduce a variant of FractionalOffset based on the EdgeInsets variant. Not yet actually used.

* Fix all the tests that depended on Row defaulting to LTR.
2017-08-28 12:50:24 -07:00
Ian Hickson
3dd1a05a8a Better debugPaintSize logic for clip renderers (#11725) 2017-08-28 12:33:23 -07:00
Michael Goderbauer
f265301519 Doc updates for Semantics; always reset SemanticsNode (#11770)
* refactor to ensureAction + some related doc fixes

* Update docs for markNeedsSemanticsUpdate

* rewording

* rewording

* ensureAction test

* ensureAction test

* ensureAction test

* more tests

* refactor to allways reset node

* tiny fixes

* more test

* doc fixes

* one more test

* review comments
2017-08-25 17:21:46 -07:00
Michael Goderbauer
c1bd6f87ae Fix paintBounds/semanticBounds of RenderSliver (#11781)
* Fix paintBounds/semanticsBounds of RenderSliver

* another test
2017-08-25 09:41:57 -07:00
xster
ca80cdfc59 Accept down event in mono drag gesture velocity calculation (#11777) 2017-08-24 16:35:16 -07:00
Michael Goderbauer
c9cefbf0be Properly update semantics when Material/Cupertino Sliders are disabled (#11776)
* Properly update semantics when Material/Cupertino Slider are disabled

* whitespace fix

* fix style
2017-08-24 12:54:34 -07:00
Hans Muller
8c2c502257 Updated I18N API for Flutter (#11497) 2017-08-23 17:07:59 -07:00
Ian Hickson
ce035d09c6 Fix non-flexible Chip in a Row. (#11669) 2017-08-23 12:59:01 -07:00
Brenton Simpson
58163e0c39 Rename springConstant to stiffness (#11686)
`stiffness` is the name of a spring's `k` input on [iOS](https://developer.apple.com/documentation/quartzcore/caspringanimation), [Android](https://developer.android.com/topic/libraries/support-library/preview/spring-animation.html), and the [Web](bbc0f831e2/src/index.js (L11-L22)).  To ensure the API is familiar to and easily understood by developers coming from other platforms, Flutter should follow this convention as well.

This is a minimally-breaking change.  Across [all of GitHub](https://github.com/search?l=Dart&q=springConstant&type=Code&utf8=%E2%9C%93), there are only 2 uses of the `springConstant` API (in Mondrian).  Those can be easily changed to use this name.

Closes #11684
2017-08-23 12:58:33 -07:00
Michael Goderbauer
f969b777b5 a11y and scrolling with slivers (#11711)
* refactor to assembleSemanticNode

* ++

* cleanup

* fix test

* add note

* review comments

* review feedback

* import fix

* another import fix

* refactor to ensure tag

* tests, tests, tests

* analyzer fixes

* review comments
2017-08-23 12:36:32 -07:00
Ian Hickson
bf47b34b60 Directionality widget (#11739) 2017-08-23 10:34:20 -07:00
Ian Hickson
9d4dd10f63 Remove a bunch of useless global configuration options. (#11726)
These properties had a high cost in the documentation because they're
all top-level properties, and there's really very little reason for
these values to be configurable in the first place.
2017-08-23 10:33:41 -07:00
Jacob Richman
5066750063 Add comments to 3 methods that were missing comments. (#11737)
* Add comments to 3 methods that were missing comments.

Fix out of order (getter, private field, setter) tuple

* Code review fix.
2017-08-22 16:06:22 -07:00
Devon Carew
f25e2f5213 Revert "fire service protocol events for frames (#11565)" (#11727)
This reverts commit 5f9acc4125ef74954493eb56feabd50be2817f68.
2017-08-22 01:06:48 -07:00
Devon Carew
5f9acc4125 fire service protocol events for frames (#11565) 2017-08-21 22:12:19 -07:00
Jacob Richman
5462ddb917 Bare bones widget inspector support. (#10332)
Bare bones widget inspector support.

Toggle the widget inspector from the flutter tool by pressing 'i'.
When the widget inspector is select mode:
Pointer down to to inspect a widget.
Pointer click to finalize selection of a widget. You can now interact
with the application as you normally would but with the inspected widget
highlighted.
Click the inspect icon in bottom left corner of screen to reactivate
select mode.
2017-08-21 16:17:54 -07:00
Chris Bracken
9c04aa15b3 Fix a FormState documentation typo (#11712) 2017-08-21 15:54:02 -07:00
Jacob Richman
4ce8c94e0d Use the phrase "must not be null" everywhere instead of "cannot be null" (#11683)
when describing non-nullable method arguments.
2017-08-18 13:37:31 -07:00
Carlo Bernaschina
272b0b956d Remove unnecessary closures (#11647)
Some widgets are using closures even if the only values that are
captured are this, context or widget, that can be accessed even from
methods of the State object.
2017-08-16 17:11:27 -07:00
xster
946a28580c Add some doc about the page route's T type (#11627) 2017-08-15 15:38:42 -07:00
Jacob Richman
0c158d549e Cleanup DiagnosticsProperty documentation. (#11514) 2017-08-15 12:16:27 -07:00
Dan Rubel
3a31c35ba0 Rename .analysis_options to analysis_options.yaml (#11594) 2017-08-15 08:46:42 -04:00
xster
4cb3a98f2c [Discuss] Let the initial date picker mode be selectable (#11614)
* Let the initial date picker mode be selectable

* Doc for enum

* Add a test

* Add a comment for test

* actually decouple test from setup state
2017-08-14 14:54:23 -07:00
Mikkel Nygaard Ravn
3b8159564f Alpha post-roll work (#11608) 2017-08-14 20:28:34 +02:00
ameiyil
b156a0f054 Wrap the label widget of the Chip in a Flexible. (#11523) (#11554)
* Wrap the label widget of the Chip in a Flexible. (#11523)

* This allows the Chip to constrain the size of its content after taking into account the space occupied by the avatar and delete icon (if they are present)

* Adding unit tests to evaluate correct size constraints of the Chip widget's label. (#11523)

* Minor change in formatting.

* Adjust function formatting.
2017-08-11 22:01:40 -07:00
xster
c9b0b3bb03 Fix iOS last up event velocity calculation - version 3 (#11571)
* Add synthesized property to pointer events

* test
2017-08-09 17:39:59 -07:00
Hans Muller
680d581db7 Correct handling of assets when no main asset is present (#11564) 2017-08-09 16:04:57 -07:00