* PopupMenuButton: create IconButton if child is Icon
Otherwise the resulting button has an abnormally small and rectangular
area. With multiple PopupMenuButton(child: Icon) they get squished
together in the AppBar.
* Add separate icon argument to PopupMenuButton
* Fix style issues and tweak dartdocs
* Add tests for icon argument to PopupMenuButton
* Group icon tests and fix broken test, analyzer warnings
* Test that the correct custom icon is present
* Apply De Morgan's to work around dart analyzer bug
see: https://github.com/dart-lang/sdk/issues/30288
* fire service protocol extension events for frames
* start time in micros
* introduce a profile() function; only send frame events when in profile (or debug) modes
* moved the profile() function to foundation/profile.dart
* refactor to make the change more testable; test the change
* fire service protocol events by listening to onFrameInfo
* remove the frame event stream; add a devicelab test
* remove a todo
* final
It was 8.0. It's now arbitrarily 18.0.
Changing this required adjusting some tests. Adjusting the tests
required debugging the tests. Debugging the tests required some tools
to help debugging gesture recognizers and gesture arenas, so I added
some. It also required updating some toString() methods which resulted
in some changes to the tree diagnostics logic.
Also I cleaned up some docs while I was at it.
Mainly, this adds documentation to members that were previously
lacking documentation.
It also adds a big block of documentation about improving performance
of widgets.
This also removes some references to package:collection and adds
global setEquals and listEquals methods in foundation that we can use.
(setEquals in particular should be much faster than the
package:collection equivalent, though both should be faster as they
avoid allocating new objects.) All remaining references now qualify
the import so we know what our remaining dependencies are.
Also lots of code reordering in Flutter driver to make the code
consistent and apply the style guide more thoroughly.
* Optimise AnimatedSize for the tight case.
* Remove `default` from a switch statement over enum (so that analyzer will complain if we add enum values).
* Adopt the Size since we use it after the child may have changed (which would throw normally).
* AnimatedCrossFade.layoutBuilder
* Prefix and Suffix support for TextFields
* Adding Tests
* Removing spurious newline.
* Fixing a small problem with the test
* Code review changes
* Code Review Changes
* Review Changes
* Export the new StrokeJoin enum
* Added example for line styles, and enabled line join styles.
* Reverting inadvertent change to main.dart.
* Updated due to code review of engine code
* Removed example.
* Added arguments to named routes, with test.
* Fixing some formatting
* Fixing Navigator.pop for named routes.
* Fixing comment.
* Simplifying test.
* Fixing new -> const for Text object.
* Tiny text change (also to kick a new Travis build)
* Added a more realistic test case.
* Reverting unintentional iml changes.
* Fixing trailing newline
* Removing some changes that snuck in.
* a11y: implement new SemanticsAction "showOnScreen" (v2)
This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen.
This requires engine rolled to flutter/engine#3856.
I am in the process of adding tests, but I'd like to get early feedback to see if this approach is OK.
* fix null check
* review comments
* review comments
* Add test
* fix analyzer warning
On Fuchsia, the system compositor is responsible for drawing shadows
for physical model layers with non-zero elevation.
Also fixed a bug where _needsCompositing was not being cleared prior
to updating it.
* Ensure that a frame is allways scheduled when a RenderObject marks itself as needing a semantics update
Fixes issue 2 described in https://github.com/flutter/flutter/issues/10971
Previously, an object could call `markNeedsSemanticsUpdate` and its wish would never be granted because no frame was scheduled that would actually update the semantics. This caused an issue during scrolling on Android where at the end of the scroll the `RenderIgnorePointer` would stop blocking the semantics of the scrolled view, call `markNeedsSemanticsUpdate`, but then no frame was scheduled to actually put the semantics of the scrolled view back into the semantics tree. That made the scrolled view unusable for a11y users.
At first I was a bit wary to call `requestVisualUpdate` within `markNeedsSemanticsUpdate` because technically the visual is fine, we only need the frame it schedules to update the semantics. However, it seems like we are using `requestVisualUpdate` for exactly that purpose in other places already where we just need an update to the semantics (e.g. 76a50fe0ca/packages/flutter/lib/src/rendering/object.dart (L2408)).
* add tests
* Make the drag resistance non-linear
* Let the easing of overscroll have a spring effect too
* Add tests and prevent possible drift by having a slightly smaller resistance when easing the overscroll
* lint
* AutomaticKeepAlive
A Widget that listens for notifications from widgets that don't want to die.
* Automatically wrap SliverList and SliverGrid children in AutomaticKeepAlive widgets
* Fixes for review comments