Michael Goderbauer
6d87337f51
Remove some obsolete // ignore: ( #50481 )
2020-02-10 14:08:09 -08:00
Jonah Williams
9bc0e6a991
Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart ( #49480 )" ( #50502 )
...
This reverts commit 902064277265daced4a79bcdaae157a310cc13c8.
2020-02-10 13:26:59 -08:00
Per Classon
5f4658973b
Update RefreshIndicator documentation to clarify the need for the child for be scrollable ( #50345 )
2020-02-10 10:08:02 -08:00
liyuqian
b277534026
Assert cache hints are not set for null painters ( #49771 )
2020-02-10 10:03:03 -08:00
Greg Spencer
9fb781a54a
Update samples to work with Dartpad, and convert all that make… ( #50377 )
...
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site.
It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally.
I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level).
I modified a few of the examples so that they looked nicer, and fit better on the page.
I added the sample description text above each DartPad instance, since that often defines the context of the example.
I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
2020-02-10 10:00:20 -08:00
Jonah Williams
2a6bc617b8
[framework] minimize performance effect of stateless/stateful swap ( #50394 )
2020-02-10 10:00:11 -08:00
Prerak Mann
9020642772
Reduced code duplication in ink_splash.dart, ink_ripple.dart ( #49480 )
2020-02-10 09:58:04 -08:00
Shi-Hao Hong
6dc3bfaa98
Fix Dropdown 'itemHeights' was called on null crash ( #50366 )
2020-02-07 18:28:02 -08:00
Michael Goderbauer
95d6ef741c
Nested TickerMode cannot turn tickers back on ( #50355 )
2020-02-07 18:23:02 -08:00
filaps
801a6a7e5e
Fix SnackBar clipping when it is floating due to FloatingActionButton positioning ( #47616 )
2020-02-07 16:08:02 -08:00
jimshepherd
92a335e465
Use state value in DropdownButtonFieldForm ( #37145 )
...
The current implementation of DropdownButtonFormField does not pass the initial value to _DropdownButtonFormFieldState. As a result changes made through the child DropdownButton are not made to the FormFieldState and the widget is not updated unless a onChanged function is provided to the DropdownButtomFormField constructor.
This change modifies DropdownButtonFormField to behave more consistently with other FormField widgets in how the Form state is handled.
2020-02-07 15:50:37 -08:00
Tong Mu
324a2168cd
Change definition of offset to object ( #50157 )
2020-02-07 13:08:02 -08:00
Dan Field
2627122324
Throw when trying to load an empty file ( #50325 )
2020-02-07 10:08:02 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping ( #50322 )
2020-02-07 16:35:55 +01:00
Dan Field
8735ab1e35
Make onImage re-entrant safe ( #50316 )
2020-02-06 23:36:59 -08:00
David Shuckerow
2032760509
Explain how the scroll controller behaves under tests ( #50129 )
2020-02-06 15:58:02 -08:00
YizhePKU
f8b286dce0
Updated documentation for CupertinoPicker ( #50264 )
2020-02-06 15:53:07 -08:00
Dan Field
d94ff4bdbe
Fix LRUness of ScrollAwareImageProvider ( #50242 )
2020-02-06 13:19:46 -08:00
creativecreatorormaybenot
e300c1a45a
Docs: provide Guidance for SingleChildRenderObjectWidget implementations ( #49993 )
2020-02-05 17:43:02 -08:00
Gary Qian
3e1a124e0e
Expose selectionHeightStyle and selectionWidthStyle on TextFields ( #48917 )
2020-02-05 17:38:03 -08:00
creativecreatorormaybenot
cc7b886491
Docs: provide Guidance for MultiChildRenderObjectWidget implementations ( #49994 )
...
provide Guidance for MultiChildRenderObjectWidget implementations
2020-02-05 15:22:57 -08:00
Kate Lovett
1c15cd863b
Fix Gold flake from gsutil fallback ( #50149 )
2020-02-05 11:03:02 -08:00
chunhtai
05eae42559
fix initial routes do not run secondary animation when pops ( #47476 )
2020-02-05 10:53:01 -08:00
creativecreatorormaybenot
7467bde424
Add Gamepad support for the activation action ( #49987 )
2020-02-04 16:33:02 -08:00
Dan Field
ccf5d641c5
Fix stack filtering ( #49956 )
2020-02-04 14:23:03 -08:00
Chris Bracken
b236465bed
Revert "Track lastKnownRemoteTextEditingValue separately from received data ( #49406 )" ( #50082 )
...
This change broke some internal tests that set the text editing value to
the same thing (the empty string) twice in a row. Note that in that
case, the developer had subclassed EditableTextState and overridden the
updateEditingValue method, which may or may not be relevant to the
failure.
This reverts commit 83d4d63a716ec8551f0d59f852a40925ddd73d8a.
2020-02-03 20:40:10 -08:00
Dan Field
26619b3c35
Reland #49925 ( #50071 )
...
* Reland "Fix custom Elements that wants to decorate State.build (#49925 )" (#50068 )"
This reverts commit 62fdcb031945c23dacb481bd464cbea8ec9037d4.
Updates stack filtering for new frames in stateful element
2020-02-03 20:39:49 -08:00
Jenn Magder
62fdcb0319
Revert "Fix custom Elements that wants to decorate State.build ( #49925 )" ( #50068 )
...
This reverts commit a1143d174f0e97b1fb831bcf87f438d07f2351d7.
2020-02-03 16:42:47 -08:00
creativecreatorormaybenot
abf4e1617d
Docs (RenderObject): minor fix and link to more information ( #49992 )
2020-02-03 14:43:02 -08:00
Remi Rousselet
a1143d174f
Fix custom Elements that wants to decorate State.build ( #49925 )
2020-02-03 14:38:07 -08:00
Bogdan Lukin
9e9e741672
fix cupertino selection handle paint with transparent color ( #49910 )
2020-02-03 14:38:04 -08:00
Shi-Hao Hong
e10df3c1a6
Step 1.5 of 3: AboutDialog uses scrollable AlertDialog ( #49913 )
2020-01-31 19:23:01 -08:00
Dan Field
8600d2305e
Image provider fix ( #49920 )
...
* Fix image provider missing early return
* test
* comments
* whitespace, another comment
2020-01-31 19:19:48 -08:00
Dan Field
a1aa3c5b3d
Reland elide long tree walks ( #49891 )
2020-01-31 19:18:03 -08:00
Hans Muller
bf4cde74e1
Clarified AppBar toolbar layout API docs ( #49583 )
2020-01-31 15:33:01 -08:00
Kate Lovett
8b600032ee
Fixing constraints.precedingScrollExtent passed to SliverPadding child ( #49433 )
2020-01-31 12:58:03 -08:00
Kate Lovett
bc8bfb10f8
Exposing inner controller of NestedScrollView ( #49004 )
2020-01-31 12:53:03 -08:00
chunhtai
2dc71a343f
reland Refactors global key duplication detection ( #49896 )
...
* reland "Refactors global key duplication detection (#46183 )"
This reverts commit d2b66dbfcfdad68473fc4366e3042cd2e17706ac.
* fix test
2020-01-31 12:51:42 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations ( #49622 )
2020-01-31 18:30:21 +01:00
Bogdan Lukin
275ec45ec4
fix material selection handle paint with transparent textSelectionHandleColor ( #49830 )
2020-01-31 09:28:17 -08:00
Shi-Hao Hong
effc019054
Revert "Elide tree walks ( #48413 )" ( #49886 )
...
This reverts commit 46ccd086745bb9ade53f2457f3bb91942b2af970.
2020-02-01 00:20:04 +08:00
Dan Field
46ccd08674
Elide tree walks ( #48413 )
2020-01-31 07:09:44 -08:00
Gary Qian
83d4d63a71
Track lastKnownRemoteTextEditingValue separately from received data ( #49406 )
2020-01-30 18:10:36 -08:00
Jonah Williams
d2b66dbfcf
Revert "Refactors global key duplication detection ( #46183 )" ( #49847 )
...
This reverts commit 340b193f20e85f2cfbebf84fe315112985a38a13.
2020-01-30 17:02:16 -08:00
chunhtai
340b193f20
Refactors global key duplication detection ( #46183 )
2020-01-30 14:23:02 -08:00
Greg Spencer
e7baef08a1
Use DiagnosticableMixin instead of Diagnosticable for some conditionals. ( #49726 )
...
This PR fixes #49647 by changing DiagnosticableMixin.toDiagnosticsNode and other things to accept DiagnosticableMixin instead of requiring Diagnosticable.
2020-01-30 14:18:09 -08:00
Dan Field
169529c370
Defer image decoding when scrolling fast ( #49389 )
2020-01-30 11:38:00 -08:00
Matthew Cliatt
9375377fa9
Fix handling backspace on macos with text selection ( #49760 )
...
Fixes #46150 by catching both the delete and backspace keys, rather than just the delete key.
2020-01-30 09:36:41 -08:00
chunhtai
406d8f7f1e
Fix focus when popping pages ( #49714 )
...
Fixes the focus handling when popping pages so that when multiple pages are popped, the focus doesn't try to focus the interstitial pages.
2020-01-30 09:35:58 -08:00
liyuqian
2ccf3f877d
Print more layer debug info ( #49679 )
2020-01-30 09:33:01 -08:00
