1103 Commits

Author SHA1 Message Date
Mouad Debbar
d670059451
[web] Respect maxLines when calculating boxes for a range (#16749) 2020-02-24 14:26:03 -08:00
Mouad Debbar
971122b314
[web] Reduce the usage of unnecessary lists in pointer binding (#16745) 2020-02-24 14:21:04 -08:00
Ferhat
b87bb0a161
[web] Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under… (#16721)
* Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under memory pressure.

* optimized _reduceCanvasMemoryUsage

* Addressed review comments
2020-02-24 11:19:47 -08:00
Miguel Beltran
d0c2418dfe
Add support for Increase Contrast on iOS (#15343) 2020-02-22 14:04:04 -08:00
Dan Field
c3f4c1a085
Migrate Path to AssociateWithDartWrapper (#16753) 2020-02-22 12:59:35 -08:00
Mouad Debbar
afe7968e6b
[web] Paragraph.longestLine doesn't need to check for isSingleLine anymore (#16736) 2020-02-21 13:18:09 -08:00
Mouad Debbar
136a057f28
[web] Rename LineMetrics.text to LineMetrics.displayText (#16734) 2020-02-21 13:17:59 -08:00
Nurhan Turgut
941aee35bd
[web] add comment to skipped safari test (#16737)
* add comment to skipped safari test

* test not running semantics on Mac

* disable semantics test which is unreliable
2020-02-21 13:03:29 -08:00
Ryan Macnak
930a80ac86
Fix some compiler warnings in newer versions of Clang. (#16733) 2020-02-21 12:57:06 -08:00
Nurhan Turgut
ab0dd12975
[web] Running safari tests on LUCI (#16715)
* Safari font collection tests skip failing methods

* add a clear to the semantics test to make sure no DOM elements are leaking to the other tests

* fix semantics_helper_test. skip for semantics_test. teardown didn't work

* skip test, the skipped method run for 8 minutes according to the logs

* history tests methods runs multiple times. only run them on linux for now. they were also already failing in edge/windows
2020-02-21 09:03:13 -08:00
Dan Field
e18aba3321
Refactor of ClaimDartHandle -> AssociateWithDartWrapper (#16720) 2020-02-20 17:31:03 -08:00
Dan Field
60b27fd545
Reland "Remove usage of Dart_AllocateWithNativeFields" (#16713) 2020-02-20 16:06:02 -08:00
vsmenon
0ef67b5e74
opt out dart:ui from nnbd (#16473)
* opt out dart:ui from nnbd

* Annotate tests as well
2020-02-20 11:04:00 -08:00
Dan Field
f2f8c342be
Revert "Remove usage of Dart_AllocateWithNativeFields from tonic (#16588)" (#16684)
This reverts commit 4941ff7bf608e0bca764e1edad769a3f8cca797f.
2020-02-19 10:00:05 -08:00
Mouad Debbar
8dba815a73
[web] Paragraph.getBoxesForRange uses LineMetrics (#16625) 2020-02-19 09:56:57 -08:00
Harry Terkelsen
d03582d183
URL-encode asset URLs so assets are properly loaded (#16630)
* URL-encode asset URLs so assets are properly loaded

* Add comment
2020-02-18 16:19:36 -08:00
Yegor
48d64c13e4
update hash code logic on the web (#16624) 2020-02-18 12:29:17 -08:00
Nurhan Turgut
77c5812d48
[web] Skipping failing edge tests (#16626)
* making edge default test browser on windows. adding some skips (not all) for methods failing on edge

* skip failing tests. make egde default for testing

* skip one more test

* addressing reviewer comments. removing extra bat file
2020-02-18 09:36:04 -08:00
Ben Konyi
4941ff7bf6
Remove usage of Dart_AllocateWithNativeFields from tonic (#16588)
This API is being removed from the Dart SDK.
2020-02-14 13:55:38 -08:00
Ferhat
15e7f51b32
Implement Path extractPath, tangent APIs (#16599)
* Add pathMeasure
* Implement tangetAt
* add extractPath segment iterator
* Implement extractPath/chopCubicAt/chopQuadAt
* Wire up extractPath and add tests for cubic/quadratic
* Switch to interpolate on chopCubic
* addressed review comments
2020-02-14 13:29:27 -08:00
Mouad Debbar
f88f7df960
[web] Unskip tests that are already passing in Safari (#16567) 2020-02-14 10:27:32 -08:00
Nurhan Turgut
65d1126778
[web] Fixing launching Safari. This should solve the LUCI issue (#16590)
* Fixing launching Safari. This should solve the LUCI issue

* more comments and linking the issue
2020-02-14 10:27:20 -08:00
Mouad Debbar
fe63094d52
[web] Handle alignment correctly in Paragraph.getPositionForOffset (#16569) 2020-02-14 10:24:13 -08:00
Ferhat
cd77e78430
Fix drawRRect failure when shader is specified (#16601) 2020-02-14 09:08:28 -08:00
Yegor
8b0b6490ee
improve surface state assert error messages (#16595) 2020-02-14 08:04:31 -08:00
Harry Terkelsen
22d08d1adc
Set the current GL context to the most recently acquired Surface (#16572) 2020-02-13 10:49:13 -08:00
Nurhan Turgut
8f8af1f890
Update felt documentation (#16559) 2020-02-12 14:05:08 -08:00
Mouad Debbar
99a265b030
[web] Fix edge cases in Paragraph.getPositionForOffset to match Flutter (#16557) 2020-02-12 13:42:52 -08:00
Francisco Magdaleno
e0ebaea590
Revert "Re-land: Use os_log instead of syslog on Apple platforms (#16549)" (#16558)
This reverts commit 6aacf5e76755feb8e0f791fa619cbd99a3bd5885.
2020-02-12 12:40:31 -08:00
Nurhan Turgut
44e80fd619
skiping tests in Safari. LUCI recipe for Mac is ready. this is the only step left for stopping us running unit tests in Safari (#16550) 2020-02-11 15:31:57 -08:00
Chris Bracken
6aacf5e767
Re-land: Use os_log instead of syslog on Apple platforms (#16549)
Migrates to using os_log for app logging on iOS 13 and above, macOS
10.11 and above. On older platform, fall back to syslog(), which is what
we used previously.

This re-lands commit 78a8909725bbaeec80870f498d01ea6e56932a3a with a fix.
That commit was reverted in a61dbf2f66b97e85f4d8bf0cfb29a8b3c2640c09.
2020-02-11 15:11:46 -08:00
Chris Bracken
a61dbf2f66
Revert "Use os_log instead of syslog on Apple platforms (#13487)" (#16546)
Looks like somehow the fix to move to static_cast didn't get merged.

This reverts commit 78a8909725bbaeec80870f498d01ea6e56932a3a.
2020-02-11 13:20:52 -08:00
Jenn Magder
78a8909725
Use os_log instead of syslog on Apple platforms (#13487)
Migrates to using os_log for app logging on iOS 13 and above, macOS
10.11 and above. On older platform, fall back to syslog(), which is what
we used previously.
2020-02-11 10:23:44 -08:00
Harry Terkelsen
a662579f7c
Clear frame references at the end of every CanvasKit frame (#16525) 2020-02-10 15:30:24 -08:00
chunhtai
7e869faf52
Adds new route annoucement method. (#16523) 2020-02-10 13:59:02 -08:00
Yegor
1daba53187
Partially fix canvas vs text paint order when running on Blink/Webkit browsers (#16483)
fix canvas vs text paint order in Blink/Webkit
2020-02-10 13:41:50 -08:00
Harry Terkelsen
acc26a2f1c
Use Skia to determine "actual" font name in CanvasKit backend (#16504)
* Use Skia to determine "actual" font name.

This way, we don't need to hard-code a mapping of Flutter names
to actual names, we can compute it when the font is registered.

* Refactor to only have loaded and unloaded fonts
2020-02-10 13:06:30 -08:00
Michael Goderbauer
e4f46f32f1
Doc fixes in BoxHeightStyle (#16424) 2020-02-07 13:41:50 -08:00
sjindel-google
c9322145f4
Ensure fields of Rect and OffsetBase classes are optimized as non-null. (#16465)
* Ensure fields of Rect and OffsetBase classes are optimized as non-null.

* Update web_ui and formatting
2020-02-07 19:06:20 +01:00
Harry Terkelsen
00904dd967
Various fixes in CanvasKit (#16433)
- Enable dynamically loaded fonts
- Fix addOval
- Fix getBoxesForRange for negative ranges
2020-02-06 14:51:12 -08:00
Ferhat
f3ce90e938
Reset width/height before deallocation for Safari allocation bug. (#16469) 2020-02-06 12:30:27 -08:00
Mouad Debbar
41d50c220b
Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (#16365) 2020-02-05 19:53:03 -08:00
Yegor
07f25c51ee
fix bad reference to maxDiffRatePercent (#16440)
* fix bad reference to maxDiffRatePercent

* back to 10%
2020-02-05 18:49:10 -08:00
Yegor
f34bc65bee
use percent for golden diff rates; tighten the values (#16430) 2020-02-05 15:53:45 -08:00
Ferhat
8f89bac4b7
[web] Fixes incorrect transform when context save and transforms are deferred. (#16412)
* Fix transform order in clipStack replay
2020-02-05 15:02:34 -08:00
Gary Qian
b98a39e0bb
Add docs (#16368) 2020-02-04 13:53:02 -08:00
vsmenon
8c6cc65cd0
Fix runtime type errors when running with canvaskit (#16312)
* fix runtime type errors when running with canvaskit
2020-02-04 10:32:51 -08:00
Mouad Debbar
036ddbb0ee
[web][felt] If full dart-sdk isn't available, install it (#16341) 2020-02-03 15:06:24 -08:00
Chinmay Garde
f7b78e001d
Remove all uses of the redundant flutter_root variable. (#16311)
This was only necessary when the Engine had to build in multiple buildroots
where the sources where checked out at different paths relative to the
buildroot. This is no longer the case and there are already cases GN rules
have been written that mix and match variable usage with the direct
specification of the path to the Flutter sources relative to the sole buildroot.
2020-01-31 21:49:48 -08:00
Yegor
804dca62a1
Use bundled Roboto in all tests (#16218)
* Use bundled Roboto in all tests
2020-01-30 17:31:32 -08:00