DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,641 Commits 882 Branches 1,069 Tags
Commit Graph

27120 Commits

Author SHA1 Message Date
Jonah Williams
ff5ea29080 [Impeller] reland: directly encode blit commands for Metal. (flutter/engine#52819) 
Fixes bad interaction with render pass clear patch, which potentially created an active blit and render pass encoder at the same time. Make sure that we start/finish the render pass before we start the blit pass.
 2024-05-14 22:32:19 +00:00
skia-flutter-autoroll
c16a2409e5 Roll Skia from 81ba2eea7b42 to d0d87c26b489 (2 revisions) (flutter/engine#52825) 
https://skia.googlesource.com/skia.git/+log/81ba2eea7b42..d0d87c26b489

2024-05-14 michaelludwig@google.com [graphite] Default to approx fit textures for layers/filters
2024-05-14 michaelludwig@google.com [graphite] Include proxy label in assert

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 22:19:49 +00:00
Chris Bracken
e210669748 [docs] Suggest using same Xcode version as bots (flutter/engine#52821) 
Document that when using RBE, users should ensure the locally installed Xcode toolchain version matches that of the bots, otherwise they're likely to experience slow builds due to cache misses.

Ideally, we should also check the value automatically against the `sdk_version` specified in the relevant `et` build config itself.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-14 21:37:09 +00:00
Zachary Anderson
cd9cf6d62b [et] Print reproxy stats when RBE shuts down (flutter/engine#52818) 
```
$ bin/et build -c ci/android_release_arm64                                                                                      ─╯
[2024-05-14T11:28:40.856][ci/android_release_arm64: GN]: OK
[2024-05-14T11:28:42.527][ci/android_release_arm64: RBE startup]: Proxy started successfully.
[2024-05-14T11:31:14.869][ci/android_release_arm64: ninja]: 100.0% (1096/1096) STAMP obj/flutter/lib/snapshot/snapshot.stamp
[2024-05-14T11:31:14.871][ci/android_release_arm64: ninja]: OK
[2024-05-14T11:31:15.182][ci/android_release_arm64: RBE shutdown]: Actions completed: 1021 (569 racing locals, 452 racing remotes)
```
 2024-05-14 14:15:10 -07:00
skia-flutter-autoroll
fadafad193 Roll Skia from e26aee36345f to 81ba2eea7b42 (3 revisions) (flutter/engine#52820) 
https://skia.googlesource.com/skia.git/+log/e26aee36345f..81ba2eea7b42

2024-05-14 scroggo@google.com Change CtsEnforcement for ImageAsyncReadPixels
2024-05-14 armansito@google.com Fix CanvasKit WebGPU build
2024-05-14 kjlubick@google.com Add WebGPU build to the CQ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 21:07:04 +00:00
Jason Simmons
6ee57afaf3 Migrate third_party/gradle to flutter/third_party/gradle (flutter/engine#52814) 
Based on https://github.com/flutter/engine/pull/52030
 2024-05-14 20:51:10 +00:00
auto-submit[bot]
c7a5f42051 Reverts "[Impeller] immediately encode blit commands for Metal. (#52795)" (flutter/engine#52816) 
Reverts: flutter/engine#52795
Initiated by: jonahwilliams
Reason for reverting: failing postsubmit testing -[MTLIGAccelCommandBuffer renderCommandEncoderWithDescriptor:]:438: failed assertion `Already have uncommitted encoder'
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde}

This change reverts the following previous change:
Metal equivalent of https://github.com/flutter/engine/pull/52794

No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.
 2024-05-14 19:39:47 +00:00
Jonah Williams
fe8dfc3e19 [Impeller] immediately encode blit commands for Metal. (flutter/engine#52795) 
Metal equivalent of https://github.com/flutter/engine/pull/52794

No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.
 2024-05-14 18:04:18 +00:00
gaaclarke
cbac232591 [Impeller] migrated one test over from aiks to dl (flutter/engine#52786) 
A redo of https://github.com/flutter/engine/pull/52711 that maintains
our existing testing patterns.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: jonahwilliams <jonahwilliams@google.com>
 2024-05-14 09:46:06 -07:00
Jason Simmons
e6f329968d [Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage (flutter/engine#52790) 
The snapshot's transform is provided to the pipeline.  If the vertices are based on the coverage rectangle, then that will apply the snapshot's transform twice.

Fixes https://github.com/flutter/flutter/issues/148213
 2024-05-14 16:36:47 +00:00
Jenn Magder
e4e7b3242e Refactor Semantics in preparation for ARC migration (flutter/engine#52729) 
Split the too-large `Semantics` [MRC to ARC migration](https://github.com/flutter/flutter/issues/137801) into two PRs: this one, which refactors, and the next which will actually do the migration.

1. Use properties instead of their backing ivars (except in the usual init, dealloc, getters/setters)
2. For Foundation collections prefer `copy` over `strong`.
3. Dot notation for properties
4. Change `privateSetParent:` to instead use a `readwrite` property in `SemanticsObject ()`. 
5. Switch the `semanticsObject` property from `weak` to `retain` to get the synthesized property (keeping it as `weak` is a compilation error in MRC) but I'll swap it back to a `weak` in the ARC migration PR coming next.
6. `SemanticsObjectTest` fails on my machine and passes on CI.  Switched the cleaner `CGRectEqualToRect` (and related) checks to instead assert x, y, width, height so we can see the value when it fails:
```
((CGSizeEqualToSize( scrollView.contentSize, CGSizeMake((w + scrollExtentMax) * effectivelyScale, h * effectivelyScale))) is true) failed
```
becomes:
```
((scrollView.contentSize.height) equal to (h * effectivelyScale)) failed: ("33.3333333333") is not equal to ("33.333336")
```
Use `XCTAssertEqualWithAccuracy` now that I can see it's a floating point precision issue.
 2024-05-14 16:30:52 +00:00
skia-flutter-autoroll
c051d81690 Roll Skia from 421d8d034e6e to 7dad6da92119 (1 revision) (flutter/engine#52806) 
https://skia.googlesource.com/skia.git/+log/421d8d034e6e..7dad6da92119

2024-05-14 armansito@google.com Revert "Add ISO 21496-1 gainmap parsing"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 13:19:23 +00:00
skia-flutter-autoroll
aacb95ffc1 Roll Skia from 7045b90f1ef8 to 421d8d034e6e (1 revision) (flutter/engine#52803) 
https://skia.googlesource.com/skia.git/+log/7045b90f1ef8..421d8d034e6e

2024-05-14 blundell@chromium.org [Graphite] Add YCbCr info to DawnTextureInfo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 08:11:53 +00:00
skia-flutter-autoroll
1418daa2be Roll Skia from 19153175a79b to 7045b90f1ef8 (3 revisions) (flutter/engine#52801) 
https://skia.googlesource.com/skia.git/+log/19153175a79b..7045b90f1ef8

2024-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b43af3a7d497 to 57395f92b117
2024-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4910599942c0 to b43af3a7d497 (4 revisions)
2024-05-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 1b2d3eb175fd to 166c9d5d561d (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 06:40:35 +00:00
Jonah Williams
12b56a350b [Impeller] use render pass to clear glyph atlas texture to transparent black. (flutter/engine#52791) 
Alternative to https://github.com/flutter/engine/pull/52746

Work towards https://github.com/flutter/flutter/issues/138798

If possible, use a render pass to clear texture to transparent black. The goal is to reduce the CPU cost for larger atlases.
 2024-05-14 06:06:12 +00:00
dependabot[bot]
f331d37840 Bump google/osv-scanner-action from 1.7.1 to 1.7.3 (flutter/engine#52798) 
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action) from 1.7.1 to 1.7.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.7.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Branches filter is not available for merge_group by <a href="https://github.com/thomasleplus"><code>@​thomasleplus</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/15">google/osv-scanner-action#15</a></li>
<li>Update to track osv-scanner v1.7.3 by <a href="https://github.com/another-rex"><code>@​another-rex</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/17">google/osv-scanner-action#17</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/shahar-h"><code>@​shahar-h</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/8">google/osv-scanner-action#8</a></li>
<li><a href="https://github.com/thomasleplus"><code>@​thomasleplus</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/15">google/osv-scanner-action#15</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/google/osv-scanner-action/compare/v1.7.1...v1.7.3">https://github.com/google/osv-scanner-action/compare/v1.7.1...v1.7.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="75532bf0bf"><code>75532bf</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/17">#17</a> from google/update-to-v1.7.3</li>
<li><a href="55793806cb"><code>5579380</code></a> Revert workflow tag cchanges</li>
<li><a href="e1d89d3de2"><code>e1d89d3</code></a> Update to v1.7.3</li>
<li><a href="667ecd2ffe"><code>667ecd2</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/15">#15</a> from thomasleplus/main</li>
<li><a href="d8e1333b3c"><code>d8e1333</code></a> Branches filter is not available for merge_group</li>
<li><a href="c6d5eb195d"><code>c6d5eb1</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/8">#8</a> from shahar-h/upgrade-actions</li>
<li><a href="1d49da2626"><code>1d49da2</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/9">#9</a> from google/add-renovatebot</li>
<li><a href="e847f4e9a7"><code>e847f4e</code></a> Add renovatebot config</li>
<li><a href="92d143c588"><code>92d143c</code></a> Upgrade github actions versions to latest</li>
<li><a href="57ddf9f868"><code>57ddf9f</code></a> Merge pull request <a href="https://redirect.github.com/google/osv-scanner-action/issues/6">#6</a> from google/update-readme</li>
<li>Additional commits viewable in <a href="https://github.com/google/osv-scanner-action/compare/v1.7.1...v1.7.3">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/osv-scanner-action&package-manager=github_actions&previous-version=1.7.1&new-version=1.7.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-05-14 05:57:52 +00:00
dependabot[bot]
f9fd65213c Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/engine#52799) 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.1 to 2.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.3.3</h2>
<blockquote>
<p>[!NOTE]<br />
There is no v2.3.2 release as a step was skipped in the release process. This was fixed and re-released under the v2.3.3 tag</p>
</blockquote>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 (v4.13.1) to github.com/ossf/scorecard/v5 (v5.0.0-rc1) by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1366">ossf/scorecard-action#1366</a></li>
<li>🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc1 to v5.0.0-rc2 by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1374">ossf/scorecard-action#1374</a></li>
<li>🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to v5.0.0-rc2.0.20240509182734-7ce860946928 by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1377">ossf/scorecard-action#1377</a></li>
</ul>
<p>For a full changelist of what these include, see the <a href="https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc1">v5.0.0-rc1</a> and <a href="https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc2">v5.0.0-rc2</a> release notes.</p>
<h3>Documentation</h3>
<ul>
<li>📖 Move token discussion out of main README. by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1279">ossf/scorecard-action#1279</a></li>
<li>📖 link to <code>ossf/scorecard</code> workflow instead of maintaining an example by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1352">ossf/scorecard-action#1352</a></li>
<li>📖 update api links to new scorecard.dev site by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1376">ossf/scorecard-action#1376</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.3">https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dc50aa9510"><code>dc50aa9</code></a> 🌱 Bump docker tag for v2.3.3 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1368">#1368</a>)</li>
<li><a href="8ff5700173"><code>8ff5700</code></a> 🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to v5.0.0-rc2.0....</li>
<li><a href="8ba5e73d11"><code>8ba5e73</code></a> update api links to new scorecard.dev site (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1376">#1376</a>)</li>
<li><a href="92ddde3eaf"><code>92ddde3</code></a> Bump github.com/ossf/scorecard/v5 from v5.0.0-rc1 to v5.0.0-rc2 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1374">#1374</a>)</li>
<li><a href="6c55905542"><code>6c55905</code></a> 🌱 Bump golang.org/x/net from 0.24.0 to 0.25.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1373">#1373</a>)</li>
<li><a href="09bb953b6a"><code>09bb953</code></a> 🌱 Bump distroless/base in the docker-images group (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1372">#1372</a>)</li>
<li><a href="1511e1305b"><code>1511e13</code></a> 🌱 Bump the github-actions group across 1 directory with 6 updates (#...</li>
<li><a href="df66cd8fd8"><code>df66cd8</code></a> 🌱 Bump the docker-images group with 2 updates (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1370">#1370</a>)</li>
<li><a href="fad9a3cc53"><code>fad9a3c</code></a> 🌱 Bump distroless/base in the docker-images group (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1364">#1364</a>)</li>
<li><a href="1e01a309c1"><code>1e01a30</code></a> 🌱 Bump the github-actions group with 3 updates (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1365">#1365</a>)</li>
<li>Additional commits viewable in <a href="0864cf1902...dc50aa9510">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.3.1&new-version=2.3.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-05-14 05:57:50 +00:00
skia-flutter-autoroll
9942fc30cf Roll Skia from 93912d50850d to 349fdd5f0b69 (2 revisions) (flutter/engine#52796) 
https://skia.googlesource.com/skia.git/+log/93912d50850d..349fdd5f0b69

2024-05-14 sharaks@google.com Merge 7 release notes into RELEASE_NOTES.md
2024-05-14 sharaks@google.com Update Skia milestone to 127

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 04:31:03 +00:00
Matan Lurey
d89f54dd65 Replace json_utils with a modern extension type, add tests. (flutter/engine#52769) 
I started on a refactoring of
https://github.com/flutter/flutter/issues/147666, and was frustrated
with the JSON decoding of `gn desc --format=json`, so I used a similar
pattern from my micro-json library (https://pub.dev/packages/jsonut) and
encapsulated it as an extension type.

My favorite is the `JsonObject.map` function which replaces:

```dart
/// Construct a RunTarget from a JSON map.
factory RunTarget.fromJson(Map<String, Object> map) {
  final List<String> errors = <String>[];
  final String name = stringOfJson(map, _nameKey, errors)!;
  final String id = stringOfJson(map, _idKey, errors)!;
  final String targetPlatform =
      stringOfJson(map, _targetPlatformKey, errors)!;

  if (errors.isNotEmpty) {
    throw FormatException('Failed to parse RunTarget: ${errors.join('\n')}');
  }
  return RunTarget._(name, id, targetPlatform);
}
```

... with:

```dart
/// Construct a RunTarget from a JSON map.
factory RunTarget.fromJson(Map<String, Object> map) {
  return JsonObject(map).map((JsonObject json) => RunTarget._(
    json.string(_nameKey),
    json.string(_idKey),
    json.string(_targetPlatformKey),
  ));
}
```
 2024-05-13 20:03:43 -07:00
Jason Simmons
3c17cf0357 Move libcxx to //flutter/third_party (flutter/engine#52773) 
Fixes https://github.com/flutter/flutter/issues/144202
 2024-05-13 19:26:04 -07:00
Dustin Green
cb40a91c25 [fuchsia][sysmem2] route fuchsia.sysmem2.Allocator (flutter/engine#52708) 
Route fuchsia.sysmem2.Allocator everywhere that
fuchsia.sysmem.Allocator is routed.

fixes flutter/flutter#146858
 2024-05-13 19:24:46 -07:00
skia-flutter-autoroll
efa6bcd8b9 Roll Dart SDK from 7c7767ecc3d7 to fe75fa5f7dc0 (1 revision) (flutter/engine#52792) 
https://dart.googlesource.com/sdk.git/+log/7c7767ecc3d7..fe75fa5f7dc0

2024-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-152.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 02:00:06 +00:00
skia-flutter-autoroll
6e8ff7b87c Roll Skia from 400c6fbeace8 to 93912d50850d (1 revision) (flutter/engine#52788) 
https://skia.googlesource.com/skia.git/+log/400c6fbeace8..93912d50850d

2024-05-13 ccameron@chromium.org Add ISO 21496-1 gainmap parsing

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-14 00:28:24 +00:00
Chinmay Garde
f3934883b0 Delete Settings::msaa_samples. (flutter/engine#52780) 
Fixes https://github.com/flutter/flutter/issues/148257
 2024-05-13 23:51:11 +00:00
Jonah Williams
e4e7a45b0f [Impeller] rectangle packer actually packs. (flutter/engine#52781) 
Fixes https://github.com/flutter/flutter/issues/148251

Work towards https://github.com/flutter/flutter/issues/138798

The rectangle packer was only filling up the top and right edge of each rectangle, making the atlas super inefficient.
 2024-05-13 23:18:06 +00:00
skia-flutter-autoroll
984bfd2149 Roll Skia from 75b3286ecaac to 400c6fbeace8 (6 revisions) (flutter/engine#52783) 
https://skia.googlesource.com/skia.git/+log/75b3286ecaac..400c6fbeace8

2024-05-13 bungeman@google.com Use tilemode for sweep in scaled_tilemode_gradient
2024-05-13 bungeman@google.com [pdf] Clean up make_function_shader
2024-05-13 armansito@google.com Revert "[graphite] Tweaks to atlas path renderer selection"
2024-05-13 bungeman@google.com Remove old "skottie" gm
2024-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Manually roll Dawn from 94ceac3a5f35 to 1b2d3eb175fd (29 revisions)
2024-05-13 michaelludwig@google.com [graphite] Clean up crash debugging code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-13 23:18:04 +00:00
Jenn Magder
ea38b72a0d ios_external_view_embedder to ARC (flutter/engine#52782) 
`ios_external_view_embedder` is only C++ and there was nothing to migrate.

Also add a few missing `FLUTTER_ASSERT_ARC` macros.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-05-13 23:14:10 +00:00
skia-flutter-autoroll
67b37c1778 Roll Dart SDK from a0a940f07d56 to 7c7767ecc3d7 (2 revisions) (flutter/engine#52777) 
https://dart.googlesource.com/sdk.git/+log/a0a940f07d56..7c7767ecc3d7

2024-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-151.0.dev
2024-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-13 22:05:22 +00:00
Chinmay Garde
9553b60725 Remove outdated comment. (flutter/engine#52778) 
The linked issue has been closed as WAI.
 2024-05-13 22:05:20 +00:00
Chinmay Garde
f20b17a2ae [Impeller] Prepare a SkiaGPU-less iOS build. (flutter/engine#52748) 
The size of the LTO build of the engine with the dylib compressed is as follows:

```sh
$ du -k libFlutter*
5236	libFlutter.dylib.tar.gz
4324	libFlutterSlimpeller.dylib.tar.gz
```

Sizes are in KiB. This represents a binary size reduction of 17.41% of the compressed artifacts. The compression ratios will likely differ based on the compression scheme.

Uncompressed, the sizes are:

```sh
$ du -k libFlutter*
16920	libFlutter.dylib
14044	libFlutterSlimpeller.dylib
```

This represents a binary size reduction of 16.99% which is in the same ballpark.

The really mucky bit was backing out the raster cache and persistent cache. I want to clean that up in a later patch so that those TUs are part of a separate submodule.

Opting out of Impeller will lead to a fatal log at startup saying the opt-out is disallowed.

Fixes https://github.com/flutter/flutter/issues/126606
 2024-05-13 21:43:47 +00:00
Jenn Magder
4261e6bab1 Remove -[NSNotificationCenter removeObserver:] in deallocs (flutter/engine#52772) 
Removing `NSNotificationCenter` observers in dealloc hasn't been necessary since iOS 8 or macOS 10.10.

> If your app targets iOS 9.0 and later or macOS 10.11 and later, and you used [addObserver:selector:name:object:](https://developer.apple.com/documentation/foundation/nsnotificationcenter/1415360-addobserver), you do not need to unregister the observer. If you forget or are unable to remove the observer, the system cleans up the next time it would have posted to it.

https://developer.apple.com/documentation/foundation/nsnotificationcenter/1413994-removeobserver

Remove it.
 2024-05-13 20:50:42 +00:00
Jenn Magder
48ea1c2f79 Migrate FlutterDartProject and FlutterPluginAppLifeCycleDelegate to ARC (flutter/engine#52719) 
- Migrate `FlutterDartProject` and `FlutterPluginAppLifeCycleDelegate` from MRC to ARC.  
- Swap a few dictionary `objectForKey:` to subscripting.
- Header cleanup.
- Cleanup build DEPS.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-05-13 19:16:16 +00:00
skia-flutter-autoroll
546316e3e0 Roll Skia from 2a7830d74a8b to dde1f5dba183 (1 revision) (flutter/engine#52762) 
https://skia.googlesource.com/skia.git/+log/2a7830d74a8b..dde1f5dba183

2024-05-13 kjlubick@google.com [bazel] Add some missing dependencies/files to Ganesh Metal Backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-13 14:00:23 +00:00
skia-flutter-autoroll
baf00539cd Roll Skia from cbe627d5ba15 to 4bc37d0feedb (1 revision) (flutter/engine#52754) 
https://skia.googlesource.com/skia.git/+log/cbe627d5ba15..4bc37d0feedb

2024-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 14a9c90d4ad7 to 4910599942c0 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-13 05:58:08 +00:00
Chinmay Garde
e844d28955 Detail a gotcha about reproxystatus (flutter/engine#52714) 2024-05-12 21:15:27 +00:00
skia-flutter-autoroll
27280f9e6d Roll Skia from b6186e1b3995 to 709deddd904f (1 revision) (flutter/engine#52727) 
https://skia.googlesource.com/skia.git/+log/b6186e1b3995..709deddd904f

2024-05-10 armansito@google.com [graphite] Tweaks to atlas path renderer selection

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-11 17:10:20 +00:00
skia-flutter-autoroll
08086a5d3f Roll Dart SDK from cbfaae24852c to ff786d99b517 (1 revision) (flutter/engine#52731) 
https://dart.googlesource.com/sdk.git/+log/cbfaae24852c..ff786d99b517

2024-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-11 13:53:37 +00:00
skia-flutter-autoroll
2da9b82678 Roll Dart SDK from de30a5dbf169 to cbfaae24852c (2 revisions) (flutter/engine#52730) 
https://dart.googlesource.com/sdk.git/+log/de30a5dbf169..cbfaae24852c

2024-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-146.0.dev
2024-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-145.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-11 05:58:09 +00:00
Chinmay Garde
c2b3eb1ebd [Impeller] Followup feedback on "Baby's First Triangle". (flutter/engine#52718) 
Addresses comments made after https://github.com/flutter/engine/pull/52703 landed.
 2024-05-11 05:05:33 +00:00
skia-flutter-autoroll
2ff1f9bf27 Roll Dart SDK from 13fc7db956c7 to de30a5dbf169 (1 revision) (flutter/engine#52728) 
https://dart.googlesource.com/sdk.git/+log/13fc7db956c7..de30a5dbf169

2024-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-144.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-11 01:55:39 +00:00
skia-flutter-autoroll
023604f04b Roll Skia from f69e8967610e to b6186e1b3995 (2 revisions) (flutter/engine#52726) 
https://skia.googlesource.com/skia.git/+log/f69e8967610e..b6186e1b3995

2024-05-10 armansito@google.com Reland "[vello] Enable the bump allocation estimator"
2024-05-10 armansito@google.com Roll vello 6c1e8b815b1e...6938a2893d6a (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-10 23:17:15 +00:00
Zachary Anderson
a1257de605 Simplify GN pools, use in more places (flutter/engine#52721) 
This PR changes from using a different GN pool for each non-compiler tool, to using one GN pool for everything.

Additionally, since we are no longer linking remotely in any configuration, this PR uses the pool for linking.

ObjC and impellerc tasks also do not (yet) run on RBE, so they are also now governed by the pool.

Needs https://github.com/flutter/buildroot/pull/856
 2024-05-10 22:43:23 +00:00
Matan Lurey
70b18ec727 Write dart:ui golden-file tests testing FilterQuality.* (flutter/engine#52687) 
Work towards https://github.com/flutter/flutter/issues/147259.

Most of this is just me understanding how `FilterQuality.*` feeds into the rest of the engine, and updating our testing documentation so we all understand how to re-run these tests in the future. Here is an example output of both Impeller and non-Impeller output of `image_filter_test`:

<img width="485" alt="Screenshot 2024-05-08 at 2 25 53 PM" src="https://github.com/flutter/engine/assets/168174/58e6a4f5-98e2-4b9e-b181-4ff613ad4d29">
 2024-05-10 22:15:23 +00:00
Jim Graham
fa49f1794a Revert "DisplayListBuilder internal reorganization with better rendering op overlap detection" (flutter/engine#52725) 
Reverts flutter/engine#52646

Some of the golden changes in G3 as a result of that PR look like bugs in the bounds calculations...
 2024-05-10 22:04:40 +00:00
gaaclarke
6a1797edc9 deletes canvas recorder (flutter/engine#52722) 
design doc: https://docs.google.com/document/d/17LiGKlt57R5CZMxcWt9wj9Z7eDihhUaUEg3oeGQAKTc/edit#heading=h.kifztz2gx2n3

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-10 22:00:03 +00:00
skia-flutter-autoroll
2ecd5a720f Roll Skia from d1118d56853c to f69e8967610e (1 revision) (flutter/engine#52723) 
https://skia.googlesource.com/skia.git/+log/d1118d56853c..f69e8967610e

2024-05-10 petermcneeley@chromium.org [graphite] Detect and apply nearest filtering for image shaders

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-10 21:56:50 +00:00
Jonah Williams
578e769483 [Impeller] treat glyph atlas texture as source of truth, remove copy of SkBitmap. (flutter/engine#52567) 
Work towards part of https://github.com/flutter/flutter/issues/138798

Allow updating single glyphs in the glyph atlas, without replacing the entire bitmap. Required to efficiently append/update to large atlases.
 2024-05-10 21:39:47 +00:00
skia-flutter-autoroll
4dba894abc Roll Dart SDK from 01121c008f4d to 13fc7db956c7 (2 revisions) (flutter/engine#52716) 
https://dart.googlesource.com/sdk.git/+log/01121c008f4d..13fc7db956c7

2024-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-143.0.dev
2024-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-142.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-10 21:33:45 +00:00
Harry Terkelsen
740e431a9d [canvaskit] Clip before applying ColorFilter so it doesn't filter beyond child bounds (flutter/engine#52704) 
When a ColorFilter affects transparent black, it will expand its bounds
to the entire screen, even if the `saveLayer` call is bounded. This
applies a clip before applying the ColorFilter so the filter is bounded
to just the child drawings.

Also fixes bug with ColorFilter being used as an ImageFilter.

Before:

![canvaskit_colorfilter_bounds_before](https://github.com/flutter/engine/assets/1961493/25394b40-c40d-44fb-9c78-9638a40d3329)

After:

![canvaskit_colorfilter_bounds_after](https://github.com/flutter/engine/assets/1961493/b25e4084-ccae-4e41-b6e6-37e8cbbd9d54)

Fixes https://github.com/flutter/flutter/issues/88866
Fixes https://github.com/flutter/flutter/issues/144015

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-05-10 12:48:41 -07:00
Jenn Magder
c24f7454d0 Migrate FlutterView, FlutterPlatformViews, FlutterOverlayView to ARC (flutter/engine#52535) 
Smart pointers support ARC as of
https://github.com/flutter/engine/pull/47612, and the unit tests were
migrated in https://github.com/flutter/engine/pull/48162.

Migrate `FlutterView`, `FlutterPlatformViews`, and `FlutterOverlayView`
from MRC to ARC.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-05-10 12:07:30 -07:00