200 Commits

Author SHA1 Message Date
godofredoc
8cd97026b0 Allow default out_dir for fuchsia symbols upload. (flutter/engine#41776)
This also allows passing target files as relative to the src folder. This is required for migrating the fuchsia builds to engine_v2.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-05 17:36:20 +00:00
Ian McKellar
cc02c8d27e [fuchsia] fix run_integration_test.sh (flutter/engine#41668)
This updates the `fx serve` check to reflect the current state of
Fuchsia's package serving.
2023-05-03 09:44:37 +10:00
M-A
1074fd7f89 fuchsia: do not read version_history.json (flutter/engine#41585)
Otherwise this causes GN to read JSON files that are irrelevant.

Co-authored-by: Marc-Antoine Ruel <maruel@google.com>
2023-04-28 09:54:28 -07:00
Adam Perry
e9942f8f52 Reland "[fuchsia] Remove component framework v1 support. (#39732)" (flutter/engine#40198)
Previously reverted in #40104, this should now be safe to reland as
the last dependency has been deleted internally.

This reverts commit 9369c1ed1f33cfdad25ebe9cb809d6b5d6941159.
2023-03-09 15:05:45 -08:00
Adam Perry
9369c1ed1f Revert "[fuchsia] Remove component framework v1 support. (#39732)" (flutter/engine#40104)
This reverts commit 181ee0e750727f4ef54e9b8421b264a333a0bdfc.
2023-03-07 10:53:16 -08:00
Adam Perry
181ee0e750 [fuchsia] Remove component framework v1 support. (flutter/engine#39732)
There are no longer any CMX-based components outside of prebuilts
which are run by existing flutter runner prebuilts.
2023-03-01 20:07:03 -08:00
Erik
8854bfc7ce [fuchsia] Add output_path property to customize output path of .so files (flutter/engine#39007)
* Add output_path property to customize output path of .so files

* Update to use proper path for ASAN vs non-ASAN
2023-02-03 20:43:50 -08:00
Zachary Anderson
e4a6e688e9 Python compatibility fix (flutter/engine#39286)
Missed in https://github.com/flutter/engine/pull/39133
2023-01-31 08:03:55 -08:00
Ricardo Amador
0dbb3ce0db Update bytes str code (flutter/engine#39275) 2023-01-31 01:39:08 +00:00
Ahmed Ashour
51c0a9ec65 Remove superfluous words from comments (flutter/engine#39068)
* Remove superfluous words.

* Format

* Duplicate in consecutive lines.
2023-01-24 09:54:19 -08:00
Sébastien Marchand
d87876e349 [fuchsia] Bump the target API level to 11 (flutter/engine#38544)
This is the latest level supported by the Fuchsia SDK.
2022-12-30 10:58:33 -05:00
Erik
b7bf0a3155 Full implementation of text-input-test (flutter/engine#37986)
Implements text-input-test, validates that we're able to receive the correct platform messages through the flutter/keyevent channel
2022-12-07 12:17:51 -05:00
Naud Ghebre
318ac378b8 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
* Use fuchsia_component

* [mouse-input] mouse-input-view doc nits and add mouse-input-test to the run_integration_test.sh script

Co-authored-by: Erik <erkln@google.com>
2022-11-10 21:10:06 +00:00
Erik
fd9e9ccd63 [fuchsia] embedding-flutter test (flutter/engine#37052)
* Add embedding-flutter test

* Lint CC files

* GN formatting

* Remove changes to embedder

* Minor refactor

* Remove unused dependencies

* Lint CC files

* Remove comments

* Rename pubspec
2022-11-07 22:04:58 +00:00
Erik
0e283234ab Add test view for touch-input-test (flutter/engine#36879)
This PR adds a touch-input-view for use in the touch-input-test to validate touch input. The view will be attached to the test, and a touch event will be injected. The test asserts that a correct response is sent back from the view (the location of the touch as well as the name of the view).
2022-10-20 13:26:41 -04:00
Sébastien Marchand
1d08f089d0 [fuchsia] Bump the Fuchsia target API level to 10 (flutter/engine#36858) 2022-10-19 13:40:37 -07:00
Alexander Biggs
a52911ad60 [fuchsia] Fix debug symbol registration. (flutter/engine#36849) 2022-10-18 15:50:41 -07:00
Alexander Biggs
16d5012361 [fuchsia] Add --gtest-filter flag for unit tests. (flutter/engine#36509) 2022-09-29 19:57:05 +00:00
Erik
777f08534e Add skip-remove-buckets parameter (flutter/engine#36481) 2022-09-28 19:39:59 +00:00
Erik
75d2baf5fe Add Dart JIT runner integration test (flutter/engine#36420) 2022-09-27 20:14:16 +00:00
Alexander Biggs
6751734343 [fuchsia] Add run_unit_tests.sh script. (flutter/engine#36308)
This is a convenience script for running unit tests locally.

To make this script work, I had to move several test exclusions
from test_suites.yaml (which controls running tests on CQ)
to the tests themselves. I think this is for the best because
it makes running the tests locally with behavior that matches
CQ easier.

Also added fuchsia_tests to build_and_copy_to_fuchsia.sh
so it builds the unit tests .far packages by default.

Tested: Ran `run_unit_tests.sh`, all tests pass. Ran
`build_and_copy_to_fuchsia.sh`, it still builds.
2022-09-21 10:40:20 -07:00
Alexander Biggs
a9dd7de3d4 [fuchsia] Remove Dart CF v1 runner. (flutter/engine#36029) 2022-09-13 21:58:44 +00:00
Alexander Biggs
5d042156f9 [fuchsia] Delete all_packages.list. (flutter/engine#36027)
This file was only used by serve.sh which
was recently deleted.

It is not used by infra either:
https://cs.opensource.google/search?q=all_packages&sq=&ss=flutter%2Frecipes
2022-09-13 11:16:21 -07:00
Alexander Biggs
4fea91b1a1 [fuchsia] Remove serve.sh. (flutter/engine#35895)
This script is unreliable. Context from @chaselatta:

```
serve.sh will still suffer from instability. The reason is that the
flutter/engine repo is using the fuchsia.com host for all of its packages.
When that script runs it tries to connect to the target and rewrite some
rules so that it resolves fuchsia.com to engine which is what is being served
locally. If you later call serve from fuchsia.git it will do the same thing
and overwrite your local repo rewrite rules and serve the runner that is
being published from fuchsia.git.

There are some changes to ffx which allow you to better set rewrite rules via
the --alias flag which would fix this problem. The bazel sdk doesn't suffer
from this because we don't use the fuchsia.com repo name and thus don't have
collisions.

I think the best solution here is to stop using fuchsia.com when referencing
the flutter runner but that is a pretty large change.
```

We're migrating to the Bazel SDK at
fuchsia.googlesource.com/flutter-embedder so we'll gain the benefits of
package serving then.
2022-09-08 19:57:26 -07:00
Alexander Biggs
aece90bdaa [fuchsia] Port text-input-test, part 1. (flutter/engine#35957)
Part 1 sets up the test to run but the UI has not been
ported yet so the test hangs.

This is mostly a straight port from
https://cs.opensource.google/fuchsia/fuchsia/+/main:src/ui/tests/integration_input_tests/text-input/

There were some nuances:

- Some FIDL APIs are not available in the SDK and have to be
  referenced by name instead (vulkan.Loader, scheduler.ProfileProvider).
- Some subtle differences between the GN rules in fuchsia.git
  vs. engine (e.g. fuchsia_component doesn't append .cm by default to
  CFv2 output).
- Moved shared logic from embedder test into a utils/ folder to
  facilitate writing new tests in the future.

Part 2 will port over the UI to dart:ui.
2022-09-07 11:57:12 -07:00
Alexander Biggs
6b013d6113 [fuchsia] Add script for Fuchsia integration tests (flutter/engine#35933)
Tested: `run_integration_tests.sh embedder`
2022-09-06 10:19:55 -07:00
Alexander Biggs
c5482e1b56 [fuchsia] Workflow script cleanups. (flutter/engine#35867)
- Switch default behavior to `lto`, forcing use of `--no-lto` flag
  for that behavior. This is the easiest way to make LTO configurable.
- Remove redundant use of `${runtime_mode}` in branch where
  it only has one possible value.
2022-09-01 13:02:31 -07:00
Alexander Biggs
07970b7250 [fuchsia] Workflow scripts. (flutter/engine#35822)
- Adds a new script to build and copy Flutter on Fuchsia.
- Rename sync_to_fuchsia.sh to checkout_fuchsia_revision.sh
  so it's more clear what git action is being performed (checkout
  instead of rebase). Update this script to `gclient sync -D` afterwards
  since not doing that will lead to subtle build issues. This script
  is only used by workflow docs, not infra, so renaming it is fine.

Once submitted I will update the documentation.
2022-08-31 13:55:13 -07:00
David Worsham
b0d80cc091 [fuchsia] Migrate integration test to CFv2 (flutter/engine#35318) 2022-08-19 17:58:53 -07:00
Erik
0b38a3be43 Change behavior of BuildTarget parameter 'additional_targets' and renamed to 'build_targets', targets must now be passed in otherwise it will default to building all of flutter (flutter/engine#35195) 2022-08-08 12:28:38 -04:00
Sébastien Marchand
91c513d243 [Fuchsia] Specify the target API level in pm_tool.gni (flutter/engine#35132)
Bug: fxb/105705
2022-08-04 09:53:20 -07:00
Sébastien Marchand
accd3e401b [fuchsia] Bump the target API level to 9 (flutter/engine#34936) 2022-07-27 07:32:07 -07:00
omerlevran46
abda444816 [fuchsia] build_fuchsia_artifacts.py use the tools from the proper (flutter/engine#34542)
directory
2022-07-08 13:09:35 -07:00
omerlevran46
ae6cc0adce [fuchsia] fidl_dart - Use the tools from the proper directory (flutter/engine#34503) 2022-07-07 16:58:04 +00:00
Sébastien Marchand
89f95ef9e4 [fuchsia] Use the proper version of fidlc (flutter/engine#34271) 2022-06-24 08:59:06 -07:00
Sébastien Marchand
a7766026f6 [fuchsia] fuchsia_archive - Use the tools from the proper directory (flutter/engine#34255) 2022-06-23 18:34:05 -07:00
jensjoha
f316b56ce7 Fix dot package references (flutter/engine#34174)
Don't use .packages -> use .dart_tool/package_config.json
2022-06-21 08:17:18 +02:00
Alex Zaslavsky
912d4bb230 Remove no-op flag from fidlc response gen (flutter/engine#34110) 2022-06-17 16:44:04 +00:00
Zachary Anderson
1790d5a019 Adds a python formatter (flutter/engine#33797)
* Adds a python formatter

* Apply format
2022-06-03 13:00:14 -07:00
Naud Ghebre
b9bcb4ee0b [dart_component] Add dart_component build rule for building dart components for fuchsia. (flutter/engine#33464) 2022-05-18 15:59:22 -04:00
Naud Ghebre
ea8342fc2b [dart_test_runner] Adapt the dart runner to implement the suite fidl protocol so that it can be used in the v2 testing framework. (flutter/engine#32751) 2022-04-28 12:55:55 -07:00
Chase Latta
97707cd2ce Bump fuchsia api from 7 -> 8 (flutter/engine#32866) 2022-04-22 10:38:10 -07:00
Alexander Biggs
406b028ccf [fuchsia] Add hack to copy unopt build to CIPD. (flutter/engine#32548) 2022-04-08 16:37:04 -07:00
Alexander Biggs
e42a0ee5ac [fuchsia] Support --no-prebuilt-dart-sdk in build_fuchsia_artifacts. (flutter/engine#32311) 2022-04-04 12:56:05 -07:00
Rich Kadel
359fac8308 Re-enable dart runner AOT builds (flutter/engine#31844)
Fixed: fxbug.dev/64153

Note that I also removed the TODO for fxbug.dev/86941. After talking
with the bug author, this file is not directly relevant to that bug.
2022-03-11 14:07:56 -08:00
David Worsham
e743ccaac4 fuchsia: Fix potential SDK errors (flutter/engine#31099) 2022-01-26 18:58:26 -08:00
Chase Latta
7f8b7f0b41 Remove version flag from pm_tool.gni (flutter/engine#31069)
This flag is deprecated and no longer used.
2022-01-25 17:04:13 -08:00
Alexander Biggs
e12159a59f [fuchsia] Document and simplify fuchsia_archive. (flutter/engine#30854)
This might not be necessary since we ultimately want to
get rid of these rules in favor of using the SDK, but it's
useful to me for reference during embedder prototyping.

I got rid of some arguments that seemed dead:

- `cml_file` in `_fuchsia_archive` didn't seem used anywhere. It is
  used in `fuchsia_archive`.
- `meta_dir` didn't seem used.
2022-01-14 18:34:02 -08:00
Chase Latta
3578ec3d99 [fuchsia] stamp package with target api level (flutter/engine#30857)
Infrastructure runs the pm command on packages in a different path
which we were not accounting for. This will make sure we stamp the
packages when infra builds them.
2022-01-14 09:32:00 -08:00
Chase Latta
0f99fadcf2 Allow additional expose_dirs in flutter_runner (flutter/engine#30749)
Users can add an expose_dirs entry to the program field in a
component's cml file to optionally expose extra directories
from their out/ directory.

BUG: fxbug.dev/89690
2022-01-10 10:44:21 -08:00