91 Commits

Author SHA1 Message Date
Nurhan Turgut
fdeef18465 Autofill main part (flutter/engine#17986)
* changes for getting the configuration

* running autofill

* simplifications, remove unused map

* more changes

* make single autofill fields work. remove print messages

* remove an extra line

* remove extra file. also update chrome version

* addressing reviewers comments

* addressing reviewer comments

* addressing reviewer comments

* addressing reviewer comments

* changing comments

* changing comments

* adding a comment on subscriptions lifecycle

* fixing a bug which was failing the existing unit tests

* add unit tests for AutofillInfo and EngineAutofillForm. add autocomplete to textarea

* add unit tests for method channels

* remove json from the end of the file

* do not change the input type for the focused element

* check name instead of autocomplete for firefox

* check name instead of autocomplete for firefox in other methods as well

* fixing a bug in the autofillhints file, testing if firefox is failing for username hint or for all autocomplete values

* fix the breaking unit test
2020-05-06 12:58:46 -07:00
Ferhat
fe06da4eba Fix path bounds for multiple rects. Implement winding rules (flutter/engine#18165) 2020-05-05 20:53:51 -07:00
Jason Simmons
b4b5342886 [web] Upgrade the test package to remove the dependency on package_resolver (flutter/engine#18135) 2020-05-05 10:57:02 -07:00
Ferhat
9561e45970 [web] Add support for ColorFilter on images (flutter/engine#18111)
* Implement Color filter for images
* Add blend modes
* complete set of blend modes
* Add golden test for blend modes, fix size setting when using drawImage instead of drawImageRect
* Add comments
* Update golden locks
* Fix analyzer errors
Co-authored-by: Harry Terkelsen <hterkelsen@users.noreply.github.com>
* fix blend group count in test
2020-05-05 10:22:16 -07:00
Yegor
e87a60fb92 soften shadows even more; fix shadow alpha (flutter/engine#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
f464cd1f7c [web] Use correct shell operator to compare file limits (flutter/engine#18032) 2020-04-29 18:12:48 -07:00
Ferhat
30fe218072 Canvas regression (flutter/engine#17738)
* Change backdrop filter element location based on ancestor clip. Add test.
* update test
* Addressed review comments. updated goldens
* Check ancestor on retain
* addressed review comments
2020-04-20 18:59:17 -07:00
Nurhan Turgut
3a745860c2 [web] fix ulimit issues on Mac (flutter/engine#17767)
* check the max user limit before changing the limits

* more detailed changes in the file/user limit increase

* addressing pr reviews
2020-04-17 17:55:52 -07:00
Ferhat
1e6e25c4da [web] Fix compositing order when adding paragraph tags (flutter/engine#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
Nurhan Turgut
29c24b8a47 Run integration tests on ci (flutter/engine#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
Nurhan Turgut
4dc4c1fcf2 [web] using pkill to quit safari (flutter/engine#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Ferhat
60ad54840a [web] Fix canvas z-index leaking across repaints when element is reused. (flutter/engine#17378)
* Fix z-index leak. Add test for canvas reuse
* add regression test
* update golden locks
* fix analysis errors
2020-03-30 12:54:06 -07:00
Yegor
97bf969dc0 fix implicit dynamic and two lints everywhere; implicit cast in dev/ (flutter/engine#17372) 2020-03-29 19:23:37 -07:00
Nurhan Turgut
63faebcd92 change chrome version (flutter/engine#17382)
* change chrome version

* change chrome version
2020-03-27 16:52:02 -07:00
Yegor
d20bb30d3a Reland "add limited analysis options (#17332)" (flutter/engine#17374)
* Reland "add limited analysis options (#17332)"

This time I'm starting without Cirrus. Will add Cirrus serpartely from code changes.

This reverts commit 27da616b212419552551d1f9a9ed097f133d1221.

* disable Cirrus analysis check
2020-03-27 11:06:10 -07:00
Chinmay Garde
27da616b21 Revert "add limited analysis options (#17332)" (flutter/engine#17368)
This reverts commit c6aa044fde6a2b4fe89b6c92402126d6b33ef01b.
2020-03-27 02:38:50 -07:00
Yegor
c6aa044fde add limited analysis options (flutter/engine#17332)
add limited analysis options
2020-03-26 14:38:59 -07:00
Nurhan Turgut
f844653475 [web] improving felt: running target unit tests, cleaning up used proccesses (flutter/engine#17339)
* improving felt: running target unit tests, cleaning up used proccesses

* removing null check
2020-03-26 14:01:36 -07:00
Nurhan Turgut
cdff1342bf [web] use web drivers as a library only. do not fetch/clone web_installers (flutter/engine#17299)
* use web drivers as a library only. do not fetch/clone web_installers

* fixing comments

* addressing reviewer comments

* adding a trim to output. otherwise last fails
2020-03-24 15:37:33 -07:00
Yegor
a63c4b7025 Soften shadows (flutter/engine#17231)
* Soften shadows

* update goldens
2020-03-20 19:50:00 -07:00
Nurhan Turgut
9f6ffe557c Felt add integration (flutter/engine#17190)
* adding arguments to felt for running different type of tests

* adding test type enums to felt

* more changes to felt for testing branches

* more additions to code

* more changes to felt

* adding code for cloning web_drivers

* validating test directories. running the integration tests. update the readme file partially

* Removing todo lists used for development

* addressing reviewers comments

* remove unused imports

* addressing more reviewer comments

* addressing more reviewer comments

* addressing reviewer comments.

* addressing reviewer comments.

* fixing typos

* using chromedriverinstaller as a library. Fixing the commit number used from web_installers repo

* clean drivers directory after tests finish

* addressing more reviewer comments

* throwing all critical exceptions instead of logging and returning boolean flags

* adding todos for items we can do for making felt easier to use for local development

* do not run integration tests on CIs. Added an issue to the TODO.

* changing todo's with issues.
2020-03-20 19:24:13 -07:00
Nurhan Turgut
0a3bbd1f00 increasing user limits for macos (flutter/engine#17097) 2020-03-11 12:15:47 -07:00
Yegor
98f2be6b1f Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040)
This reverts 7205c0e7b3e575a6dd5d14c0c22058ae40f261a3 and re-lands 8b77254d97416bb9b347a578410911ed09efbce3. The 8b77254d97416bb9b347a578410911ed09efbce3 was good. The screenshot changes were expected.

Fixes https://github.com/flutter/flutter/issues/32215
2020-03-09 20:32:59 -07:00
Ferhat
c54d2ebe85 Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
* Add support for firefox mac installer. Update web_ui pubspec for http.wq
* Addressed review comment 'final'
2020-03-09 18:13:37 -07:00
Chris Bracken
7205c0e7b3 Revert "fix shadows and mask filter blurs (#16963)" (flutter/engine#17008)
Broke golden file tests in the framework. Reverting to unblock the
engine roll to the framework.

This reverts commit 8b77254d97416bb9b347a578410911ed09efbce3.
2020-03-07 10:18:10 -08:00
Yegor
8b77254d97 fix shadows and mask filter blurs (flutter/engine#16963)
* fix shadows and mask filter blurs

* update goldens

* clarify the choice to min the shadows
2020-03-05 22:07:57 -08:00
Nurhan Turgut
a868ed4b44 [web] changing user limits for macos (flutter/engine#16797)
* changing user limits for macos

* check kernel name instead
2020-02-25 15:04:07 -08:00
vsmenon
a605113c25 opt out dart:ui from nnbd (flutter/engine#16473)
* opt out dart:ui from nnbd

* Annotate tests as well
2020-02-20 11:04:00 -08:00
Nurhan Turgut
97d1caffaa [web] Skipping failing edge tests (flutter/engine#16626)
* making edge default test browser on windows. adding some skips (not all) for methods failing on edge

* skip failing tests. make egde default for testing

* skip one more test

* addressing reviewer comments. removing extra bat file
2020-02-18 09:36:04 -08:00
Nurhan Turgut
fb1b707879 [web] Fixing launching Safari. This should solve the LUCI issue (flutter/engine#16590)
* Fixing launching Safari. This should solve the LUCI issue

* more comments and linking the issue
2020-02-14 10:27:20 -08:00
Ferhat
3ed6b577e9 Fix drawRRect failure when shader is specified (flutter/engine#16601) 2020-02-14 09:08:28 -08:00
Nurhan Turgut
5a5c8d04b3 Update felt documentation (flutter/engine#16559) 2020-02-12 14:05:08 -08:00
Yegor
25de6825f3 Partially fix canvas vs text paint order when running on Blink/Webkit browsers (flutter/engine#16483)
fix canvas vs text paint order in Blink/Webkit
2020-02-10 13:41:50 -08:00
Ferhat
a00b502efa [web] Fixes incorrect transform when context save and transforms are deferred. (flutter/engine#16412)
* Fix transform order in clipStack replay
2020-02-05 15:02:34 -08:00
Mouad Debbar
950eb2447f [web][felt] If full dart-sdk isn't available, install it (flutter/engine#16341) 2020-02-03 15:06:24 -08:00
Yegor
fe7cbf64b1 Use bundled Roboto in all tests (flutter/engine#16218)
* Use bundled Roboto in all tests
2020-01-30 17:31:32 -08:00
Nurhan Turgut
9fe323f5e0 updating the versions of the browsers for flutter web engine unit tests (flutter/engine#15977) 2020-01-24 16:28:21 -08:00
Dan Field
62a99c60c5 the the fix (flutter/engine#15973) 2020-01-24 12:43:32 -08:00
Ferhat
328ff31301 Implement Canvas drawPoints API for Html backend (flutter/engine#15870) 2020-01-21 16:37:41 -08:00
Nurhan Turgut
8397831dd2 windpws batch script for running felt. it does not have snapshot option (flutter/engine#15746) 2020-01-21 09:30:57 -08:00
Ferhat
924f12ee44 Clipping path fix for browsers that don't use correct units when applying clip-path css using svg (flutter/engine#15712) 2020-01-17 10:41:02 -08:00
Nurhan Turgut
8ca3dd95d8 [web] edge launcher for windows (flutter/engine#15690)
* edge launcher for windows

* addressing PR comments

* url mistake

* remove uncessary import

* initialization error fix

* format
2020-01-16 14:48:13 -08:00
Yegor
8b63cb5933 fix text blurriness in HTML-rendered text (flutter/engine#15649)
* fix text blurriness in HTML-rendered text
2020-01-15 14:20:28 -08:00
Nurhan Turgut
cdf45aa737 [web] Add Edge support for Flutter Engine unit-tests. (flutter/engine#15641)
* Add Edge support for Flutter Engine unit-tests. This does not include the launcher

* Add mapping from browser name to platform.

* remove ie from supported browser maps
2020-01-14 16:44:44 -08:00
Nurhan Turgut
0e59dd9f6d modify test_runner.dart for windows to fix test build errors (flutter/engine#15326) 2020-01-09 14:58:01 -08:00
Nurhan Turgut
6e33e9d443 adding windows platform to felt. fixing signal (flutter/engine#15111) 2020-01-08 06:30:57 -08:00
Ferhat
c848cb7c93 Refactor BitmapCanvas, lazily allocate canvas, fix image composition bug. (flutter/engine#15153)
* Refactor BitmapCanvas. Fix image compositing bug. Allocate canvas lazily
* Fix recording canvas test by restoring context save
* Update recording canvas test for drawColor to show multiply blend
2020-01-07 15:36:48 -08:00
Yegor
527ee6403a [web] implement pushImageFilter (flutter/engine#14599)
implement pushImageFilter in the HTML and CanvasKit backends
2019-12-20 12:10:56 -08:00
Ferhat
62edec4b08 Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535)
* Fix lint warnings across web_ui

* add textureCoordinates/indices getters for Vertices

* fix compositor indices
2019-12-19 17:39:33 -08:00
Nurhan Turgut
f3fff73826 [web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555)
* Launch safari browser

* Adding safari tests to supported browsers

* changing the directrory for redirect file. This works without opening a permision pop-up. Note: there is no headless mode in safari

* addressing reviewer comments
2019-12-19 08:05:16 -08:00