371 Commits

Author SHA1 Message Date
George Wright
fcc1a07ccd Add some APIs to StringUtils (flutter/engine#25043)
* Add the following APIs to StringUtils:

- NumberToString16
- JoinString
- ReplaceChars
- WideToUTF16
- UTF16ToWide

Implement the following APIs for Windows:

- UTF8ToUTF16
- UTF16ToUTF8

* Review comments

Add a couple TODOs for decimal formatting and use std::u16string::npos
rather than std::string::npos.

* Update licences_flutter

Co-authored-by: Chris Bracken <chris@bracken.jp>
2021-03-17 15:44:47 -07:00
George Wright
a219aacc41 Code formatting for imported Chromium code 2021-03-16 10:18:21 -07:00
George Wright
7c3d796a83 Initial import from upstream Chromium of:
AXActivePopup
AXFragmentRootWin
AXPlatformRelationWin
AXPlatformNodeDelegateUtilsWin
AXPlatformNodeWin
Range
ScopedVariant
ScopedBstr
ScopedSafearray
EnumVariant
UiaRegistrarWin
VariantUtil
VariantVector
atl.h
atl_module.h
base_export.h
2021-03-16 10:18:21 -07:00
George Wright
fbcf0800f1 Implement AXPlatformNodeBase::GetInstanceCountForTesting (flutter/engine#24999) 2021-03-15 16:13:02 -07:00
chunhtai
521edb0159 fix selectable text selections are not announced in voice over (flutter/engine#24933) 2021-03-15 14:23:02 -07:00
Chris Bracken
64a2844ce8 Fix attribute replace bug in TextAXNodeWrapper (flutter/engine#24986)
When replacing an int/float/bool attribute on the test node, we want to
erase the range from the iterator returned by remove_if to end(), which
may be an empty range. In the case where remove_if() returns end(), the
single-parameter variant of erase() attempts to remove an element past
the end of the container.
2021-03-12 22:35:02 -08:00
Chris Bracken
13cf185e1c Correct setup-related typos (flutter/engine#24846)
Corrects uses of setup as a verb to 'set up', leaves noun/noun-phrase
forms of setup as 'setup'. Also settles on 'teardown' as opposed to
tear-down for consistency across the codebase.

A few other minor comment/wording corrections.
2021-03-08 17:31:10 -08:00
Jason Simmons
b978d1fb46 Initialize max_ascent/descent from the strut only if the strut is valid (flutter/engine#24802) 2021-03-05 15:44:01 -08:00
Jason Simmons
71e7d8e96e SkParagraph: support multiple default font families (flutter/engine#24662) 2021-03-04 15:34:01 -08:00
Jason Simmons
6b98e883a1 Allow calls to legacyMakeTypeface in the AssetFontManager (flutter/engine#24612) 2021-03-04 14:54:01 -08:00
LongCatIsLooong
deec3a0d07 Reland "TextStyle level leadingDistribution (#24025)" reverted in #24665 (flutter/engine#24668) 2021-03-01 14:55:03 -08:00
LongCatIsLooong
b82a309954 Revert "TextStyle level leadingDistribution (#24025)" (flutter/engine#24665) 2021-02-26 12:41:01 -08:00
LongCatIsLooong
e10becadf3 TextStyle level leadingDistribution (flutter/engine#24025) 2021-02-25 11:46:02 -08:00
Jason Simmons
3356802d18 Define FLUTTER_ENABLE_SKSHAPER consistently when building txt_unittests and txt_benchmarks (flutter/engine#24253) 2021-02-09 14:11:02 -08:00
Jason Simmons
34b5763be8 libtxt: apply the justify offset to glyph positions instead of paint records (flutter/engine#24219) 2021-02-09 12:11:01 -08:00
George Wright
1b171451d0 Fixes required for libax to compile on Windows 2021-02-02 11:14:34 -08:00
George Wright
fa1a5c2f1f Delete ax_platform_text_boundary as it is not required for Windows 2021-02-02 11:14:34 -08:00
George Wright
b4a3dd5c60 Import windows_types.h from upstream ax 2021-02-02 11:14:34 -08:00
George Wright
9d00999aa7 Add stub types for Windows accessibility 2021-02-02 11:14:34 -08:00
Jason Simmons
a46c49db5b Remove libtxt styled runs benchmark (flutter/engine#23934) 2021-01-28 08:54:02 -08:00
chunhtai
053c0e3eb4 Implements accessibility bridge in common library (flutter/engine#23491) 2021-01-22 09:29:02 -08:00
Dan Field
e778949043 Reland path vol tracker (flutter/engine#23840)
This time making sure to deref the native object on GC.
2021-01-21 16:03:43 -08:00
Jason Simmons
43a836fd96 Use references when iterating over SkParagraph text boxes (flutter/engine#23837) 2021-01-21 14:24:12 -08:00
Dan Field
cb57183325 revert path volatility tracker (flutter/engine#23822) 2021-01-21 08:34:02 -08:00
chunhtai
e738d329d7 fix ax unique id flake (flutter/engine#23518) 2021-01-13 16:54:03 -08:00
gaaclarke
dbc486213c Plumbing refactor to allow the usage of Dart_CreateIsolateInGroup (flutter/engine#23549)
Did the plumbing refactor that allows us to call Dart_CreateIsolateInGroup when applicable.
2021-01-12 16:43:12 -08:00
chunhtai
25844bebd0 disable UnassignedIdsAreReused flaky test (flutter/engine#23511) 2021-01-07 15:07:08 -08:00
chunhtai
ec2eb68f80 Apply local patch to chromium accessibility code (flutter/engine#23110) 2021-01-06 17:39:02 -08:00
Dan Field
dedf9bd1af Reland path volatility tracker, disabling it if deterministic rendering is requested (flutter/engine#23226)
* Reland path volatility tracker (#23063)" (#23220)

This reverts commit b56fc25561417f96e17dacab375e66f474a54c94.

* allow disabling based on whether deterministic rendering is needed
2020-12-22 08:25:20 -08:00
Dan Field
b56fc25561 Revert "Reland path volatility tracker (#23063)" (flutter/engine#23220)
This reverts commit 77c7096efb0b1392acc9793c386561a3c36012ba.
2020-12-21 13:53:18 -08:00
Chun-Heng Tai
b4977cb51a format forked chromium accessibility code 2020-12-21 13:31:48 -08:00
Chun-Heng Tai
da504d2db0 fork additional raw chromium a11y code 2020-12-21 13:31:48 -08:00
liguisheng
1387021a0d fix crash in FontCollection::init() when FontFamily is empty (flutter/engine#23019) 2020-12-16 15:29:02 -08:00
George Wright
3294070ac5 Formatting changes 2020-12-15 18:03:58 -08:00
George Wright
4e7009f6a1 Initial import of accessibility code from Chromium. There are no
modifications to this code.
2020-12-15 18:03:58 -08:00
Dan Field
77c7096efb Reland path volatility tracker (flutter/engine#23063)
* Revert "Revert "Set SkPath::setIsVolatile based on whether the path survives at least two frames (#22620)" (#23044)"

This reverts commit feda80cb42f99e2588a9a6b9ab3dd1f812d0f45b.

* Fix tracing
2020-12-14 17:21:55 -08:00
Dan Field
feda80cb42 Revert "Set SkPath::setIsVolatile based on whether the path survives at least two frames (#22620)" (flutter/engine#23044)
This reverts commit 2d52a3c87c97660a050e4bf5559091d0cec262f3.
2020-12-11 15:39:24 -08:00
Dan Field
2d52a3c87c Set SkPath::setIsVolatile based on whether the path survives at least two frames (flutter/engine#22620)
This patch defaults the volatility bit on SkPaths to false, and then flips it to true if the path survives at least two frames.
2020-12-10 13:57:23 -08:00
Zachary Anderson
1f4cc8b4ee Revert "Roll buildroot and benchmark (#22804)" (flutter/engine#22816)
This reverts commit 0d078a2b1661236e3a813b30788d367943599085.
2020-12-01 18:32:10 -08:00
Dan Field
0d078a2b16 Roll buildroot and benchmark (flutter/engine#22804)
Roll benchmark to google/benchmark@bf585a2

Roll buildroot to flutter/buildroot@084f0d3
2020-12-01 13:39:37 -08:00
Jason Simmons
dcbace3a9d libtxt: Clone an ICU line break iterator for each Paragraph/WordBreaker (flutter/engine#22594) 2020-11-20 13:43:03 -08:00
Filip Filmar
6381d11abd Roll ICU to c2a4cae149aae7fd30c4cbe3cf1b30df03b386f1 (flutter/engine#22465)
Changes to make this work:

- Had to change the use of an UBool constant `FALSE` to 0 because
  the file referring to it does not include the respective header.

- Had to change the license checker to ignore files in the directory
  icu/source/samples.  There were random changes to the licensing
  headers which tripped up license checks.  And since we don't include
  samples in the binaries we build, the most efficient way to fix it is
  to exclude sample code from license checks.

Issue: https://github.com/flutter/flutter/issues/70370
2020-11-13 14:52:11 -08:00
Filip Filmar
b52a40fcc9 Add an include in minikin (flutter/engine#22466)
FontLanguageListCache.cpp uses the ICU constant FALSE of type UBool, but
does not #include <umachine.h> where it is defined.

This makes the code brittle with respect to header file reorganization,
and I found this while trying to roll ICU version 68.1 to Flutter
engine.
2020-11-12 11:08:10 -08:00
Jason Simmons
5441ac8cf5 libtxt: use a placeholder run's width as the width of the placeholder character's glyph (flutter/engine#22451) 2020-11-12 10:24:01 -08:00
Daco Harkes
b6c5eff614 WeakPersistentHandle migration (flutter/engine#19843)
and roll Dart to 52783837369de45d3372cb6c6b7cdd63e71cd829.
2020-11-03 13:06:53 +01:00
Jason Simmons
edd1e923fc Invalidate the cached SkParagraph font collection when a new font manager is installed (flutter/engine#22157) 2020-10-29 09:31:04 -07:00
Chinmay Garde
927393d54b Fix native constructor of list of zircon handles and remove unused list factory specializations. (flutter/engine#21980) 2020-10-19 19:42:01 -07:00
Jason Simmons
546df582bb Forward font collection APIs to the SkParagraph font collection (flutter/engine#21734) 2020-10-19 16:27:03 -07:00
Jason Simmons
4e7a837cfa Specify the Noto Naskh Arabic font to get consistent results in tests using Arabic characters (flutter/engine#21974)
See https://github.com/flutter/flutter/issues/68493
2020-10-19 13:51:39 -07:00
gaaclarke
faa1ea2490 Temporarily disabled tests that were using latin and arabic characters (flutter/engine#21971)
while we fix them.
2020-10-19 11:51:34 -07:00