66 Commits

Author SHA1 Message Date
chunhtai
533816d116
Refactor web text editing shortcuts (#103377) 2022-05-12 13:09:06 -07:00
Kate Lovett
6eb601bc3e
Fix AppBar scrolledUnder initial state - the third (#102582) 2022-04-27 15:34:08 -07:00
Pierre-Louis
9644aa8d76
Fixes documentation inconsistencies around 'material' and 'material design' (#102632) 2022-04-27 09:29:06 -07:00
Kate Lovett
a75743e80e
Revert "Re-land reverse case for AppBar scrolled under" (#102580) 2022-04-26 11:14:06 -07:00
Kate Lovett
558016455a
Re-land reverse case for AppBar scrolled under (#102343) 2022-04-25 13:54:05 -07:00
Taha Tesser
900e5405c2
Replace ListTile with Chip in the debugCheckHasMaterial control test (#102311) 2022-04-21 12:59:07 -07:00
chunhtai
52fd2412f4
Reland "Add default selection style (#100719)" (#101954) 2022-04-15 16:44:07 -07:00
Kate Lovett
ea26272e2a
Revert "Fix reverse cases for App Bar scrolled under behavior (#101460)" (#101929)
merging now since it blocks flutter roll for too long
2022-04-14 15:58:05 -07:00
chunhtai
95e52dac76
Revert "Add default selection style (#100719)" (#101921)
* Revert "Add default selection style (#100719)"

This reverts commit c8057bc5064f54c04cbe054f00904722a7233a63.

* update

* update
2022-04-14 11:31:39 -07:00
Jonah Williams
08a23498c1
Revert changes to opacity/fade transition repaint boundary and secondary change (#101844) 2022-04-13 13:24:06 -07:00
chunhtai
c8057bc506
Add default selection style (#100719) 2022-04-13 11:49:09 -07:00
Jonah Williams
33e540a92e
fix test from opacity/repaint change (#101774) 2022-04-12 11:18:48 -07:00
Jonah Williams
6def1596cd
[framework] introduce repaint boundary in Opacity widgets (#101601) 2022-04-12 10:34:11 -07:00
Kate Lovett
135bb5d4f2
Remove deprecated Scaffold SnackBar API (#98549) 2022-04-08 14:27:07 -07:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Hans Muller
f4f23ecb59
Added SharedAppData to the widgets library (#93175) 2021-11-08 12:27:14 -08:00
Hans Muller
0815da4d38
Revert "Added widgets/AppModel" (#93161) 2021-11-05 16:13:03 -07:00
Hans Muller
389a12f4e0
Added widgets/AppModel (#92297) 2021-11-03 20:23:02 -07:00
LongCatIsLooong
ffcd32ebb6
Move text editing Actions to EditableTextState (#90684) 2021-11-03 11:11:32 -07:00
Jonah Williams
2900347afe
[flutter] prevent errant text field clicks from losing focus (#86041) 2021-07-13 16:46:04 -07:00
Greg Spencer
1ac209c222
Turn on avoid_dynamic_calls lint, make appropriate changes. (#84478) 2021-06-23 16:36:03 -07:00
Jonah Williams
85be4f6c96
[flutter] when primary mouse pointers don't contact a focused node, reset the focus (#82575) 2021-06-08 17:39:05 -07:00
chunhtai
97dfafbb62
Make tooltip hoverable and dismissible (#83830) 2021-06-03 17:49:05 -07:00
Alexandre Ardhuin
fa19b3d3bd
add missing trailing commas (#81329) 2021-04-27 17:09:03 -07:00
Justin McCandless
541bff4058
Text Editing Movement Keys via Shortcuts (#75032)
Text editing shortcuts involving the arrow keys are no longer handled by RenderEditable's RawKeyboardListener, they use the new Shortcuts setup.  First PR in a plan to port all text editing keyboard handling to shortcuts.
2021-03-11 15:52:04 -08:00
Kate Lovett
f4a0511e8b
Re-land 'Default Keyboard ScrollActions with PrimaryScrollController' (#70893) 2020-11-19 17:48:04 -08:00
Jim Graham
e803b13f01
Revert "Re-land 'Default Keyboard ScrollActions with PrimaryScrollController' (#70401)" (#70675)
This reverts commit 9b56241eef3a81bfe4e1ff72cc453a7693861944.
2020-11-16 22:55:59 -08:00
Kate Lovett
9b56241eef
Re-land 'Default Keyboard ScrollActions with PrimaryScrollController' (#70401) 2020-11-16 14:47:04 -06:00
Todd Volkert
f8d2f58b52
Ignore DismissIntent when barrier is not dismissible (#70156) 2020-11-12 11:45:32 -08:00
Zachary Anderson
3fce16c329
Revert "Default Keyboard ScrollActions with PrimaryScrollController (#69795)" (#70391)
This reverts commit 1f0df54553bab852026a2801ce3921a2ba493fab.
2020-11-12 09:49:12 -08:00
Kate Lovett
1f0df54553
Default Keyboard ScrollActions with PrimaryScrollController (#69795) 2020-11-11 15:29:05 -08:00
Darren Austin
3c21775c94
Migrate Material framework tests to null safety (#67556)
Migrate Material framework tests to null safety.
2020-10-07 16:44:00 -07:00
Tong Mu
0fbc95df21
Remove the extra wrapping of Listener (#67340) 2020-10-07 13:12:05 -07:00
Kate Lovett
64c845c579
Re-land ScaffoldMessenger (#66504) 2020-10-05 18:59:12 -05:00
Michael Goderbauer
fc85492d7c
Make Navigator restorable (inkl. WidgetsApp, MaterialApp, CupertinoApp) (#65658) 2020-10-02 11:42:02 -07:00
Hans Muller
13860a7d23
Revert "Re-land ScaffoldMessenger (#65416)" (#65482)
This reverts commit adc5f26b504f3cb80557455d8f0badad874ebc8b.
2020-09-10 13:17:51 -07:00
Hans Muller
adc5f26b50
Re-land ScaffoldMessenger (#65416) 2020-09-08 16:02:06 -07:00
Zachary Anderson
02d0163244
Revert "ScaffoldMessenger (#64101)" (#65257)
This reverts commit 48f1a0a8d5531a08de638f087678770dd26b01ba.
2020-09-04 13:46:53 -07:00
Kate Lovett
48f1a0a8d5
ScaffoldMessenger (#64101) 2020-09-03 15:55:04 -07:00
chunhtai
5623fea53c
Reverse the semantics order of modal barrier and modal scope (#59290)
* Add semantics sort key for modal scope and modal barrier

* fix test

* fix test

* fix test

* fix space

* fix more tests

* addressing comments
2020-06-24 10:37:53 -07:00
Darren Austin
06de567811
Dismiss modal routes with a keyboard shortcut (#59310) 2020-06-18 11:53:02 -07:00
Kate Lovett
97dc7eee57
Step 3 of 3: Remove opt-in for debugCheckHasMaterialLocalizations assertion on TextField (#58831) 2020-06-12 12:40:03 -07:00
Alexandre Ardhuin
4d7525f05c
Opt out nnbd in packages/flutter (#59186)
* add language version 2.8 in packages/flutter

* enable non-nullable analyzer flag
2020-06-11 14:11:30 +02:00
chunhtai
17ed4e0b3a
Introduce inherited navigator observer and refactor hero controller (#58808) 2020-06-08 16:18:02 -07:00
Greg Spencer
0f68b46f6a
Revise Action API (#42940)
This updates the Action API in accordance with the design doc for the changes: flutter.dev/go/actions-and-shortcuts-design-revision

Fixes #53276
2020-04-07 16:49:39 -07:00
Shi-Hao Hong
6d4121c075
Fix tests that rely on FadeTransition incorrectly and depend on implementation details of FadeUpwardsTransitionBuilder (#51150) 2020-02-22 16:54:02 -08:00
Greg Spencer
d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Greg Spencer
c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046ed18ca32827e1a715ca5e405c646ac because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Greg Spencer
8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00