engine-flutter-autoroll
e2e543dbd7
Roll Fuchsia Linux SDK from nUffQhlaVpp0P2Yl6... to qRgW6vhjBdWGGopHL... ( #170638 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-15 06:17:28 +00:00
Jim Graham
ba56e065a9
[Impeller] eliminate PathReceiver::PathEnd which is only used in one case ( #170500 )
...
Fixes: https://github.com/flutter/flutter/issues/169719
2025-06-14 21:01:09 +00:00
Jim Graham
c0db0332b3
[Impeller] Remove use of simple Skia objects ( #170494 )
...
Just a few remaining references to Skia types like SkScalar and
SkSize/Rect. After this most of Impeller is Skia-free except for areas
that deal with fonts, images, and the `toolkit/interop` and
`typographer` directories.
2025-06-14 20:59:37 +00:00
engine-flutter-autoroll
883a22dc54
Roll Dart SDK from 533af3e58e48 to ae721d7d5b51 (1 revision) ( #170630 )
...
https://dart.googlesource.com/sdk.git/+log/533af3e58e48..ae721d7d5b51
2025-06-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-235.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-14 15:57:42 +00:00
engine-flutter-autoroll
0f06b78ad3
Roll Fuchsia Linux SDK from lVfYTWxB0rTTuW_k3... to nUffQhlaVpp0P2Yl6... ( #170623 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-14 04:01:00 +00:00
engine-flutter-autoroll
edb15c5ab6
Roll Dart SDK from 1a6f6d7c6f2c to 533af3e58e48 (6 revisions) ( #170622 )
...
https://dart.googlesource.com/sdk.git/+log/1a6f6d7c6f2c..533af3e58e48
2025-06-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-234.0.dev
2025-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-233.0.dev
2025-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-232.0.dev
2025-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-231.0.dev
2025-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-230.0.dev
2025-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-229.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-14 03:03:50 +00:00
engine-flutter-autoroll
ac6ce42d59
Roll Skia from 39fc446abf5c to f8cd9fe75f21 (2 revisions) ( #170621 )
...
https://skia.googlesource.com/skia.git/+log/39fc446abf5c..f8cd9fe75f21
2025-06-13 mike@reedtribe.org Speed up SkFont::getBounds
2025-06-13 syoussefi@google.com [vulkan] Generate more readable SPIR-V
disassembly
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-14 03:00:54 +00:00
engine-flutter-autoroll
aea91d5df4
Roll Skia from 438ea4e05e15 to 39fc446abf5c (6 revisions) ( #170608 )
...
https://skia.googlesource.com/skia.git/+log/438ea4e05e15..39fc446abf5c
2025-06-13 mike@reedtribe.org Use SkSpan for drawAtlas
2025-06-13 fmalita@google.com move pathops into a module
2025-06-13 borenet@google.com [SkPathBuilder] Add rArcTo
2025-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 4ef9a1d933cf to 222889ea0395 (2 revisions)
2025-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from d8c154990b5b to fdff117046ce (6 revisions)
2025-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from a5570b3b45a2 to e3ddb182d581 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-13 23:49:43 +00:00
Jonah Williams
c64e652bfe
[Impeller] disable lossy texture compression. ( #170596 )
...
Fixes https://github.com/flutter/flutter/issues/170056
Fixes https://github.com/flutter/flutter/issues/170089
Lossy texture compression can cause rendering artifacts in certain kinds
of images. Disable automatic application of it.
2025-06-13 23:48:30 +00:00
Jackson Gardner
c3c56d116d
Fix whitespace issue in .ci.yaml. ( #170615 )
...
Getting failures in CI both presubmit and postsubmit that look like:
```
[2025-06-13 13:23:25.219514] ERROR: ERROR: Whitespace check failed. The following files have trailing spaces:
/b/s/w/ir/cache/builder/engine/src/flutter/.ci.yaml:62: bringup: true # LUCI failing KVM access https://github.com/flutter/flutter/issues/170529
Checking C++/ObjC/Shader formatting...
```
This looks like it was introduced in
https://github.com/flutter/flutter/pull/170607
2025-06-13 21:56:39 +00:00
Jonah Williams
f7d37ca6d7
[Impeller] when decoding image on iOS, block on command buffer scheduling and log gpu errors. ( #169378 )
...
Attempted fix for https://github.com/flutter/flutter/issues/166668 .
Plan is to ask for testing once rolled into g3 since we weren't given a
repro.
Explaination: we can only submit command buffers to the metal command
queue when the device is in the foreground. push notifications
temporarily wake up the app and can trigger images to begin decoding.
This decoding can fail, possibly due to the app re-backgrounding. In
theory, the sync switch should prevent this from happening - but because
we don't actually block on the scheduling of the command buffer there is
technically a race that can happen.
Add the ability to block submission on scheduling for metal. note that
other graphics APIs do not have a distinction for commited vs scheduled
and so it no-ops for them.
See
https://developer.apple.com/documentation/metal/preparing-your-metal-app-to-run-in-the-background
> When UIKit calls your app delegate’s
[applicationDidEnterBackground(_:)](https://developer.apple.com/documentation/UIKit/UIApplicationDelegate/applicationDidEnterBackground(_:) )
method, make sure Metal has scheduled all command buffers you’ve already
committed before your app returns control to the system. ... Finish
encoding commands to render the frame and commit the command buffer,
then call
[waitUntilScheduled()](https://developer.apple.com/documentation/metal/mtlcommandbuffer/waituntilscheduled() ).
2025-06-13 18:49:55 +00:00
gaaclarke
3bddd07fa6
licenses_cpp: Started writing the licenses file ( #170539 )
...
This writes the licenses and associates them with packages. It has
simple deduplication. This also adds linux ci tests. Writing the file
adds about 7 seconds, now we are at 37s. Too much is getting written now
though so that should come down once the output is corrected.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-13 18:44:50 +00:00
John "codefu" McDole
8303a96a0a
infa: linux_android_emulator_tests to bringup (bad kvm config) ( #170607 )
...
The tree is closed; LUCI doesn't support KVM access right now.
fyi: @matanlurey
2025-06-13 18:23:22 +00:00
Kostia Sokolovskyi
a7c0621241
[web] Add Paint dithering. ( #170362 )
...
Fixes https://github.com/flutter/flutter/issues/168798
Closes https://github.com/flutter/flutter/issues/134250
### Description
- Adds `Paint` dithering for gradient shaders in `canvaskit`
- Adds `Paint` dithering for gradient shaders in `skwasm`
### CanvasKit
| Before | After |
| - | - |
| <img width="739" alt="canvaskit_bug"
src="https://github.com/user-attachments/assets/cf15e6ff-e0ab-4bce-9db1-653271f5adc8 "
/> | <img width="739" alt="canvaskit_fix"
src="https://github.com/user-attachments/assets/3aba09a5-f27a-4c17-a596-44b53961373e "
/> |
### SkWASM
| Before | After |
| - | - |
| <img width="739" alt="skwasm_bug"
src="https://github.com/user-attachments/assets/fe882450-f656-4a1b-9811-fdded5e4a737 "
/> | <img width="739" alt="skwasm_fix"
src="https://github.com/user-attachments/assets/86bf2cf9-d743-453b-9d7a-600e293bf8f1 "
/> |
<details>
<summary>Sample Source Code</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const App());
}
class App extends StatelessWidget {
const App({super.key});
@override
Widget build(BuildContext context) {
return Container(
width: 400,
height: 400,
decoration: BoxDecoration(
gradient: LinearGradient(
colors: const [Color(0xff324958), Color(0xff26323a)],
begin: Alignment.bottomLeft,
end: Alignment.topRight,
),
),
);
}
}
```
</details>
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-13 06:40:34 +00:00
Hannah Jin
978ef6b820
Reland ( #167738 ) but with some flags updated to use enum ( #170505 )
...
Reland (#167738 ) : [a11y] Semantics flag refactor step 2: embedder part
*with some updates*
The original PR was reverted because the changes to embedder should be
in one PR to avoid introducing breaking changes.
This PR contains 2 commits, one commit of re-landing #167738 and one
commit of new enum updates.
new Updates :
Add new enum FlutterTristate and FlutterCheckState in embedder.h for 7
flags.
For CheckState, it used to use 3 bools (hasCheck, isChecked,
isCheckStateMixed) to represent check states, replace them with a
FlutterCheckState enum.
For other 6 flags, each has 2 bools (hasXXState and isXX), replace them
with a FlutterTristate enum.
TODO:
Will also update these flags in dart:ui and framework to be tristate too
in another PR, this PR is only for embedder.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Chris Bracken <chris@bracken.jp>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-06-13 04:46:28 +00:00
engine-flutter-autoroll
9b319b85f9
Roll Dart SDK from ac589dba5282 to 1a6f6d7c6f2c (4 revisions) ( #170566 )
...
https://dart.googlesource.com/sdk.git/+log/ac589dba5282..1a6f6d7c6f2c
2025-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-228.0.dev
2025-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-227.0.dev
2025-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-226.0.dev
2025-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-225.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-13 03:38:25 +00:00
engine-flutter-autoroll
bf0a05333e
Roll Fuchsia Linux SDK from Dueykg3VpLT5D_jSG... to lVfYTWxB0rTTuW_k3... ( #170557 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-13 01:37:24 +00:00
Loïc Sharma
2e0b9f26cc
[Windows] Use ANGLE blit extension on GLES 2.0 ( #170298 )
...
This updates Flutter Windows to fall back to
[`glBlitFramebufferANGLE`](https://github.com/google/angle/blob/main/extensions/ANGLE_framebuffer_blit.txt )
if `glBlitFramebuffer` is not available. This makes Flutter Windows work
on devices where ANGLE supports only GLES 2.0.
Fixes: https://github.com/flutter/flutter/issues/169178
### Background
ANGLE only implements GLES 2.0 on some Windows 10+ machines
([1](https://github.com/flutter/flutter/issues/169178#issuecomment-2943735504 ),
[2](https://github.com/flutter/flutter/issues/169178#issuecomment-2944096179 )).
Flutter Windows 3.27.4 and lower was using `glBlitFramebuffer` on GLES
2.0 devices, even though that requires GLES 3.0. This magically worked
though, thanks to ANGLE.
However in 3.29.0, Impeller was updated to not resolve GLES 3.0 procs on
GLES 2.0: https://github.com/flutter/engine/pull/56636 . This caused
Flutter Windows to crash on GLES 2.0 devices since it was calling
`glBlitFramebuffer`.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-13 01:31:27 +00:00
Jonah Williams
3b95b61fd4
[Impeller] fix mask filter application to Vertices. ( #170548 )
...
Fixes https://github.com/flutter/flutter/issues/170480
Vertices should ignore mask filter. One particular code path in draw
vertices with no per-vertex colors was applying it though.
2025-06-12 23:13:10 +00:00
engine-flutter-autoroll
b2f8c57c00
Roll Skia from b41e7017658e to 22018eab8c1f (2 revisions) ( #170551 )
...
https://skia.googlesource.com/skia.git/+log/b41e7017658e..22018eab8c1f
2025-06-12 michaelludwig@google.com Reland "[graphite] Use HW blends for
kPlus on unorm texture formats"
2025-06-12 thomsmit@google.com Promote linear gradient bias calculation
to f32
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-12 22:52:36 +00:00
engine-flutter-autoroll
0777beac65
Roll Dart SDK from 9f741ef8a689 to ac589dba5282 (3 revisions) ( #170519 )
...
https://dart.googlesource.com/sdk.git/+log/9f741ef8a689..ac589dba5282
2025-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-224.0.dev
2025-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-223.0.dev
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-222.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-12 21:22:17 +00:00
engine-flutter-autoroll
f79452e3f4
Roll Skia from 38b9f9b0e496 to b41e7017658e (12 revisions) ( #170514 )
...
https://skia.googlesource.com/skia.git/+log/38b9f9b0e496..b41e7017658e
2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from c6b3440bf382 to d8c154990b5b (8 revisions)
2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 80f512e1a5d1 to a5570b3b45a2 (14 revisions)
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 155f095a8c63 to 7b7b93aa0b85 (3 revisions)
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 9d27097cc7dd to 517d8b7d9a1d (15 revisions)
2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c786a2e47b03 to ee3e78abdb24 (5 revisions)
2025-06-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-11 thomsmit@google.com GrTriangulator: Fix stability and
correctness with degenerate paths
2025-06-11 robertphillips@google.com Fix ChromePrecompileTest on non-M1
jobs
2025-06-11 robertphillips@google.com [graphite] Add some missing Android
Precompilation combinations
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-12 11:35:26 +00:00
Renzo Olivares
cf12796001
Fix Semantics.identifier on TextField not working on web ( #170395 )
...
Fixes #155323
Before this change the `identifier` would not be updated even if marked
dirty for a `SemanticRole` that had no `SemanticBehavior`s. After this
change an `identifier` marked dirty is now updated even if the
`SemanticRole` has no `SemanticBehavior`s.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Renzo Olivares <roliv@google.com>
2025-06-12 07:13:20 +00:00
Hannah Jin
a534b21380
Revert "[a11y] Semantics flag refactor step 2: embedder part" ( #170498 )
...
Reverts flutter/flutter#167738
Reason: I want to make more changes on embedder so some semantics flags
will be tristate. To avoid introducing breaking changes, revert the
former PR
2025-06-12 03:37:56 +00:00
engine-flutter-autoroll
85cef5f226
Roll Dart SDK from b569246d64bc to 9f741ef8a689 (1 revision) ( #170473 )
...
https://dart.googlesource.com/sdk.git/+log/b569246d64bc..9f741ef8a689
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-221.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-11 23:07:50 +00:00
Jonah Williams
2773965a3c
[impellerc] add GLES shader define. ( #170375 )
...
Fixes https://github.com/flutter/flutter/issues/169429
For ImageShader.filter we need a way to distinguish between the
coordinate system of GL vs Metal/Vulkan. I documented in
https://github.com/flutter/flutter/pull/169761 how to do it but
neglected to wire up the define. This fixes that.
2025-06-11 23:06:05 +00:00
engine-flutter-autoroll
e57ebb3408
Roll Skia from b78fdc3ba26b to 38b9f9b0e496 (7 revisions) ( #170453 )
...
https://skia.googlesource.com/skia.git/+log/b78fdc3ba26b..38b9f9b0e496
2025-06-11 syoussefi@google.com [graphite][vulkan] Mark Imagination
hardware as coherent
2025-06-11 robertphillips@google.com Disable SimplifyPaintTest on
*Protected jobs
2025-06-11 michaelludwig@google.com Remove S7 Vulkan jobs
2025-06-11 mike@reedtribe.org Simplify asADash() to return its span
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e16ef854c44f to c786a2e47b03 (1 revision)
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a787766551aa to c6b3440bf382 (11 revisions)
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 29821d9a17ae to 80f512e1a5d1 (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-11 18:53:23 +00:00
Harry Terkelsen
f59e8e5885
[canvaskit] Manually trigger input event in text editing tests for Safari ( #170022 )
...
Manually trigger an `input` event to trigger the `handleChange` handler
in the text input element. In Safari for MacOS 15.5, this workaround is
now required.
Fixes https://github.com/flutter/flutter/issues/169282
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Mouad Debbar <mdebbar@google.com>
2025-06-11 17:48:41 +00:00
Jim Graham
68f39bac27
[Impeller] Avoid creating paths when rendering arcs ( #170398 )
...
We now avoid a temporary path object and feed arc paths directly to the
renderer in all `DrawArc` cases.
2025-06-11 16:02:18 +00:00
Florin Malita
d95aa4d6e2
Add SK_SUPPORT_UNSPANNED_APIS staging flag ( #170139 )
...
Skia is updating its public APIs to use spans instead of rawptr + count.
This is a temporary flag to enable the old style entry points while
clients are being updated.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-11 15:59:19 +00:00
engine-flutter-autoroll
0cb0c5590d
Roll Dart SDK from 6290dfd1d88a to b569246d64bc (4 revisions) ( #170430 )
...
https://dart.googlesource.com/sdk.git/+log/6290dfd1d88a..b569246d64bc
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-220.0.dev
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-219.0.dev
2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-218.0.dev
2025-06-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-217.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-11 15:59:19 +00:00
engine-flutter-autoroll
46a225fd68
Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) ( #170412 )
...
Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions)
https://skia.googlesource.com/skia.git/+log/910070084066..b78fdc3ba26b
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 3d47c8a32f07 to 9d27097cc7dd (14 revisions)
2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from a857503547cb to 155f095a8c63 (2 revisions)
2025-06-11
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d9842c624bd1 to e16ef854c44f (6 revisions)
2025-06-10 danieldilan@google.com Reland "[png] Simplify extra endian
transform for SkPngEncode"
2025-06-10 lukasza@chromium.org [rust png] Reset
`fIncrementalDecodingState` after nonrecoverable errors
2025-06-10 jreck@google.com Add host_supported to libskia_skcms
2025-06-10 syoussefi@google.com [graphite][vulkan] Disable MSAA on Intel
2025-06-10 robertphillips@google.com [graphite] Fold ColorFilters and
constant Shaders into a Solid Color
2025-06-10 mike@reedtribe.org Use SkSpan in SkTextBlob API
2025-06-10 mike@reedtribe.org Use SkSpan for dashing
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from fe4617b72605 to d9842c624bd1 (5 revisions)
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 3a15fab06cff to a787766551aa (7 revisions)
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 3c7e00b52946 to 29821d9a17ae (13 revisions)
2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from f3220117fc62 to 3d47c8a32f07 (12 revisions)
2025-06-09 ccameron@chromium.org HDR v2: Add no-op OOTF parameters to
sk_color_space_transform
2025-06-09 syoussefi@google.com [vulkan] Require Vulkan 1.1 in Ganesh
2025-06-09 mike@reedtribe.org Use size_t for font/typeface return values
(to match span's)
2025-06-09 syoussefi@google.com [graphite][vulkan] Use
VK_EXT_graphics_pipeline_library
2025-06-09 thomsmit@google.com Reland "[graphite] Fix clamping bug on
Intel UHD 630."
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d5d3942f4b8f to fe4617b72605 (1 revision)
2025-06-09 jreck@google.com Add dng sdk 1.4 -> 1.7.1 migration compat
2025-06-09 mike@reedtribe.org Use SkSpan in read and write buffers
2025-06-09 mike@reedtribe.org Use new span APIS (time to dogfood)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual Roll
vulkan-deps from 1c3b39ad6dc0 to d5d3942f4b8f (14 revisions)
2025-06-09 bungeman@google.com Remove many deprecated declarations
2025-06-09 syoussefi@google.com [vulkan] Apply RelaxedPrecision to
OpImageSampleImplicitLod
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from db9624073324 to 3a15fab06cff (4 revisions)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 11dc1b167af4 to a857503547cb (1 revision)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 3bbfa4528971 to 3c7e00b52946 (5 revisions)
2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 63ca6919b752 to f3220117fc62 (31 revisions)
2025-06-08 ccameron@chromium.org SkColorSpaceXformSteps: Start to add
support for HLG and PQ
2025-06-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com ,kjlubick@google.com,michaelludwig@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
...
2025-06-11 15:57:05 +00:00
Kaylee Lubick
b4219783bb
Use pathops module groups ( #169857 )
...
Skia is moving its [pathops code around](http://review.skia.org/999760 ).
In http://review.skia.org/1001216 we added a new set of filegroups to
facilitate this. This updates the BUILD.gn rules to use those new
groups.
## Pre-launch Checklist
- [ x ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ x ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ x ] I read and followed the [Flutter Style Guide], including
[Features we expect every widget to implement].
- [ x ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ x ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ x ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ x ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-11 14:36:04 +00:00
Harry Terkelsen
db8a64f90d
Verify old version of Python has the lib2to3 import available ( #170187 )
...
The `yapf.sh` script checks for specific "known-to-work-with-YAPF"
versions of Python to run YAPF with. On my machine, I have `python3.11`
and `python3.12` (`python3` is a symlink to `python3.12`). However, the
`python3.11` release doesn't have `lib2to3` so the YAPF script fails
with:
```
Checking Python formatting...
To fix, run `et format` or:
git apply <<DONE
/usr/local/google/home/het/Projects/flutter/engine/src/flutter/tools/gn
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/usr/local/google/home/het/Projects/flutter/engine/src/flutter/third_party/yapf/yapf/__main__.py", line 16, in <module>
import yapf
File "/usr/local/google/home/het/Projects/flutter/engine/src/flutter/third_party/yapf/yapf/__init__.py", line 35, in <module>
from yapf.yapflib import errors
File "/usr/local/google/home/het/Projects/flutter/engine/src/flutter/third_party/yapf/yapf/yapflib/errors.py", line 16, in <module>
from lib2to3.pgen2 import tokenize
ModuleNotFoundError: No module named 'lib2to3'
DONE
```
On my Ubuntu machine I cannot install `lib2to3` through normal APT
packages; `apt install python3.11-lib2to3` fails since that package has
been obsoleted. I've been able to work around this by manually editing
the `yapf.sh` script to check if `lib2to3` can be imported before using
that version of Python.
See https://github.com/flutter/flutter/issues/158384
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-10 22:51:57 +00:00
Jonah Williams
d1f63480c4
[engine] Reland: ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. ( #170389 )
...
Reland of https://github.com/flutter/flutter/pull/170313
We were missing a call to android_surface->SetupImpellerSurface(); which
happened to just work before.
2025-06-10 22:07:09 +00:00
Jia Hao
32b513bbb2
Revert "Add call to Dart_NotifyDestroyed when the flutter view is des… ( #170309 )
...
…troyed. (flutter/engine#37539 )"
This reverts commit 7296b2b66dac82f04ebe9017320bde81a7b5f486.
In b/422322882, we have done a small experiment on addtoapp Android,
with and without a patched engine where `Dart_NotifyDestroyed` is not
called:
1. Add a Flutter view
2. Measure memory with `adb shell dumpsys meminfo`
3. Call detach
5. Measure memory again
"Call detach" refers to the following pseudocode:
```kt
flutterViewContainer.removeView(flutterView)
engine.activityControlSurface.detachFromActivity()
engine.lifecycleChannel.appIsDetached()
flutterView!!.detachFromFlutterEngine()
```
We observed that the memory recordings with and without the patched
engine are mostly the same. @a-siva also mentioned that
7296b2b66dac82f04ebe9017320bde81a7b5f486 could be no longer needed
today.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-10 21:34:29 +00:00
auto-submit[bot]
03e445e71c
Reverts "[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. ( #170313 )" ( #170377 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#170313
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: broke tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {mboetger}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
The fact that this landed and failed no tests originally likely
indicates we have no tests using Engine.spawn APIs. Seems bad.
Fixes https://github.com/flutter/flutter/issues/170295
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-06-10 18:53:20 +00:00
Hannah Jin
cb01defdcf
[a11y] Semantics flag refactor step 2: embedder part ( #167738 )
...
issue: https://github.com/flutter/flutter/issues/166101 , overall goal is
to update semantics flag to be a struct/class to support more than 32
flags.
step 1: https://github.com/flutter/flutter/pull/167421 updated
semantics_node.h and dart:ui
step 2(this PR): Update Embedder part to use a struct instead of a int
bit mask.
step 3: https://github.com/flutter/flutter/pull/167771 Update Framework
use the SemanticsFlags class instead of bitmask
step 4 https://github.com/flutter/flutter/pull/168852 Update web engine
to use the new class and update SemanticsUpdateBuilder.updateNode to
pass the new class instead of bitmask
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Chris Bracken <chris@bracken.jp>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-06-10 18:11:07 +00:00
engine-flutter-autoroll
83c86873fe
Roll Dart SDK from c26e7ca44805 to 6290dfd1d88a (5 revisions) ( #170363 )
...
https://dart.googlesource.com/sdk.git/+log/c26e7ca44805..6290dfd1d88a
2025-06-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-216.0.dev
2025-06-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-215.0.dev
2025-06-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-214.0.dev
2025-06-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-213.0.dev
2025-06-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-212.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-10 18:07:08 +00:00
Jonah Williams
389f10e678
[engine] ensure engines spawned from an engine using dynamic rendering selection still use the dynamic surface. ( #170313 )
...
The fact that this landed and failed no tests originally likely
indicates we have no tests using Engine.spawn APIs. Seems bad.
Fixes https://github.com/flutter/flutter/issues/170295
2025-06-10 17:23:06 +00:00
Jonah Williams
2d30ce56fe
[engine] dont double free surface texture interop objects. ( #170284 )
...
Fixes https://github.com/flutter/flutter/issues/152459
I suspect the double free is related to
https://github.com/flutter/flutter/issues/162147 .
With the Impeller backend, the second free is performed by the reactor
and comes only after the application has returned to the foreground.
This increaases the likelyhood that we nuke a handle that is in active
use by another part of the system.
Since SurfaceTexture:: detachFromGLContext is documented as releasing
the texture, we don't need to free it at all and can "leak" it on our
side.
2025-06-10 16:25:12 +00:00
Michael Ludwig
ee0eb22cdb
Update test_vulkan_context.cc to use Vulkan 1.1 ( #170351 )
...
Skia is moving to require 1.1 as its minimum supported version instead
of 1.0.
This is part of an effort to clean up and consolidate Vulkan
initialization logic, which gets much easier with some of the extensions
that were promoted to 1.1. This is for skbug.com/422204178 and required
to roll https://skia-review.googlesource.com/c/skia/+/1002391 into
Flutter.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-10 16:25:12 +00:00
gaaclarke
386f767f36
licenses_cpp: initial commit ( #169105 )
...
Initial commit for the c++ license checker.
This lays the foundation for all the technical challenges. The logic
isn't 100% what we want yet. This is a facsimile of the operations we
want to perform and currently it operates in 30s as opposed to 30m with
the old license chcker.
Included in this PR:
1) Sets up BUILD.gn
1) Makes RE2 available to the repo.
1) Sets up the test infrastructure (integration and unit tests).
1) Sets up the executable.
1) Sets up VSCode integration
1) Sets up the CI (macos builds for now)
1) Sets up logic
1) Sets up the crawling through the tree.
1) Sets up flex lexer for comments.
1) Runs git subprocesses.
1) Parses command line arguments.
1) Sets up data practices
1) Allow/deny lists added.
1) In memory representation of license catalog added.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-10 14:07:23 +00:00
gaaclarke
85867b0911
Export FlutterSceneDelegate ( #170169 )
...
This allows people to subclass FlutterSceneDelegate. This is necessary
for many workflows like capturing launchoptions.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-10 00:59:54 +00:00
gaaclarke
af6cd4e7ac
Removed the FlutterViewController.pluginRegistrant ( #169995 )
...
issue: https://github.com/flutter/flutter/issues/167267
We opted for FlutterAppDelegate.pluginRegistrant since the IBOutlets
couldn't be loaded the way we link Flutter (via a bespoke script instead
of using xcode).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-09 20:44:13 +00:00
Jim Graham
b9e7ba3fe4
[Impeller] Avoid allocating path for dashed lines ( #169881 )
...
We use the new algorithmically generated `PathSource` mechanism for
generating dashed lines to avoid allocating a growable path object.
2025-06-09 20:12:00 +00:00
Jim Graham
88a889a089
[Impeller] Fix vertex allocation counts for flat curves ( #170194 )
...
The code that estimated the vertex counts for filling paths was not
taking into account that the minimum number of points allocated for a
curve segment is 1. The iteration estimates will return "don't bother to
subdivide the curve" cases as "0 subdivisions" and we estimated no
vertices would be generated. In fact, the rendering code would always
emit the final point regardless of the subdivision estimate. Other cases
that returned a value >0 were already accurate.
2025-06-09 17:25:27 +00:00
engine-flutter-autoroll
e9e989bef3
Roll Dart SDK from f8e88f6ce02a to c26e7ca44805 (1 revision) ( #170198 )
...
https://dart.googlesource.com/sdk.git/+log/f8e88f6ce02a..c26e7ca44805
2025-06-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-211.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-07 11:45:31 +00:00
engine-flutter-autoroll
2eec076321
Roll Dart SDK from 239174405ad0 to f8e88f6ce02a (14 revisions) ( #170182 )
...
https://dart.googlesource.com/sdk.git/+log/239174405ad0..f8e88f6ce02a
2025-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-210.0.dev
2025-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-209.0.dev
2025-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-208.0.dev
2025-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-207.0.dev
2025-06-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-206.0.dev
2025-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-205.0.dev
2025-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-204.0.dev
2025-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-203.0.dev
2025-06-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-202.0.dev
2025-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-201.0.dev
2025-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-200.0.dev
2025-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-199.0.dev
2025-06-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-198.0.dev
2025-06-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-197.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-06 23:40:24 +00:00
Koji Wakamiya
f4bd508c28
Dispose ImmutableBuffer at web_ui.instantiateImageCodecFromBuffer and web_ui.instantiateImageCodecWithSize ( #161488 )
...
fix https://github.com/flutter/flutter/issues/150016
Fixed `instantiateImageCodecFromBuffer` and
`instantiateImageCodecWithSize` and added tests.
doc
> The buffer will be disposed by this method once the codec has been
created, so the caller must relinquish ownership of the buffer when they
call this method.
*
https://api.flutter.dev/flutter/dart-ui/instantiateImageCodecFromBuffer.html
*
https://api.flutter.dev/flutter/dart-ui/instantiateImageCodecWithSize.html
ui
bd1ebf2e14/engine/src/flutter/lib/ui/painting.dart (L2484-L2504)bd1ebf2e14/engine/src/flutter/lib/ui/painting.dart (L2541-L2558)bd1ebf2e14/engine/src/flutter/lib/web_ui/lib/painting.dart (L640-L679)https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Mouad Debbar <mdebbar@google.com>
2025-06-06 23:36:16 +00:00
