DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,793 Commits 882 Branches 1,069 Tags
Commit Graph

23454 Commits

Author SHA1 Message Date
Greg Spencer
fc5b70b5d4 Add Doxygen doc generation for iOS, macOS, Linux, Windows, and Impeller (flutter/engine#43915) 
## Description

This starts generating Doxygen docs for iOS, macOS, Linux, Windows, and Impeller. It doesn't remove the existing generation for iOS for now, until we can migrate the API docs to include these instead of those.

## Related Issues
 - https://github.com/flutter/flutter/issues/130999
 - Fixes https://github.com/flutter/flutter/issues/124833
 2023-08-17 20:49:05 +00:00
Jason Simmons
1c573b5165 Fix FlutterInjectorTest assumptions about how the executor service assigns tasks to threads (flutter/engine#44775) 2023-08-17 20:37:59 +00:00
John McCutchan
5c518f77f3 Reenable HardwareBuffer backed Android Platform Views on SDK >= 29 (flutter/engine#44790) 
- Fix a bug in the SDK < 33 ImageReader construction code path.
- Fix a bug that resulted in references to Images produced by a closed
ImageReader.
- Fix an order of operations bug in ImageReaderPlatformViewRenderTarget
release/finalizer code path.
- Enable HardwareBuffer backed Android Platform Views on SDK >= 29

Manually tested on device rotating and shutting down the app.
 2023-08-17 13:15:25 -07:00
Tong Mu
177a6128c1 Basic view management for engine classes (flutter/engine#42991) 
_This PR is part of the multiview engine project. For a complete roadmap, see [this doc](https://docs.google.com/document/d/10APhzRDR7XqjWdbYWpFfKur7DPiz_HvSKNcLvcyA9vg/edit?resourcekey=0-DfGcg4-XWRMMZF__C1nmcA)._

------

This PR adds view management to all engine classes that need it. View management here basically means `AddView` and `RemoveView` methods, and most importantly, how to handle the implicit view.

The implicit view is a special view that's handled differently than all the other "regular views", since it keeps the behavior of the current single view of Flutter. Detailed introduction can be found in `Settings.implicit_view_enabled`.

The following two graphs show the difference between initializing with/without the implicit view and creating regular views.

<img width="879" alt="image" src="https://github.com/flutter/engine/assets/1596656/31244685-d9d3-4c9a-9a9e-6e8540a5711e">

<img width="864" alt="image" src="https://github.com/flutter/engine/assets/1596656/e2dd4b8c-57e3-428d-8547-834fb270052b">

<img width="860" alt="image" src="https://github.com/flutter/engine/assets/1596656/58dae687-8c17-434e-ae24-a48c2d8fa5fa">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-17 20:06:25 +00:00
skia-flutter-autoroll
a257852606 Roll Skia from d0d390f9310d to bfd45173e5e3 (5 revisions) (flutter/engine#44820) 
https://skia.googlesource.com/skia.git/+log/d0d390f9310d..bfd45173e5e3

2023-08-17 kjlubick@google.com Fix old use of GrBackendRenderTarget for GL
2023-08-17 kjlubick@google.com [bazel] Fix extension handling in gcs_mirror
2023-08-17 johnstiles@google.com Fix WGSL code generation of matrix-div-scalar.
2023-08-17 kjlubick@google.com Remove bridge code for legacy GL GrBackendSurface code
2023-08-17 brianosman@google.com Remove SkOpts_avx and _ssse3 completely

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 20:06:23 +00:00
Matan Lurey
1aa93ad798 Implement 2 suggested Clang Tidy fixes we don't look for yet. (flutter/engine#44816) 
I haven't investigated if there are more occurrences or if it's worth
enforcing turning the check on generally.

(They were flagged on the Google roll, ironically)

---


[`readability-redundant-smartptr-get`](https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-smartptr-get.html)

> Find and remove redundant calls to smart pointer’s `.get()` method


[`performance-for-range-copy`](https://clang.llvm.org/extra/clang-tidy/checks/performance/for-range-copy.html)

> Finds C++11 for ranges where the loop variable is copied in each
iteration but it would suffice to obtain it by reference.
 2023-08-17 12:34:15 -07:00
LouiseHsu
089957e3e0 Add share to selection controls (flutter/engine#44554) 
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc. 

https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765

This PR is the engine portion of the changes that will allow Share to be implemented
This PR addresses https://github.com/flutter/flutter/issues/107578
More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)
 2023-08-17 17:34:11 +00:00
Zachary Anderson
38d3dcbc72 Adds new builders for partial clang-tidy checks. (flutter/engine#44811) 
This is the first in a sequence of PRs which will lint only changed files on presubmit. The process is the following:
1. Add new `bringup: true` builders that lint only changed files. `bringup: true` builders don't run in presubmit, and since after landing this no files will be detected as changed, these builders will not do anything yet.
1. Remove `bringup: true`. This will allow the new builders to run in presubmit.
1. Ask the team to monitor the new checks on PRs to make sure they are doing the right thing.
1. When we're reasonably sure that the checks are doing the right thing, add `presubmit: false` to `mac_clang_tidy` and `linux_clang_tidy` so that we no longer needlessly lint all files in presubmit.

Related https://github.com/flutter/flutter/issues/105068
 2023-08-17 17:25:26 +00:00
hellohuanlin
380e7d7402 [ios][ios17]fix auto correction highlight on top left corner (flutter/engine#44779) 
Fix native auto-correction highlight region on top left corner. 

This PR uses the system auto-correction highlight on iOS 17, which was disabled by https://github.com/flutter/engine/pull/44354

<img width="479" alt="Screenshot 2023-08-16 at 1 19 39 PM" src="https://github.com/flutter/engine/assets/41930132/a5a1dda7-ba21-462e-a65c-1afeecf7559f">

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/131622
Fixes https://github.com/flutter/flutter/issues/131695
Fixes https://github.com/flutter/flutter/issues/130818

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-17 16:48:06 +00:00
yaakovschectman
deaf5f2b5b [Windows] Delay enabling app lifecycle states until requested (flutter/engine#44238) 
Await a platform message before sending lifecycle state updates so we
are not sending messages that do not get consumed by the framework.
In the _near_ future we hope to extend the embedder API to allow
registering callbacks called upon the framework registering a listener
to a channel, which would obviate this problem.

https://github.com/flutter/flutter/issues/131616

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-17 12:30:28 -04:00
Tong Mu
bd3da2c47e Move viewConfiguration parsing from PlatformDispatcher to _hooks (flutter/engine#44787) 
This PR moves the code that parses `viewConfiguration` from
`PlatformDispatcher` to `_hooks`. This makes `PlatformDispatcher`'s API
cleaner by hiding the encoding implementation of `ViewConfiguration` in
`_hooks`, and allows more APIs to pass view configuration, such as the
`addView` that will be introduced in
https://github.com/flutter/engine/pull/42991.

This PR should not need unit tests since it's just a refactor, and the
code path that contains `_updateWindowMetrics` has been tested in
existing unit tests.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-17 09:29:12 -07:00
skia-flutter-autoroll
a2bf6ed1f2 Roll Dart SDK from 92c32df13d31 to 7e4e5796ee99 (2 revisions) (flutter/engine#44810) 
https://dart.googlesource.com/sdk.git/+log/92c32df13d31..7e4e5796ee99

2023-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-81.0.dev
2023-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 14:54:11 +00:00
skia-flutter-autoroll
12e6652cce Roll Skia from 11cb8cdd37c1 to efb5a5e0b78b (1 revision) (flutter/engine#44792) 
https://skia.googlesource.com/skia.git/+log/11cb8cdd37c1..efb5a5e0b78b

2023-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 716ec65fb647 to f1d21dc58818 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 05:42:30 +00:00
Matan Lurey
809b6b8fa0 Passthrough stderr results of clang_tidy when --enable-check-profile. (flutter/engine#44789) 
Required to actually see the results of the profile :)
 2023-08-17 00:58:02 +00:00
skia-flutter-autoroll
147fcb7dbe Roll Dart SDK from d6e1fca5dbdf to 92c32df13d31 (1 revision) (flutter/engine#44788) 
https://dart.googlesource.com/sdk.git/+log/d6e1fca5dbdf..92c32df13d31

2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-17 00:27:00 +00:00
skia-flutter-autoroll
df58539fed Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786) 
https://skia.googlesource.com/skia.git/+log/233c4f26427a..11cb8cdd37c1

2023-08-16 armansito@google.com [graphite][compute] Store buffer view size alongside BindBufferInfo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 23:13:04 +00:00
Jason Simmons
156b05274e Revert "Conditionally enable HardwareBuffer backed platform views (#44744)" (flutter/engine#44785) 
This reverts commit 4620733d5c4b100fae10861eaae6d6e97003c282.

The https://github.com/flutter/flutter/tree/master/dev/integration_tests/abstract_method_smoke_test test was not rendering the platform view with that change.
 2023-08-16 23:09:08 +00:00
Dan Field
3020e19c19 [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782) 
This got missed when setting this to always be `YES`.
 2023-08-16 22:01:30 +00:00
John McCutchan
1278a933a7 Switch some ERROR logs to WARNING logs (flutter/engine#44784) 2023-08-16 15:00:25 -07:00
skia-flutter-autoroll
ce8e23534d Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780) 
https://skia.googlesource.com/skia.git/+log/02870a1df818..233c4f26427a

2023-08-16 johnstiles@google.com Add WGSL support for matrix-divided-by-matrix.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 21:28:33 +00:00
skia-flutter-autoroll
c23c289013 Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770) 
https://dart.googlesource.com/sdk.git/+log/cc5eeac65f89..d6e1fca5dbdf

2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 20:41:59 +00:00
skia-flutter-autoroll
6b28b250fc Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778) 
https://skia.googlesource.com/skia.git/+log/e65aabc26c86..02870a1df818

2023-08-16 jvanverth@google.com [OpenGL] Disable CopyTexSubImage2D when using sRGB on ES2
2023-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 53e39be12b9e to 53905a380315 (4 revisions)
2023-08-16 jamesgk@google.com [graphite] Allow multiple views on a Dawn texture
2023-08-16 cmumford@google.com [shaders] Create shaders Docker image build target
2023-08-16 jmbetancourt@google.com [jetski] ask for a crop rect when using ImageFilter.blur
2023-08-16 herb@google.com Define Point for Bentley-Ottmann
2023-08-16 brianosman@google.com Remove unused isValid parameter from GrVkBackendSurfaceInfo::assign

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 20:40:22 +00:00
Matan Lurey
c9246dfaf1 Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773) 
Example usage:

```shell
$ dart tools/clang_tidy/bin/main.dart --lint-all --enable-check-profile
```

I plan to use this to help triage why clang_tidy takes so long, and if
particular rules are contributing to most of the cost.
 2023-08-16 13:06:01 -07:00
LouiseHsu
8f2b35bbfc Fix search web test (flutter/engine#44704) 
Fixed an issue with the test `testSearchWebInvoked` not mocking out openURL and crashing subsequent tests
 2023-08-16 19:48:47 +00:00
godofredoc
952079dab6 Remove duplicated v1 builds. (flutter/engine#44767) 
This is part of the cleanup of the migration to engine v2 builds.

Bug: https://github.com/flutter/flutter/issues/132600

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-16 18:24:07 +00:00
skia-flutter-autoroll
0b7dc6356c Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768) 
https://skia.googlesource.com/skia.git/+log/d029f149a806..e65aabc26c86

2023-08-16 johnstiles@google.com Fix WGSL code generation for SwitchWithFallthroughAndVarDecls test.
2023-08-16 jamesgk@google.com [dm] Use a specific pixel geometry for GraphiteSink
2023-08-16 johnstiles@google.com Allow SkSL Graphite benchmarks to run on Perfbots.
2023-08-16 michaelludwig@google.com [skif] Remove legacy MatrixConvolution code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 18:22:02 +00:00
Zachary Anderson
ea835aa116 Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763) 
Fixes https://github.com/flutter/flutter/issues/132657
 2023-08-16 11:16:00 -07:00
John McCutchan
4620733d5c Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744) 
On Android >= 29 we can use a more efficient platform view render target
 2023-08-16 10:30:32 -07:00
Zachary Anderson
4676ed194b Adds runIf to linux_clang_tidy (flutter/engine#44759) 
Related https://github.com/flutter/flutter/issues/132605
 2023-08-16 16:32:09 +00:00
skia-flutter-autoroll
a06c27de61 Roll Dart SDK from e6bf503b36fe to 80b9a90ae563 (2 revisions) (flutter/engine#44753) 
https://dart.googlesource.com/sdk.git/+log/e6bf503b36fe..80b9a90ae563

2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-76.0.dev
2023-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-75.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 06:07:55 +00:00
skia-flutter-autoroll
72f1897469 Roll Fuchsia Linux SDK from orVLXMF7ak2qfFkGs... to GpKKtPGPMiRcY0kcz... (flutter/engine#44751) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 05:33:10 +00:00
skia-flutter-autoroll
15e23723ad Roll Skia from 8f0238837ee4 to 586a6309e3a1 (2 revisions) (flutter/engine#44752) 
https://skia.googlesource.com/skia.git/+log/8f0238837ee4..586a6309e3a1

2023-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 446e642885e7 to 716ec65fb647 (3 revisions)
2023-08-16 armansito@google.com [graphite][compute] Remove draw-specific parameters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 05:33:07 +00:00
skia-flutter-autoroll
3581b5bd43 Roll Skia from 3d2b84e28e79 to 8f0238837ee4 (1 revision) (flutter/engine#44748) 
https://skia.googlesource.com/skia.git/+log/3d2b84e28e79..8f0238837ee4

2023-08-16 lovisolo@google.com //gm/gm.h: Fold GM::onISize() into GM::getISize().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 03:03:18 +00:00
godofredoc
23467ff8ba Move cache builders to prod. (flutter/engine#44739) 
These builders have been running as bringup for a very long time with no failures.

Bug: https://github.com/flutter/flutter/issues/132597

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-16 02:34:06 +00:00
Rulong Chen（陈汝龙）
75ac0d3957 Enabling the host application to control the timing of attaching the |FlutterView| to the engine (flutter/engine#43595) 
In the add-to-app scenario where multiple FlutterViews share the same FlutterEngine, the host application desires to determine the timing of attaching the FlutterView to the engine, for example, during the `onResume` instead of the `onCreateView`.

As an example, consider the following scenario: A native page contains multiple tabs, and each tab is a FlutterFragment. During initialization, FlutterFragments of different tabs are created almost simultaneously, but only the one that needs to be displayed currently requires attachment to the engine, while the others need to be attached only when they receive the |onResume| callback.

Partial fix: https://github.com/flutter/flutter/issues/130235

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-16 02:34:04 +00:00
skia-flutter-autoroll
3df865c3fe Roll Skia from 9fc1c628456a to 3d2b84e28e79 (1 revision) (flutter/engine#44746) 
https://skia.googlesource.com/skia.git/+log/9fc1c628456a..3d2b84e28e79

2023-08-15 johnstiles@google.com Perform error-checking when creating a Dawn shader module.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 02:18:15 +00:00
skia-flutter-autoroll
f655d5da85 Roll Dart SDK from b36934aae968 to e6bf503b36fe (1 revision) (flutter/engine#44745) 
https://dart.googlesource.com/sdk.git/+log/b36934aae968..e6bf503b36fe

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-74.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-16 01:09:03 +00:00
Matan Lurey
8567814d32 [Skia] Only respect ui.Paint.dither when the colorSource is a gradient (flutter/engine#44730) 
In the Impeller backend, we **only** support dithering of _gradients_. In addition, it will be the default (and only option).

In the [process of enabling dithering by default](https://github.com/flutter/engine/pull/44705), i.e.
```diff
class Paint {
-  static bool enableDithering = false;
+  static bool enableDithering = true;
}
```

... we realized with internal Google testing this will now apply dithering on more than just gradients, i.e. images in the Skia backend. Since we won't support dithering of images in the Impeller backend, this PR gives a "hint" on whether the `colorSource` (if one is set) can be dithered by the contrived rules we've created.
 2023-08-16 01:07:39 +00:00
Jonah Williams
01c2363b16 [Impeller] Cache render target texture allocations across frames. (flutter/engine#44527) 
When allocating a non-host visible texture for a render target, the allocator will hold onto a reference to this texture descriptor. On the immediate next frame, this texture is made available to replace requested allocations for new render target textures. if this texture is not used, then at the end of the next frame it is discarded.

This removes the vast majority of allocations in most flutter gallery and wonderous. This does not attempt to use different sized textures for the cache.

There are two caveats noted in the PR contents.

Fixes https://github.com/flutter/flutter/issues/131515
 2023-08-16 00:25:08 +00:00
Amir Panahandeh
e9f54512c8 Add more tests for CompositionAwareMixin (flutter/engine#44717) 
Adds missing tests for `CompositionAwareMixin`. Check https://github.com/flutter/engine/pull/44139#discussion_r1288733128 and https://github.com/flutter/engine/pull/44139#discussion_r1288009016

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-16 00:08:42 +00:00
John McCutchan
7bf371d161 Fix clang_tidy lints (flutter/engine#44740) 2023-08-15 16:40:32 -07:00
skia-flutter-autoroll
fdd3eaf715 Roll Skia from b07a6964a1cf to 9fc1c628456a (5 revisions) (flutter/engine#44737) 
https://skia.googlesource.com/skia.git/+log/b07a6964a1cf..9fc1c628456a

2023-08-15 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Simplify how Gold keys are generated.
2023-08-15 brianosman@google.com Remove deprecated Metal GrBackendRenderTarget constructor
2023-08-15 johnstiles@google.com Move SDFTextRenderStep logic into modules.
2023-08-15 johnstiles@google.com Move BitmapTextRenderStep logic into modules.
2023-08-15 lovisolo@google.com //gm/gm.h: Fold GM::onShortName() into GM::getName() and make it const.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 21:44:22 +00:00
godofredoc
6ae25ffa72 Add SLSA L1 badge (flutter/engine#44731) 
Adds the SLSA L1 compliance badge for the engine.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-15 21:33:03 +00:00
John McCutchan
50190fcaa6 Add support for SurfaceTexture based external textures on Android under Impeller/GLES. (flutter/engine#44734) 
- Refactor AndroidExternalTextureGL into SurfaceTextureExternalTexture
base class with two specialized implementations:
- Add SurfaceTextureExternalTextureGL for legacy GL rendering.
- Add SurfaceTextureExternalTextureImpellerGL for Impeller GLES
rendering.

NOTE: There is still no support for SurfaceTextures under Vulkan
rendering.
 2023-08-15 14:25:03 -07:00
Jonah Williams
4367ca66ae [Impeller] Make porter duff blended atlas calls faster. (flutter/engine#44059) 
This implements part of https://github.com/flutter/flutter/issues/131345

---

Makes all porter-duff draw atlas blending avoid subpass creation, by tweaking the existing porter duff shader to support per-vertex colors and output opacity. This requires a small trick: What the blend shaders and what (drawAtlas/drawVertices) consider the source and destination is reversed. That is a blend mode color filter treats the color as the source whereas drawVertices/drawAtlas treat their per-vertex colors as the destination. Therefore I cannot simply make all color inputs per vertex and use the exact same shaders :(

However, for the porter duff blends we should just be able to reverse the blend mode (srcover -> dstOver, xor->xor) (I'm pretty sure I did this correctly) so that the blending is still correct. I don't think we can do this for the advanced blends, but supporting those is less important than the common atlas blending parameters like dstIn.

This PR only updates drawAtlas.
 2023-08-15 19:40:09 +00:00
skia-flutter-autoroll
015275a126 Roll Skia from 4beb6fd05f4f to c7c9e85a8657 (7 revisions) (flutter/engine#44729) 
https://skia.googlesource.com/skia.git/+log/4beb6fd05f4f..c7c9e85a8657

2023-08-15 jmbetancourt@google.com always make image asset if slotID is present
2023-08-15 johnstiles@google.com Add conditional-testing macros for Graphite unit tests.
2023-08-15 scroggo@google.com Update Android Viewer app instructions
2023-08-15 nicolettep@google.com Consider external format when determining whether YCBCR information is valid
2023-08-15 johnstiles@google.com Add nanobench entries for Graphite Metal/WGSL large shaders.
2023-08-15 bungeman@google.com Reland "[skunicode] Consolidate SkUnicode_IcuBidi"
2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from d672b19e7eab to 3590e8eac703

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 19:06:28 +00:00
skia-flutter-autoroll
3f8ae3d15b Roll Dart SDK from 19c87486f0a9 to b36934aae968 (1 revision) (flutter/engine#44728) 
https://dart.googlesource.com/sdk.git/+log/19c87486f0a9..b36934aae968

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-73.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 18:12:01 +00:00
Matej Knopp
d4607aa5cb Reset editing delta state when replacing editing state (flutter/engine#44595) 
Fixes https://github.com/flutter/flutter/issues/131023

Likely needs a test.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-15 14:26:49 +02:00
Jia Hao
1f58484e28 Namespace imports with flutter (flutter/engine#44709) 
For Google3, this makes it easier since we only need to make one source transform (from `#include "flutter` -> `#include "third_party` instead of requiring a source transform for every root directory in this repo.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-15 06:03:54 +00:00
skia-flutter-autoroll
a82b81e2db Roll Skia from d8d880c560f8 to e137aad081a3 (1 revision) (flutter/engine#44712) 
https://skia.googlesource.com/skia.git/+log/d8d880c560f8..e137aad081a3

2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 11084ddef4cb to 446e642885e7 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 05:41:25 +00:00