1924 Commits

Author SHA1 Message Date
Michael Goderbauer
bb0290a4dc
Revert "Remove all service extensions from release mode (#23038)" (#23290)
This reverts commit 8e2ca93f52d82d22df8b987cef74238ac53b4b28.

Fixes https://github.com/flutter/flutter/issues/23172
2018-10-19 11:48:15 +02:00
Stanislav Baranov
d5777b6a9a
Implement correct orthographic projection (#22985) 2018-10-18 11:27:02 -07:00
Hans Muller
4f4050bf47
Support for disabling interactive TextField caret and selection (#22924)
Make it possible to disable TextField's default handlers for tap and long press. If enableInteractiveSelection is false then taps no longer move the text caret and long-press no longer selects text and shows the cut/copy/paste menu. Accessibility is similarly limited.
2018-10-18 09:14:27 -07:00
Yegor
3fbd140e77
Use new mixin syntax for super-mixins (#22870)
This re-lands 3c56e6c on top of a new Dart SDK that contains new mixin syntax fixes.
2018-10-17 13:10:05 -07:00
Alexandre Ardhuin
8b0de38ef8
fix upcoming lint avoid_returning_null_for_void (#23190) 2018-10-17 11:01:37 +02:00
Dwayne Slater
cab7ecb8e5 Fix out of range spring simulation in ClampingScrollSimulation (#22394)
If the scroll is out of range for any reason (for instance, changing scroll physics or manually messing with scroll position), the spring simulation causes the scroll position to slingshot towards the end. Also, before this change, `end` was unused.
2018-10-17 10:49:27 +02:00
Alexandre Ardhuin
936dea28da
enable lint prefer_void_to_null (#23174)
* enable lint prefer_void_to_null

* replace last Null by void
2018-10-17 08:09:29 +02:00
Hans Muller
7a63fac0a2
TextTheme.apply() should not assume non-null TextStyle fields (#23184) 2018-10-16 19:43:52 -07:00
jslavitz
fd02bdf1b5
Fix disabled formfield validation (#23167)
* Fix form field validate method being called if form field is disabled
2018-10-16 14:03:49 -07:00
Francisco Magdaleno
d556d2117d Finalize editing when hitting the enter key on a single line TextField (#23015)
Behavior remains the same for multiline TextFields. This behavior already happens on iOS and Android, but not desktop. #23014
2018-10-16 14:02:00 -07:00
Max Bittker
25e40ba599 fix Curves.bounceInOut math (#22825)
* fix Curves.bounceInOut

* assert maximum slope
2018-10-16 13:49:18 -07:00
Alexandre Ardhuin
0fb84e96c7
Prefer void to null (#22977)
* Future<void> main

* Future<void>.delayed

* prefer_void_to_Null

* address review comments
2018-10-16 22:03:06 +02:00
jslavitz
c12b99f282
Adds callback for Long Press Up (#22822)
* add onLongPressUp geasture which is fired when a long-press ends
2018-10-16 10:39:06 -07:00
escamoteur
6b79d37797 Add disabledHint to DropdownButton (#18770)
If `items` or `onChanged` is null the button will be disabled, the down arrow will be grayed out, and
the new `disabledHint` will be shown (if provided).
2018-10-16 10:16:28 -07:00
Amir Hardon
707eaf5edf
Make AndroidView take gesture recognizer factories. (#21657)
Before this PR AndroidView's gestureRecognizers field was a list of
gesture recognizers. This was problematic as when the widget was rebuilt
with the same gesture recognizer instances we would try to re-join the
recognizers to a gesture arena team and crash (as a OneSeqeunceGestureRecognizer
team can only be set once).

With this change, we instead take a set of factories.
This allows AndroidView to create the gesture recognizers just before
adding them to the team, and thus be sure that they are only added once to a
team.

The factories are identified by the type of the object they create, this
allows AndroidView to know when it is given an equivalent set of gesture
recognizer factories, and do nothing in that case.
2018-10-15 21:30:40 -07:00
Jacob Richman
c6a222fa28
Revert "Run flutter tests with --track-widget-creation as part of the build. (#22596)" (#23129)
This reverts commit bf92d7f28688c9c94f7b93154cbe69b72dd8bf1b.
2018-10-15 17:13:44 -07:00
Gary Qian
bdc3dda5f2
Add support for text shadows and roll engine (26 commits) (#22449)
* Add support for shadows in text.

* Use dart:ui Shadow as base class for Shadows

* Update lerp definition

* Roll engine 3ffa3629523..84fe4a9f7e24e4 - Text Shadows and update goldens for skia roll.

git log 50c2e69daff4e207c54e463d2304139985c7511c..32f417db0d566d354605305cb29c251276fa65ee --oneline --no-merges
32f417db0 Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541)
4ee77256c Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537)
964acafeb Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536)
d4bae4ca4 Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535)
ff93ccf47 Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534)
a4161c895 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532)
116072e46 Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531)
ef0b0f6e9 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530)
f46b7b971 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529)
9033c3902 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528)
e6887a412 Add missing imports for unicode/utf16.h (#6524)
1242f6dfe Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527)
a1bbea77c Add a no-op platform view layer. (#6505)
2bb3afad8 Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526)
75e875240 Fix the Mac embedder build (#6525)
436f9707b Add version check for dismissable (#6522)
7767c785b Provide a default GL function resolver in the embedder (#6523)
32841dd89 Case-insensitive matching of family names for custom fonts (#6519)
a9076c7e6 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520)
f2e7441b5 An API for loading fonts from a buffer provided by the application (#6508)
05aac0f27 fix ResourceExtractor npe. (#6461)
cf5a2a145 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517)
84fe4a9f7 Re-revert invalid line height tests (#6516)
5f529566c Add support for text shadows (#6385)
e44c10c96 Reland "Share engine layers with the framework" (#6412) (#6468)
ba0449971 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)
2018-10-15 15:03:02 -07:00
Jacob Richman
bf92d7f286
Run flutter tests with --track-widget-creation as part of the build. (#22596) 2018-10-15 13:46:25 -07:00
Hans Muller
4f4005ee65
TextTheme.apply() corrections (#23108)
TextTheme.apply was incorrectly applying displayColor to the TextTheme's headline, title, subhead, body1, and body2 TextStyle colors. In all cases it should have been bodyColor.
2018-10-15 12:18:13 -07:00
Michael Klimushyn
6fef292f44
Wire decodedCacheRatioCap from PaintingBinding to Codec (#22452)
Users can set `PaintingBinding.decodedCacheRatioCap` to control the max
amount of memory used per image to avoid decoding frames each animation
loop.

This depends on flutter/engine#6310.

Fixes #20998, and fixes #14344
2018-10-15 11:22:27 -07:00
Mouad Debbar
43001a3ab6 Correctly throw when MaterialPageRoute's builder returns null (#22885) 2018-10-15 09:49:16 +02:00
Michael Goderbauer
8e2ca93f52
Remove all service extensions from release mode (#23038)
Service extensions can only be activated in debug or profile mode, their code should never be included in release mode. This PR adds guards around all service extension registration calls that enable Dart's tree shaker to remove the extension's code in release mode, which reduces our binary size:

Android Snapshot (uncompressed): minus 127,384 Bytes (-124.40KB)
APK (compressed): minus 38,136 Bytes (-37.24KB)
iOS Snapshot (App.framework, uncompressed): 264,304 Bytes(-258.10KB)

For details: https://docs.google.com/document/d/13JlgvliCn5sWwT2K2SfDwD1NhEfxpJH9DCf22gZZru8/edit

**Benchmark Regressions:** This PR may cause benchmarks to regress because it may change the timing of GC. If you notice a benchmark regression **please note down the exact set of benchmarks that regressed on this PR** and then feel free to revert. I will follow-up with a PR that forces a GC before the effected benchmarks run to get a clean baseline before re-applying this PR.
2018-10-12 21:07:55 -07:00
matthew-carroll
04a26778c5
Revert "Reversion for roll (#22984)" (#23029)
This reverts commit 80f80ab08c0dad8551c91087cd1017aba094d22c.
2018-10-12 16:31:34 -07:00
liyuqian
53de41cac6
Roll engine to 50c2e69da with goldens fix (#23016)
Goldens updated due to Skia AA changes. We previously also made a mistake by having a golden test run on MacOS.

git log 3ffa36295234..50c2e69da --no-merges --oneline
50c2e69da Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2a1 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10ad1 Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)
2018-10-12 13:15:25 -07:00
Artur Rymarz
a3670a2f85 Add parameters to allow hiding icons and border of the Cupertino TabBar (#22804) 2018-10-12 09:08:57 -07:00
matthew-carroll
80f80ab08c
Reversion for roll (#22984)
For G3 Roll:

* Revert "MaterialButton must honor its minWidth and height parameters (#22919)"

This reverts commit a02332335a0849e92daa7fb272e2ee1ccc7d4248.

* Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"

This reverts commit 655bf6a290714248733c7af46c637fce34b56206.

* Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"

This reverts commit a590940e458ae02d89f63062e45a406cb3a73f4e.

* Revert "Bring TextTheme into alignment with the current Material spec (#22330)"

This reverts commit 8bfb4b3ee5e908165135aaa57dc6bce5d561a693.

* Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"

This reverts commit eea3465ae75ac5445c54490c542047032f8f8314.

* Manual adjustments to fix reversion issues.
2018-10-11 18:17:46 -07:00
Alexandre Ardhuin
0e76cb4c10
prefer_void_to_null in flutter_test (#22847)
* prefer_void_to_null in flutter_test

* fix CI
2018-10-11 18:00:46 +02:00
Hans Muller
a02332335a MaterialButton must honor its minWidth and height parameters (#22919) 2018-10-10 20:22:07 -07:00
Hans Muller
a590940e45
ButtonTheme.of().colorScheme defers to Theme (#22880)
ButtonThemeData no longer requires a colorScheme. If colorScheme is null, ButtonTheme.of() will initialize it from the current Theme.
2018-10-10 11:40:30 -07:00
Hans Muller
8bfb4b3ee5
Bring TextTheme into alignment with the current Material spec (#22330) 2018-10-09 17:00:15 -07:00
Jonah Williams
fb7a5937ba
Basic scroll semantics support (#21764) 2018-10-09 14:16:28 -07:00
Jonah Williams
9e51cc3e83
Add assert for null duration on snackbar (#22746) 2018-10-09 13:45:56 -07:00
jslavitz
8d545e9301
Add disabledThumbColor and other properties from Switch to SwitchListTile final (#22823)
* added missing properties
2018-10-09 13:43:15 -07:00
Ian Hickson
874df1ec21
Fix bug in AnimatedSwitcher (#22183)
* Refactor AnimatedSwitcher

This is mostly just a little bit of cleanup with hopefully no semantic
changes, done to teach me how the code works so that I could fix a bug.

* Add debugging information to AnimatedSwitcher

* Fix AnimatedSwitcher to handle the case of back-to-back changes

Previously, if a child was replaced the very next frame after it was
added, we'd get confused because we tried to reverse the controller,
which causes us to remove the child from the going-away list, before
we had added the child to the list in the first place.

The fix is just to move the reverse to after the add.
2018-10-08 14:06:18 -07:00
Hans Muller
bbb080b3a3
Material Switch optionally adapts per platform: Switch.adaptive() (#22688) 2018-10-08 10:39:59 -07:00
jslavitz
d422e85f5b
Large Dropdown Menu Fix (#22594)
* Adds comments clarifying the procedure used to render the menu as well as tests verifying various dropdown menu button positioning and initial scroll states.
2018-10-08 10:39:39 -07:00
Jonah Williams
cdf1cec902
add ability to match child semantics data (#22001) 2018-10-05 17:44:26 -07:00
Yegor
3184b7cb66
Revert "Use mixin syntax for Flutter's super-mixins (#22435)" (#22748)
This reverts commit 3c56e6c77dc5c351d610d5c2a11d86e8be88519f.

It breaks the AOT build.
2018-10-05 15:09:38 -07:00
Yegor
3c56e6c77d
Use mixin syntax for Flutter's super-mixins (#22435)
* first pass

* revert WidgetsBindingObserver

* disable prefer_mixin

* docs and more mixins

* newer engine; binding fixes

* upgrade dependencies

* fix test binding

* remove whitespace

* remove the obsolete `enableSuperMixins: true`

* upgrade dartdoc to 0.22.0

* temporarily use git version of dartdoc

* fix pub global activate syntax

* use dartdoc 0.23.0
2018-10-05 14:54:41 -07:00
xster
f7e0f83678
Let MaterialApp/CupertinoApp provide default cupertino localization (#22706) 2018-10-05 10:41:09 -07:00
Gary Qian
00bcffd108
Roll engine and update tests (#22643)
git log 7e3b41dc7ba6..74e68ff8b108 --no-merges --oneline
74e68ff8b Roll src/third_party/skia 7b7805581733..66a973493468 (4 commits) (#6436)
58fbd1fd1 Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (#6435)
83151d9fc Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (#6434)
5fe7e377d Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (#6432)
5340f4224 Revert "Use single_root_scheme when compiling platform (#6402)" (#6431)
37fd43d43 Add deadline_now_delta argument to Engine::NotifyIdle's trace (#6419)
4af077b29 Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (#6429)
165f3dd1c Update //third_party/benchmark dependency to 21f1eb (ToT). (#6427)
34bd0ef87 Don’t build benchmarking binaries on Windows. (#6428)
ae4db4469 Ensure setViewIdResourceName has the correct version guard (#6404)
2c5d0c407 [rapidjson] Fix import statements (#6418)
c2128fc80 Create a benchmarking target for the shell. (#6420)
30f78af91 Raise errors on non-zero exits while creating artifacts on the bots. (#6424)
191168cec Disable line_height tests on Windows (#6423)
061cc6643 Fix ideographic baseline to match spec. (#6422)
74eac1f56 Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (#6421)
10b45405b Implement ParagraphStyle.line_height and add tests for line_height and baselines. (#6417)
2018-10-04 10:57:30 -07:00
jslavitz
64029ba6ea
Vertical divider (#22641)
* Vertical divider bug fix and additional cleaning.
2018-10-04 10:29:32 -07:00
Alexandre Ardhuin
2ea1d81cdc
sort_constructors_first (#22575) 2018-10-04 07:28:07 +02:00
Jonah Williams
3e0cefb80e
Fix build by removing new (#22634) 2018-10-03 14:34:50 -07:00
Philip
d0c9560856 Make RotationTransition widget alignment configurable (#22535) 2018-10-03 14:20:05 -07:00
jslavitz
f44b277fa6
Custom offset functionality for Popup Menu Button (#22534)
* Adds offset functionality to popup menu
* Adds a test
2018-10-03 11:19:19 -07:00
jslavitz
8d76d37f33
Choice Chip Fix (#22589)
* choice chip fix

* added test
2018-10-03 11:08:01 -07:00
xster
dd3af0e287
Cupertino picker fidelity fixes (#22537) 2018-10-02 18:35:02 -07:00
Hans Muller
eea3465ae7
Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)
Introduce an overall material "color scheme" and to make it possible to redefine how a component's visual properties bind to the color scheme and to the existing material Theme.
2018-10-02 14:50:43 -07:00
Alexandre Ardhuin
f62afdcf57
add missing type parameter on methods (#22096) 2018-10-01 21:29:08 +02:00