131 Commits

Author SHA1 Message Date
Chris Bracken
ef6d27f840 Formatting cleanup for CONTRIBUTING.md (flutter/engine#26080)
Re-wrap to 80 columns and use references for style guide links.

Unofficially, this is more about triggering a build than cleaning up.
2021-05-11 16:10:16 -07:00
Chris Bracken
bb7caf0bf9 Use 'For example' in place of 'e.g.' (flutter/engine#25486)
This avoids the awkward capitalisation 'E.g.' but more importantly
triggers a build with the latest recipe update, which includes Windows
UWP build products.
2021-04-07 22:15:28 -07:00
stuartmorgan
dae32b99fb Add a style note about Linux embedding style (flutter/engine#21819) 2020-10-15 10:47:01 -07:00
Kaushik Iska
e365786b0d kick build (flutter/engine#19575) 2020-07-07 09:05:29 -07:00
Kaushik Iska
abba8a2911 [fuchsia] Add additional contributing instructions for Googlers (flutter/engine#16337) 2020-02-03 11:46:06 -08:00
stuartmorgan
fa82f9abf1 Add style guide and formatting information (flutter/engine#11669)
Updates CONTRIBUTING.md with style guide links for the engine languages, as well as a note about auto-formatting.
2019-09-04 09:39:34 -07:00
Will Larche
a31aeb7b77 [Docs] Correcting link to contributing guide. (flutter/engine#8472) 2019-04-08 11:32:22 -07:00
Chris Bracken
ad9247dcfe Correct URL for Cirrus CI build status badge (flutter/engine#8054) 2019-03-05 18:30:39 -08:00
Chris Bracken
7c57f7d274 Minor cleanups to CONTRIBUTING.md (flutter/engine#8043)
This is really just in order to trigger a build. ci.chromium.org infra
had a short outage during our last build.
2019-03-05 12:07:07 -08:00
Ian Hickson
729424e086 Update the contributing guide (flutter/engine#6754)
Content has moved to the wiki.
2018-11-06 13:41:06 -08:00
Dan Field
b089d88a94 Update contributing.md for xcode_backend refactor notes (flutter/engine#6642)
* Update contributing.md for xcode_backend refactor notes
2018-10-25 11:29:55 -07:00
liyuqian
7357a29311 Remove travis directory (flutter/engine#5935)
This reflects that we no longer uses travis. Scripts are moved to ci folder.
2018-08-06 15:06:49 -07:00
liyuqian
d86db51c33 Mention that running git clone isn't necessary (flutter/engine#5816)
This copies https://github.com/flutter/engine/pull/5810 in order to use the newest format.sh to pass Travis.
2018-07-20 17:09:51 -07:00
matthew-carroll
85f553fb14 Android instructions format improvement in CONTRIBUTING.md (flutter/engine#5589) 2018-06-22 21:50:51 +00:00
Ian Hickson
127b1e271a Update CONTRIBUTING.md (flutter/engine#5444) 2018-06-01 13:24:53 -07:00
xster
77b1a14fde Correct ninja command instruction (flutter/engine#5032)
giving -C twice silently only builds one directory
2018-04-17 18:32:50 -07:00
Ian Hickson
e61f21b5be Breadcrumbs to the wiki (flutter/engine#5017)
* Breadcrumbs to the wiki

* Update README.md
2018-04-16 13:26:42 -07:00
xster
0739f028f4 Add hint to use ninja with goma (flutter/engine#4894) 2018-03-28 15:51:33 -07:00
Yegor
ee3f5ece99 CONTRIBUTING.md: explain the need for building host with non-host (flutter/engine#4863)
* CONTRIBUTING.md: explain the need for building host with non-host

* address comments

* locally-built
2018-03-23 17:50:52 -07:00
Florian Loitsch
d1a92cb0aa Fix missing backtick (flutter/engine#4788) 2018-03-15 11:25:07 +01:00
Ian Hickson
65a0ef4309 Remove mention of update-packages now that we pin them (flutter/engine#4500) 2018-01-02 17:16:20 -08:00
Ian Hickson
2e4166a960 Remove mention of adb from instructions (flutter/engine#4499)
* Remove mention of adb from instructions

This isn't a step we have our users do, so best that we don't do it either.

* Update CONTRIBUTING.md
2018-01-02 17:14:41 -08:00
Ian Hickson
d1defefec1 Updated depot_tools link (flutter/engine#4498) 2018-01-02 17:14:28 -08:00
Chris Bracken
8a9f21d076 Document that Xcode 9 is required to build the engine (flutter/engine#4469)
The engine build bots and engine development team now rely solely on
Xcode 9 to build the engine. The iOS 11 SDK is required (though we build
with deployment target of iOS 8) for several features such as safe area
inset support.
2017-12-18 10:00:19 -08:00
amirh
8b0815d5de Remove target-os specific gclient dependencies. (flutter/engine#4374)
As we anyway always recommend to set the target_os to android.
Also if you happen to not set the target_os to android it messes up the licenses script output.
2017-11-22 15:55:09 -08:00
Yegor
f49775667f CONTRIBUTING.md: suggest skipping intro (flutter/engine#4188)
...if the environment is already setup
2017-10-10 10:02:21 -07:00
Michael Goderbauer
11a9ee14fe Enforce clang-format for c-like sources on Travis (flutter/engine#4089)
* Enforce clang-format for c-like sources on Travis

* Edit CONTRIBUTING,md

* review feedback:

* ++

* ++

* ++
2017-09-12 15:42:37 -07:00
Michael Goderbauer
a8ea6bd4af Mention Goma for Googlers in CONTRIBUTING.md (flutter/engine#3946)
* Mention Goma for Googlers in CONTRIBUTING.md

* review comments
2017-08-02 13:49:27 -07:00
Abhishek Amit
5ec8f6d9f2 Fix android-cpu flag reference (flutter/engine#3943) 2017-08-01 14:02:28 -07:00
Michael Goderbauer
370fdd56a7 Add Windows support to CONTRIBUTING.md (flutter/engine#3825) 2017-06-23 17:58:57 -07:00
gspencergoog
1b33b0f50b Removed 'pub get' from the instructions (flutter/engine#3774)
* Removed 'pub get' from the instructions

According to Hixie, 'pub get' is abstracted into flutter packages upgrade, and so there shouldn't be a need to run pub get directly.

* Removed pub get lines entirely.
2017-06-14 16:28:21 -07:00
xster
7b2e3b2609 Link to lldb page in tip (flutter/engine#3593) 2017-04-18 10:48:46 -07:00
xster
3f70cb283a Add instructions for debugging engine with xcode (flutter/engine#3411) 2017-02-10 13:56:02 -08:00
xster
cceefabcb1 Add CONTRIBUTING instructions for simulator (flutter/engine#3407) 2017-02-09 23:06:11 -08:00
xster
04d16b0303 Document the need to sync the engine repo to avoid #8005 (flutter/engine#3403)
* Document the need to sync the engine repo to avoid #8005

* Flit gclient sync and git pull
2017-02-09 12:08:37 -08:00
xster
1d95ca0ba0 Some tweaks to the contributing doc (flutter/engine#3402) 2017-02-08 18:29:11 -08:00
Michael Thomsen
b194ed3b5e Update editor recommendation (flutter/engine#3317)
Fixes https://github.com/flutter/flutter/issues/7294
2016-12-22 21:41:15 +01:00
Chinmay Garde
f1486c2ca0 Fix typo in README regarding --unopt builds on host. (flutter/engine#3308) 2016-12-12 16:04:57 -08:00
Ian Hickson
1ac8083795 Mention updating the buildroot git remotes (flutter/engine#3285)
* Mention updating the buildroot git remotes

I always forget how to do this...

* Update CONTRIBUTING.md
2016-11-30 20:33:19 -08:00
Philippe Ombredanne
13ee233052 Add unzip as a requirement in the contributing documentation. (flutter/engine#3273)
unzip is missing from documentation and is required to run 
"gclient sync"  successfully. Unzip does not come installed by default
on every Linux installations.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
2016-11-29 11:03:34 -08:00
Ian Hickson
d0de04bfa7 Update CONTRIBUTING.md (flutter/engine#3203)
At some point recently we started putting a JSON file in the out/ directory and this broke this suggested build script.
This patch makes the script more resilient to such files.
2016-11-04 14:36:27 -07:00
Chinmay Garde
70e14cacb6 Run the download_android_tools.py in a gclient hook. (flutter/engine#3050)
Originally, this was a step that had to be carried out manually. Presumably because we did not want developers to download the Android SDK and NDK if they were not targetting Android. In practice, this is rarely the case. Even the buildbots unconditionally run the script (though they don’t need Android artifacts on the Mac since there is no Mac to Android builder).
2016-09-21 12:05:02 -07:00
Ian Hickson
1ac1e37f63 Update CONTRIBUTING.md (flutter/engine#3028)
Have the sample build script exit after the first failed build.
2016-09-14 10:30:36 -07:00
Ian Hickson
b134c83830 Make the script rebase the right repository (flutter/engine#3025) 2016-09-13 23:40:50 -07:00
Ian Hickson
b51f7f0926 Update CONTRIBUTING.md (flutter/engine#2895) 2016-08-09 15:30:51 -07:00
Adam Barth
2a17639878 Update CONTRIBUTING.md to account for buildroot (flutter/engine#2893) 2016-08-09 14:14:10 -07:00
Chinmay Garde
0c30ca0d8d Update CONTRIBUTING.md to add iOS engine development instructions. (flutter/engine#2844) 2016-07-29 16:22:35 -07:00
Eric Seidel
e362c35d6c Better explain how to use a local engine
Added a section which explains how to get `dart:ui` changes.
2016-07-06 15:28:40 -07:00
Todd Volkert
4a7cbc0246 Remove instructions to add engine's dart-sdk to user's path. (#2736) 2016-06-07 14:16:32 -07:00
Adam Barth
1e8a040c70 Update docs about command line flags (#2725) 2016-05-31 10:19:52 -07:00