1121 Commits

Author SHA1 Message Date
Yegor
b0f7f61073 Preserve zones in Window callbacks (flutter/engine#17298)
preserve Window callback zones
2020-03-25 17:25:06 -07:00
Ferhat
8a3fe7d441 Switch ui.window.devicePixelRatio from browser logical to physical. (flutter/engine#17209)
* Switch ui.window.devicePixelRatio to browser dpi
* Add integration test for multi res image loading
* Update cirrus for new integration test
* update canvas golden test root transform
* Update compositing golden test with dpr transform
2020-03-25 12:41:17 -07:00
Mouad Debbar
ec142ff495 Add the chromedriver/ directory to gitignore
This folder is generated by the integration test manager.
2020-03-25 09:08:15 -07:00
Gary Qian
700e276dd4 Add empty string check to Locale toString (flutter/engine#17280) 2020-03-24 15:54:40 -07:00
Nurhan Turgut
cdff1342bf [web] use web drivers as a library only. do not fetch/clone web_installers (flutter/engine#17299)
* use web drivers as a library only. do not fetch/clone web_installers

* fixing comments

* addressing reviewer comments

* adding a trim to output. otherwise last fails
2020-03-24 15:37:33 -07:00
Chinmay Garde
929fb3f825 Remove checks for the always true using_fuchsia_sdk flag in all GN files. (flutter/engine#17261) 2020-03-23 18:31:02 -07:00
Mouad Debbar
0201dfd46b [web] Introduce js interop to enable experimental flags on web (flutter/engine#17099) 2020-03-23 13:22:10 -07:00
Yegor
a63c4b7025 Soften shadows (flutter/engine#17231)
* Soften shadows

* update goldens
2020-03-20 19:50:00 -07:00
Nurhan Turgut
9f6ffe557c Felt add integration (flutter/engine#17190)
* adding arguments to felt for running different type of tests

* adding test type enums to felt

* more changes to felt for testing branches

* more additions to code

* more changes to felt

* adding code for cloning web_drivers

* validating test directories. running the integration tests. update the readme file partially

* Removing todo lists used for development

* addressing reviewers comments

* remove unused imports

* addressing more reviewer comments

* addressing more reviewer comments

* addressing reviewer comments.

* addressing reviewer comments.

* fixing typos

* using chromedriverinstaller as a library. Fixing the commit number used from web_installers repo

* clean drivers directory after tests finish

* addressing more reviewer comments

* throwing all critical exceptions instead of logging and returning boolean flags

* adding todos for items we can do for making felt easier to use for local development

* do not run integration tests on CIs. Added an issue to the TODO.

* changing todo's with issues.
2020-03-20 19:24:13 -07:00
Ferhat
91323d3ed8 Fix blend test diffrate on mac (flutter/engine#17198)
* Fix error message for golden failure. Fix blend test diffrate when running on MacOS

* Revert MacOS adjustment
2020-03-18 16:47:58 -07:00
Dan Field
fd0cc9a285 Teach frontend compiler to replace toString with super.toString for selected packages (flutter/engine#17068)
Adds annotation `keepToString` to opt out.
2020-03-17 15:40:09 -07:00
Dan Field
f728eed4ae Two point conical gradient for web CanvasKit (flutter/engine#17146) 2020-03-16 12:11:02 -07:00
Ferhat
0cde474823 [web] Add HtmlCodec progress callback (flutter/engine#17139)
* Wire up htmlcodec chunkcallback for progress events

* Add test for HtmlCodec
2020-03-16 11:41:44 -07:00
MennaFadali
77db1c8e9e Implementing Locale.toLanguageTag in flutter web. (flutter/engine#17131) 2020-03-13 08:57:53 -07:00
Nurhan Turgut
0a3bbd1f00 increasing user limits for macos (flutter/engine#17097) 2020-03-11 12:15:47 -07:00
Chinmay Garde
6349c95def Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
This moves the Metal `GrContext` creation utilities from `GPUSurfaceMetal` into
a separate `IOSContext` object subclass. An analogue of this object was used in
the GL regime for the management of onscreen and offscreen contexts that were
not tied to the lifecycle of the `GPUSurface`. This pattern has now been
generalized for use with all backends that need a resource context
(`IOSContextGL` and `IOContextMetal`).

The platform views controller management in the `ExternalViewEmbedder` interface
implementation was repeated three times for [Metal][metal], [OpenGL](opengl) and
[Software](software) rendering. This repetition has been removed and a single
implementation present in the base `IOSSurface` and used on all platforms.
Addition of new client rendering APIs should not affect how the engine renders
into the platform view interleaving levels.

All rendering API selection logic has been moved into a single set of utilities
in `rendering_api_selection.h`. This enables the removal of a lot of code blocks
guarded by `FLUTTER_SHELL_ENABLE_METAL`. The remaining uses of this will be
removed when unified builds are enabled.

The Metal backend now also adds traces similar to the GL backend.

The `IOGLContext` has been renamed to `IOContextGL` to be more in line with the
convention used in this library.

Fixes https://github.com/flutter/flutter/issues/41827
Adds https://github.com/flutter/flutter/issues/52150

[metal]: 46dbf3a761/shell/platform/darwin/ios/ios_surface_metal.mm (L55)
[opengl]: 46dbf3a761/shell/platform/darwin/ios/ios_surface_gl.mm (L95)
[software]: 46dbf3a761/shell/platform/darwin/ios/ios_surface_software.mm (L146)
2020-03-10 16:01:53 -07:00
Chinmay Garde
52e75cba16 Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
We no longer package AOT artifacts as discrete blobs. The portable ELF loader
from the testing library may be used instead.

Fixes https://github.com/flutter/flutter/issues/52263
2020-03-10 12:28:24 -07:00
Ferhat
b9785ff7c3 [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
* Work around line measurement rounding bug in Firefox. Add -webkit prefix for Safari text decoration
* Add check for measurement tests for firefox
2020-03-09 22:36:46 -07:00
Dan Field
f48784c95b Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824) 2020-03-09 21:18:50 -07:00
Yegor
98f2be6b1f Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040)
This reverts 7205c0e7b3e575a6dd5d14c0c22058ae40f261a3 and re-lands 8b77254d97416bb9b347a578410911ed09efbce3. The 8b77254d97416bb9b347a578410911ed09efbce3 was good. The screenshot changes were expected.

Fixes https://github.com/flutter/flutter/issues/32215
2020-03-09 20:32:59 -07:00
Ferhat
c54d2ebe85 Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
* Add support for firefox mac installer. Update web_ui pubspec for http.wq
* Addressed review comment 'final'
2020-03-09 18:13:37 -07:00
Yegor
ec1c0c147c fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995) 2020-03-09 16:26:18 -07:00
Yegor
138614b81a Add more child lifecycle tests (flutter/engine#16689) 2020-03-09 16:26:06 -07:00
Chris Bracken
7205c0e7b3 Revert "fix shadows and mask filter blurs (#16963)" (flutter/engine#17008)
Broke golden file tests in the framework. Reverting to unblock the
engine roll to the framework.

This reverts commit 8b77254d97416bb9b347a578410911ed09efbce3.
2020-03-07 10:18:10 -08:00
Yegor
8dafc47d0e remove 10s timeouts from tests (flutter/engine#16988) 2020-03-06 12:37:52 -08:00
Ferhat
d6a38fbd6f [web] Fixes IE11 crash due to missing canvas ellipse support and font polyfill failure (flutter/engine#16965)
* Add context ellipse polyfill
* Change call sites for ellipse
* Switch fontloader polyfill font for ie11
2020-03-06 09:50:02 -08:00
Yegor
8b77254d97 fix shadows and mask filter blurs (flutter/engine#16963)
* fix shadows and mask filter blurs

* update goldens

* clarify the choice to min the shadows
2020-03-05 22:07:57 -08:00
Chris Bracken
90f3de7400 Revert "Drop last usages of Dart_New from engine (#16838)" (flutter/engine#16915)
We believe this may be implicated in a Windows-specific crash during the
Flutter Gallery integration test.

See:
https://github.com/flutter/flutter/issues/51896

This reverts commit b41f86eb00e16e0dd6e1bfba7d670e05a8dafd4b.
2020-03-03 14:52:56 -08:00
Dan Field
b41f86eb00 Drop last usages of Dart_New from engine (flutter/engine#16838)
Image
Codec
FrameInfo
Scene/Picture toImage
2020-03-02 21:30:28 -08:00
Dan Field
18f7355d00 shake out Paint.toString (flutter/engine#16850) 2020-02-28 10:41:55 -08:00
Dan Field
4a2a7fbaa3 Avoid using Dart_New for semantics (flutter/engine#16849) 2020-02-28 10:31:03 -08:00
Dan Field
81efbea9a8 remove usage of Dart_New for paragraph/libtxt (flutter/engine#16837) 2020-02-28 00:15:40 -08:00
Ben Konyi
780e60193d Enable HTTP and socket profiling dart:io service extensions for Flutter (flutter/engine#16800) 2020-02-27 08:29:58 -08:00
Ferhat
df9e5782b0 Fix stale physicalSize on resize event (flutter/engine#16822) 2020-02-26 15:54:10 -08:00
Mouad Debbar
b77b7512c7 [web] Guard the remaining calls to window.onPlatformMessage (flutter/engine#16791) 2020-02-25 15:06:07 -08:00
Nurhan Turgut
a868ed4b44 [web] changing user limits for macos (flutter/engine#16797)
* changing user limits for macos

* check kernel name instead
2020-02-25 15:04:07 -08:00
Ferhat
0e20dc802c Evict BitmapCanvas(s) from cache when canvas allocation fails (flutter/engine#16793) 2020-02-25 13:38:25 -08:00
Mouad Debbar
53dc99cd26 [web] Respect maxLines when calculating boxes for a range (flutter/engine#16749) 2020-02-24 14:26:03 -08:00
Mouad Debbar
489ddd405b [web] Reduce the usage of unnecessary lists in pointer binding (flutter/engine#16745) 2020-02-24 14:21:04 -08:00
Ferhat
a07014a9ca [web] Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under… (flutter/engine#16721)
* Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under memory pressure.

* optimized _reduceCanvasMemoryUsage

* Addressed review comments
2020-02-24 11:19:47 -08:00
Miguel Beltran
0858707729 Add support for Increase Contrast on iOS (flutter/engine#15343) 2020-02-22 14:04:04 -08:00
Dan Field
9bbbd5078d Migrate Path to AssociateWithDartWrapper (flutter/engine#16753) 2020-02-22 12:59:35 -08:00
Mouad Debbar
1e37bb489a [web] Paragraph.longestLine doesn't need to check for isSingleLine anymore (flutter/engine#16736) 2020-02-21 13:18:09 -08:00
Mouad Debbar
5f8ca597db [web] Rename LineMetrics.text to LineMetrics.displayText (flutter/engine#16734) 2020-02-21 13:17:59 -08:00
Nurhan Turgut
a443623a34 [web] add comment to skipped safari test (flutter/engine#16737)
* add comment to skipped safari test

* test not running semantics on Mac

* disable semantics test which is unreliable
2020-02-21 13:03:29 -08:00
Ryan Macnak
101b70147f Fix some compiler warnings in newer versions of Clang. (flutter/engine#16733) 2020-02-21 12:57:06 -08:00
Nurhan Turgut
3fb1af296c [web] Running safari tests on LUCI (flutter/engine#16715)
* Safari font collection tests skip failing methods

* add a clear to the semantics test to make sure no DOM elements are leaking to the other tests

* fix semantics_helper_test. skip for semantics_test. teardown didn't work

* skip test, the skipped method run for 8 minutes according to the logs

* history tests methods runs multiple times. only run them on linux for now. they were also already failing in edge/windows
2020-02-21 09:03:13 -08:00
Dan Field
b1f692e9cb Refactor of ClaimDartHandle -> AssociateWithDartWrapper (flutter/engine#16720) 2020-02-20 17:31:03 -08:00
Dan Field
a03a05a385 Reland "Remove usage of Dart_AllocateWithNativeFields" (flutter/engine#16713) 2020-02-20 16:06:02 -08:00
vsmenon
a605113c25 opt out dart:ui from nnbd (flutter/engine#16473)
* opt out dart:ui from nnbd

* Annotate tests as well
2020-02-20 11:04:00 -08:00