752 Commits

Author SHA1 Message Date
Hans Muller
dac80aac89 Make min/max fling velocity and min fling distance ScrollPhysics properties (#8928) 2017-03-21 11:00:04 -07:00
Adam Barth
d443d598c2 Align TextEditingValue and InputValue (#8922)
This patch prepares us to remove InputValue in favor of TextEditingValue.
2017-03-20 17:18:35 -07:00
Adam Barth
97816e1571 Rename Dismissable to Dismissible (#8919)
The latter is the proper spelling.

Fixes #8883
2017-03-20 16:17:08 -07:00
Adam Barth
9c8763368f Fixed extent lists cannot handle infinite extent (#8885)
Previously they tried to compute an integer target end index, but
integers can't represent infinity. Now we use null to represent
infinity.

Also, fix some similar issues with grids.

Fixes #8398
2017-03-20 12:45:52 -07:00
Adam Barth
e836a84e30 Add Image.memory for making images from typed data (#8877)
Fixes #7503
Fixes #8870
2017-03-20 11:14:41 -07:00
David Yang
f1c2d78455 Updating Cupertino Button MinSize to comply with iOS guidelines (#8881)
The recommended minimum tappable area is actually 44.0pt according to the [iOS Human Interface Guidline](https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/).

> Provide ample spacing for interactive elements. Try to maintain a minimum tappable area of 44pt x 44pt for all controls.

I've also added an override to allow for flexibility in situations where designers get naughty and have a desire to make everything super small.
2017-03-19 05:19:40 -07:00
Adam Barth
c95e73418f Adds support for custom fonts for icons (#8880)
This update adds support for custom fonts in icons. As an example, it
can be used with the icon-set from https://materialdesignicons.com

Thanks to @vlidholt for the original patch.

Fixes #4494
Fixes #3199
2017-03-18 14:09:51 -07:00
Hans Muller
031e042eee Now each Colors.foo constant is-a Color and a color swatch (#8833) 2017-03-17 15:24:54 -07:00
Adam Barth
5cf04b6141 Rename ImageFit to BoxFit (#8871)
This machinery is useful for arbitrary boxes (e.g., with FittedBox).

Fixes #6463
2017-03-17 15:21:55 -07:00
Hans Muller
d1f4822e07 Verify that stateful hero state persists mid-flight (#8817) 2017-03-17 15:00:58 -07:00
Adam Barth
ef43d00045 Ignore some missing plugins. (#8852)
Fixes #8850
2017-03-17 09:40:58 -07:00
Mikkel Nygaard Ravn
dce4bf8599 Remove old platform messaging API (#8837)
Breaking change: removed deprecated methods of PlatformMessages, leaving only binary messaging there. All other use of platform communication now goes through PlatformMessageChannel and PlatformMethodChannels. Retained use of String and JSON codecs for now.

Companion engine PR: flutter/engine#3482
2017-03-17 11:56:50 +01:00
Alexandre Ardhuin
a0769f2488 apply the upcoming rule unnecessary_this (#8838) 2017-03-17 08:05:42 +01:00
Alexandre Ardhuin
90aa2957fe replace const Duration() with Duration.ZERO (#8835) 2017-03-17 08:04:48 +01:00
Hans Muller
e0f26b44f2 Fixed a typo in AnimationController.repeat() (#8816) 2017-03-16 07:28:47 -07:00
Alexandre Ardhuin
2166ea5b7f apply partially the upcoming unnecessary_lambdas (#8810) 2017-03-15 23:09:58 +01:00
Hans Muller
6f9bfbdaba Support aborted hero flights (#8805) 2017-03-15 12:35:20 -07:00
Alexandre Ardhuin
a9ba0e2f88 prefer_initializing_formals (#8797) 2017-03-15 18:30:55 +01:00
Jason Simmons
054b566915 Framework callback for engine memory pressure events (#8778) 2017-03-15 09:54:10 -07:00
Adam Barth
146fc617ca ScrollController should notify when its offset changes (#8768)
This change make it easier to track the position of the scroll view without
having to worry about the position object changing out from under the
controller.
2017-03-14 14:07:35 -07:00
Adam Barth
fd51093146 Rename SliverPadding.child to SliverPadding.sliver (#8757)
The new name follows the pattern of the name suggesting which layout
protocol the parent expects the child to speak.

Fixes #8664
2017-03-14 14:07:13 -07:00
Hans Muller
859da8d28b Rename ListItem to ListTile, document ListTile fixed height geometry (#8769) 2017-03-14 11:46:30 -07:00
Adam Barth
6b75ac3fde Rename dependenciesChanged to didChangeDependencies (#8767)
The new name matches the style guide. (The old name was just old and predated
the style guide.)

Fixes #8000
2017-03-14 11:21:53 -07:00
Mikkel Nygaard Ravn
789c2f1f7a Fixed endianness unit test (#8753) 2017-03-14 01:01:49 +01:00
Ian Hickson
8eac6cd0da Test API improvements: pumpAndSettle, autogenerate pointer IDs (#8751) 2017-03-13 16:27:15 -07:00
Hans Muller
8a36588627 Fixed scrollable TabBar flashing (#8741) 2017-03-13 14:07:47 -07:00
Michael Goderbauer
f613fef23b Fix tests to pass internally (#8683) 2017-03-09 12:09:20 -08:00
Hans Muller
00c9e326db Additional Hero tests: destination moves midflight (#8668) 2017-03-09 10:36:53 -08:00
Alexandre Ardhuin
6a2148dde9 prefer const constructors (#8594)
* prefer const constructors

* fix double throw
2017-03-08 14:58:14 -08:00
Alexandre Ardhuin
329e52c02c apply upcoming rule use_collection_literals_when_possible (#8649) 2017-03-08 14:57:31 -08:00
Ian Hickson
944ee24b94 Report GlobalKey duplicates (#8593) 2017-03-07 17:17:02 -08:00
Hans Muller
0d958f036c Added a hero test (#8629) 2017-03-07 14:56:48 -08:00
Luke
bbf84b1d69 Fixes PageView.onPageChanged to only report changes in range (#8553)
* clamp the pixels used in the page calculation to be within min + max extents to avoid pages outside of the range of children

* add test to check onPageChanged not fired on overscroll
2017-03-05 09:38:10 -08:00
Chris Bracken
46291903e0 Declare locals final where not reassigned (tests) (#8566) 2017-03-03 17:43:22 -08:00
xster
f894edebff Use exact Ahem and exact dimensions for Cupertino button test (#8561)
* Use exact Ahem and exact dimensions for test

* use ‘px’ everywhere
2017-03-03 14:30:33 -08:00
Adam Barth
0403ed4659 Add viewportFraction feature to PageView (#8539)
This feature lets you see a portion of the next and previous page in a
PageView.

Fixes #8408
2017-03-02 21:09:14 -08:00
Adam Barth
1bb164ab0d Stabilize initial scroll simulation velocity on Android (#8543)
Previously, we would create a simulation whose initial velocity did not match
the requested parameters. We now compute the parameters for the simulation in a
way that ensures all the math works out.

Fixes #8255
2017-03-02 17:40:36 -08:00
Chris Bracken
62cc326a67 Constrain app bar header paint origin on iOS overscroll (#8517)
Prevent the app bar header from being overscrolled on iOS by setting
paintOrigin to the overlap.
2017-03-02 14:25:04 -08:00
Mikkel Nygaard Ravn
ddaba8992f PlatformMessageChannel: code cleanup, bugfixes, and unit tests (#8509) 2017-03-02 07:24:18 +01:00
Chris Bracken
5271546794 Better defaulting for scroll view primary-ness (#8506)
* Improved defaults for scroll view primary-ness

* Vertical scroll views default to primary:true.
* Horizontal scroll views default to primary:false.
* If a scroll view is primary and it got a non-null inherited primary
  scroll controller, it introduces a primary scroll controller inherited
  with a value of null for its descendants.

ScrollController now multiplexes writes to all registered positions;
reads of position continue to assert that only one position is
registered. Reads still require a single position.
2017-03-01 16:13:09 -08:00
xster
a76c352d57 Add Cupertino to gallery and add CupertinoButton and many yak friends (#8411)
* Add cupertino to gallery and add CupertinoButto

* Use single quotes

* Add disabled state

* Some review notes

* Make button animation more responsive and tweak timing

* Renamed things Cupertino

* Button with background, move cupertino demos, move material demos

* Move 2 level list too

* Refactor various demo route names

* Some review notes

* More reviews and add test

* Linter as

* Move private constant up
2017-03-01 16:06:48 -08:00
Chris Bracken
9f92f7928e Add tests for ScrollController assertions (#8499)
Ensure that read and write operations fail on ScrollControllers
associated with a number of positions other than 1.
2017-03-01 11:18:43 -08:00
Adam Barth
fcf6740851 Factor BackButton out of AppBar (#8491)
This widget is useful on its own. This patch factors it out of AppBar so
folks can use it separately.

Fixes #8489
2017-03-01 10:45:44 -08:00
Chris Bracken
297a0341a6 Update scroll tests to use pumpUntilNoTransientCallbacks (#8495)
This ensures that both timer/microtask queues are cleared out rather
than assuming that all work is completed in a specified amount of time.
2017-03-01 10:09:29 -08:00
Mikkel Nygaard Ravn
390993d070 PlatformXxxChannel concepts added to support Flutter/platform interop (#8394)
New concepts: PlatformMessageChannel (basic message send/receive superseding some existing  PlatformMessages methods), PlatformMethodChannel (method invocation and event streams), pluggable codecs for messages and method calls: unencoded binary, string, json, and 'standard' flutter binary encoding.
2017-03-01 14:35:41 +01:00
Adam Barth
a9e9e3fde6 CustomSingleChildLayout should support listenable (#8470) 2017-02-28 19:09:58 -08:00
Adam Barth
ecb6efa926 Generalize AnimatedWidget to work with any Listenable (#8469) 2017-02-28 16:40:41 -08:00
Alexandre Ardhuin
18ad3eb557 avoid // ignore: prefer_const_constructors (#8419)
* avoid // ignore: prefer_const_constructors

* address review comments
2017-02-28 16:40:10 -08:00
Adam Barth
9a83659d78 Add ValueNotifier (#8463)
It's common to have a ChangeNotifier that wraps a single value. This class
makes that easy by providing a generic implementation.
2017-02-28 11:25:23 -08:00
Chris Bracken
6491cbf7a3 Ensure PrimaryScrollController is returned when primary: true (#8440)
Also a small formatting fix.
2017-02-27 17:17:29 -08:00