721 Commits

Author SHA1 Message Date
Kevin Lubick
709e160b5c Fix includes of SkBitmap/SkImage (flutter/engine#40026) 2023-03-02 12:25:42 -08:00
Nayuta403
51f3dfb971 fix typo (flutter/engine#39971)
fix typo
2023-03-02 09:25:26 +00:00
Jim Graham
cf7d6b6440 remove obsolete DlAttribute::From(SkObject) methods (flutter/engine#40005)
remove obsolete DlAttribute::From(SkObject) methods
2023-03-02 03:49:18 +00:00
Jim Graham
90da25ef48 uncomment a DL raster cache unittest enhancement now that it is feasible (flutter/engine#39845)
uncomment a DL raster cache unittest enhancement now that it is feasible
2023-02-24 19:00:14 +00:00
Jim Graham
0fa8cbec8a Create DlCanvas interface and implement with DisplayListBuilder and SkCanvasAdapter (flutter/engine#39762)
* Create DlCanvas interface and implement with DisplayListBuilder and SkCanvasAdapter
2023-02-23 22:09:35 -08:00
Jim Graham
39c93ced57 Cached DisplayList opacity inheritance fix (flutter/engine#39690)
* only indicate opacity inheritance when DL is actually cached

* unit test

* use CacheInfo struct to simplify return values
2023-02-17 05:18:23 +00:00
Rulong Chen(陈汝龙)
4fb5044193 Uses int64_t instead of int for the |view_id| parameter. (flutter/engine#39618) 2023-02-16 20:20:15 +00:00
gaaclarke
f51ea3b01f [Impeller] Adds wide gamut support for iOS. (flutter/engine#39111)
* Implemented wide gamut images for iOS

Moved the surface to an extended range color format.

* wrong gamma but default pixel format set to bgra10_xr

* BGR10_XR add

* format

* updated todos

* updated todo with information about pixel formats

* switched logic for determining if we have a wide gamut image

* cleaned up gamut math to match style and linked source

* made the color attachment pixel format match the surface

* updated vulkan format switch

* removed comment

* added enable disable switch

* moved default to bgr10 for now since there is a bug where someone is still reading this, msaa?

* fixed the decoder settings to make sure we don't lose wide gamut colors

* fixed stored srgb gamut variable

* fixed false lint

* updated test

* added ability to grab the surface data for tests

* made the screenshot utility return the format

* added width and height to the platform channel payload

* fixed a couple of broken targets

* moved back the default pixel buffer format

* cleanup and add docstrings

* made the surfacedata feature only available in debug builds

* added decoding unit test

* fixed objc tests

* turned off by default

* bdero feedback1

* bdero2

* bdero3

* fixed merge issue

* removed using std::shared_ptr
2023-02-11 00:08:20 +00:00
Matej Knopp
066c6c6d8f Use DisplayListMatrixClipTracker in DiffContext (flutter/engine#38010) 2023-02-10 20:50:28 +00:00
Jim Graham
99de2ca94b add support to run dl_canvas_unittests on GPU surfaces (off by default) (flutter/engine#38993)
* add support to run dl_canvas_unittests on GPU surfaces (off by default)

* empty commit to trigger build

* conditionally include platform-specific surface provider headers

* ignore DL test files during license checks

* typo

* add dependencies to rendertests to hopefully build on Windows

* remove benchmarking deps from dl_rendertests

* more changes to get Windows rendertests to link

* add --enable-gl synonym and prevent non-SW surface provider dest on Windows

* fix gn formatting

* review feedback
2023-02-10 20:43:13 +00:00
Callum Moffat
a367fdc132 Fix position of BackdropFilter above PlatformView (flutter/engine#39244)
* Fix position of BackdropFilter in PlatformView

* Add check of PushFilterToVisitedPlatformViews
2023-02-09 23:58:28 +00:00
Brandon DeRosier
841758cc6c Add SkSurface include to every file where it's used (flutter/engine#39304) 2023-02-01 00:50:58 +00:00
Callum Moffat
be0feedee7 Fix position of ImageFilter layer when raster-cached (flutter/engine#38567)
* Fix position of ImageFilter layer when raster-cached

* Move integral transform and add tests

* Don't round in Preroll
2023-01-25 21:12:02 +00:00
Kevin Lubick
ecd5ad9c7c SkBudgeted -> skgpu::Budgeted (flutter/engine#38660)
* SkBudgeted -> skgpu::Budgeted

* colon

* format

* fix GN rules

* undo includes
2023-01-05 21:42:34 +00:00
Jim Graham
c48bdca6da Display list R-Tree culling (flutter/engine#38429)
* collect DL indices in RTree for clip culling

* fix bounds in unit test and minor opt in Dispatch

* normalize inline matrix objects and minor fixes to unit test

* remove over-eager DCHECK and improve R-Tree comments

* formatting

* include vector for Windows

* method rename and distribute child nodes more evenly

* add R-Tree specific unit tests and debug checks

* add comments about geometry to R-Tree unit tests and adjust spacing

* licenses

* licenses attempt 2

* fix potential overflow with uint32_t

* aggressively const DisplayList fields and methods

* add implementation comments per review feedback
2022-12-22 10:16:25 +00:00
ColdPaleLight
2779c20e03 Collapse bounds calculations into DisplayListBuilder (flutter/engine#34365)
* Collapse bounds calculations into DisplayListBuilder

* Tweak code

* Remove bounds cull

* Remove obsolete comment
2022-12-15 11:52:52 +00:00
Jim Graham
f2fd4d7f0e Fix premature LayerStateStack layer culling (flutter/engine#38159)
* remove premature opacity culling

* remove premature clip culling
2022-12-09 21:31:05 +00:00
Ian Hickson
7ab8cddeb7 Documentation and other cleanup in dart:ui, plus a small performance improvement. (flutter/engine#38047)
* Remove nonsensical (and I think unnecessary?) comment.
* Document willChangeHint, isComplexHint
* Fix grammer in Rect docs
* Remove runtimeType.toString twice
* Add detail to ImageShader constructor docs.
* Document Vertices and drawVertices!
* Update checks in Vertices constructors (and add tests).
* Fix some typos.
* Minor other doc improvements.
* Fold in @jonahwilliams' performance improvement from https://github.com/flutter/engine/pull/38041
2022-12-03 01:13:06 +00:00
Jim Graham
07fc5a59f9 Add optional offset parameter to ImageFilterLayer (flutter/engine#36863)
* add optional offset parameter to ImageFilterLayer

* update unit test for LayerStateStack and fix HTML implementation
2022-11-21 17:59:55 +00:00
Jenn Magder
3085f214f9 Turn on clang tidy error for underscores in Google tests (flutter/engine#37700) 2022-11-17 21:13:11 +00:00
Jim Graham
2252b6f362 Reland layer state stack 2 (flutter/engine#37394)
* Revert "Revert "Reland layer state stack" (#37178)"

This reverts commit 21cc000359d8a4da097e8849e83dcbe8ac941e01.

* fix double-transform rendering issues in #114359

* adjust recently added unit test to state_stack APIs

* introduce LSS delegates to simplify some code and reduce overhead

* Fix ShellTest.OnServiceProtocolEstimateRasterCacheMemoryWorks

* add unit test for tracker.setTransform(4x4) and fix bug

* fix culling issue in LayerTree::Flatten
2022-11-17 19:34:19 +00:00
Michael Ludwig
8191916a47 Use SkImageFilters::Shader instead of ::Paint (flutter/engine#37682)
* Use SkImageFilters::Shader instead of ::Paint

SkImageFilters::Paint() is deprecated and will be removed in https://skia-review.googlesource.com/c/skia/+/604917

* Fix formatting
2022-11-16 12:56:57 -08:00
Brandon DeRosier
0a11bb12d7 Add more raster traces (flutter/engine#37510) 2022-11-11 17:05:25 -08:00
ColdPaleLight
1218c3cf7b [Impeller] Support YUV external textures on iOS (flutter/engine#36685)
* Tweak Texture::Paint API

* Support external textures for iOS

* format code

* Tweak code

* format

* Clean code

* [Impeller] Support YUV external textures on iOS

* Fix test

* Clean code

* Fix compile error

* Add todo link

* Clean code
2022-11-03 22:13:01 +00:00
Jim Graham
effa8367d2 fix use of intersect/intersects in DisplayListRasterCacheItem (flutter/engine#37238) 2022-11-02 17:24:45 +00:00
Dan Field
21cc000359 Revert "Reland layer state stack" (flutter/engine#37178) 2022-10-31 18:56:18 +00:00
Jim Graham
df85a4f401 Reland layer state stack (flutter/engine#37135) 2022-10-30 18:30:22 +00:00
Chris Yang
b7b95e9372 Reland "PlatformView partial blur #36015" (flutter/engine#37086) 2022-10-28 16:43:14 +00:00
Jim Graham
8ed073eb54 Revert layer state stack (flutter/engine#37090)
* Revert "Fix a clang-tidy warning in display_list_canvas_unittests.cc (#37062)"

This reverts commit 709c6735fc7ed34df36cee23805bdaa7f6969774.

* Revert "Create a mechanism to manage layer state (#36458)"

This reverts commit 501916deb19a8303ca2a3a9bb37692a873d4679e.
2022-10-27 15:29:58 -07:00
Chris Yang
1806c34015 Revert "PlatformView partial blur" (flutter/engine#37085) 2022-10-27 18:15:14 +00:00
Chris Yang
d30087802c PlatformView partial blur (flutter/engine#36015) 2022-10-27 18:02:09 +00:00
Jim Graham
501916deb1 Create a mechanism to manage layer state (flutter/engine#36458) 2022-10-26 21:43:10 +00:00
gaaclarke
cb4c9f4727 Clang-tidy: made verbose print out commands and fixed quoting problem for warnings as errors (flutter/engine#37015) 2022-10-26 08:19:12 +00:00
Jonah Williams
ffff2c1c37 Remove expensive trace events (flutter/engine#36989) 2022-10-25 21:13:14 +00:00
ColdPaleLight
388cb71ea2 [Impeller] Support external textures on iOS (flutter/engine#36498) 2022-10-19 21:49:17 +00:00
Dan Field
e4d709de85 Avoid using non-UTF-8 encoded argv more often (flutter/engine#36590) 2022-10-05 12:03:20 -07:00
Nayuta403
630ca23bc5 Fix documentation typos in flow (flutter/engine#36527) 2022-09-30 18:29:59 -07:00
gaaclarke
e41c775200 Removed instances of unnecessary values (flutter/engine#36221) 2022-09-26 21:28:04 +00:00
Jonah Williams
614a9bde21 Revert "DiffContext: Remove transform_override" (flutter/engine#36285) 2022-09-26 20:56:20 +00:00
Nayuta403
4cf8312021 fix typo (flutter/engine#36271) 2022-09-22 22:11:51 +00:00
Jonah Williams
9dffe4a887 dont snap in preroll (flutter/engine#36239) 2022-09-19 20:11:46 +00:00
Jonah Williams
b748ae9f39 Fix preroll matrix snapping (flutter/engine#36213) 2022-09-16 20:34:41 +00:00
Jonah Williams
4828d8139e Ensure pre-rolled opacity children see snapped matrix (flutter/engine#36173) 2022-09-15 20:32:15 +00:00
fzyzcjy
9a31ce9956 Fix typo (flutter/engine#36167) 2022-09-15 20:19:03 +00:00
Chris Bracken
1c9384e781 [lint] Update local variable names in flow (flutter/engine#36136)
This updates local variable names to use clang `lower_case` style in the
flow directory. This is one of several patches to update our variable
names to a consistent style before enabling enforcement in our
clang-tidy rules.

This is a formatting-only change with no intended semantic change.
2022-09-14 07:33:23 -07:00
Jonah Williams
c4d3db0133 add pixel snapping conditional on presence of raster cache (flutter/engine#35981) 2022-09-09 01:10:01 +00:00
Dan Field
4f14c3d127 Use the frame size to cull (flutter/engine#35973) 2022-09-07 23:18:10 +00:00
emilyabest
2fd7dde9c8 PlatformView Blur for Backdrop Filter (flutter/engine#34596) 2022-09-06 17:30:57 +00:00
xiaomiao
9439f622fd Introduce bitset to manage bool flags in mock_layer unit test. (flutter/engine#35489) 2022-09-02 09:15:18 +00:00
ColdPaleLight
e9ad8e2454 [Impeller] Implement ui.Picture.toImage() (flutter/engine#35633) 2022-09-01 22:59:41 +00:00