auto-submit[bot]
5bdd0beed2
Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files ( #169245 )" ( #170770 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#169245
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Increased the time of the test task
`gradle_java8_compile_test` from about 5 minutes per run to over 30m,
which hits the timeout causing tree failures.
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20gradle_java8_compile_test
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: ash2moon
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
This commit checks if there have been any changes to the gradle files
and if gradle lock files need updating. If so, it will alert then PR
owner to update their PR with the new gradle lock file.s
Fixes https://github.com/flutter/flutter/issues/163228
Example test run:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712427303492230593/+/u/run_gradle_java8_compile_test/stdout?format=raw
This was added as an existing test under Linux gradle_java8_compile_test
because benchmarking results showed on average about 3min 30s to run on
my local M2 Mac. SInce it is not > 10min to run, placing it inside an
existing test case was ideal.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-06-17 23:59:28 +00:00
ash2moon
22dc6b6566
add run_gradle_lock_files_check.dart for new PR's that modify gradle files ( #169245 )
...
This commit checks if there have been any changes to the gradle files
and if gradle lock files need updating. If so, it will alert then PR
owner to update their PR with the new gradle lock file.s
Fixes https://github.com/flutter/flutter/issues/163228
Example test run:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712427303492230593/+/u/run_gradle_java8_compile_test/stdout?format=raw
This was added as an existing test under Linux gradle_java8_compile_test
because benchmarking results showed on average about 3min 30s to run on
my local M2 Mac. SInce it is not > 10min to run, placing it inside an
existing test case was ideal.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-17 17:25:14 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
keyonghan
8027842393
Copy artifacts to applicationBinaryPath when specified for build+test separation ( #109879 )
2022-08-23 16:32:39 +00:00
Ian Hickson
57f097b532
Refactor devicelab bin/run.dart and other cleanup ( #96320 )
2022-01-10 13:40:17 -08:00
Darren Austin
8fcace1d6c
Migrate devicelab tests and test runners to null safety. ( #85999 )
...
* Migrate devicelab tests and test runners to null safety.
2021-07-23 13:37:57 -07:00
Jenn Magder
94a41cde83
Mixed null safety in dev/devicelab ( #84017 )
2021-06-05 02:29:03 -07:00
Jenn Magder
1ff5665fdd
Force LANG=en_US.UTF-8 in test runner ( #82308 )
2021-05-12 10:49:02 -07:00
Casey Hillers
c571804913
Revert "Reland [devicelab] Migrate Gallery to BuildTestTask ( #78361 )" ( #79903 )
...
This reverts commit 0c9781e3dd043f4fa9f356611bff88535c37931b.
2021-04-06 16:28:54 -07:00
Casey Hillers
0c9781e3dd
Reland [devicelab] Migrate Gallery to BuildTestTask ( #78361 )
2021-04-06 16:04:03 -07:00
Casey Hillers
b0afe3464e
Create BuildTestTask ( #77307 )
2021-03-04 18:49:03 -08:00
Casey Hillers
7ed797b053
Revert "[devicelab] Separate build and test from Flutter gallery tests ( #76415 )" ( #77086 )
...
This reverts commit 297c7b5cf2606168a9a6fd95ed3fb958051c4466.
2021-03-02 12:17:18 -08:00
Casey Hillers
297c7b5cf2
[devicelab] Separate build and test from Flutter gallery tests ( #76415 )
2021-03-02 11:49:02 -08:00
