266 Commits

Author SHA1 Message Date
Michael Goderbauer
9e54a5ded0 Remove single-window assumption from scenario_app (flutter/engine#40156)
Remove single-window assumption from scenario_app
2023-03-09 00:37:47 +00:00
hellohuanlin
a0e967921b [platform_view] fix overlapping platform view not touchable (flutter/engine#39527)
* [platform_view]fix overlapped platform view not touchable

* scenario test

* nit

* actually fix todo
2023-02-21 23:53:20 +00:00
Chris Yang
7e60a47eea test (flutter/engine#39630)
more comments
2023-02-16 20:26:16 +00:00
Jenn Magder
55a427bec8 Default to running the scenario tests on an arm iOS simulator variant on an Apple Silicon host Mac (flutter/engine#39210)
* Default to using an arm iOS simulator variant on Apple Silicon

* Kick tests
2023-01-28 02:57:45 +00:00
Michael Goderbauer
c545a799d2 Remove unnecessary null checks (flutter/engine#39113) 2023-01-25 10:15:02 -08:00
Chris Yang
1284ee8f45 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965)
* draft

fix

rename

unittest

* update scenario

* test
2023-01-18 22:19:13 +00:00
Jenn Magder
260d48be24 Update scenario screenshots to iOS 16 (flutter/engine#38962)
* Update scenario screenshots to iOS 16

* Rename
2023-01-18 04:16:30 +00:00
Alex Wallen
29524c3c79 Remove single view assumptions from window.dart (flutter/engine#38453)
* Refactor `window.dart`

* Remove single window assumption from platform dispatcher

* Expose viewId

* Remove FlutterWindow from web_ui

* Refactor EngineFlutterWindow to inherit from FlutterView

* Rename window property

* Undo Iterable -> Map conversion

* Add window and deprecate it so that the change isn't breaking

* Name resolution

* Revisions

* Doc changes

* Refactor deprecation message

* Newline

* Expose getViewById, hide map interface

* Fix compilaiton errors

* Introduce addView API

* Change deprecation message

* Update lib/ui/window.dart

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Take greg's todos

* Add mutual exclusion assertion

* Fix trailing whitespace lint

* Use only one property to store backing view

* Add doc comment to view

* Document view and window parameters in the constructor of ViewConfiguration

* Sync web api

* Refactor assertion

* Improve deprecation message

* Improve window documentation

* Assert one of window/view is null in copyWith ViewConfiguration

* Remove EngineFlutterWindowView

* Make dartdoc happy

* Refactor copyWith()

* Change to internal map implementation

* final private refactor

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

* Deprecate window parameter in copyWith

* Repl Window w/ View

* Add tests for viewConfiguration

* Make test descriptions better

* Add ViewConfiguration initialization with window tests

* Update lib/web_ui/lib/src/engine/window.dart

Co-authored-by: David Iglesias <ditman@gmail.com>

* Refactor TODO message

* Add expectation :)

* Fix viewId in window.dart

* Remove double deprecation access

* punctuation

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Add kSingletonWindowID const

Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: David Iglesias <ditman@gmail.com>
2023-01-05 19:58:19 +00:00
Chris Yang
6eb43b7697 iOS PlatformView only sets a maskView when necessary (flutter/engine#37434)
* only clip when necessary

tests

fix tests

format

review

fix

add scenario tset

more scenario tests

add docs and comments

use offset.zero

* remove mistakenly checked-in code
2022-11-18 02:43:50 +00:00
Kaushik Iska
5b9e42523e [Reland] Add rects to accumulator rather than bounds (#37435) (flutter/engine#37451)
* [Reland] Add rects to accumulator rather than bounds (#37435)

When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251

* Add a test for nested display list rtree
2022-11-09 10:57:29 +00:00
Kaushik Iska
2155c6ce00 Revert "Add rects to accumulator rather than bounds (#37435)" (flutter/engine#37444)
This reverts commit 10da0743a513f0ae3ae5afb5a6bd99350b881989.
2022-11-08 18:10:14 -05:00
Kaushik Iska
10da0743a5 Add rects to accumulator rather than bounds (flutter/engine#37435)
When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.

Fixes: https://github.com/flutter/flutter/issues/113251
2022-11-08 19:09:49 +00:00
ColdPaleLight
922ebdc160 [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) 2022-11-07 17:40:09 +00:00
Jenn Magder
64bef739e9 Fix typo in overlay platform view iOS test (flutter/engine#37262) 2022-11-04 17:33:46 +00:00
Chris Yang
b7b95e9372 Reland "PlatformView partial blur #36015" (flutter/engine#37086) 2022-10-28 16:43:14 +00:00
Chris Yang
1806c34015 Revert "PlatformView partial blur" (flutter/engine#37085) 2022-10-27 18:15:14 +00:00
Chris Yang
d30087802c PlatformView partial blur (flutter/engine#36015) 2022-10-27 18:02:09 +00:00
Jenn Magder
59383d2857 Run iOS Scenario apps with Skia and Impeller (flutter/engine#36652) 2022-10-12 00:16:28 +00:00
Alex Wallen
3cd8b9eaa4 Deprecate single semantics tree assumption from platform dispatcher (flutter/engine#36675) 2022-10-10 18:41:16 +00:00
stuartmorgan
3eb6e7f4c3 Allow Hybrid Composition fallback for Android platform views (flutter/engine#35233) 2022-09-12 16:23:49 +00:00
stuartmorgan
d49e749f10 Remove context assertion from Android platform views using Virtual Display (flutter/engine#35997) 2022-09-09 11:40:30 +00:00
emilyabest
2fd7dde9c8 PlatformView Blur for Backdrop Filter (flutter/engine#34596) 2022-09-06 17:30:57 +00:00
Callum Moffat
4713e320b5 Scroll inertia cancel for iPadOS (flutter/engine#34929) 2022-09-01 20:27:55 +00:00
Jason Simmons
60df5a37f3 Add a comment in the scenario app to meet the latest analyzer requirements (flutter/engine#35838) 2022-08-31 18:20:15 +00:00
Chris Yang
8e1a4eebed Add warning message when PlatformView's origin is not 0 (flutter/engine#35501) 2022-08-29 19:51:16 +00:00
Gary Qian
b30aeada6d Upgrade Android SDK to 33 Tiramisu (flutter/engine#35415) 2022-08-19 00:26:52 +00:00
Phil Quitslund
e1a6ff373d [testing/scenario_app] fix no-op interpolated toStrings() (flutter/engine#35165) 2022-08-04 18:37:07 +00:00
Michael Goderbauer
f6aab09ca3 Remove unnecessary exceptions from analysis_options.yaml (flutter/engine#35054) 2022-08-02 16:20:03 +00:00
Michael Goderbauer
cc50c5249c Sync analysis_options.yaml with flutter/flutter (flutter/engine#34986) 2022-07-29 16:41:04 -07:00
Michael Goderbauer
7224607a1c Make analyzer hints and warnings fatal (flutter/engine#35013) 2022-07-29 22:09:04 +00:00
Jason Simmons
2232f767bd Use uncompressed image size as the basis for the fuzzy pixel matching threshold in the Skia Gold scenario tests (flutter/engine#34431) 2022-07-20 20:03:04 +00:00
Dwayne Slater
e4ca9ee66c Fix sample video frame rate and reenable ExternalTextureTests (flutter/engine#34479) 2022-07-18 23:54:05 +00:00
Dan Field
b0a6764623 Skip test that crashes platform (flutter/engine#34675) 2022-07-14 22:30:04 +00:00
Jason Simmons
1362b082e9 Disable the ExternalTextureTests scenario app test (flutter/engine#34433) 2022-07-01 23:35:04 +00:00
Emmanuel Garcia
135a1c8e56 Handle SurfaceView in a VirtualDisplay (flutter/engine#33599) 2022-06-22 19:39:05 -07:00
Dwayne Slater
903b84e145 Re-Enable ExternalTexturesTest (flutter/engine#34118)
Use ImageFormat.PRIVATE since produced images are not read. Hint to downstream surface producers that the image will be sampled from on the GPU.
2022-06-21 10:11:06 -07:00
Emmanuel Garcia
a01c2201b5 Reland: Re-enable scenario tests on Android (flutter/engine#34048) 2022-06-14 21:03:04 -07:00
Callum Moffat
20d8f266ac iPad trackpad gestures (flutter/engine#31591) 2022-06-13 20:48:04 -07:00
Jason Simmons
6f247c88f5 Output the scenario app lint results at the path expected by the GN script (flutter/engine#33943) 2022-06-09 15:33:03 -07:00
Zachary Anderson
7976841a64 Revert "Re-enable scenario tests on Android (#33574)" (flutter/engine#33813)
This reverts commit ab51155132d7815f51dd2f73c9843eff5174482c.
2022-06-03 13:53:28 -07:00
Emmanuel Garcia
ab51155132 Re-enable scenario tests on Android (flutter/engine#33574) 2022-06-03 08:53:05 -07:00
Gary Qian
c2fb536113 Upgrade android SDK to API 32 (flutter/engine#33524) 2022-06-01 18:58:04 -07:00
Chris Yang
d303a310a6 PlatformView to set the correct overlay view frame, merge thread at the endFrame (flutter/engine#33262) 2022-05-31 14:42:34 -07:00
Chris Bracken
56fbdd0232 [lint] Enforce k prefix for global constants (flutter/engine#33666)
Enforces that all global constants are prefixed with a 'k' as per the
style guide and updates the codebase into conformance where necessary.

This does not change any public API.

Additional testing provided by the addition of the lint rule.

Ref: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#begin-global-constant-names-with-prefix-k
2022-05-27 18:33:38 -07:00
Emmanuel Garcia
5ce95c21d7 Fix scenario tests on Android (flutter/engine#33360) 2022-05-20 12:38:05 -07:00
Zachary Anderson
fb5c781136 Delete AppLifecycleTests testDismissedFlutterViewControllerNotRespondingToApplicationLifecycle (flutter/engine#32971) 2022-04-27 16:14:04 -07:00
Dwayne Slater
346d9b3016 Add test for external textures on Android (flutter/engine#31642) 2022-03-25 10:59:54 -07:00
Gary Qian
0422046115 Revert "Delete io.flutter.app android v1 embedding" (flutter/engine#32232) 2022-03-24 00:10:04 -07:00
Gary Qian
08cef2ee55 Delete io.flutter.app android v1 embedding (flutter/engine#32074) 2022-03-23 20:22:54 -07:00
Jenn Magder
a9f3ed3e46 Delete scenario test TextSemanticsFocusTest (flutter/engine#29370) 2022-02-17 14:34:08 -08:00