1086 Commits

Author SHA1 Message Date
Michael Goderbauer
51a00ac884 Remove single window assumption from testing/dart (flutter/engine#40160) 2023-03-09 10:10:00 -08:00
Jim Graham
bc162fe559 Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module" (#40114)" (flutter/engine#40161)
Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module""
2023-03-09 02:41:54 +00:00
Michael Goderbauer
9e54a5ded0 Remove single-window assumption from scenario_app (flutter/engine#40156)
Remove single-window assumption from scenario_app
2023-03-09 00:37:47 +00:00
Dan Field
0af50a84c0 Fix multi-frame codec frame reuse (flutter/engine#40125) 2023-03-08 15:49:36 -08:00
Dan Field
3950fa55ca Improve error messaging when render target cannot be created (flutter/engine#40150) 2023-03-08 12:33:29 -08:00
Jim Graham
53a80bdedf Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40114)
Reland "Sequester all Skia<->DL interactions into the skia sub-module"
2023-03-07 19:03:17 +00:00
Jason Simmons
6927af678e Revert "Sequester all Skia<->DL interactions into the skia sub-module (#40083)" (flutter/engine#40103)
Revert "Sequester all Skia<->DL interactions into the skia sub-module (#40083)"
2023-03-07 02:58:49 +00:00
Jim Graham
acd130b2b2 Sequester all Skia<->DL interactions into the skia sub-module (flutter/engine#40083)
Sequester all Skia<->DL interactions into the skia sub-module
2023-03-06 19:55:32 +00:00
LongCatIsLooong
48c413ae2f Add new test font (flutter/engine#39809)
Add new test font
2023-03-03 21:38:01 +00:00
Michael Goderbauer
c6fb732042 Remove PlatformConfiguration and ViewConfiguration (flutter/engine#40012)
Remove PlatformConfiguration and ViewConfiguration
2023-03-02 23:14:04 +00:00
Jim Graham
cf7d6b6440 remove obsolete DlAttribute::From(SkObject) methods (flutter/engine#40005)
remove obsolete DlAttribute::From(SkObject) methods
2023-03-02 03:49:18 +00:00
Greg Spencer
c55ce6d9be Reland: Add testing hints (#39868) (flutter/engine#39931)
Reland: Add testing hints (#39868)
2023-02-28 19:39:46 +00:00
Zachary Anderson
a3d5c25a5c Revert "Add testing hints (#39868)" (flutter/engine#39921)
Revert "Add testing hints"
2023-02-27 20:36:03 +00:00
Greg Spencer
2f30f0c6a4 Add testing hints (flutter/engine#39868)
Add testing hints
2023-02-27 20:08:53 +00:00
Jim Graham
7ac53d958d delete DL ops no longer needed after removing SkCanvasRecorder (flutter/engine#39863)
delete DL ops no longer needed after removing SkCanvasRecorder
2023-02-25 01:42:20 +00:00
Jim Graham
0fa8cbec8a Create DlCanvas interface and implement with DisplayListBuilder and SkCanvasAdapter (flutter/engine#39762)
* Create DlCanvas interface and implement with DisplayListBuilder and SkCanvasAdapter
2023-02-23 22:09:35 -08:00
hellohuanlin
a0e967921b [platform_view] fix overlapping platform view not touchable (flutter/engine#39527)
* [platform_view]fix overlapped platform view not touchable

* scenario test

* nit

* actually fix todo
2023-02-21 23:53:20 +00:00
Chris Yang
7e60a47eea test (flutter/engine#39630)
more comments
2023-02-16 20:26:16 +00:00
godofredoc
4f175e2481 Enable the same tests in linux host for v2 and legacy recipes. (flutter/engine#39635)
* Enable the same test in linux host for v2 and legacy recipes.

Dart tests were not being run in the engine v2 linux builds.

Bug: https://github.com/flutter/flutter/issues/120701

* Generate path_ops.

* Remove unopt build requirement.

* Remove the check for host_debug_unopt.

* Add shell_testing deps.

* Add path_ops.

* Build benchmarks in release.

* Enable fml benchmarks.

* Add UI benchmarks.

* Add ui_list.

* Add geometry benchmarks.

* Add remaining benchmark targets.
2023-02-16 16:39:39 +00:00
William Hesse
39f9c3374b Change run_tests.sh to use python3 (flutter/engine#39586) 2023-02-13 16:57:16 +00:00
Jason Simmons
37323ac0bd Ignore invalid filters when constructing an image compose filter (flutter/engine#39528)
Fixes https://github.com/flutter/flutter/issues/120278
2023-02-10 15:48:05 +00:00
luckysmg
e9254a637b Add iOS spring animation objc files (flutter/engine#38801)
* ++

* ++

* ++

* ++

* ++

* ++

* Add tests

* ++

* ++

* ++

* ++

* ++
2023-02-02 00:29:17 +00:00
Brandon DeRosier
841758cc6c Add SkSurface include to every file where it's used (flutter/engine#39304) 2023-02-01 00:50:58 +00:00
Brandon DeRosier
e1ced4e387 Unblock Skia roll by including SkSurface header (flutter/engine#39295) 2023-01-31 11:43:30 -08:00
Ben Konyi
d3f45828bf Reland "Remove references to Observatory (#38919)" (flutter/engine#39139)
This reverts commit 5dd945442b230a2c0549ee6d798fda71e031a4a9.
2023-01-30 09:50:09 -05:00
Jenn Magder
55a427bec8 Default to running the scenario tests on an arm iOS simulator variant on an Apple Silicon host Mac (flutter/engine#39210)
* Default to using an arm iOS simulator variant on Apple Silicon

* Kick tests
2023-01-28 02:57:45 +00:00
Jenn Magder
1b4ce3fa8b Use arm64 engine variant on simulators in iOS unit tests (flutter/engine#39213) 2023-01-28 00:16:47 +00:00
Jonah Williams
e5d80e9fe2 [Impeller] partially remove remap sampler support (flutter/engine#39147)
* partially remove remap sampler support

* Update runtime_effect_contents.cc
2023-01-26 19:20:05 +00:00
Ricardo Amador
2e9905afab Update infrastructure python code to be compatible with python 2 and python 3 (flutter/engine#39133)
* Compatibility with python2 and python3

* Formatting

* Updated to use a function instead of decoding bytes in multiple places.

* Formatting and whitespace cleanup.

* Fix import statement.

* Linter change for docstring.

* Formatting.

* Remove function from run_tests.py since it is a pain to import.

* Add todo message for python 2 deprecation.

* Updated copyright year.
2023-01-26 16:04:31 +00:00
Michael Goderbauer
c545a799d2 Remove unnecessary null checks (flutter/engine#39113) 2023-01-25 10:15:02 -08:00
Todd Volkert
2363e70858 Add more flexible image loading API (flutter/engine#38905)
* Add more flexible image loading API

This adds a new `instantiateImageCodecWithSize` method, which can be
used to decode an image into a size, where the target size isn't known
until the caller is allowed to inspect the image descriptor.

This enables the use case of loading an image whose aspect ratio isn't
known at load time, and which needs to be resized to fit within a
bounding box while also maintaining its original aspect ratio.

https://github.com/flutter/flutter/issues/118543

* Add test

* Fixed test failure

* Update

* Respond to review comments

* Add web implementation

* Fixed typo

* Review comments

Also changed the TargetImageSizeCallback to just take intrinsic
width & height, rather than the full image descriptor.

* Forgot to remove the _SizeOnlyImageDescriptor class - it's no longer needed

* Forgot to update test
2023-01-23 01:48:24 +00:00
Ben Konyi
002fce29e0 Revert "Remove references to Observatory (#38919)" (flutter/engine#39035)
Reason for revert: breaking Flutter -> plugins roll

This reverts commit 1f603711c7b7afe52dff3872a5035789e3ddba02.
2023-01-20 12:33:40 -05:00
Ben Konyi
1f603711c7 Remove references to Observatory (flutter/engine#38919)
Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags.

See https://github.com/dart-lang/sdk/issues/50233
2023-01-19 09:20:46 -05:00
Chris Yang
1284ee8f45 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965)
* draft

fix

rename

unittest

* update scenario

* test
2023-01-18 22:19:13 +00:00
Jenn Magder
260d48be24 Update scenario screenshots to iOS 16 (flutter/engine#38962)
* Update scenario screenshots to iOS 16

* Rename
2023-01-18 04:16:30 +00:00
Jim Graham
eb615c6cc4 delete include of private GrMtlTypes header (flutter/engine#38783) 2023-01-11 19:57:47 +00:00
Alex Wallen
29524c3c79 Remove single view assumptions from window.dart (flutter/engine#38453)
* Refactor `window.dart`

* Remove single window assumption from platform dispatcher

* Expose viewId

* Remove FlutterWindow from web_ui

* Refactor EngineFlutterWindow to inherit from FlutterView

* Rename window property

* Undo Iterable -> Map conversion

* Add window and deprecate it so that the change isn't breaking

* Name resolution

* Revisions

* Doc changes

* Refactor deprecation message

* Newline

* Expose getViewById, hide map interface

* Fix compilaiton errors

* Introduce addView API

* Change deprecation message

* Update lib/ui/window.dart

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Take greg's todos

* Add mutual exclusion assertion

* Fix trailing whitespace lint

* Use only one property to store backing view

* Add doc comment to view

* Document view and window parameters in the constructor of ViewConfiguration

* Sync web api

* Refactor assertion

* Improve deprecation message

* Improve window documentation

* Assert one of window/view is null in copyWith ViewConfiguration

* Remove EngineFlutterWindowView

* Make dartdoc happy

* Refactor copyWith()

* Change to internal map implementation

* final private refactor

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

* Deprecate window parameter in copyWith

* Repl Window w/ View

* Add tests for viewConfiguration

* Make test descriptions better

* Add ViewConfiguration initialization with window tests

* Update lib/web_ui/lib/src/engine/window.dart

Co-authored-by: David Iglesias <ditman@gmail.com>

* Refactor TODO message

* Add expectation :)

* Fix viewId in window.dart

* Remove double deprecation access

* punctuation

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Add kSingletonWindowID const

Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: David Iglesias <ditman@gmail.com>
2023-01-05 19:58:19 +00:00
Loïc Sharma
18a38c535a Fix build using VS 17.4's C++ STL (flutter/engine#38614) 2023-01-04 21:21:46 +00:00
ColdPaleLight
f2007cfd2b Use DisplayListMatrixClipTracker in DisplayListBuilder (flutter/engine#38349)
* Use DisplayListMatrixClipTracker in DisplayListBuilder

* Ignore is_aa

* Revert "Ignore is_aa"

This reverts commit b201dadc773f8e726ec68ed88114df9be7b5a9b0.

* Tweak code

* Use content_culled

* getLocalClipBounds without device clip bounds roundsOut

* Tweak code and add more tests

* remove virtual
2022-12-20 10:05:40 +00:00
Siva
99b4cb739a Manual Roll Dart SDK from 7b4d4ec3cad1 to 35f6108ef685 (4 revisions) (flutter/engine#38409)
* Manual Roll Dart SDK from 7b4d4ec3cad1 to 35f6108ef685 (4 revisions)

https://dart.googlesource.com/sdk.git/+log/7b4d4ec3cad1..35f6108ef685

2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-39.0.dev
2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-38.0.dev
2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-37.0.dev
2022-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-36.0.dev

* Add package:js path dependency
2022-12-19 19:31:31 -08:00
Chinmay Garde
a35e55cf9a [Impeller] Disable impeller_unittests. (flutter/engine#38307)
Fixes https://github.com/flutter/flutter/issues/114872
Followup in https://github.com/flutter/flutter/issues/117122
2022-12-15 02:27:17 +00:00
Phil Quitslund
9545fe3573 Fix new unnecessary_parenthesis diagnostics. (flutter/engine#38291)
These will get flagged w/ the latest linter.

See, [try failure](https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8794866247739072257/+/u/analyze_flutter_plugins/stdout) and [linter roll PR](https://dart-review.googlesource.com/c/sdk/+/275044).
2022-12-14 20:05:08 +00:00
Zachary Anderson
9896c5f66d pylint all Python scripts under testing/ (flutter/engine#38268) 2022-12-14 16:23:16 +00:00
Jonah Williams
6bbe15577d Fix sampler offsets (flutter/engine#38170)
* [impeller] dont remap floats

* ++

* Update fragment_shader_test.dart

* ++:

* ++
2022-12-10 18:37:04 +00:00
Zachary Anderson
6a6203c77e Pylint testing/run_tests.py (flutter/engine#38016) 2022-12-09 09:14:48 -08:00
Jonah Williams
83206b1c23 [Impeller] order metal samplers according to declared order and not usage order (flutter/engine#38115)
* [Impeller] order metal samplers according to declared order and not use order

* ++

* always enabl remapping

* Revert "always enabl remapping"

This reverts commit 2fffb05aeea9cfcbd0df051540054ca0d6c337c0.

* ++

* add test

* ++

* ++

* only run on mac
2022-12-08 17:23:12 +00:00
Erik
b7bf0a3155 Full implementation of text-input-test (flutter/engine#37986)
Implements text-input-test, validates that we're able to receive the correct platform messages through the flutter/keyevent channel
2022-12-07 12:17:51 -05:00
Jason Simmons
426d21f97e Disable an extension in Xvfb to work around errors seen when running Impeller/Vulkan unit tests (flutter/engine#38092)
See https://github.com/flutter/flutter/issues/116130
2022-12-06 17:18:12 +00:00
Ian Hickson
7ab8cddeb7 Documentation and other cleanup in dart:ui, plus a small performance improvement. (flutter/engine#38047)
* Remove nonsensical (and I think unnecessary?) comment.
* Document willChangeHint, isComplexHint
* Fix grammer in Rect docs
* Remove runtimeType.toString twice
* Add detail to ImageShader constructor docs.
* Document Vertices and drawVertices!
* Update checks in Vertices constructors (and add tests).
* Fix some typos.
* Minor other doc improvements.
* Fold in @jonahwilliams' performance improvement from https://github.com/flutter/engine/pull/38041
2022-12-03 01:13:06 +00:00
Erik
94c88a9253 [fuchsia] arm64 Dart runner (flutter/engine#37399)
- Fuchsia FEMU tests now run using `ffx`
- There is now a Fuchsia arm64 FEMU builder to allow tests to run on an arm64 emulator
2022-11-28 17:39:50 -05:00