DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,050 Commits 882 Branches 1,069 Tags
Commit Graph

22333 Commits

Author SHA1 Message Date
skia-flutter-autoroll
f79135b34a Roll Skia from 28946eda0f6d to 69f7860093b4 (6 revisions) (flutter/engine#42262) 
https://skia.googlesource.com/skia.git/+log/28946eda0f6d..69f7860093b4

2023-05-23 kjlubick@google.com Add placeholders to pdf.gni for SkJpegInfo
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8a3971e5e9c5 to cd2d20c6e4a3 (3 revisions)
2023-05-23 weiyuhuang@google.com Fix Line Break Rounding
2023-05-23 jacksongardner@google.com Create a `GrExternalTextureGenerator` that is usable outside skia.
2023-05-23 kjlubick@google.com Guard extra implementation of SkGetJpegInfo
2023-05-23 brianosman@google.com Avoid redefinition errors in Flutter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 22:34:46 +00:00
skia-flutter-autoroll
35bf453e4d Roll Skia from 292879d286e9 to 28946eda0f6d (5 revisions) (flutter/engine#42257) 
https://skia.googlesource.com/skia.git/+log/292879d286e9..28946eda0f6d

2023-05-23 michaelludwig@google.com [skif] Match decl/def parameter name in merge filter
2023-05-23 jvanverth@google.com [graphite] Clean out ProxyCache before unrefing Resources' cacheref.
2023-05-23 nicolettep@google.com Change Descriptors.h -> DescriptorTypes.h
2023-05-23 nicolettep@google.com [graphite] Get vertex & frag shader for Vulkan pipeline creation
2023-05-23 brianosman@google.com Remove SkOpts::hash_fn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 19:44:05 +00:00
Jonah Williams
be33a58e18 [Impeller] Encode render passes concurrently on iOS. (flutter/engine#42028) 
Allows pushing encoding of command buffers to a worker thread, relying on the fact that these buffers are always scheduled in the order that they are enqueued. This follows the guidelines from https://developer.apple.com/documentation/metal/mtlcommandbuffer?language=objc
 2023-05-23 19:40:05 +00:00
Jesse Seales
3e4dabb16d Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256) 
Reverts flutter/engine#42247

Reverting in order to find solution which doesn't add a skipped test onto all PRs. Only PRs which address vuln scanning need to have this test showing at all.
 2023-05-23 19:08:54 +00:00
Jesse Seales
c7bcd52ec2 Vuln scan on 3p deps triggered by label on PR (flutter/engine#42247) 
This change allows for anyone submitting a PR which resolves a vulnerability found from the scanning action to be run on the PR to check for resolution if the label 'vulnerability patch' is applied to the PR. 

*List which issues are fixed by this PR. You must list at least one issue.*
b/283970087

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-23 18:42:21 +00:00
Jonah Williams
52b5bc5340 Revert "[Impeller] use host image upload path on simulator" (flutter/engine#42212) 
Reverts flutter/engine#42161

As reported by uses, this did not help with the issue.
 2023-05-23 18:22:47 +00:00
Jesse Seales
4caf5b7de7 Vulnerability scanning print failed command in case of error (flutter/engine#42190) 
The 3p deps vulnerability scanner currently isn't providing helpful output in the case of errors during the processing of the dependencies. This change adds outputting which command caused the error, and conditionally add error output to help aid any changes that need to be made to the dependencies.

*List which issues are fixed by this PR. You must list at least one issue.*
b/282959127

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-23 17:51:17 +00:00
skia-flutter-autoroll
30c213e526 Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 17:22:21 +00:00
gaaclarke
5ed6890c14 [Impeller] Removed last ivars to raw vk::Device's. (flutter/engine#42215) 
Removes the last ivars that hold onto a `Device` directly.  This have recently been the cause of crashes, so the safer thing is to remove them all.

For the Allocator and the Sampler library, removing the device ivars is likely just a precaution since they should have only been accessed from the raster thread and killed before the Device.  The fence waiter however was potentially accessing the device from a separate thread, so that was much more risky and likely to cause crashes.

Testing: The existing `impeller_unittests` verify this is setup correctly.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-23 17:03:19 +00:00
skia-flutter-autoroll
8fbc30e305 Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (flutter/engine#42249) 
https://skia.googlesource.com/skia.git/+log/225d51031ad0..292879d286e9

2023-05-23 jlavrova@google.com Removing an extra (wrong) placeholder for CLIENT_ICU
2023-05-23 michaelludwig@google.com Revert "[skif] Remove dedicated SkDropShadowImageFilter implementation"
2023-05-23 michaelludwig@google.com [skif] Remove legacy SkImageImageFilter implementation
2023-05-23 brianosman@google.com Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"
2023-05-23 michaelludwig@google.com Reland "[skif] Add FilterResult::Builder and update SkMergeImageFilter to use it"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 16:53:55 +00:00
Zachary Anderson
fa4d9d029d Build arm64 FlutterEmbedder.framework and lipo the result (flutter/engine#42233) 
This PR modifies the mac_host_engine build config to build the
FlutterEmbedder.framework for arm64, and adds a generator that creates a
fat framework containing both the intel and arm64 dylibs. The fat
framework is uploaded to the gcs bucket instead of the thin intel-only
one.

The script to create the lipo'd embedder framework is different enough
from the desktop framework to have a separate script, but this still
triggers the pylint duplicate-code check. Due to a bug in our version of
pylint (https://github.com/pylint-dev/pylint/issues/214), it isn't
possible to disable per-file, so this PR also disables the check
globally.
 2023-05-23 09:50:25 -07:00
Alexander Aprelev
90ee66eeaa Roll watcher dependency for web_ui to 1.1.0. (flutter/engine#42248) 
Incoming dart sdk roll
https://dart.googlesource.com/sdk.git/+log/90b4df96e9dc..4881eadbade6
needs updated version of watcher due to FileSystemEvent becoming sealed.
 2023-05-23 09:44:20 -07:00
Mouad Debbar
9aec8c5c62 [web] Move platformViewRegistry to ui_web (flutter/engine#41877) 
In this PR, I'm leaving a getter for `platformViewRegistry` in `dart:ui` for backwards compatibility. At some point, we need to properly deprecate it (e.g. print a warning asking users to import it from `dart:ui_web` instead).

Next step is to migrate all call sites in flutter/flutter, flutter/packages and flutter/devtools (anything else?).

Issue: https://github.com/flutter/flutter/issues/126831

Fixes https://github.com/flutter/flutter/issues/41563
 2023-05-23 16:17:56 +00:00
skia-flutter-autoroll
e784e3174d Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (flutter/engine#42246) 
https://skia.googlesource.com/skia.git/+log/3ded22186598..225d51031ad0

2023-05-23 kjlubick@google.com Make codec registration for decoding explicit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 14:59:34 +00:00
skia-flutter-autoroll
0497fa73e4 Roll Skia from 1c3d1e200d72 to 4d0166106722 (2 revisions) (flutter/engine#42238) 
https://skia.googlesource.com/skia.git/+log/1c3d1e200d72..4d0166106722

2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ddf59ec4e8fc to 97f14b3b6c39
2023-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a17cd49ee1eb to ddf59ec4e8fc (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 07:17:30 +00:00
Brandon DeRosier
892d301b87 [Impeller] Place Entity Geometry classes in separate TUs (flutter/engine#42236) 
Resolves https://github.com/flutter/flutter/issues/122854.

One of those quality of life things I keep putting off...
 2023-05-22 22:46:41 -07:00
skia-flutter-autoroll
545e8806ff Roll Skia from 6a57876d0e44 to fc369d15070f (1 revision) (flutter/engine#42234) 
https://skia.googlesource.com/skia.git/+log/6a57876d0e44..fc369d15070f

2023-05-23 brianosman@google.com Revert "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 03:54:27 +00:00
skia-flutter-autoroll
a8326dc3f7 Roll Fuchsia Linux SDK from LrfeC0dLk8ToJVik5... to Zbd3haNY2Idcdu1Fj... (flutter/engine#42232) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 03:30:18 +00:00
Zachary Anderson
1a85b3733f Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42231) 
Reverts flutter/engine#42115

Failing on the framework tree as in
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ios__timeline_summary/11103/overview
 2023-05-22 19:35:47 -07:00
skia-flutter-autoroll
10a6d1ec51 Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 
https://skia.googlesource.com/skia.git/+log/ac87929b3d2e..6a57876d0e44

2023-05-22 nscobie@google.com Revert "Disable thinLTO in skia  for riscv"
2023-05-22 scroggo@google.com Revert "[skottie] Don't revalidate during render()"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 02:01:27 +00:00
skia-flutter-autoroll
98661be0ff Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 
https://skia.googlesource.com/skia.git/+log/d448fe07ea46..ac87929b3d2e

2023-05-22 brianosman@google.com Replace SkOpts::hash/hash_fn with SkChecksum::Hash32
2023-05-22 jamesgk@google.com Make destcolor GM non-Ganesh-specific
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dc49e5c6de1e to e2fe2393abb4 (1 revision)
2023-05-22 brianosman@google.com Add wyhash as SkChecksum::Hash32/64
2023-05-22 brianosman@google.com Make ChecksumBench much more interesting and representative
2023-05-22 michaelludwig@google.com Revert "[skif] Add FilterResult::Builder and update SkMergeImageFilter to use it"
2023-05-22 johnstiles@google.com Add WGSL support for anonymous function parameters.
2023-05-22 robertphillips@google.com Add Protected checks to GL and Mock onCanCopySurface methods

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-23 00:10:08 +00:00
Dan Field
ccd8afabde Make FML_LOG safe from static initialization (flutter/engine#42219) 
I ran into this while trying to get some printing going for places where we're creating thread local keys. 

Supposedly, just including `<iostream>` should statically initialize `std::cout/cerr`, but it gets really hard to reason about whether your statically initialized code is going to be initialized before or after that happens. I tried making sure that the TU for `fml/logging.cc` did that initialization statically, but that also failed in the verison of the test included here (it passed in some other iterations that modified run_all_unittests.cc). We _could_ make sure it happens each and every time we touch `std::cerr` but ... we could also just use `fprintf(stderr, ...)` and it works just fine.

/cc @flar who ran into problems around this a little while back and was asking about it.
 2023-05-23 00:02:17 +00:00
Emircan Uysaler
d84c05920b [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 
This CL posts ChildViewWatcher calls on platform thread.

Bug: fxb/125256
 2023-05-23 10:00:27 +10:00
skia-flutter-autoroll
652e1f18ca Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 
https://dart.googlesource.com/sdk.git/+log/b3e1eeda4918..1ca8f8368ecc

2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-134.0.dev
2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-133.0.dev
2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-132.0.dev
2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-131.0.dev
2023-05-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-130.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 23:35:04 +00:00
Jason Simmons
b4b589148b [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 
Fixes https://github.com/flutter/flutter/issues/127061

See https://github.com/flutter/flutter/issues/126768
 2023-05-22 20:43:05 +00:00
fzyzcjy
7387859481 Again a two-word super tiny typo (flutter/engine#42181) 
Find this when reading source code today...

Btw, what about introducing a spell checker to Flutter source code? ;)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-22 13:28:16 -07:00
Chris Yang
b20b25128a Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 
The original PR (https://github.com/flutter/engine/pull/41573) was reverted due to https://github.com/flutter/flutter/issues/126951

The issue will be fixed in https://github.com/flutter/engine/pull/42079

This needs to be landed after https://github.com/flutter/engine/pull/42079

fixes: https://github.com/flutter/flutter/issues/125620

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-22 20:10:37 +00:00
Jason Simmons
c40d8bbc8e [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 
Previously this was attempting to invert the TransformBounds done by GetCoverage.  TransformBounds computes a bounding box of the transformed rectangle and can not be reversed.

Fixes https://github.com/flutter/flutter/issues/127103
 2023-05-22 20:01:49 +00:00
Jonah Williams
19c071da39 [Impeller] Add UV compute shader. (flutter/engine#42192) 
Adds a compute shader that computes the UV mapping for an arbitrary geometry. Use it with drawPoints since I didn't realize it was possible to use an image shader with this 😆 .
 2023-05-22 20:01:47 +00:00
Jonah Williams
e4427e5c92 [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) 
From local testing, this doesn't seem to be necessary on physical iOS devices, with or without platform views.
 2023-05-22 20:00:37 +00:00
skia-flutter-autoroll
fee0f3ae59 Roll Skia from 2612bb159848 to d448fe07ea46 (5 revisions) (flutter/engine#42213) 
https://skia.googlesource.com/skia.git/+log/2612bb159848..d448fe07ea46

2023-05-22 michaelludwig@google.com [skif] Remove dedicated SkDropShadowImageFilter implementation
2023-05-22 fmalita@chromium.org [skottie] Don't revalidate during render()
2023-05-22 michaelludwig@google.com [skif] Add FilterResult::Builder and update SkMergeImageFilter to use it
2023-05-22 michaelludwig@google.com Skip flaky tests in Xe and Radeon ANGLE D3D9
2023-05-22 kjlubick@google.com Update all versions of Bazelisk and add one for Intel Macs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 19:59:03 +00:00
Alexander Aprelev
88faba02e2 Skip and ignore boringssl/src/rust when looking for the licenses. (flutter/engine#42210) 
third_party/boringssl/src/rust/bssl-crypto/deny.toml coming in as part of https://dart-review.googlesource.com/c/sdk/+/304210 triggers 'potential license' license script error.

Rust sources of boringssl are not included into flutter, don't need to be scanned for licenses.
 2023-05-22 19:53:54 +00:00
Jonah Williams
6ee594c86f [Impeller] Create reusable prefix sum. (flutter/engine#42167) 
Creates a reusable function macro for performing a prefix sum. Eventually, we'll need this for polyline decomposition

![image](https://github.com/flutter/engine/assets/8975114/3d9af2b2-f1ea-413a-ac1f-d4a69211388e)

Reasonably fast with max (1024) input elements.
 2023-05-22 16:08:06 +00:00
skia-flutter-autoroll
80d986be9f Roll Skia from ef226c5a7930 to 2612bb159848 (1 revision) (flutter/engine#42209) 
https://skia.googlesource.com/skia.git/+log/ef226c5a7930..2612bb159848

2023-05-22 kjlubick@google.com Remove GPU code from MaskFilters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 16:08:05 +00:00
skia-flutter-autoroll
82d77fd9ab Roll Skia from 76303a5498e9 to 79088c6b7a33 (2 revisions) (flutter/engine#42204) 
https://skia.googlesource.com/skia.git/+log/76303a5498e9..79088c6b7a33

2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a17cd49ee1eb to 19a1ee338aa1
2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b6ae2e881c8b to a17cd49ee1eb (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-22 07:27:35 +00:00
Tong Mu
4a01af4737 [macOS] Clean up unused methods in FlutterRenderer (flutter/engine#42196) 
This PR removes the methods in `FlutterRenderer` that will never be
used.

These methods allows the engine to get a drawable and present a
drawable, but they will never be called on the macOS embedder. This is
because they go through the `FlutterMetalRendererConfig` struct to
`GPUSurfaceMetalSkia`, which is bypassed if the engine has a non-null
external view embedder, which the macOS always provides.

Removing these methods not only cleans up the code (and the confusion),
but also reduces the methods that might need to be migrated for the
multi-view project.

After this change, `FlutterRenderer` is left with very few
functionalities:
* It hosts `device` and `commandQueue`.
* It creates `FlutterRendererConfig`.
* It implements `FlutterTextureRegistry` and
`FlutterTextureRegistrarDelegate`, linking `FlutterTexture` and
`FlutterTextureRegistrar`.

We might want to refactor this class, but that's for the future.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-21 16:53:57 -07:00
skia-flutter-autoroll
b43f7317f1 Roll Skia from 5b2005e47bf3 to 2d4ea9542e83 (1 revision) (flutter/engine#42200) 
https://skia.googlesource.com/skia.git/+log/5b2005e47bf3..2d4ea9542e83

2023-05-21 johnstiles@google.com Fix fuzzer-discovered issue with empty buffers.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-21 17:03:23 +00:00
skia-flutter-autoroll
e41cfec63d Roll Skia from 7c7dff949a27 to 5b2005e47bf3 (1 revision) (flutter/engine#42199) 
https://skia.googlesource.com/skia.git/+log/7c7dff949a27..5b2005e47bf3

2023-05-21 johnstiles@google.com Reject SkSL programs that are larger than 8MB.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-21 15:12:05 +00:00
Kevin Lubick
7751d1c5eb Move SkSurface::MakeNull to SkSurfaces::Null (flutter/engine#42158) 
In https://skia-review.googlesource.com/c/skia/+/696537 (and earlier in
https://skia-review.googlesource.com/c/skia/+/687639), Skia moved all
SkSurface factories. This changes the last calls of the old static
methods to the methods in the `SkSurfaces` namespace

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-20 10:11:44 -04:00
skia-flutter-autoroll
a98b701976 Roll Fuchsia Linux SDK from TWjmvLCOnYAUgAzvT... to c_fRDyBVZX-MwW5fS... (flutter/engine#42189) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-20 10:20:23 +00:00
skia-flutter-autoroll
218a9ef722 Roll Skia from 7202b405f061 to b4a4782cf89d (19 revisions) (flutter/engine#42185) 
https://skia.googlesource.com/skia.git/+log/7202b405f061..b4a4782cf89d

2023-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 68bc448fa901 to 44392282e953 (5 revisions)
2023-05-19 lovisolo@google.com [bazel] Remove SkImageAndroid.h from //include/android:public_hdrs.
2023-05-19 kjlubick@google.com Revert "Remove legacy SkSurface factories"
2023-05-19 johnstiles@google.com Add WGSL support for short-circuited expressions.
2023-05-19 johnstiles@google.com Add new SkSL tests to dm.
2023-05-19 armansito@google.com [vello] Support compiling the vello dependencies using Bazel
2023-05-19 penghuang@chromium.org dawn: use alpha version of BlendFactor for wgpu::BlendState::alpha
2023-05-19 johnstiles@google.com Implement non-trivial ternary expressions in WGSL.
2023-05-19 lovisolo@google.com [bazel] //tests/adb_test.bzl: Rewrite test runner in Go.
2023-05-19 jamesgk@google.com [graphite] Choose renderer before updating clip stack
2023-05-19 kjlubick@google.com Remove legacy SkSurface factories
2023-05-19 michaelludwig@google.com [skif] Remove legacy SkPictureImageFilter
2023-05-19 michaelludwig@google.com [skif] Update SkImageImageFilter to use FilterResult
2023-05-19 lovisolo@google.com [bazel] //tests/android.bzl: Rewrite tarball creation script in Go.
2023-05-19 johnstiles@google.com Allow WGSL expression generators to emit extra statements.
2023-05-19 johnstiles@google.com Add new 'Statement' level for operator precedence.
2023-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3600ed906bb4 to 68bc448fa901 (3 revisions)
2023-05-19 kjlubick@google.com Speculative fixes for CreateDockerImage_Skia_Release
2023-05-19 lovisolo@google.com [bazel] BazelTest-* task schema: Add support for precompiled Android tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-20 06:44:22 +00:00
Dan Field
f9b687885e [Impeller] avoid creating multiple concurrent message loops for Andorid Vulkan (flutter/engine#42146) 
Fixes https://github.com/flutter/flutter/issues/127160

We should avoid creating multiple message loops that each have as many threads as processors on the machine.
 2023-05-20 03:41:18 +00:00
Jackson Gardner
8812268345 Implement ImageFilter/ColorFilter/MaskFilter in Skwasm (flutter/engine#42088) 
This implements https://github.com/flutter/flutter/issues/126342

This implements `ImageFilter`, `ColorFilter` and `MaskFilter` in Skwasm. This includes support on the `Paint` object, as well as the `SceneBuilder` layers that use these types.
 2023-05-20 00:46:10 +00:00
gaaclarke
d18ae43605 [Impeller] Made other vulkan objects cleanup properly. (flutter/engine#42113) 
fixes https://github.com/flutter/flutter/issues/127058

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-20 00:38:19 +00:00
ColdPaleLight
026967383a [Impeller] Fix the issue that 'coverage_coords' is incorrectly calculated in 'FillPathGeometry::GetPositionUVBuffer' (flutter/engine#42155) 
fix https://github.com/flutter/flutter/issues/127183

## without patch
![3Q7pxQTjei](https://github.com/flutter/engine/assets/31977171/5d7ce98a-afef-4d42-96a4-b3524345e69a)
## whti patch
![LRG6o1t9mm](https://github.com/flutter/engine/assets/31977171/66c9c3f9-762c-4dc8-b10b-cde179a7bbc4)
 2023-05-19 23:45:22 +00:00
chunhtai
dcfd92f566 Overrides accessibilityScrollToVisible (flutter/engine#42047) 
fixes https://github.com/flutter/flutter/issues/61624

Observed behavior is that this method is called when an item is swipe-to-focusd in VoiceOver.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-19 22:02:05 +00:00
Chris Bracken
206d0974f7 [macOS] Extract PlatformView mutator clip updating (flutter/engine#42164) 
Extracts `updatePathClipViewsWithPaths:origin:` which updates the stack of AppKit clip views hosting the platform view.

This change is a cleanup change for readability and makes no semantic changes to how mutator views are applied. Existing unit tests in [FlutterMutatorViewTest.mm](https://github.com/flutter/engine/blob/main/shell/platform/darwin/macos/framework/Source/FlutterMutatorViewTest.mm) are expected to pass without changes.

This is refactoring prior to applying a fix for rotation handling.

Issue: https://github.com/flutter/flutter/issues/124490

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-19 19:37:11 +00:00
htoor3
1046b076ce [web] Fix event offset for transformed widgets (and text input nodes). (flutter/engine#41870) 
Text inputs have moved outside of the shadowDOM and are now using the pointer event offset calculation algorithm that platform views use.  However, transforms (e.g. scaling) applied to the input element aren't currently accounted for, which leads to incorrect offsets and clicks being registered inaccurately.

This PR attempts to transform those offset coordinates using the transform matrix data that is included in the geometry information sent over to `text_editing.dart` from the framework.

## Issues

* Fixes https://github.com/flutter/flutter/issues/125948 (text editing)
* Fixes https://github.com/flutter/flutter/issues/126661 (platform view scaling)
* Fixes https://github.com/flutter/flutter/issues/126754

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-19 19:25:58 +00:00
Zachary Anderson
079f084e48 Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/engine#42166) 
Engine PR to match https://github.com/flutter/flutter/pull/127218
 2023-05-19 19:06:49 +00:00
Brandon DeRosier
d650e423f1 [Impeller] Limit blur kernel to 1000x1000 pixels (flutter/engine#42154) 
Resolves https://github.com/flutter/flutter/issues/127151.

This is the same internal limit that Skia uses.
 2023-05-19 11:34:07 -07:00