DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,308 Commits 882 Branches 1,069 Tags
Commit Graph

25224 Commits

Author SHA1 Message Date
skia-flutter-autoroll
f712ddcb03 Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195) 
https://skia.googlesource.com/skia.git/+log/83f8fe8bbcee..3de801338767

2023-12-18 johnstiles@google.com Handle rewrite-matrix-vector-multiply directly in SPIR-V.
2023-12-18 johnstiles@google.com Expand RewriteMatrixVectorMultiply test to cover non-constants.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 20:46:09 +00:00
Bartek Pacia
b87524c6d3 Delete SemanticsUpdateBuilderNew and all references and usages (flutter/engine#49139) 
This PR completest the migration by removing `SemanticsUpdateBuilderNew` from the engine.

This is mainly targeted at https://github.com/flutter/flutter/issues/17988

Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
part 2: [flutter] use `SemanticsUpdateBuilderNew` https://github.com/flutter/flutter/pull/138331
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/48882
part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again https://github.com/flutter/flutter/pull/139942
**part 5: [engine] remove `SemanticsBuilderNew`** <-- we are here
 2023-12-18 19:35:58 +00:00
Chinmay Garde
b29921cf93 Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002) 
We use a statically linked libcxx and don't expose any of the internal symbols. This theoretically allows us to namespace everything to avoid accidentally using the wrong version libcxx. Also, not having to worry about ABI stability allows libcxx to opt into optimized routines.

But, since libcxx uses CMake and we don't, the mechanism to generate the __config_site file doesn't exist in GN. Instead, we check in a file that would have been generated for us by CMake. The file we check in though is a default with additional configuration. This version of the file makes it so that we opt into the unstable ABI (and get optimizations) and also namespace everything for Flutter so collisions are immediately flagged.
 2023-12-18 19:35:56 +00:00
skia-flutter-autoroll
c34bf9ead7 Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191) 
https://skia.googlesource.com/skia.git/+log/4b2639427e7e..10e7ee119ea9

2023-12-18 bungeman@google.com Revert "Cache the one SkEmptyTypeface"
2023-12-18 brianosman@google.com Reland "Support multiple image filters in SaveLayerRec"
2023-12-18 johnstiles@google.com Add Type::columnType.
2023-12-18 herb@google.com Compare the slopes of two segments
2023-12-18 mike@reedtribe.org Limit recursion in contour-measure
2023-12-18 jvanverth@google.com [graphite] Switch to use TokenTracker for RasterAtlas page invalidation.
2023-12-18 bungeman@google.com Cache the one SkEmptyTypeface
2023-12-18 johnstiles@google.com Revert "Allow an SkSL compiler to be created without shader caps."
2023-12-18 johnstiles@google.com Fix fuzzer-discovered issue with inlining.
2023-12-18 bungeman@google.com Document that SkDocument::beginPage calls endPage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 19:07:21 +00:00
skia-flutter-autoroll
05558a52ba Roll Skia from 290fefdef726 to 4b2639427e7e (1 revision) (flutter/engine#49183) 
https://skia.googlesource.com/skia.git/+log/290fefdef726..4b2639427e7e

2023-12-18 herb@google.com Myers: Point and Segment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 16:16:25 +00:00
skia-flutter-autoroll
2d59f91787 Roll Skia from 276075b97567 to 290fefdef726 (1 revision) (flutter/engine#49180) 
https://skia.googlesource.com/skia.git/+log/276075b97567..290fefdef726

2023-12-18 johnstiles@google.com Remove a four-year temporary workaround.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-18 15:32:03 +00:00
Mouad Debbar
4d71cad1fb [web] Set cursor property on body (flutter/engine#49098) 
This is a temporary workaround to get mouse cursor working in multi-view (until https://github.com/flutter/flutter/issues/140226 is resolved).
 2023-12-18 15:20:04 +00:00
Matej Knopp
33a6339c63 Add FlutterMetalLayer as optional alternative to CAMetalLayer (flutter/engine#48226) 
This PR implements `FlutterMetalLayer`, a drop-in (as far as Flutter is
concerned) replacement for `CAMetalLayer`. The biggest difference is
that `FlutterMetalLayer` can present frames from background thread
within a `CATransaction`.

`FlutterMetalLayer` is disabled by default. To opt-in, add the following
item to `Info.plist`:

```xml
        <key>FLTUseFlutterMetalLayer</key>
	<true/>
```

The performance seems quite good, consistent 120hz on iPhone 13 Pro.

Benefits
- presenting with transaction from background thread, which, down the
line, would allow for platform views without thread merging.
- fine control over how the surface is displayed - we can display single
surface on multiple `CALayers`, each showing different part, allowing
for performant implementation of unobstructed platform views.
 
Drawbacks
- this not being a metal layer makes working with metal instrument tools
more awkward
 2023-12-16 21:53:32 +01:00
skia-flutter-autoroll
8580ec5d36 Roll Skia from d231faf34f8a to 35d0d7eb991c (1 revision) (flutter/engine#49137) 
https://skia.googlesource.com/skia.git/+log/d231faf34f8a..35d0d7eb991c

2023-12-16 brianosman@google.com Revert "Support multiple image filters in SaveLayerRec"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 14:16:39 +00:00
skia-flutter-autoroll
6e5f1c22b6 Roll Skia from 01aa69c38af5 to d231faf34f8a (1 revision) (flutter/engine#49134) 
https://skia.googlesource.com/skia.git/+log/01aa69c38af5..d231faf34f8a

2023-12-16 lehoangquyen@chromium.org GraphiteDawn: support mapping draw buffers directly.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 10:16:32 +00:00
skia-flutter-autoroll
587501aae1 Roll Skia from 191943f9c43e to 01aa69c38af5 (4 revisions) (flutter/engine#49128) 
https://skia.googlesource.com/skia.git/+log/191943f9c43e..01aa69c38af5

2023-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a2df0f5a263 to 4382b905737a (2 revisions)
2023-12-16 jvanverth@google.com [graphite] Remove conditional uploads for the text atlas.
2023-12-16 lehoangquyen@chromium.org Re-enable GraphitePurgeNotUsedSinceResourcesTest
2023-12-15 michaelludwig@google.com [skif] Add SrcRectConstraint to SkDevice::drawSpecial

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 05:05:37 +00:00
skia-flutter-autoroll
1b87dca813 Roll Dart SDK from d66f9c854db7 to 620976ef6b80 (2 revisions) (flutter/engine#49125) 
https://dart.googlesource.com/sdk.git/+log/d66f9c854db7..620976ef6b80

2023-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-237.0.dev
2023-12-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-236.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-16 04:24:14 +00:00
Dan Field
19726b1650 Statically link swiftshader into flutter_tester (flutter/engine#48708) 
Depends on https://swiftshader-review.googlesource.com/c/SwiftShader/+/72768

Fixes https://github.com/flutter/flutter/issues/138169
 2023-12-16 00:47:57 +00:00
Jason Simmons
7c532f1ab8 [Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC (flutter/engine#49114) 
Shader bundles only produce the flat buffer output and do not write a depfile.
 2023-12-16 00:30:16 +00:00
auto-submit[bot]
2bb1d061ec Reverts "Run tests on macOS 13 exclusively" (flutter/engine#49115) 
Reverts flutter/engine#49099
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-15 23:27:26 +00:00
Brandon DeRosier
96e13e165f [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter/engine#49076) 
We use this bounds rect for querying the DisplayList rtree when culling.
But when sub-DisplayLists are being dispatched, the DisplayList's rtree
is local and doesn't incorporate parent layer filters. So
sub-DisplayLists are getting culled as if no filters are being applied.

Technically our local bounds tracking in Aiks is actually correct here,
but this is a quick fix to alleviate the problem. I don't know what the
best longterm solution for this is.
 2023-12-15 13:34:37 -08:00
skia-flutter-autoroll
46564e6588 Roll Skia from cf84bab13da3 to 191943f9c43e (1 revision) (flutter/engine#49105) 
https://skia.googlesource.com/skia.git/+log/cf84bab13da3..191943f9c43e

2023-12-15 brianosman@google.com Fix color uniforms in SkMesh

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 21:26:40 +00:00
skia-flutter-autoroll
4851164d87 Roll Dart SDK from e6528d1b7997 to d66f9c854db7 (1 revision) (flutter/engine#49104) 
https://dart.googlesource.com/sdk.git/+log/e6528d1b7997..d66f9c854db7

2023-12-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-235.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 21:11:09 +00:00
Victoria Ashworth
d2ef296ea7 Run tests on macOS 13 exclusively (flutter/engine#49099) 
Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-15 20:33:03 +00:00
skia-flutter-autoroll
a0f907c961 Roll Skia from 4f0f3f3992e0 to cf84bab13da3 (1 revision) (flutter/engine#49097) 
https://skia.googlesource.com/skia.git/+log/4f0f3f3992e0..cf84bab13da3

2023-12-15 drott@chromium.org [COLRv1] Move coincident stop and angles test from var to static

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 19:00:00 +00:00
skia-flutter-autoroll
62ae6a64e7 Roll Skia from c10028c9756f to 4f0f3f3992e0 (2 revisions) (flutter/engine#49094) 
https://skia.googlesource.com/skia.git/+log/c10028c9756f..4f0f3f3992e0

2023-12-15 johnstiles@google.com Allow an SkSL compiler to be created without shader caps.
2023-12-15 brianosman@google.com Move bench setup code to onDelayedSetup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 18:03:10 +00:00
Jason Simmons
7403719fb2 Revert "[Impeller] Provide the clear color to an advanced blend if it was optimized out" (flutter/engine#49064) 
This reverts commit 2de054c92a2e5948f12ec39ac08235bb079f82ec.

That PR was outputting incorrect colors on the Play/AiksTest.BlendMode advanced blend tests.
 2023-12-15 16:56:19 +00:00
skia-flutter-autoroll
d532b76173 Roll Skia from 0e0e00e2969b to 7a97b766b14b (1 revision) (flutter/engine#49090) 
https://skia.googlesource.com/skia.git/+log/0e0e00e2969b..7a97b766b14b

2023-12-15 brianosman@google.com Support multiple image filters in SaveLayerRec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 16:23:19 +00:00
skia-flutter-autoroll
b9649bf5fa Roll Skia from 1537198c5461 to 0e0e00e2969b (1 revision) (flutter/engine#49088) 
https://skia.googlesource.com/skia.git/+log/1537198c5461..0e0e00e2969b

2023-12-15 SCHMIDT Move SKSurfaceProps usage to default constructor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 15:28:23 +00:00
Kevin Lubick
408a017697 Fix text missing in performance overlay (on Android) (flutter/engine#49035) 
The Android fontmgr does not return a default typeface when a nullptr
style is passed in [1] (I'm not sure if this is a feature or a bug).
However, calling legacyMakeTypeface will use a default sans-serif font.
This adds in that backup behavior.

[1]
4170fba2d8/src/ports/SkFontMgr_android.cpp (L310-L312)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-12-15 08:37:36 -05:00
skia-flutter-autoroll
604e25ec96 Roll Dart SDK from f1e37ed8917e to bb1b67b78b8d (1 revision) (flutter/engine#49073) 
https://dart.googlesource.com/sdk.git/+log/f1e37ed8917e..bb1b67b78b8d

2023-12-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-232.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 05:51:25 +00:00
Matan Lurey
23f7b463ef Move third_party/json to flutter/third_party/json. (flutter/engine#48844) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from `//third_party` to
`//flutter/third_party`.
 2023-12-14 20:54:37 -08:00
Matan Lurey
3aae0411b7 Automatically fix header guards in the rest of the flutter/engine repo. (flutter/engine#49059) 2023-12-15 04:11:06 +00:00
skia-flutter-autoroll
c770714926 Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065) 
https://dart.googlesource.com/sdk.git/+log/0471164827b9..f1e37ed8917e

2023-12-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-231.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-15 01:43:15 +00:00
Dan Field
a9b85c6bcb [Impeller] impellerc: delete unused code (flutter/engine#49061) 2023-12-15 01:12:55 +00:00
gaaclarke
a53bf6a572 [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050) 
issue https://github.com/flutter/flutter/issues/140106

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-15 01:12:53 +00:00
gaaclarke
b526c0726e Revert "[Impeller] Turned on new blur." (flutter/engine#49062) 
Reverts flutter/engine#48472

This is causing memory crashes in the device lab:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20backdrop_filter_perf_ios__timeline_summary/14324/overview
```
[2023-12-14 15:55:20.660354] [STDOUT] stdout: [+1764 ms] Process 611 stopped
[2023-12-14 15:55:20.662620] [STDOUT] stdout: [   +2 ms] * thread #12, name = 'io.flutter.1.raster', stop reason = EXC_RESOURCE (RESOURCE_TYPE_MEMORY: high watermark memory limit exceeded) (limit=2098 MB)
[2023-12-14 15:55:20.662686] [STDOUT] stdout: [        ]     frame #0: 0x0000000106705e78 Flutter`void std::_LIBCPP_ABI_NAMESPACE::allocator<impeller::Command>::construct[abi:v15000]<impeller::Command, impeller::Command>(impeller::Command*, impeller::Command&&) + 8
[2023-12-14 15:55:20.662784] [STDOUT] stdout: [        ] Flutter`std::_LIBCPP_ABI_NAMESPACE::allocator<impeller::Command>::construct[abi:v15000]<impeller::Command, impeller::Command>:
[2023-12-14 15:55:20.662883] [STDOUT] stdout: [        ] ->  0x106705e78 <+8>:  str    x8, [x0]
[2023-12-14 15:55:20.662932] [STDOUT] stdout: [        ]     0x106705e7c <+12>: ldr    x8, [x1, #0x8]
[2023-12-14 15:55:20.663033] [STDOUT] stdout: [        ]     0x106705e80 <+16>: str    x8, [x0, #0x8]
[2023-12-14 15:55:20.663097] [STDOUT] stdout: [        ]     0x106705e84 <+20>: ldr    x8, [x1, #0x10]
[2023-12-14 15:55:20.663194] [STDOUT] stdout: [        ] Target 0: (Runner) stopped.
[2023-12-14 15:55:20.663309] [STDOUT] stdout: [        ] thread backtrace all
[2023-12-14 15:55:20.663403] [STDOUT] stdout: [        ] process detach
```
 2023-12-14 16:36:27 -08:00
Matan Lurey
02f6c46771 Fix header-guard naming convention in shell/. (flutter/engine#49006) 
Part of landing https://github.com/flutter/engine/pull/48903.

Some of these actually seem like potential owchy spots, i.e. `#ifndef FLUTTER_FLUTTER_H_`.
 2023-12-14 23:37:22 +00:00
Jason Simmons
1edcdb5db2 Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054) 
Includes an update for a deprecated FFI API
(see https://dart.googlesource.com/sdk/+/efb60eac5999e47853505f2e3fc3eaf19f56f495)
 2023-12-14 23:22:20 +00:00
Matan Lurey
2ecbd2ff7d Rename font-subset to font_subset. (flutter/engine#49051) 
For consistency, I don't think we have any other tools with `-`'s.

I'll be honest - this seemed easier than teaching the header guard tool
how to handle `-`'s in directory names, but if you feel strongly about
it I can revert.
 2023-12-14 15:16:09 -08:00
skia-flutter-autoroll
10bb1d87b6 Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056) 
https://skia.googlesource.com/skia.git/+log/92935b91193a..79f23e8d8b5d

2023-12-14 michaelludwig@google.com [skif] Refine SkSpecialImage::asShader() API for fast constraints

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-14 23:11:49 +00:00
Lau Ching Jun
2363abacfe Suppress warning for the new Activity library. (flutter/engine#49046) 
Context: cl/582573869
 2023-12-14 23:09:54 +00:00
Jonah Williams
d036f2a352 [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 
If we clear to transparent black, we're not forcing the pass to be constructed. Change the entity pass API so that we can tell the difference between clearing transparent black and not having a clear color.

In https://github.com/flutter/flutter/issues/139571 , the app is creating a layer that is clearing to a transparent color, which is getting skipped. That invalid texture is fed into a blend which produces either black or magenta error texture.

Fixes https://github.com/flutter/flutter/issues/139571
 2023-12-14 21:37:29 +00:00
Victoria Ashworth
117716f199 Unpin mac_toolchain version (flutter/engine#48994) 
mac_toolchain has been updated to no longer have 2 minute slowdown (https://github.com/flutter/flutter/issues/138109), so unpin to use the latest version.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-14 21:27:04 +00:00
gaaclarke
9ca6bd8786 [Impeller] Turned on new blur. (flutter/engine#48472) 
This new blur should perform faster since it scales down the image
before blurring it. Jonah did early testing of it and found it to be
faster. Scrolling around with the blur perf bug it seems faster. It also
has a wider test bed and is hopefully easier to maintain since it
contains all of its logic for both directions.

testing: There are existing blur tests and we've backfilled more as
we've added features to this blur.

fixes https://github.com/flutter/flutter/issues/131580
fixes https://github.com/flutter/flutter/issues/138259

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-12-14 13:09:32 -08:00
LongCatIsLooong
0be3f2d5d6 Fix a bug in the HTML render's getClosestGlyphInfo implementation (flutter/engine#48774) 
`closestFragmentAtOffset` takes a horizontal offset from the start of the line, not the start of the paragraph. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-14 20:57:48 +00:00
Jenn Magder
2d0010fcb6 Fix NSPrivacyCollectedDataTypes array in privacy manifest (flutter/engine#49041) 
In https://github.com/flutter/engine/pull/48951 `NSPrivacyCollectedDataTypes` is an array with an empty dictionary, but the privacy report wants an empty array or it errors:

<img width="523" alt="Screenshot 2023-12-14 at 10 02 52 AM" src="https://github.com/flutter/flutter/assets/682784/a128b384-db2f-49d7-8b71-7965f2826de8">

When this is fixed the privacy report is blank, but that seems to be an Xcode bug?  Will investigate.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-14 20:26:05 +00:00
skia-flutter-autoroll
a98c213612 Roll Skia from 5353de0c25b9 to 92935b91193a (1 revision) (flutter/engine#49044) 
https://skia.googlesource.com/skia.git/+log/5353de0c25b9..92935b91193a

2023-12-14 briansalomon@gmail.com [graphite] Make Graphite/WebGPU build and run in Debug

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-14 20:09:59 +00:00
Jason Simmons
9538c024ca Reland manual roll of Dart SDK from 82c4571bb2de to a677378ae254 (flutter/engine#49034) 
Includes type annotations for JSArray/JSPromise
(see https://dart-review.googlesource.com/c/sdk/+/337923)
 2023-12-14 20:01:01 +00:00
Loïc Sharma
d5968a10c0 [Windows] Remove header guard from generated key map (flutter/engine#48993) 
No tests as this is a refactoring with no semantic changes.

The generator was updated by https://github.com/flutter/flutter/pull/140082
 2023-12-14 19:50:05 +00:00
Jim Graham
a4a845b511 [Impeller] Round rects with circular ends should not generate ellipses (flutter/engine#49021) 
Fixes https://github.com/flutter/flutter/issues/140118

A bad test caused round rects with completely rounded sides to become ellipses.
 2023-12-14 19:36:07 +00:00
skia-flutter-autoroll
e1110df3ac Roll Skia from 0d5356a0f3cb to 5353de0c25b9 (1 revision) (flutter/engine#49040) 
https://skia.googlesource.com/skia.git/+log/0d5356a0f3cb..5353de0c25b9

2023-12-14 kjlubick@google.com Remove type union from MutableTextureState

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-14 19:24:59 +00:00
skia-flutter-autoroll
6fada5664e Roll Skia from 4170fba2d89f to 0d5356a0f3cb (1 revision) (flutter/engine#49036) 
https://skia.googlesource.com/skia.git/+log/4170fba2d89f..0d5356a0f3cb

2023-12-14 briansalomon@gmail.com [graphite] Re-add support for BackendTexture from WGPUTextureView

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-14 18:18:41 +00:00
Bruno Leroux
6162b4211f [Windows] Expose channel buffers 'resize' and 'overflow' control commands exposed by the control channel. (flutter/engine#47158) 
## Description

This PR adds two helper functions to invoke the 'resize' and 'overflow' commands exposed by the control channel.
See:

c00c022036/lib/ui/channel_buffers.dart (L302-L309)

Implementation based on the discussion from https://github.com/flutter/engine/pull/46998.

## Related Issue

Windows implementation for https://github.com/flutter/flutter/issues/132386

## Tests

Adds 4 tests.
 2023-12-14 15:56:56 +00:00
skia-flutter-autoroll
77264a5781 Roll Skia from 47f84c5cf15d to 9746c141d66b (1 revision) (flutter/engine#49029) 
https://skia.googlesource.com/skia.git/+log/47f84c5cf15d..9746c141d66b

2023-12-14 maryla@google.com Add support for gain map tone mapping in a different colorspace.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-14 13:48:33 +00:00