152 Commits

Author SHA1 Message Date
Yegor
f3a4f722c4 [flutter_test] new WidgetTester API based on finder objects (#3288) 2016-04-13 23:40:15 -07:00
Ian Hickson
571e2e84aa Stop importing identifiers we don't use. (#3314) 2016-04-13 14:42:07 -07:00
Adam Barth
ec4a6a96f2 Add more dartdocs to material.dart (#3279) 2016-04-12 14:18:58 -07:00
Adam Barth
47715c5076 Add padding support to LazyBlock (#3272)
Also fill in some related dartdocs.
2016-04-12 13:05:44 -07:00
Adam Barth
8254dce2f5 Dismissable doesn't resize from its full size (#3194)
Previously we'd snap to the size of the background widget before resizing to

zero. Now we force the background widget to match the size of the dimissable

widget at the time it was dismissed.



Fixes #3092
2016-04-07 15:08:02 -07:00
Adam Barth
7570495b0a SnackBarActions shouldn't be tappable twice
They should automagically disable after the first tap.
2016-04-06 21:13:53 -07:00
Adam Barth
76f66605b0 TabView should keep state
Previously, we lost sync with the tab view contents when switching tabs. Now we
key the subtrees to make sure they keep their state across tab animations.

Fixes #3147
2016-04-06 17:15:53 -07:00
Adam Barth
2d49e8074c Remove MixedViewport
Also, port the MixedViewport tests to LazyBlockViewport. Fix bugs found by the tests.
2016-04-06 15:24:52 -07:00
Ian Hickson
798dfa2bc9 Fix analyzer warnings
Fix some legit uses of GlobalKey to specify the type they want.



Fix some sketchy uses of GlobalKey in tests to fake it with "as

dynamic".



Remove some extraneous imports that made the build red.
2016-04-06 14:14:34 -07:00
Adam Barth
6fd6859793 LazyBlock docs and physics
This patch adds dartdoc to LazyBlock. Also, this patch fixes the scrolling
physics of LazyBlock. Previously, we updated a running simulation only when the
change in scroll behavior changed the current scroll offset. Now we update
running simulations every time the behavior changes because the simulation
might depend on quantities other than the current scroll offset.
2016-04-06 12:36:54 -07:00
Adam Barth
40899eb274 Port clients of ScrollableMixedWidgetList to LazyBlock
LazyBlock is going to replace ScrollableMixedWidgetList at some point.
2016-04-05 20:18:35 -07:00
Ian Hickson
ee703da9de Rationalise all our exception handling.
- Create a FlutterErrorDetails struct-like class that describes an

  exception along with more details that aren't in the exception, like

  where it was caught and what was going on when it was caught.



- Provide a FlutterError static API for handling these objects:



  - FlutterError.onError which is called whenever Flutter catches an

    error.



  - FlutterError.reportError() which handles an error.



  - FlutterError.dumpErrorToConsole() which is the default behavior

    for onError.



- Removes all the existing exception handler callbacks.



- Replaces all the existing places that described exceptions using

  debugPrint with calls to FlutterError.reportError().



- Extend lockState() to also catch exceptions, so that we catch

  exceptions that happen during finalizers.



- Make the test framework catch errors and treat them as failures.



- Provide a mechanism to override this behavior in the test framework.



- Make the tests that used to depend on the exception handler

  callbacks use this new mechanism.



- Make pump() also support the phase argument.



- Improve some tests using these new features.



Fixes #2356, #2988, #2985, #2220.
2016-04-02 10:24:12 -07:00
Andrew P. Wilson
f516dbcc2e Leave all entered targets when finishing. 2016-04-01 09:45:28 -07:00
Adam Barth
fca2ac1189 Merge pull request #3023 from abarth/add_test
Add a scrolling test now that it passes
2016-04-01 08:16:35 -07:00
Adam Barth
884ec65c9e Don't delay between dismissing a snack bar and the next snack bar
Previously, the Dismissable widget was animating down to zero width off
screen. Now, we tell it to skip the resize animation.

Fixes #3030
2016-03-31 23:25:03 -07:00
Adam Barth
dbb7c2e850 Add a scrolling test now that it passes
We fixed this issue a different way but the test is still valuable.
2016-03-31 17:28:20 -07:00
Kris Giesing
9dfd5d4021 Part 2 of independent layout pipelines
Adds BuildOwner to manage the dirty list and build processing for
widgets/elements, and adds a widget unit test to make sure separation
is enforced.

Fixes #2723
2016-03-31 11:02:00 -07:00
Adam Barth
b841e868f1 Reactivating a StatefulElement should imply a build
Fixes #2901
2016-03-29 16:02:10 -07:00
Andrew Wilson
fad5df4c5e Merge pull request #2948 from apwilson/image
Add keys to ResourceImages.
2016-03-29 14:16:18 -07:00
Andrew Wilson
ed00f3ed5c Add keys to ResourceImages. 2016-03-29 14:02:49 -07:00
Hixie
baf06515e5 Table widget
- Add x and y to the parent data, in case it's useful. In point of fact,
  I ended up not needing it.

- Make columnWidths settable rather than having a setter so that the
  code in the widgets layer is more idiomatic.

- Teach setFlatChildren about avoiding unnecessary drop/adopt loops.

- Assert that the child list length is correct more aggressively so that
  we catch the dumb bug I had more quickly next time.

- Improve the toString() to handle empty tables better.

- Resort the imports in framework.dart.

- Introduce a LocalKey for cases where you don't want to allow use of
  GlobalKey.

- Make inflateWidget and deactivateChild public for subclass use.

- Table widget.

- Cell widget.

- TableRow fake widget.
2016-03-29 12:43:19 -07:00
Andrew Wilson
8ff1982776 Allow Draggables to drop through DragTargets that don't accept them to one that does. 2016-03-29 10:31:04 -07:00
Adam Barth
1ba539a661 Add constants for FractionalOffsets
Adds some names for common FractionalOffset values.
2016-03-28 22:51:06 -07:00
Matt Perry
641604ad94 Merge pull request #2850 from mpcomplete/form
Added a Form widget to manage multiple Input widgets.
2016-03-28 13:55:08 -04:00
Matt Perry
a7b28a3ede Added a Form widget to manage multiple Input widgets. 2016-03-25 17:55:38 -04:00
Andrew Wilson
3a84cef248 Merge pull request #2907 from apwilson/velocity_drop
Add a callback when a Draggable is dropped without being accepted.
2016-03-25 14:28:14 -07:00
Andrew Wilson
f90ccf4825 Add a callabck when a Draggable is dropped without being accepted. 2016-03-25 14:18:24 -07:00
Adam Barth
3c6d4f660e Add a default MediaQuery value
Now MediaQuery.of always returns a non-null value. By default, you get the
values associated with the current ui.Window.

Fixes #2894
2016-03-25 13:07:42 -07:00
Adam Barth
c8c325d095 Replace EdgeInsets.TRBL with EdgeInsets.fromLTRB
This matches the pattern from Rect. I've left EdgeInsets.TRBL marked as
deprecated to give clients a chance to update.

Fixes #2860
2016-03-24 15:19:40 -07:00
Adam Barth
e361c0b096 Inherited widgets should work across reactivations
Previously we updated only the reactivated element's inherited widgets. Now we
update all the inherited widgets for the whole subtree that's being
reactivated. We need to visit the whole subtree anyway, so there isn't much of
a loss.

Fixes #2733
Fixes #2438
Fixes #1701
2016-03-24 10:54:08 -07:00
Hixie
34cc0c4728 Rationalise the overflow render boxes
New RenderAligningShiftedBox abstract class for render boxes with
"alignment", which as of now is:

 - RenderPositionedBox
 - RenderConstrainedOverflowBox (ex RenderOverflowBox)
 - RenderSizedOverflowBox
 - RenderFractionallySizedOverflowBox (ex RenderFractionallySizedBox)

(The respective widgets are Align, OverflowBox, SizedOverflowBox, and
FractionallySizedBox. They haven't been renamed.)

Also I added some toString details.
2016-03-22 14:06:49 -07:00
Hans Muller
70550a7a9a Fix _LazyWidgetProvider indexing, move Ali Connors 2016-03-21 12:20:09 -07:00
Andrew Wilson
861423876d Refactor CheckedModeBanner into something more reusable. 2016-03-18 19:03:16 -07:00
Hixie
7e3bef1163 Replace WidgetError and RenderingError with FlutterError 2016-03-18 15:40:38 -07:00
Adam Barth
502a4ae078 Use FractionalOffset for gradients
These were using Offsets, but they're really FractionalOffsets.

Fixes #2318
2016-03-15 19:30:41 -07:00
Adam Barth
a710676d5f Tapping drawer during animation causes it to stick
The problem was we were using a tap gesture to stop the motion of the
drawer and a drag gesture to settle it. That can cause a broken
lifecycle. Now we use a single drag recognizer to drive the whole
lifecycle.

Fixes #775
Fixes #1276
2016-03-15 16:43:34 -07:00
Adam Barth
3ebd4c58b6 Let RenderObjectWidgets use inherited properties
This prepares us for depending on the LTR/RTL inherited property in
RenderObjectWidgets.
2016-03-14 16:56:56 -07:00
Hixie
797e27edd3 Add @override annotations to flutter framework 2016-03-14 14:02:26 -07:00
Adam Barth
89987fc040 [rename fixit] TwoLevelSublist left->leading, center->title 2016-03-14 12:24:58 -07:00
Hixie
4e6b287881 Remove some more 'dynamic's 2016-03-14 11:11:41 -07:00
Adam Barth
d5b2e2a01c [rename fixit] Flex alignments
* justifyContent -> mainAxisAlignment
* alignItems -> crossAxisAlignment
* FlexJustifyContent -> MainAxisAlignment
* FlexAlignItems -> CrossAxisAlignment

Fixes #231
2016-03-12 18:33:47 -08:00
Adam Barth
5e1af2f37e [rename fixit] DismissDirection left -> endToStart, right -> startToEnd
Removes an LTR bias in DismissDirection.

Fixes #2562
2016-03-12 18:33:47 -08:00
Adam Barth
e48c822ce3 [rename fixit] left -> leading, right -> trailing
The terms "left" and "right" have an LTR bias. Instead, we now use
"leading" and "trailing", for these list and grid decorations so that
we can later rearrange them to match the reading order.

Fixes #2540
Fixes #2548
2016-03-12 17:31:01 -08:00
Adam Barth
9b9ad3db17 [rename fixit] RouteBuilder -> BuildContext
Fixes #2353
2016-03-12 17:18:31 -08:00
Adam Barth
95fc5ae070 [rename fixit] *Component* -> *Widget*
This patch renames StatelessComponent to StatelessWidget and
StatefulComponent to StatefulWidget.

Fixes #2308
2016-03-12 12:34:05 -08:00
Adam Barth
726eff4953 [rename fixit] *OneChild* -> *SingleChild*
Fixes #1482
2016-03-12 12:33:39 -08:00
Adam Barth
e71bd77e4f [rename fixit] EdgeDims -> EdgeInsets
Fixes #1382
2016-03-12 12:33:38 -08:00
Adam Barth
e9b8f4450b [rename fixit] scrollDirection -> mainAxis
Fixes #581
2016-03-12 11:35:24 -08:00
Adam Barth
19f615fc2f [rename fixit] MultiChildLayoutDelegate#isChild -> hasChild
Fixes #459
2016-03-12 11:13:10 -08:00
Hixie
6795efacab Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-12 00:37:31 -08:00