240 Commits

Author SHA1 Message Date
Jason Simmons
4836cde8d3 Improve performance of Locale.toString (flutter/engine#7990)
Use a map instead of a switch to replace deprecated language and country codes.
Also cache the result for the most recently used locale.
2019-02-27 14:41:58 -08:00
Jonah Williams
5a03c42aae Switch flutter's dart sdk to full and add dartdevc libraries (flutter/engine#7968) 2019-02-26 14:49:09 -08:00
Jason Simmons
f6e50eebfd Update licenses for the switch away from the Wuffs GIF decoder (flutter/engine#7786) 2019-02-11 11:41:21 -08:00
Michael Klimushyn
f81154f9f3 Don't use Wuffs (flutter/engine#7785)
This code path isn't stable yet.

Fixes flutter/flutter#27718
Reopens flutter/flutter#23838
2019-02-11 11:09:45 -08:00
Dan Field
6c9922b776 allow specifying out directory root (flutter/engine#7753) 2019-02-08 15:15:47 -08:00
Dan Field
021996ff8d use correct no-download-badge (flutter/engine#7735) 2019-02-07 15:15:41 -08:00
liyuqian
0aa9535b36 Disable wuff on Windows (flutter/engine#7713)
MSVC won't compile wuff...
2019-02-06 11:52:25 -08:00
Jason Simmons
a9c3e82bc8 Use the Wuffs GIF decoder (flutter/engine#7658)
Fixes https://github.com/flutter/flutter/issues/23838
2019-02-05 14:09:18 -08:00
liyuqian
074cda1d2e Respect default goma path on Windows (flutter/engine#7643) 2019-01-30 13:00:34 -08:00
Dan Field
8a5344f0ce Check in GEM_HOME for jazzy (flutter/engine#7628)
* Check in GEM_HOME for jazzy
2019-01-29 13:01:35 -08:00
Chinmay Garde
3407c73dbd Allow generating coverage reports for all unit-tests in the engine. (flutter/engine#7576) 2019-01-24 14:03:15 -08:00
Dan Field
1b3d586cfe Roll buildroot and update method of getting android SDK and support libs (flutter/engine#7284)
* Get support, use new SDK tooling from buildroot
* Roll NDK to 19
* Skip Android bits on Windows with note
2019-01-18 15:20:56 -08:00
Vyacheslav Egorov
692952dfd0 Pass operator_new_alignment value through gn script into GN args. (flutter/engine#7031)
Background:

Some allocators (tcmalloc) don't provide alignment guarantees that
match clang's default expectations, which causes crashes when using
clang compiled binary with such allocators.

For example clang can produce movaps instructions to initialize newly
allocated object - which would crash if result of ::operator new() is
not 16 bytes aligned.
2019-01-15 16:09:46 +01:00
Chris Bracken
e82a699995 [License] Enable avoid_positional_boolean_parameters lint (flutter/engine#7275) 2018-12-20 16:05:43 -08:00
Chris Bracken
d4ea07a082 [License] Sync analysis_options.yaml from framework (flutter/engine#7273)
Updates to the framework analysis_options.yaml, but enables a few more lints that
  (a) seem sensible and
  (b) don't require any code changes.
2018-12-20 15:36:35 -08:00
Chris Bracken
ed84026a81 [License] Enable always_require_non_null_named_parameters
Adds dependency on package:meta.
2018-12-20 14:56:23 -08:00
Chris Bracken
31e171846d [License] Enable flutter_style_todos lint 2018-12-20 14:56:23 -08:00
Chris Bracken
3c70c53b6e [License] Enable prefer_is_empty lint 2018-12-20 14:56:23 -08:00
Chris Bracken
3d8a5ecb8d [License] Enable prefer_const_constructors lint 2018-12-20 14:56:23 -08:00
Chris Bracken
153e071ef9 [License] Enable unnecessary_parenthesis lint 2018-12-20 14:56:23 -08:00
Chris Bracken
bdfdae4abb [License] Enable prefer_initializing_formals lint 2018-12-20 14:56:23 -08:00
Chris Bracken
ddbe4bf456 [License] Enable prefer_collection_literals lint 2018-12-20 14:56:23 -08:00
Chris Bracken
dcdbeeba3e [License] Enable prefer_void_to_null lint 2018-12-20 14:56:23 -08:00
Chris Bracken
41ac8b88ec [License] Enable directives_ordering lint 2018-12-20 14:56:23 -08:00
Chris Bracken
8f2171b00f [License] Enable unnecessary_overrides lint 2018-12-20 14:56:23 -08:00
Chris Bracken
dabdcc19a7 [License] Enable avoid_function_literals_in_foreach_calls lint 2018-12-20 14:56:23 -08:00
Chris Bracken
b5e7301452 [License] Enable prefer_const_declarations lint 2018-12-20 14:56:23 -08:00
Chris Bracken
9fcc2f0a94 [License] Enable prefer_final_fields lint 2018-12-20 14:56:23 -08:00
Chris Bracken
daa400f0ef [License] Enable prefer_asserts_in_initializer_lists lint 2018-12-20 14:56:23 -08:00
Chris Bracken
7f63386418 [License] Enable prefer_equal_for_default_values lint 2018-12-20 14:56:23 -08:00
Chris Bracken
4e9eed6141 [License] Enable empty_catches lint 2018-12-20 14:56:23 -08:00
Chris Bracken
f1d81a6960 [License] Enable unnecessary_this lint 2018-12-20 14:56:23 -08:00
Chris Bracken
5fd7a23242 [License] Enable prefer_single_quotes lint 2018-12-20 14:56:23 -08:00
Chris Bracken
33a144cbc5 [License] Assert license filename is non-null, non-empty (flutter/engine#7270) 2018-12-20 13:50:21 -08:00
Chris Bracken
16949aab71 [License] Eliminate duplicate case in switch (flutter/engine#7269)
This changes behaviour, but we should treat diffs as binary for the
reasons outlined in the comment on the remaining diff case.
2018-12-20 13:22:30 -08:00
Chris Bracken
a3bb2045a4 Mark all unreassigned locals final in license tool (flutter/engine#7267)
Marks locals final where possible, and enables the prefer_final_locals
lint.
2018-12-20 12:27:50 -08:00
Chris Bracken
30f4d14d6b Eliminate use of new keyword in licence tool (flutter/engine#7266)
This eliminates the use of the now-optional new keyword and enforces the
unnecessary_new lint.
2018-12-20 11:29:28 -08:00
Chris Bracken
7c7a5cc412 Re-run license tool on all source when it changes (flutter/engine#7260)
The license tool includes an optimization whereby it skips re-running on
components (flutter, third_party, skia, currently) when it detects that
no changes have occurred to the sources in that component.

When the license script itself changes, we now force re-run it on all
components in order to verify the tool still works and output is as
expected.
2018-12-19 23:15:44 -08:00
Dan Field
e12c087f9e Fix javadoc for Android-28 (flutter/engine#7254)
* Fix javadoc for Android-28

* build javadoc as part of pre-submit
2018-12-19 09:24:02 -08:00
Chris Bracken
548657787a Extract function to collect licenses for component (flutter/engine#7250)
Extracts _collectLicensesForComponent() from main, which collects the
licenses for the specified component (e.g. flutter, third_party, skia).

This is pre-factoring related to a fix for flutter/flutter#25519.
2018-12-18 20:08:15 -08:00
Chris Bracken
0435cdb920 Revert spelling correction in licence matcher (flutter/engine#7242)
In 0e73c0f16da78665b8786e0eb559da11b787ae11 (#7179), the word
'publically' was altered to 'publicly', causing the licence aggregator
to fail to match the licence text included in many BoringSSL source
files.

The original licence includes several misspellings (e.g. 'rouines'
rather than 'routines') which we need to faithfully reproduce in our
match regex.

The failure this triggered went unnoticed during pre-/post-submit
due to the fact that the contents of the third_party directory didn't
change, so hash of the list of files used as a signature matched the
signature in the golden file, causing the run to be skipped.
2018-12-17 18:57:04 -08:00
Jimmy Casey
0e73c0f16d Correct spelling in doc comments (flutter/engine#7179)
Applies spelling corrections to accessibility-related doc comments and in the
license tool.
2018-12-16 12:51:00 -08:00
liyuqian
bc52fcc390 Add .woff file to binary format (flutter/engine#7202)
Fixes https://github.com/flutter/flutter/issues/25285
2018-12-12 10:29:02 -08:00
Michael Goderbauer
3b9b551b7d Reland "Compile libcxx and libcxxabi for Android (#6886)" (flutter/engine#7160)
This reverts commit 402e052414bb800a317fea62d411416a9ccb57c4.
2018-12-11 19:20:53 -08:00
Chinmay Garde
557745787e Don't provide system vulkan header paths to Skia. (flutter/engine#7003)
Skia privately brings in its own copy. https://skia-review.googlesource.com/c/skia/+/172147
2018-11-28 15:31:16 -08:00
Michael Goderbauer
1d8a9edcb4 Remove unused code from licenses script (flutter/engine#6910)
Code became obsolete with https://github.com/flutter/engine/pull/3627.

Also fixes mix-in syntax and marks class as private. With the latter the anaylser tells us in the future if there are unused classes in the file.
2018-11-20 12:34:16 -08:00
Michael Goderbauer
f480d3596c Revert "Compile libcxx and libcxxabi for Android (#6886)" (flutter/engine#6912)
This reverts commit 29dd185ae9f5060009c1e7d728b2d4eaa2ed0dac.
2018-11-19 22:19:51 -08:00
Michael Goderbauer
29dd185ae9 Compile libcxx and libcxxabi for Android (flutter/engine#6886) 2018-11-19 20:29:31 -08:00
Jason Simmons
708c487c14 Update Vulkan headers to 1.1 (flutter/engine#6806) 2018-11-09 12:01:57 -08:00
Michael Goderbauer
4e289e704a Delete unused license goldens and add check (flutter/engine#6784) 2018-11-07 13:23:18 -08:00