DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,207 Commits 882 Branches 1,069 Tags
Commit Graph

25939 Commits

Author SHA1 Message Date
Loïc Sharma
f3ad50c810 [Windows] Make the engine create the view (flutter/engine#50673) 
This makes the Windows engine create views. Benefits:

1. This will allow the engine to assign IDs to views as it creates them. This will be added in a subsequent change
2. Previously views needed special logic to not crash if they were used before an engine was attached to them. Now, views are always attached to an engine.

Part of https://github.com/flutter/flutter/issues/137267
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-20 16:41:46 +00:00
skia-flutter-autoroll
4f1b2c05e6 Roll Skia from 2f9bb1517740 to 2dc00a705f1c (2 revisions) (flutter/engine#50782) 
https://skia.googlesource.com/skia.git/+log/2f9bb1517740..2dc00a705f1c

2024-02-20 brianosman@google.com Use SkColor4f in shader luminance color functions
2024-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 01a09793b6e4 to 01c25f446238 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-20 16:23:48 +00:00
skia-flutter-autoroll
e0366fd12d Roll Skia from a76b083ac4cc to 2f9bb1517740 (1 revision) (flutter/engine#50781) 
https://skia.googlesource.com/skia.git/+log/a76b083ac4cc..2f9bb1517740

2024-02-20 sharaks@google.com Update Skia milestone to 124

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-20 15:14:50 +00:00
skia-flutter-autoroll
7bf6f31048 Roll Dart SDK from 8bb8ff24aea3 to f344e2266468 (1 revision) (flutter/engine#50780) 
https://dart.googlesource.com/sdk.git/+log/8bb8ff24aea3..f344e2266468

2024-02-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-157.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-20 14:01:22 +00:00
skia-flutter-autoroll
da4c4e82f3 Roll Skia from ff602d384586 to d448ca514a56 (4 revisions) (flutter/engine#50776) 
https://skia.googlesource.com/skia.git/+log/ff602d384586..d448ca514a56

2024-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cbcd86cee01f to 6564b89238ac
2024-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3527012e3563 to cbcd86cee01f (1 revision)
2024-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d3e0bd4770cc to 4663ec14a251 (5 revisions)
2024-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 13783d616289 to 01a09793b6e4 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-20 06:15:16 +00:00
skia-flutter-autoroll
d7193159fd Roll Fuchsia Linux SDK from HFmcvzkR3TYeHa_0U... to gKg6HlBeR52y-cMhu... (flutter/engine#50771) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-20 03:07:09 +00:00
Jim Graham
7ceed6ac6b [Impeller] Run stroke benchmarks on unclosed paths (flutter/engine#50765) 
The stroking benchmarks were using source paths that were completely closed which means that they were never testing the performance of stroke caps since none would be generated while widening the paths.

All stroking benchmarks are now run against unclosed versions of the paths to provide a mix of caps and joins in the measurements, and the non-stroking benchmarks are now also run against unclosed versions of the paths to add more measurements using the newly available test path data.

This change will affect all of the geometry benchmarks named "stroke_[Curve type]_[Cap]_[Join]". The Round and Square cap benchmarks will be the most affected and for the worse.
 2024-02-19 21:04:22 +00:00
skia-flutter-autoroll
53f43d4885 Roll Dart SDK from 6d659f880394 to 475e710429ee (1 revision) (flutter/engine#50763) 
https://dart.googlesource.com/sdk.git/+log/6d659f880394..475e710429ee

2024-02-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-155.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-19 18:01:23 +00:00
Taha Tesser
393748e8c5 Revert "Fix iOS password autofill prompt dismissal causes layout to resize (#50364)" (flutter/engine#50760) 
This reverts commit 5f93393312241b5616a9253b7bf9cd82b5d77dda.

Reverts https://github.com/flutter/engine/pull/50364

fixes https://github.com/flutter/flutter/issues/143642

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-19 09:36:32 +00:00
skia-flutter-autoroll
24b8456a94 Roll Skia from a4ff02094bbd to 6eaa7cf6d013 (4 revisions) (flutter/engine#50759) 
https://skia.googlesource.com/skia.git/+log/a4ff02094bbd..6eaa7cf6d013

2024-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3ca8befb2412 to e04b7c7392d9 (8 revisions)
2024-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3527012e3563 to cbcd86cee01f
2024-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from cfeca87ea13f to 3527012e3563 (5 revisions)
2024-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d8439c0f5bfa to d3e0bd4770cc (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-19 07:47:28 +00:00
Matan Lurey
cfac6a5d5f Write adb logcat results and screenshots to FLUTTER_LOGS_DIR if able. (flutter/engine#50722) 
Fixes https://github.com/flutter/flutter/issues/143586.

This should make it easier to understand what is/isn't happening, and will unblock https://github.com/flutter/flutter/issues/143458, and make https://github.com/flutter/flutter/issues/143459 potentially easier to debug.
 2024-02-18 20:31:28 +00:00
Brandon DeRosier
ef2a104514 [Impeller] Fix golden flake due to rand use. (flutter/engine#50743) 
Now that we're capturing goldens, we shouldn't use `std::rand` here. Explicitly seeded pseudorandom generators offered by the runtime or STL may also result in flakes as the runtime is updated over time.
 2024-02-17 23:04:23 +00:00
skia-flutter-autoroll
2038bc726f Roll Fuchsia Linux SDK from YN5KCfom7Ax0Z69s_... to uSZ0te7RWVq4IFpjb... (flutter/engine#50746) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-17 21:24:08 +00:00
skia-flutter-autoroll
35632d8cd1 Roll Skia from bb61c2b4614e to 0d2dbf53aef6 (3 revisions) (flutter/engine#50744) 
https://skia.googlesource.com/skia.git/+log/bb61c2b4614e..0d2dbf53aef6

2024-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a8bde474ad6e to 73413fef3ec0 (4 revisions)
2024-02-16 scroggo@google.com SkWuffsCodec: Skip copying stream if PreferStillImage
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cfeca87ea13f to 80035da8ddde

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-17 11:26:55 +00:00
Jonah Williams
4a5c573f14 [Impeller] add additional setup method that caches more pipelines, warms internal shader code (flutter/engine#50521) 
Part of https://github.com/flutter/flutter/issues/138236

Fixes a number of issues related to startup performance by adding an "InitializeCommonlyUsedShadersIfNeeded" method to content context.

On the first frame of a flutter application renders, the backend will populate the glyph atlas for the first time. On the Vulkan backend, this executes vkCmdCopyBufferToImage. The first time this runs, Arm Mali drivers will generate an additional shader program. Creates a 1x1 texture and sets the contents to force this code to compile eagerly.

![image](https://github.com/flutter/engine/assets/8975114/558e7680-77e1-4cec-94d2-17128f4c8865)

The first time a render pass is constructed, a shader is complied. This does not seem to depend on the properties of the render pass, so we just create a trivial one and submit it.

![image](https://github.com/flutter/engine/assets/8975114/4d9c9266-adfb-4d18-84cc-eb60127147ed)

Finally there are a few missing shader variants. Lets just go ahead a populate that cache a bit more
 2024-02-17 05:37:05 +00:00
Brandon DeRosier
ca0765d43a [Impeller] Assign subpass depth on restore rather than creation. (flutter/engine#50626) 
The subpass depth is used for drawing the texture to the parent pass. So it needs a depth > all of the clips contained within the subpass.

Also correct the way we're assigning the depth value in shaders.
 2024-02-17 04:39:13 +00:00
skia-flutter-autoroll
d3c5ebf9cd Roll Dart SDK from fa66195a3814 to 6d659f880394 (1 revision) (flutter/engine#50739) 
https://dart.googlesource.com/sdk.git/+log/fa66195a3814..6d659f880394

2024-02-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-154.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-17 02:01:18 +00:00
Robert Ancell
0c1e0846c0 Connect signals in swapped form. (flutter/engine#50705) 
This makes them look more like methods.
 2024-02-16 17:01:03 -08:00
Jason Simmons
46354c09fe Restore use of the API 34 device in the Firebase Test Lab script and handle FTL infrastructure errors in the script (flutter/engine#50735) 
This test had been temporarily moved to an API 33 device as a workaround for an FTL infrastructure issue (see https://github.com/flutter/engine/pull/50721)

This PR resumes use of a Pixel 8/API 34 device for the FTL tests.  It also retries the test if FTL returns an error code that is known to represent an FTL infrastructure error.  If the retries fail, then the test script will not block the engine tree if all failures were caused by infrastructure.

This is similar to what the CI recipes are doing in https://flutter.googlesource.com/recipes/+/a181878fde742dacd94afca04c5a4db1b3c30b91
 2024-02-17 00:56:05 +00:00
skia-flutter-autoroll
4e8d419e25 Roll Skia from e4e234d412ee to bb61c2b4614e (4 revisions) (flutter/engine#50736) 
https://skia.googlesource.com/skia.git/+log/e4e234d412ee..bb61c2b4614e

2024-02-16 brianosman@google.com Return a luminance color from SkColor4Shader
2024-02-16 kjlubick@google.com Enforce IWYU on misc ganesh files
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 59c02c8da968 to a8bde474ad6e (5 revisions)
2024-02-16 bungeman@google.com [svg] Add offset adjustment once per line

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 23:44:23 +00:00
skia-flutter-autoroll
0446189603 Roll Skia from 6ae5032133d0 to e4e234d412ee (1 revision) (flutter/engine#50733) 
https://skia.googlesource.com/skia.git/+log/6ae5032133d0..e4e234d412ee

2024-02-16 jvanverth@google.com [graphite] Add 4-byte alignment to RasterPathAtlas uploads.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 22:52:24 +00:00
gaaclarke
8515af7ee9 Pulled out dir contents golden tool (flutter/engine#50703) 
fixes https://github.com/flutter/flutter/issues/143459

This also starts using it as part of scenario_app.

Testing: Is part of the testing infrastructure.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-16 22:18:05 +00:00
skia-flutter-autoroll
85129f0e30 Roll Dart SDK from 21b9ee6f0a52 to fa66195a3814 (3 revisions) (flutter/engine#50732) 
https://dart.googlesource.com/sdk.git/+log/21b9ee6f0a52..fa66195a3814

2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-153.0.dev
2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-152.0.dev
2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-151.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 22:04:14 +00:00
skia-flutter-autoroll
a0aba8e2ce Roll Skia from 2919d86cad12 to 6ae5032133d0 (8 revisions) (flutter/engine#50729) 
https://skia.googlesource.com/skia.git/+log/2919d86cad12..6ae5032133d0

2024-02-16 lovisolo@google.com [bazel] Rewrite Android benchmark tests to depend on the modular build.
2024-02-16 kjlubick@google.com Add #ifdef guards to headers to avoid double-declarations
2024-02-16 lovisolo@google.com [bazel] Rewrite benchmark tests to depend on the modular build.
2024-02-16 kjlubick@google.com Remove SkWuffsCodec.h
2024-02-16 bungeman@google.com Enable skia_use_libgrapheme on jobs
2024-02-16 lovisolo@google.com [bazel] BazelBenchmarkTestRunner.cpp: Various cleanups.
2024-02-16 lovisolo@google.com [bazel] GaneshBenchmarkTarget.cpp: Fix outdated enum.
2024-02-16 johnstiles@google.com Reduce single-component swizzles to an unmasked copy.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 21:27:59 +00:00
Jackson Gardner
b8d198edc2 Temporarily disable goldens for Safari. (flutter/engine#50724) 
Safari is producing too many golden diffs. See https://github.com/flutter/flutter/issues/143591. This disables them for now to stop the noise, but we should look into a longer term solution.
 2024-02-16 21:14:10 +00:00
Martin Kustermann
0e6ffa7346 [web] Remove unused allowInterop usage in flutter web code (flutter/engine#50718) 
The CLs that migrated to static interop forgot to update the
corresponding comments regarding the need to use `allowInterop`.

The re-exported `allowInterop` function happened in an internal library
(not exposed via `dart:ui*`) and was unused.

Issue https://github.com/dart-lang/sdk/issues/54908
 2024-02-16 21:46:42 +01:00
Jonah Williams
0b9a9d6d1d [Impeller] use fewer threads for shader bootstrap workers on low core machines. (flutter/engine#50726) 
Part of https://github.com/flutter/flutter/issues/143540

We were using 4 threads for shader bootstrap on a device with only 4 cores. Using fewer threads seems to improve performance on fewer core machines.
 2024-02-16 20:34:21 +00:00
Michael Goderbauer
da30adfc6f Fix implementation imports outside of lib (flutter/engine#50727) 
Work towards https://github.com/dart-lang/linter/issues/4859

There are libraries outside a `lib/` directory, which violate `implementation_imports`.
 2024-02-16 20:19:33 +00:00
skia-flutter-autoroll
9176419d68 Roll Skia from 87e8e9c8f42b to 2919d86cad12 (8 revisions) (flutter/engine#50723) 
https://skia.googlesource.com/skia.git/+log/87e8e9c8f42b..2919d86cad12

2024-02-16 bungeman@google.com [skunicode] libgrapheme accumulate line break pos
2024-02-16 johnstiles@google.com Allow sk_Caps in private runtime effects.
2024-02-16 brianosman@google.com Remove AVX2 slice of BitmapProcState_opts
2024-02-16 johnstiles@google.com Use immediate-mode binary ops for two-slot arithmetic.
2024-02-16 kjlubick@google.com Remove extraneous SK_API from SkFontMgr_custom_empty.cpp
2024-02-16 michaelludwig@google.com Revert "[skif] Track padding around FilterResult images"
2024-02-16 kjlubick@google.com Address a few clang-tidy suggestions
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c2c1bfb03bd7 to 59c02c8da968 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 18:50:23 +00:00
skia-flutter-autoroll
f5d36627c4 Roll Dart SDK from 947c8c487e28 to 21b9ee6f0a52 (2 revisions) (flutter/engine#50717) 
https://dart.googlesource.com/sdk.git/+log/947c8c487e28..21b9ee6f0a52

2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-150.0.dev
2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-149.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 18:01:07 +00:00
skia-flutter-autoroll
6da068b6bd Roll Skia from c89a4cd72308 to 87e8e9c8f42b (3 revisions) (flutter/engine#50716) 
https://skia.googlesource.com/skia.git/+log/c89a4cd72308..87e8e9c8f42b

2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e53270c9ca1a to 3ca8befb2412 (20 revisions)
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6ca8603c26c8 to cfeca87ea13f (3 revisions)
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2def6c361471 to d8439c0f5bfa (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 17:53:38 +00:00
skia-flutter-autoroll
19f9409aa6 Roll Fuchsia Linux SDK from fXqP_YC4zTp9G2hA5... to YN5KCfom7Ax0Z69s_... (flutter/engine#50719) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 17:47:29 +00:00
Jason Simmons
84ce5f16aa Use the Pixel 7/API 33 device in the Firebase test lab script (flutter/engine#50721) 
This test is currently failing consistently when running with Pixel 8/API 34
 2024-02-16 17:27:13 +00:00
Bruno Leroux
4b5c993fe4 [Web] Ignore invalid keyboard events related to autofill (flutter/engine#50590) 
## Description

This PR fixes an 'Unexpected null value' error related to autoFill.
When using Autofill feature, Chrome emits keyboard events whose `event.code` and `event.key` are null.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/114620.

## Tests

Adds 1 test.
 2024-02-16 07:04:48 +00:00
Jason Simmons
ea6b80144d Add the web package to the set of Dart third_party packages in DEPS (flutter/engine#50714) 
Dart is rolling the http package to a version that depends on the web package. (see https://dart.googlesource.com/http/+/d8b237d273f49bada2aa7feaa0e7795e2541fe83)
 2024-02-16 06:54:49 +00:00
skia-flutter-autoroll
1c47705918 Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709) 
https://dart.googlesource.com/sdk.git/+log/9bbac4d40725..947c8c487e28

2024-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-148.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 01:47:19 +00:00
Loïc Sharma
89b44f4fff [Windows] Improve FlutterWindow unit tests (flutter/engine#50676) 
_This was split from https://github.com/flutter/engine/pull/50673 to reduce noise in that PR._

Previously `MockFlutterWindow` called a `FlutterWindow` constructor which created a window & resized it. This change introduces a minimal base constructor for testing purposes. This allows us to skip some noisy mocks in a subsequent change: https://github.com/flutter/engine/pull/50673

This also introduces a fixture for the window unit tests.

Part of https://github.com/flutter/flutter/issues/137267
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-16 00:38:18 +00:00
Zachary Anderson
80076b93fb [et] Adds a logger (flutter/engine#50693) 2024-02-16 00:22:54 +00:00
Matan Lurey
d99aee7142 Update README.md (flutter/engine#50702) 
Oopsie.
 2024-02-15 15:38:20 -08:00
skia-flutter-autoroll
58f6902888 Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704) 
https://skia.googlesource.com/skia.git/+log/078b316e0563..3cbb5d6a71fe

2024-02-15 jvanverth@google.com [graphite] Fill out SmallPathAtlas.
2024-02-15 weiyuhuang@google.com Strut Half Leading Attempt 2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 22:54:33 +00:00
Juanjo Tugores
ec948a8b48 Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608) 
Move the accesibility placeholder to the platform dispatcher.

This change makes the platform dispatcher append a single accesibility placeholder, per app, to the `<body />`. Previous behavior was to insert a placeholder inside each `<flutter-view />`

Relevant Issues are:

* Design doc: https://flutter.dev/go/focus-management 
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443
* Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 22:07:58 +00:00
skia-flutter-autoroll
403c2a297c Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700) 
https://skia.googlesource.com/skia.git/+log/a8e4db1afac5..078b316e0563

2024-02-15 lovisolo@google.com [bazel] GaneshGLSurfaceManager: Fix sample counts in configs.
2024-02-15 michaelludwig@google.com [skif] Track padding around FilterResult images
2024-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 16c7058465af to c2c1bfb03bd7 (2 revisions)
2024-02-15 lovisolo@google.com [bazel] BazelGMTestRunner.cpp: Add --knownDigestsFile flag.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 21:58:36 +00:00
skia-flutter-autoroll
fd7318004a Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699) 
https://dart.googlesource.com/sdk.git/+log/5e442dc80903..9bbac4d40725

2024-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-147.0.dev
2024-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-146.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 21:55:40 +00:00
Rulong Chen（陈汝龙）
8d744a5fbe [Android] Remove the unnecessary parent interface. (flutter/engine#50677) 
`ImageConsumer` and `GLTextureConsumer` should not inherit from `TextureEntry`.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 21:49:54 +00:00
Brandon DeRosier
5b42e9e87e [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698) 
So that it's easy to determine whether the playground test itself caused the failure or not.
 2024-02-15 21:32:13 +00:00
skia-flutter-autoroll
18a6a57cff Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696) 
https://skia.googlesource.com/skia.git/+log/6ee2b5f61ae5..a8e4db1afac5

2024-02-15 kjlubick@google.com Move GrBackendDrawableInfo to Vulkan subfolder
2024-02-15 brianosman@google.com Add --runtimeCPUDetection to nanobench
2024-02-15 dtapuska@chromium.org Fix iOS 17.4 SDK build failure
2024-02-15 kjlubick@google.com Skip Name.json in SkottieWasm perf test
2024-02-15 jvanverth@google.com Remove MtlIsAppInBackground.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 20:50:22 +00:00
zijiehe@
4c418e9452 [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 
This change replicas https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20arm64%20FEMU and runs tests on simulated arm64 on x64. E.g. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/1994921/overview
or more accurately, https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756061244290412945/+/u/test:_arm64_emulator_based_debug_tests/stdout

The vulkan tests are excluded, qemu does not support vulkan.
The display_list_render_tests is excluded as it's way too slow (over 400 seconds).

After this change, comparing to femu_test.py, the only missing case is the dart-aot-runner-integration-test which is executed in fuchsia_profile_x64 anyway. It needs `--no-lto` in fuchsia_profile_arm64. I may need to confirm if the fuchsia_profile_arm64 build is used in fuchsia or the fuchsia_release_arm64.

Bug: https://github.com/flutter/flutter/issues/140179

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 20:22:23 +00:00
gaaclarke
7d9ad5606f [Impeller] Updated benchmarks (flutter/engine#50694) 
Looks like we changed devices sometime in august.  This mostly switches comparisons from using Samsung galaxy 10 to pixel 7 pro.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 19:28:17 +00:00
godofredoc
b6753d492b Documentation for test timeouts. (flutter/engine#50687) 
Support for test timeouts was added on the engine v2 recipes and this is documenting the new properties in build tests and global tests configurations.

Bug: https://github.com/flutter/flutter/issues/143021

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 19:09:56 +00:00
Zachary Anderson
8ed833927f Shift some Linux builders from Goma to RBE (flutter/engine#50653) 
This PR shifts all Linux builders except for linux_fuchsia and
linux_clang_tidy from GOMA to RBE. It also shifts one build from another
builder to linux_unopt.
 2024-02-15 10:42:43 -08:00