52 Commits

Author SHA1 Message Date
Siva
11b6afe00c
Roll src/third_party/dart 67ab3be10d...b5aeaa6796 (#9675)
* Roll src/third_party/dart 67ab3be10d...b5aeaa6796

dart-lang/sdk@b5aeaa6796 Revert "Reland "[vm/ffi] SimDBC on Arm64 Android""
dart-lang/sdk@02fe07bbd3 [dart2js] new-rti: Set Array instance type
dart-lang/sdk@bae5bdefd5 [dart2js] Add '--golem-x' command-line flag
dart-lang/sdk@ac30ab12ab [dartdevc] Bump pedantic to v1.8.0 and apply new lints
dart-lang/sdk@4b0c5c166a fix field name
dart-lang/sdk@327f5eb826 Fix for issue 37429
dart-lang/sdk@43891316ca [ VM / Observatory ] Emit IsolateReload event after reload completes
dart-lang/sdk@2ea7e5513b Perform type promotion when NNBD, using flow analysis.
dart-lang/sdk@766e542e53 handle return in async function
dart-lang/sdk@51cf8f218a Add entension support to the summary idl
dart-lang/sdk@0e9957c7b1 [dartdevc] Adding support for analyzer dep pruning
dart-lang/sdk@c100308ba6 Repro for inferring arrays with out of range lengths
dart-lang/sdk@5d77657e7a Prepare to publish analyzer version 0.37.0.
dart-lang/sdk@86ce74caaa update NodeBuilder for default value type arguments
dart-lang/sdk@439692c9e2 Mark the name in an extension as being in a declaration context
dart-lang/sdk@372bcae536 [gardening] Fix 3xHEAD Flutter build after revert
dart-lang/sdk@052874e93e Avoid non-web integer literal in corelib_2/int_round_test
dart-lang/sdk@480337106e Implementation of extension override AST node
dart-lang/sdk@4f78ad90df An initial and partial implementation of an element model for extensions
dart-lang/sdk@744bb47361 [infra] Remove custom timeouts for dart2js compiler config
dart-lang/sdk@9b53686ffb update NodeBuilder for declared identifier implicit type
dart-lang/sdk@3d14b75f97 Revert "Reland "[vm/concurrency] Introduce concept of Isolate Groups""
dart-lang/sdk@527238e008 [vm] Cleanup C99 header includes
dart-lang/sdk@9f32f9b87e [cfe] Store the initializer tokens in constructor builders
dart-lang/sdk@bbbeb8b509 Pull in latest pub
dart-lang/sdk@851958ee54 update NodeBuilder to handle for loop
dart-lang/sdk@7a73682c6a update NodeBuilder to handle catch clause
dart-lang/sdk@fc6cb0ac21 [vm/ffi] Revamp struct representation in FFI.
dart-lang/sdk@5fd51b9fd2 Cleanup remnants of ignoring Dart v1.x subtype checks
dart-lang/sdk@45172f0690 Revert "Reland "[llvm] Add initial scaffolding""
dart-lang/sdk@b9a6630367 [ Observatory ] _getVMTimeline -> getVMTimeline in timeline.js
dart-lang/sdk@1f02c10b9a Update language_2/const_map4_test for type inference
dart-lang/sdk@99ed4871b3 Fix a hint in analysis server
dart-lang/sdk@c3c43689d5 [vm] Remove platform/math.h
dart-lang/sdk@524fdc13a9 Reland "[llvm] Add initial scaffolding"
dart-lang/sdk@45a9815aff [vm/debugger] break on asyncfunction entry
dart-lang/sdk@e0eeffaf9b update NodeBuilder parameter tracking when visiting executable declarations
dart-lang/sdk@182a59cebb Skip all tests that use spawnUri when running in simulator mode as it makes no sense to run the CFE on the simulator.
dart-lang/sdk@1427a218f3 update DecoratedType asserts
dart-lang/sdk@f4dc001729 Migration: begin adding support for LUB computations in conditional expressions.
dart-lang/sdk@585794ab75 Fix status file line.
dart-lang/sdk@4a69ef4a50 Skip all spawnURI tests for the simulator architectures as these tests involve invoking the front end for compilation which would mean the front end has to run in simulated mode.
dart-lang/sdk@26f369eb8e Fix doc comment for NullabilityNode.forLUB
dart-lang/sdk@9ed728ec7a Add: Example usage to fillRange method.
dart-lang/sdk@fc7049ae7d Migration: implement support for user-definable prefix expressions.
dart-lang/sdk@77aa5f0c02 Migration: Add support for function-typed formal parameters.
dart-lang/sdk@326e970b81 Migration: handle method invocations that resolve to a getter.
dart-lang/sdk@822de210b5 fix branch_canonicalization_test
dart-lang/sdk@a2e1434603 Breaking changes for analyzer version 0.37
dart-lang/sdk@6694aa821d [dart2js] new-rti: Temporary work-around for timeouts
dart-lang/sdk@18ff5ce893 [dart2js] new-rti: Implement general As/Check methods
dart-lang/sdk@90c88d984e Fix large integer literals in dart2js_extra/round_constant_folding_test
dart-lang/sdk@9349f71721 bump linter to 0.1.93
dart-lang/sdk@c384212f9e [vm] Remove vestigial verified_memory_test.cc file
dart-lang/sdk@f4824d332d [vm] Drop support for MSVC older than 2013
dart-lang/sdk@bbb027aa2a [vm] Fix offset that was breaking bare_instructions_trampolines_test
dart-lang/sdk@1db0b4436c [dart2js] new-rti: Implement type bounds check
dart-lang/sdk@686742585a Migration: add a more robust assertion to the DecoratedType constructor
dart-lang/sdk@2fd4ca570b set DecoratedType.returnType for FunctionType
dart-lang/sdk@ca4b6e533a [dart2js] new-rti: Implement basic is-test
dart-lang/sdk@39b71253ce Fix for curly_braces_in_flow_control_structures lint.
dart-lang/sdk@b6c3b2c98c Enable 'Surround with XYZ' only for Statement(s) in Block(s).
dart-lang/sdk@79e478e50e Fixed some links
dart-lang/sdk@279c1da42d Use absolute paths as canonical paths for inputs digest maps
dart-lang/sdk@cbf9cff19f Infer types of field formals before all fields.
dart-lang/sdk@0c6b3d1277 Migration: do better function type formatting in DecoratedType.toString.
dart-lang/sdk@a76c459239 Migration: Remove unnecessary duplicate type test
dart-lang/sdk@a515a0c256 Reland "[vm/ffi] SimDBC on Arm64 Android"
dart-lang/sdk@0baf81e7d6 Tests for Never and potential nullable / non-nullable.
dart-lang/sdk@26d308aad3 Use flow analysis for reporting use sites of not assigned locals during resolution.
dart-lang/sdk@79f276e07d Migration: handle field formal parameters.
dart-lang/sdk@c8c3572ca9 Migration: standardize method names in EdgeBuilderTest.
dart-lang/sdk@c0c15c1283 Migration: build nullability node for default type parameter bounds directly.
dart-lang/sdk@b57ff85906 Migration: clean up and test implicit dynamic return type of Function() syntax.
dart-lang/sdk@0f2eda8644 Migration: add support for function expression invocations.
dart-lang/sdk@a200980da0 Migration: add support for variable and field type inference.
dart-lang/sdk@ca25f56883 Migration: add support for type inference of function types.
dart-lang/sdk@a436c0621f Migration: fix DecoratedType.toString to support named function parameters.
dart-lang/sdk@9dee307bdb Migration: update nullability graph debug dump to support union edges.
dart-lang/sdk@b60dcdbf73 Migration: Remove the `create` parameter from Variables.decoratedElementType.
dart-lang/sdk@18c21ee9d1 Migration: add support for generic instance creation.
dart-lang/sdk@f7ddfdf6ca Migration: don't forget to visit variable initializers in NodeBuilder.
dart-lang/sdk@a39e4fabfb Add information about the deprecated ParameterElement.parameterKind
dart-lang/sdk@f6dfad02f4 [analyzer] add a space to the quick for for REPLACE_COLON_WITH_EQUALS

* Update license.
2019-07-03 19:10:07 -07:00
Siva
3c4dbe223c
Revert " Roll src/third_party/dart 67ab3be10d...43891316ca (#9670)" (#9673)
This reverts commit 5e596f2ac89cf3d665091cbba560ae4961b17848.
2019-07-03 18:08:06 -07:00
Siva
5e596f2ac8
Roll src/third_party/dart 67ab3be10d...43891316ca (#9670)
* Roll src/third_party/dart 67ab3be10d...43891316ca

dart-lang/sdk@/43891316ca [ VM / Observatory ] Emit IsolateReload event after reload completes
dart-lang/sdk@/2ea7e5513b Perform type promotion when NNBD, using flow analysis.
dart-lang/sdk@/766e542e53 handle return in async function
dart-lang/sdk@/51cf8f218a Add entension support to the summary idl
dart-lang/sdk@/0e9957c7b1 [dartdevc] Adding support for analyzer dep pruning
dart-lang/sdk@/c100308ba6 Repro for inferring arrays with out of range lengths
dart-lang/sdk@/5d77657e7a Prepare to publish analyzer version 0.37.0.
dart-lang/sdk@/86ce74caaa update NodeBuilder for default value type arguments
dart-lang/sdk@/439692c9e2 Mark the name in an extension as being in a declaration context
dart-lang/sdk@/372bcae536 [gardening] Fix 3xHEAD Flutter build after revert
dart-lang/sdk@/052874e93e Avoid non-web integer literal in corelib_2/int_round_test
dart-lang/sdk@/480337106e Implementation of extension override AST node
dart-lang/sdk@/4f78ad90df An initial and partial implementation of an element model for extensions
dart-lang/sdk@/744bb47361 [infra] Remove custom timeouts for dart2js compiler config
dart-lang/sdk@/9b53686ffb update NodeBuilder for declared identifier implicit type
dart-lang/sdk@/3d14b75f97 Revert "Reland "[vm/concurrency] Introduce concept of Isolate Groups""
dart-lang/sdk@/527238e008 [vm] Cleanup C99 header includes
dart-lang/sdk@/9f32f9b87e [cfe] Store the initializer tokens in constructor builders
dart-lang/sdk@/bbbeb8b509 Pull in latest pub
dart-lang/sdk@/851958ee54 update NodeBuilder to handle for loop
dart-lang/sdk@/7a73682c6a update NodeBuilder to handle catch clause
dart-lang/sdk@/fc6cb0ac21 [vm/ffi] Revamp struct representation in FFI.
dart-lang/sdk@/5fd51b9fd2 Cleanup remnants of ignoring Dart v1.x subtype checks
dart-lang/sdk@/45172f0690 Revert "Reland "[llvm] Add initial scaffolding""
dart-lang/sdk@/b9a6630367 [ Observatory ] _getVMTimeline -> getVMTimeline in timeline.js
dart-lang/sdk@/1f02c10b9a Update language_2/const_map4_test for type inference
dart-lang/sdk@/99ed4871b3 Fix a hint in analysis server
dart-lang/sdk@/c3c43689d5 [vm] Remove platform/math.h
dart-lang/sdk@/524fdc13a9 Reland "[llvm] Add initial scaffolding"
dart-lang/sdk@/45a9815aff [vm/debugger] break on asyncfunction entry
dart-lang/sdk@/e0eeffaf9b update NodeBuilder parameter tracking when visiting executable declarations
dart-lang/sdk@/182a59cebb Skip all tests that use spawnUri when running in simulator mode as it makes no sense to run the CFE on the simulator.
dart-lang/sdk@/1427a218f3 update DecoratedType asserts
dart-lang/sdk@/f4dc001729 Migration: begin adding support for LUB computations in conditional expressions.
dart-lang/sdk@/585794ab75 Fix status file line.
dart-lang/sdk@/4a69ef4a50 Skip all spawnURI tests for the simulator architectures as these tests involve invoking the front end for compilation which would mean the front end has to run in simulated mode.
dart-lang/sdk@/26f369eb8e Fix doc comment for NullabilityNode.forLUB
dart-lang/sdk@/9ed728ec7a Add: Example usage to fillRange method.
dart-lang/sdk@/fc7049ae7d Migration: implement support for user-definable prefix expressions.
dart-lang/sdk@/77aa5f0c02 Migration: Add support for function-typed formal parameters.
dart-lang/sdk@/326e970b81 Migration: handle method invocations that resolve to a getter.
dart-lang/sdk@/822de210b5 fix branch_canonicalization_test
dart-lang/sdk@/a2e1434603 Breaking changes for analyzer version 0.37
dart-lang/sdk@/6694aa821d [dart2js] new-rti: Temporary work-around for timeouts
dart-lang/sdk@/18ff5ce893 [dart2js] new-rti: Implement general As/Check methods
dart-lang/sdk@/90c88d984e Fix large integer literals in dart2js_extra/round_constant_folding_test
dart-lang/sdk@/9349f71721 bump linter to 0.1.93
dart-lang/sdk@/c384212f9e [vm] Remove vestigial verified_memory_test.cc file
dart-lang/sdk@/f4824d332d [vm] Drop support for MSVC older than 2013
dart-lang/sdk@/bbb027aa2a [vm] Fix offset that was breaking bare_instructions_trampolines_test
dart-lang/sdk@/1db0b4436c [dart2js] new-rti: Implement type bounds check
dart-lang/sdk@/686742585a Migration: add a more robust assertion to the DecoratedType constructor
dart-lang/sdk@/2fd4ca570b set DecoratedType.returnType for FunctionType
dart-lang/sdk@/ca4b6e533a [dart2js] new-rti: Implement basic is-test
dart-lang/sdk@/39b71253ce Fix for curly_braces_in_flow_control_structures lint.
dart-lang/sdk@/b6c3b2c98c Enable 'Surround with XYZ' only for Statement(s) in Block(s).
dart-lang/sdk@/79e478e50e Fixed some links
dart-lang/sdk@/279c1da42d Use absolute paths as canonical paths for inputs digest maps
dart-lang/sdk@/cbf9cff19f Infer types of field formals before all fields.
dart-lang/sdk@/0c6b3d1277 Migration: do better function type formatting in DecoratedType.toString.
dart-lang/sdk@/a76c459239 Migration: Remove unnecessary duplicate type test
dart-lang/sdk@/a515a0c256 Reland "[vm/ffi] SimDBC on Arm64 Android"
dart-lang/sdk@/0baf81e7d6 Tests for Never and potential nullable / non-nullable.
dart-lang/sdk@/26d308aad3 Use flow analysis for reporting use sites of not assigned locals during resolution.
dart-lang/sdk@/79f276e07d Migration: handle field formal parameters.
dart-lang/sdk@/c8c3572ca9 Migration: standardize method names in EdgeBuilderTest.
dart-lang/sdk@/c0c15c1283 Migration: build nullability node for default type parameter bounds directly.
dart-lang/sdk@/b57ff85906 Migration: clean up and test implicit dynamic return type of Function() syntax.
dart-lang/sdk@/0f2eda8644 Migration: add support for function expression invocations.
dart-lang/sdk@/a200980da0 Migration: add support for variable and field type inference.
dart-lang/sdk@/ca25f56883 Migration: add support for type inference of function types.
dart-lang/sdk@/a436c0621f Migration: fix DecoratedType.toString to support named function parameters.
dart-lang/sdk@/9dee307bdb Migration: update nullability graph debug dump to support union edges.
dart-lang/sdk@/b60dcdbf73 Migration: Remove the `create` parameter from Variables.decoratedElementType.
dart-lang/sdk@/18c21ee9d1 Migration: add support for generic instance creation.
dart-lang/sdk@/f7ddfdf6ca Migration: don't forget to visit variable initializers in NodeBuilder.
dart-lang/sdk@/a39e4fabfb Add information about the deprecated ParameterElement.parameterKind
dart-lang/sdk@/f6dfad02f4 [analyzer] add a space to the quick for for REPLACE_COLON_WITH_EQUALS

* Revert changes makde in the engine for the Isolate Group API change.

* Fix compilation error.

* Update license.

* Format.
2019-07-03 17:30:59 -07:00
Chris Bracken
fd24007cac
Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (#9638)
This is a reland of #9364 with fixes for Fuchsia.

000cf0560c clean up type_literal_test
0f20911022 Improve type_literal_test
a108bef7fb [vm, bytecode] Interpreter support for newer recognized natives.
2a15d38759 Revert "[llvm] Add initial scaffolding"
13b470ac46 Parse error expectations in tests.
b71d2d9996 [llvm] Add initial scaffolding
5f2bcd9d6c [vm/bytecode] Reuse flow graph building for recognized methods

This includes a breaking change: https://dart-review.googlesource.com/c/sdk/+/105241
```
  Dart_CreateIsolate -> Dart_CreateIsolateGroup
  Dart_IsolateCreateCallback -> Dart_IsolateGroupCreateCallback
  Dart_IsolateCleanupCallback -> Dart_IsolateGroupShutdownCallback
  Dart_CreateIsolateFromKernel -> Dart_CreateIsolateGroupFromKernel
  Dart_CurrentIsolateData -> Dart_CurrentIsolateGroupData
  Dart_IsolateData -> Dart_IsolateGroupData
  Dart_GetNativeIsolateData -> Dart_GetNativeIsolateGroupData
  Dart_InitializeParams.create -> Dart_InitializeParams.create_group
  Dart_InitializeParams.cleanup -> Dart_InitializeParams.shutdown_group
  Dart_InitializeParams.shutdown -> Dart_InitializeParams.shutdown_isolate
```
2019-07-01 15:47:49 -07:00
Chris Bracken
64b9eef5c1
Revert "Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (#9634)" (#9637)
This broke the Fuchsia build.

This reverts commit 45e1ad27400d5d48941ebffc76537aae11af9ea8.
2019-07-01 14:28:35 -07:00
Chris Bracken
45e1ad2740
Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (#9634)
000cf0560c clean up type_literal_test
0f20911022 Improve type_literal_test
a108bef7fb [vm, bytecode] Interpreter support for newer recognized natives.
2a15d38759 Revert "[llvm] Add initial scaffolding"
13b470ac46 Parse error expectations in tests.
b71d2d9996 [llvm] Add initial scaffolding
5f2bcd9d6c [vm/bytecode] Reuse flow graph building for recognized methods

This includes a breaking change: https://dart-review.googlesource.com/c/sdk/+/105241
```
  Dart_CreateIsolate -> Dart_CreateIsolateGroup
  Dart_IsolateCreateCallback -> Dart_IsolateGroupCreateCallback
  Dart_IsolateCleanupCallback -> Dart_IsolateGroupShutdownCallback
  Dart_CreateIsolateFromKernel -> Dart_CreateIsolateGroupFromKernel
  Dart_CurrentIsolateData -> Dart_CurrentIsolateGroupData
  Dart_IsolateData -> Dart_IsolateGroupData
  Dart_GetNativeIsolateData -> Dart_GetNativeIsolateGroupData
  Dart_InitializeParams.create -> Dart_InitializeParams.create_group
  Dart_InitializeParams.cleanup -> Dart_InitializeParams.shutdown_group
  Dart_InitializeParams.shutdown -> Dart_InitializeParams.shutdown_isolate
```
2019-07-01 12:55:57 -07:00
Jason Simmons
ea7ca9804a
Send the isolate service ID from the engine to the embedder (#9324)
Applications can use an embedder API to obtain the isolate ID and then use it
in calls to the Dart service protocol.
2019-06-17 16:02:26 -07:00
Zachary Anderson
3a29e6a7a7
Plumb arguments from Settings to Dart main() (#8710) 2019-04-25 07:57:54 -07:00
Chinmay Garde
1239df96aa
Allow native bindings in secondary isolates. (#8658)
The callbacks can be wired in via the Settings object. Both runtime and shell unit-tests have been patched to test this.
2019-04-19 17:36:36 -07:00
Chinmay Garde
eec74e5c92
Rename the blink namespace to flutter. (#8517)
Some components in the Flutter engine were derived from the forked blink codebase. While the forked components have either been removed or rewritten, the use of the blink namespace has mostly (and inconsistently) remained. This renames the blink namesapce to flutter for consistency. There are no functional changes in this patch.
2019-04-09 12:44:42 -07:00
Chinmay Garde
424045c3f2
Enable shutting down all root isolates in a VM. (#8457)
This reverts commit 800ea0a40397d53311715e0de94f0340195bfcea.
2019-04-05 13:34:40 -07:00
Chinmay Garde
800ea0a403
Revert "Enable shutting down all root isolates in a VM. (#8402)" (#8431)
This reverts commit b59c4436ce9fb8aa09bad6eb5ca729350a3ab272.
2019-04-03 17:08:56 -07:00
Chinmay Garde
b59c4436ce
Enable shutting down all root isolates in a VM. (#8402) 2019-04-03 15:44:29 -07:00
Chinmay Garde
7e38b0aa23
Revert "Revert "Separate the data required to bootstrap the VM into its own class. (#8397)" (#8406)" (#8414)
This reverts commit f7b4903d7c9913447af3aaebc4308d1a1e2a4dde.
2019-04-03 13:38:12 -07:00
Zachary Anderson
f7b4903d7c
Revert "Separate the data required to bootstrap the VM into its own class. (#8397)" (#8406)
This reverts commit c991647404f8117dab2ca4ed49aa3ba48a634240.
2019-04-02 09:12:56 -07:00
Chinmay Garde
c991647404
Separate the data required to bootstrap the VM into its own class. (#8397)
When attempting to shutdown and subsequently restart the VM, having the
VM own this data introduces lifecycle issues due to circular references.
2019-04-01 14:58:05 -07:00
Chinmay Garde
131cc625a1
Allow native entrypoint registration for runtime unittests. (#8379) 2019-03-29 17:53:49 -07:00
Ben Konyi
f521df3839
Fixed service isolate not being initialized correctly due to bad name (#8251)
* Fixed service isolate not being initialized correctly due to bad name

The name for the service isolate was being set to the empty string,
causing the microtask loop to not be run on the service isolate leading
to the service hanging on the first 'await'. See
https://dart-review.googlesource.com/c/sdk/+/97107 for revert due to
this issue.

* Removed unnecessary params from DartCreateAndStartServiceIsolate
2019-03-26 14:36:51 -07:00
Dan Field
572fea361c
Revert "Shut down and restart the Dart VM as needed. (#7832)" (#7877)
This reverts commit 0d6ff1669c4a765774b91e37353b4392408d112a.
2019-02-19 16:14:18 -08:00
Chinmay Garde
0d6ff1669c
Shut down and restart the Dart VM as needed. (#7832)
The shell was already designed to cleanly shut down the VM but it couldnt
earlier as |Dart_Initialize| could never be called after a |Dart_Cleanup|. This
meant that shutting down an engine instance could not shut down the VM to save
memory because newly created engines in the process after that point couldn't
restart the VM. There can only be one VM running in a process at a time.

This patch separate the previous DartVM object into one that references a
running instance of the DartVM and a set of immutable dependencies that
components can reference even as the VM is shutting down.

Unit tests have been added to assert that non-overlapping engine launches use
difference VM instances.
2019-02-15 14:16:17 -08:00
Chinmay Garde
23b7e29f04
Re-land "Wrap the user entrypoint function in a zone with native exception callback. (#7512)" (#7551)
This reverts commit 4c135c298a8173bb9affafc1f92120a0158c1e6e and applies relevant fixes.
2019-01-24 13:42:51 -08:00
Vyacheslav Egorov
4c135c298a
Revert "Wrap the user entrypoint function in a zone with native exception callback. (#7512)" (#7522)
This reverts commit 25559ed0779604d56c47c5d2341ffd16b137cd10.

Reason for revert: broken in AOT mode.

@pragma('vm:entry-point') placed on a function only instructs
the compiler to retain the function itself, but does not tell
compiler to generate and retain tear-off for this function.

In this PR _runMainZoned was marked as an entry-point but C++
code was trying to tear it off and use a closure, instead of
invoking it directly, which is not supported.
2019-01-17 11:49:20 +01:00
Chinmay Garde
25559ed077
Wrap the user entrypoint function in a zone with native exception callback. (#7512) 2019-01-16 16:08:51 -08:00
Dan Field
43fa420b04
Make IOManager own resource context (#7272)
* Make IOManager own resource context
2019-01-14 13:46:38 -08:00
Alexander Aprelev
14ee957fb4
Set up secondary isolates with all kernel buffers rather than just one buffer. (#6832)
* Set up secondary isolates with all kernel buffers rather than just one buffer.
* Capture copy of the list
* Make sure child_isolate_preparer_ is initialized only once
2018-11-14 09:50:42 -08:00
Michael Goderbauer
09ef73ff6e
Fix code smells reported by chrome's clang plugin (#6833) 2018-11-12 19:59:29 -08:00
Michael Goderbauer
70a1106b50
Unify copyright lines (#6757) 2018-11-07 12:24:35 -08:00
Chinmay Garde
20c805c973
Ensure that Scene::toImage renders texture backed images. (#6636)
TL;DR: Offscreen surface is created on the render thread and device to host
transfer performed there before task completion on the UI thread.

While attempting to snapshot layer trees, the engine was attempting to use the
IO thread context. The reasoning was that this would be safe to do because any
textures uploaded to the GPU as a result of async texture upload would have
originated from this context and hence the handles would be valid in either
context. As it turns out, while the handles are valid, Skia does not support
this use-case because cross-context images transfer ownership of the image from
one context to another. So, when we made the hop from the UI thread to the IO
thread (for snapshotting), if either the UI or GPU threads released the last
reference to the texture backed image, the image would be invalid. This led to
such images being absent from the layer tree snapshot.

Simply referencing the images as they are being used on the IO thread is not
sufficient because accessing images on one context after their ownership has
already been transferred to another is not safe behavior (from Skia's
perspective, the handles are still valid in the sharegroup).

To work around these issues, it was decided that an offscreen render target
would be created on the render thread. The color attachment of this render
target could then be transferred as a cross context image to the IO thread for
the device to host tranfer.

Again, this is currently not quite possible because the only way to create
cross context images is from encoded data. Till Skia exposes the functionality
to create cross-context images from textures in one context, we do a device to
host transfer on the GPU thread. The side effect of this is that this is now
part of the frame workload (image compression, which dominate the wall time,
is still done of the IO thread).

A minor side effect of this patch is that the GPU latch needs to be waited on
before the UI thread tasks can be completed before shell initialization.
2018-10-22 17:40:24 -07:00
Ryan Macnak
60bb5da33c
Reapply "Some cleanups enabled by removing support for Dart 1" (#6250)
Following fixes in dart-lang/sdk@91cbb57cd5
2018-09-14 09:36:13 -07:00
Michael Goderbauer
6f459e2f10
Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (#6216)" (#6232)
This reverts commit e3133e0e3f7cbbd57fa930c11f3640561d691eba.
2018-09-12 12:07:20 +02:00
Ryan Macnak
e3133e0e3f
Reapply "Some cleanups enabled by removing support for Dart 1." (#6216)
- Add missing Dart 2 flags to gen_snapshot invocation.
 - Disable brittle service test.
2018-09-10 17:03:54 -07:00
Ryan Macnak
bf96dbed38
Revert "Some cleanups enabled by removing support for Dart. (#5621)" (#6205)
This reverts commit 4c2448d1591a5fab033de3885ad34d1fdf5474f1.
2018-09-07 17:39:51 -07:00
Ryan Macnak
4c2448d159
Some cleanups enabled by removing support for Dart. (#5621)
- Switch core snapshot to Dart 2 and remove support for loading platform.dill.
 - Remove support for loading script snapshots.
 - Remove support for loading source.
 - Remove settings and fix names to reflect the above.
 - Remove support for loading the service isolate from source.
2018-09-07 15:44:46 -07:00
Chinmay Garde
9f8285ac6c
Remove all dependencies on Garnet. (#5869) 2018-07-26 12:49:34 -07:00
Jason Simmons
0bad812c72
Migrate to a standalone Tonic repository separated from Topaz (#5817) 2018-07-23 11:49:35 -07:00
Ben Konyi
672e587e74
Background Execution Implementation for iOS (#5539) 2018-07-13 10:55:24 -07:00
Ryan Macnak
ab1b0db966
No-copy kernel loading. (#5580)
Required by https://dart-review.googlesource.com/c/sdk/+/60202
2018-06-21 15:44:04 -07:00
Ben Konyi
8d8d91bfc3
IsolateNameServer reland (#5519)
* Reland "Added IsolateNameServer functionality (#5410)"

This reverts commit c3976b3c7183f479717bffed3f640fb92afbd3dc.

* Fixed issue with isolate_name_server_test which caused test to timeout

* Disabled thread_annotations on Android as they aren't supported in the
NDK headers for std::mutex. Readded thread annotations to
IsolateNameServer.
2018-06-13 11:57:10 -07:00
Ben Konyi
c3976b3c71
Revert "Added IsolateNameServer functionality (#5410)" (#5516)
This reverts commit 61a2d129cfc8c52cf1ff59b03bccf67d9b07af63.
2018-06-12 17:03:13 -07:00
Ben Konyi
61a2d129cf
Added IsolateNameServer functionality (#5410)
* Added IsolateNameServer functionality, which allows for the association
of string names with isolate SendPort ids that can be used to establish
inter-isolate communications.
2018-06-12 15:50:48 -07:00
Chinmay Garde
5441ee79ff
Allow embedders to specify a custom advisory URI and entrypoint. (#5408)
The Fuchsia embedder wants to specify the application name in the field for the advisory URI. This allows embedders to specify whatever they want.
2018-05-29 15:10:12 -07:00
Ryan Macnak
fb709e25e3
[fuchsia] Plumbing for sharing between AOT snapshots. (#5351) 2018-05-24 13:24:14 -07:00
Ryan Macnak
30c649dd74
[fuchsia] Teach engine how to set up an isolate from a list of kernel files. (#5210) 2018-05-16 10:09:53 -07:00
Jason Simmons
2970c099f7
Use the default microtask scheduler on all isolates except the UI isolate (#5068)
See https://github.com/flutter/flutter/issues/16846
2018-04-23 15:02:19 -07:00
Chinmay Garde
09d05a3891
Prepare and run child isolates on a VM managed (i.e. no UI) task runner. (#5054) 2018-04-19 19:17:11 -07:00
Jason Simmons
7a6b77999f
Remove the weak pointer factory from the service isolate's DartIsolate object (#5041)
The WeakPtrFactory must be deleted on the thread where it was created.
However, the service isolate is created and destroyed on threads from
the Dart thread pool, and the creating thread may not be the same as
the destroying thread.
2018-04-18 13:02:19 -07:00
Chinmay Garde
a0804f3738
Simplify weak pointer factories and allow vending weak pointers on multiple threads. (#5029) 2018-04-18 11:07:16 -07:00
Chinmay Garde
58e84c8bf0
Re-land "Support multiple shells in a single process. (#4932)" (#4998)
* Re-land "Support multiple shells in a single process. (#4932)"

This reverts commit 723c7d01439da4261bc836075fb55651ce9e7f03.
2018-04-13 13:48:15 -07:00
Vyacheslav Egorov
723c7d0143
Revert "Re-land "Support multiple shells in a single process. (#4932)" (#4977)" (#4981)
This reverts commit a3327bff86800b3e654a2988fa7e6049edeb679c.
2018-04-12 18:28:55 +02:00
Chinmay Garde
a3327bff86
Re-land "Support multiple shells in a single process. (#4932)" (#4977)
This reverts commit 9199b40f2a2a6e448cd251de44e020ec3b75002d.
2018-04-11 15:41:23 -07:00