290 Commits

Author SHA1 Message Date
gaaclarke
91e31dca51
Made the license check ignore the .vscode directory. (#9398)
* Made the license check ignore the .vscode directory.

* updated license hash

* updated signature
2019-06-21 11:26:12 -07:00
gaaclarke
cd973f8aae
Added unit tests for the ios code. (#9388)
* Added unit tests for the ios code.

* Moved the tests to live next to the source.

* Added mocking library.

* Fixed formatting and removed third_party from the format check.

* fixed formatting 2

* Removed ocmock from third_party.

* Added ocmock to third_party, compile from source.

* removed ocmock from license checking

* updated licenses_flutter

* updated tool_signature
2019-06-20 17:37:03 -07:00
Chris Bracken
63d5f015dd
Add Dart SDK > 2.3.0 constraint to license script (#9385)
The license script uses Set literals among other Dart 2.3.0 features.
2019-06-19 15:52:30 -07:00
Chinmay Garde
ece4f59377
Update Metal backend to account for Skia updates. (#9383)
Also makes it so that folks don't have to patch the buildroot manually when
building for Metal.
2019-06-19 15:24:26 -07:00
Chris Bracken
1593838393
Handle Fuchsia SDK in license tool + roll SDK (#9302)
The Fuchsia SDK includes a root directory with multiple
license/copyright files. For files that don't include a copyright header
matching them to a specific license (e.g. shared library binaries) we
match them to all licenses.

Specifically, the SDK includes:
* LICENSE: the Fuchsia license
* LICENSE.vulkan: Apache 2.0 license for Vulkan
* COPYRIGHT.vulkan: additional non-Apache licenses/copyrights for Vulkan
* COPYRIGHT.musl: musl license/copyrights

Also rolls the Fuchsia SDK CIPD packages.
2019-06-12 17:32:32 -07:00
Chinmay Garde
7bb5b9aea5
Wire up Swiftshader based OpenGL ES unit-tests on hosts. (#9264)
Currently, all our host unit-tests that have rendering concerns use the software backend because of OpenGL ES availability and stability issues on the various platforms where we run host tests. Unfortunately, entire subsystems are disabled (and not tested) when rendering with the software backend. This patch pulls in SwiftShader and via pending patches in the buildroot, configures the host unit-tests to optionally use OpenGL ES in a stable manner without relying on the OpenGL drivers being present (and functional).

I have wired up the embedder test fixture in this patch to use the SwiftShader based OpenGL ES driver. I will update the shell and runtime unittests in a subsequent patch as well. The on and offscreen surfaces are configured as 1x1 pbuffer surface because we should be able to write pixel tests using OpenGL directly wihout having to deal with surfaces.
2019-06-12 12:32:09 -07:00
Chris Bracken
10a3ab0858
Fix missing return lint (#9246)
A recent Dart roll improved the detection of missing return statements.
Since we enforce that all enum values must be covered in switch
statements, this isn't an issue, but we add a return to fix the lint.
2019-06-11 10:49:06 -07:00
Chinmay Garde
e8ee6acf8d
[engine] Fix builds targeting Android from a Windows host gen_snapshot (#9190) 2019-06-07 22:46:29 -07:00
Chris Bracken
153416e554
Eliminate deprecated super_goes_last lint (#9156)
This eliminates the (deprecated) super_goes_last lint in the license
tool's analysis options. It's been an error in the default analyzer since
Dart 2.

See the deprecation details at https://dart-lang.github.io/linter/lints/super_goes_last.html
2019-05-31 14:41:34 -07:00
Jason Simmons
44f1b440aa
Revert "Use track-widget-creation transformer included in the sdk. (#9085)" (#9134)
This reverts commit 651c90409ee7b8f43da7d1c60fcb172f1ad51901.

With this change applied, test/widgets/widget_inspector_test.dart is failing
when run by the dev/bots/test.dart script in the framework tree.
2019-05-29 17:40:28 -07:00
KyleWong
867120c0c7 Better help message. (#9097) 2019-05-28 12:33:30 -07:00
Chinmay Garde
e27c6e890a
Forward custom IDE flags to GN. (#9023) 2019-05-28 12:21:58 -07:00
Chris Bracken
0f1ff3bdb3
Correct typos, adopt US spellings (#9081)
Corects a bnuch of typeos throughout teh engien codebsae. Also makes
a couple minor Commonwealth -> US spelling adjustments for consistency
with the rest of Flutter's codebase.

Made use of `misspell` tool:
https://github.com/client9/misspell
2019-05-25 13:14:46 -07:00
Terry Lucas
651c90409e
Use track-widget-creation transformer included in the sdk. (#9085)
This improves performance as the version in the SDK is able to work more
incrementally and avoids creating an expensive ClassHierarchy.
There is now no measureable performance difference with the option so the
kernel transformer can be enabled by default.
2019-05-25 06:38:51 -07:00
Matt Carroll
cfa524fcdf
New Plugin API PR4: Adds Lifecycle support to the new plugin system. (#9049) 2019-05-24 19:28:49 -07:00
Jason Simmons
424940f171
Add support for the Fontconfig-based Skia font manager (#8977) 2019-05-16 15:22:22 -07:00
Chinmay Garde
5526884e78
Wire up the Skia Metal backend on iOS. (#8936) 2019-05-11 15:21:26 -07:00
Dan Field
2b1f9925e4
new lints (#8849)
Dart lints added:
* Avoid optional new
* Avoid optional const
* Prefer single quotes
* Prefer default assignment `=`
2019-05-07 16:10:21 -07:00
Chinmay Garde
f6e6d39860
Wire up Fuchsia SDK related updated for shell dependencies. #8869
This does not actually import the runners into the engine. It only sets up the targets so they need no modifications are necessary when the migration is done. The engine has been verified to build in both buildroots.
2019-05-06 18:01:59 -07:00
Dan Field
3671182a95
Get prebuilt Dart via CIPD (#8859) 2019-05-06 11:31:23 -07:00
Dan Field
88e82d371a
Remove static leaks (#8825) 2019-05-03 16:57:04 -07:00
Dan Field
7ce2666e54
Guard Android logs (#8824) 2019-05-03 14:32:29 -07:00
Dan Field
480844608c
Remove asserts and add BuildConfig (#8821) 2019-05-02 17:30:19 -07:00
Chinmay Garde
c97bd45439
Download the Fuchsia SDK and toolchain in a gclient hook. (#8794)
Downloads into `//fuchsia/sdk/platform` and `//fuchsia/toolchain/platform`. `//fuchsia` is in the buildroot gitignore.
2019-05-02 16:37:43 -07:00
Chinmay Garde
7e37080ec0
Allow specifying the Mac SDK path as an environment variable to //flutter/tools/gn (#8643)
As long as the Mac SDK is i386 ready, engine developers should be able to use the latest version of Xcode to build all artifacts. This issue goes away when gen_snapshot migrates to x64.
2019-04-19 10:01:44 -07:00
Chinmay Garde
324b8403e8
Remove the flutter_aot GN argument. (#8581)
This argument has been defunct for a while. It was originally added as a
means of testing the AOT machinery in debug modes.
2019-04-15 12:57:45 -07:00
Matt Carroll
23fceaacd4
Added new Android embedding packages to javadoc generation. (#8411) 2019-04-02 13:23:47 -07:00
stuartmorgan
3a415c4f1e
Map glfw into third_party, and roll buildroot (#8308)
Adds glfw to //third_party/, and rolls the buildroot to
ee817fb84542865e253bcce1866bc13e4065ca4d
to pick up the build rules for it.
2019-03-27 14:08:22 -04:00
Chinmay Garde
b68f7e72aa
Allow specifying an alternate Mac host SDK. (#8249) 2019-03-21 15:46:29 -07:00
Matt Carroll
1dbd2046b5
Moved io.flutter.embedding.engine.android package to io.flutter.embedding.android (#8221) 2019-03-20 11:30:49 -07:00
Jason Simmons
e28fc3c810
Define the dart_platform_sdk GN variable only on host targets (#8206)
dart_platform_sdk is not available in Android builds
2019-03-19 09:43:17 -07:00
Jonah Williams
048d70bc09
Support dartdevc, dart2js with shared source files, dartdevc sdk (#8105) 2019-03-18 11:58:35 -07:00
Chris Bracken
d9fda1c208
Add --no-full-dart-sdk option to GN (#8196)
Allows enabling/disabling building trained snapshots for dart2js and
dartdevc.
2019-03-17 15:52:41 -07:00
Jonah Williams
d92f937301
Add flag to allow only building full sdk on release to speed up bots (#8080) 2019-03-15 13:13:44 -07:00
Chinmay Garde
906d684a77
Reland ""Add support for trace counters with variable arguments and instrument the raster cache." (#8145)
This reverts commit bc901324faf5a24f9220cc7ecbcf5b97b96ae09f and fixes the
discovered on Windows builds.
2019-03-13 13:53:22 -07:00
Chinmay Garde
3c93817839
Add “full-dart-debug” that disabled optimizations in the Dart VM. (#8147) 2019-03-13 12:54:57 -07:00
Dan Field
9e8f8d0889
Drop android_sdk_downloader in favor of cipd (#8087)
* remove sdk downloader, use cipd

* roll buildroot to drop android_sdk_downloader
2019-03-09 12:39:16 -08:00
Dan Field
e77337bb1c
Use right stream for Java, on mac try to autoselect Java 1.8 (#8099)
* Use right stream for Java, on mac try to autoselect Java 1.8
2019-03-08 23:38:59 -08:00
Michael Klimushyn
a63ff46327
Android linter prints to the console by default (#8090)
The HTML report can still be generated by passing in an `--html` flag
to the tool.

This will make errors easier to debug in CI.
2019-03-08 22:23:10 -08:00
Matt Carroll
718329ce6e
Android Embedding PR 17: Clarify AccessibilityBridge and move logic out of FlutterView. (#8061) 2019-03-08 18:09:04 -08:00
Michael Klimushyn
1d10e0eb67
Guard against NewAPI failures (#8048)
Adds minimum SDK checks around minimum APIs.

flutter/flutter#28848
2019-03-08 13:33:58 -08:00
Dan Field
4c94049502
Move android_sdk_downloader so I can more easily deprecate it (#8084) 2019-03-08 12:10:53 -08:00
Dan Field
95ef58cf48
Add script to help generate PR messages (#8074)
* Add script to help generate PR messages

* newline
2019-03-07 16:56:46 -08:00
Jason Simmons
d71bfe58dd
Only build a full Dart SDK when building for the host system (#8071) 2019-03-07 11:44:00 -08:00
liyuqian
3335764ae9
Skip skp files in license check (#8050)
* Skip skp files in license check

This fixes https://bugs.chromium.org/p/skia/issues/detail?id=8828

* Update signature
2019-03-06 08:39:00 -08:00
Chris Bracken
70a18b5153
Add clang static analysis support to gn wrapper (#8047)
Adds --clang-static-analysis option to GN to enable/disable compiling
with clang static analysis enabled.
2019-03-05 17:35:43 -08:00
Dan Field
14e082fa05
add lint script for Android with baseline (#8036)
* add lint script for Android with baseline
2019-03-05 09:36:16 -08:00
Ian Hickson
2cd9b41ba5 Select MPL instead of LGPL (#7991) 2019-03-04 18:43:47 -08:00
Dan Field
a2246c1990
Start of linting Android embedding (#8023)
* Add a tool for running Android SDK lint on Android embedding
2019-03-04 13:55:53 -08:00
Dan Field
130cf77c57
Build engine for iOS on presubmit (#8011)
* build the ios engine on Cirrus
2019-03-02 10:01:15 -08:00