8 Commits

Author SHA1 Message Date
Márk Tolmács
f41c1644d8 Enabling pre-push checks on Windows (flutter/engine#36123)
Re-submit the changes to enable windows pre-push checks.

This patch changes how `ci/bin/format.dart` generate diffs from `diff` and `patch` commands to `git diff` and `git apply` in order to have a common method for these operations on all platforms. Windows installations don't have diff and patch commands available by default and many implementations which provide such commands work differently than the UN*X tools. Git however works consistently across all platforms.

Additionally, this patch also changes the python executable in some of the pre-push components affected by this to `vpython3` to continue the effort started at flutter/flutter#108474 and I also removed the `--no-sound-null-safety` parameter in the ci/format.sh, ci/format.bat files

NOTE: Since the original patch caused some issues, I suggest that this should be tested more carefully before it is merged.

### Issues fixed by this PR
* flutter/flutter#108122
* flutter/flutter#107920
* flutter/flutter#86506
* flutter/flutter#106615

### [flutter/tests] repo impact
None.

writing and running engine tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-21 17:20:06 +00:00
Siva
aac2690ea4 Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (flutter/engine#38105)
* Remove uses of --no-sound-null-safety in preparation for the Dart 3.0
roll.

* Update quiver package to latest.

* Run Fuchsia engine in null safe mode.

* Run Fuchsia engine in non null safe mode.

* Update Dart version to 3.0

* Address review comments.
2022-12-06 20:38:02 -08:00
Loïc Sharma
0fd8f28571 Revert "Fix pre-push githooks on Windows and enable all format checks" (flutter/engine#34821) 2022-07-21 20:07:04 +00:00
Márk Tolmács
140e1231cf Fix pre-push githooks on Windows and enable all format checks (flutter/engine#34374) 2022-07-13 22:06:05 +00:00
Tong Mu
1bdcf5501f Windows: Fix AltGr key causing CtrlLeft to hang (flutter/engine#27266)
Fixes an issue where pressing AltGr key (on supporting layouts such as Spanish) on Windows causes CtrlLeft to hang pressed for both Flutter and Windows.

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2021-07-11 21:38:22 -07:00
Zachary Anderson
996427a9ea Clean up Dart scripts in ci/ (flutter/engine#26325) 2021-05-21 13:29:23 -07:00
Greg Spencer
7e620bae64 Convert format and lint scripts to null safety. (flutter/engine#25078) 2021-03-25 15:09:02 -07:00
Greg Spencer
c001ea6f4a Convert format script to Dart (flutter/engine#20572)
This converts the ci/format.sh script to a Dart script that uses process_runner and isolates to multi-process the clang-format, diffs, and grepping needed to do the formatting changes.

It also will (by default) only check the formatting of changed files.

The user can optionally check all files (--all-files) or do only some types of checks with --check. --verbose prints the versions of the tools used for Clang format and Java format.

Specifying --fix will cause any formatting errors that would have been detected to be fixed.
2020-08-18 13:25:30 -07:00