Jia Hao
f03cc19612
Add flutter prefix to import ( flutter/engine#49793 )
...
This keeps things consistent with other imports and fixes the internal breakage (b/320443454).
While the build system here is able to handle imports both with and without the flutter prefix, the internal mechanism that rewrites these imports is currently unable to handle the latter case.
2024-01-16 16:11:19 +00:00
Ivan Inozemtsev
445a8fb328
Support running sound null safe kernels from dart_runner ( flutter/engine#49598 )
...
Before starting an isolate, `dart[_test]_component_controller` detects
sound null safety status for all given kernels and fails if they aren't
the same, and uses the result to set `null_safety` in isolate flags.
Also switch to `core` snapshots from `core-jit` snapshots, based on
https://github.com/flutter/engine/pull/30744 , as it looks like
`core-jit` snapshots are not null safety agnostic.
See b/315776399
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [X] All existing and new tests are passing.
2024-01-16 07:58:01 -08:00
Brandon DeRosier
6aced2dd87
Manually bump Dart to 3.4.0-34.0.dev ( flutter/engine#49792 )
...
https://dart.googlesource.com/sdk.git/+log/d6c08fa9bb54..992d6c2562
2024-01-16 07:11:37 -08:00
dependabot[bot]
b509a5786b
Bump actions/upload-artifact from 3.1.3 to 4.1.0 ( flutter/engine#49788 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3.1.3 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add migrations docs by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/482 ">actions/upload-artifact#482</a></li>
<li>Update README.md by <a href="https://github.com/samuelwine "><code>@âsamuelwine</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/492 ">actions/upload-artifact#492</a></li>
<li>Support artifact-url output by <a href="https://github.com/konradpabjan "><code>@âkonradpabjan</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/496 ">actions/upload-artifact#496</a></li>
<li>Update readme to reflect new 500 artifact per job limit by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/497 ">actions/upload-artifact#497</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/samuelwine "><code>@âsamuelwine</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/492 ">actions/upload-artifact#492</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.1.0 ">https://github.com/actions/upload-artifact/compare/v4...v4.1.0 </a></p>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.</p>
<p>â¹ï¸ However, this is a major update that includes breaking changes. Artifacts created with versions v3 and below are not compatible with the v4 actions. Uploads and downloads <em>must</em> use the same major actions versions. There are also key differences from previous versions that may require updates to your workflows.</p>
<p>For more information, please see:</p>
<ol>
<li>The <a href="https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/ ">changelog</a> post.</li>
<li>The <a href="https://github.com/actions/upload-artifact/blob/main/README.md ">README</a>.</li>
<li>The <a href="https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md ">migration documentation</a>.</li>
<li>As well as the underlying npm package, <a href="https://github.com/actions/toolkit/tree/main/packages/artifact "><code>@âactions/artifact</code></a> documentation.</li>
</ol>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/vmjoseph "><code>@âvmjoseph</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/464 ">actions/upload-artifact#464</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v4.0.0 ">https://github.com/actions/upload-artifact/compare/v3...v4.0.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1eb3cb2b3ehttps://redirect.github.com/actions/upload-artifact/issues/497 ">#497</a> from actions/robherley/update-readme-limit</li>
<li><a href="8688a8649273d8b66edehttps://redirect.github.com/actions/upload-artifact/issues/496 ">#496</a>)</li>
<li><a href="c320f57948https://redirect.github.com/actions/upload-artifact/issues/492 ">#492</a>)</li>
<li><a href="cf8714cfeahttps://redirect.github.com/actions/upload-artifact/issues/482 ">#482</a> from actions/robherley/add-migration-docs</li>
<li><a href="7f16e37e88353073034fhttps://redirect.github.com/actions/upload-artifact/issues/468 ">#468</a> from actions/robherley/misc-updates</li>
<li><a href="6c139afa6fc7d193f32ehttps://redirect.github.com/actions/upload-artifact/issues/466 ">#466</a> from actions/v4-beta</li>
<li><a href="13131bb095https://github.com/actions/upload-artifact/compare/v3.1.3...1eb3cb2b3e0f29609092a73eb033bb759a334595 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-01-16 07:20:29 +00:00
Chinmay Garde
c6b8349d0a
Remove pthread based thread local support. ( flutter/engine#49297 )
...
The thread_local storage class was not available pre-C++11. Even when C++11 was available, the C++ runtime in versions of iOS <= 9.0 was not capable of supporting this storage class. So we ended up using pthread directly in that case. The unique pointer support was added later. Now that the storage class has been supported on all Flutter platforms for a while, we can remove the fallback and remove a bunch of code. The ThreadLocalUniquePtr can be removed too but that can be attempted in a separate migration.
2024-01-13 21:28:26 +00:00
gaaclarke
6bd7574e88
[Impeller] fixed nested save layer mipmap counts ( flutter/engine#49778 )
...
resolves https://github.com/flutter/engine/pull/49607#discussion_r1450982660
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-13 01:34:22 +00:00
Dan Field
08e89db585
[Impeller] Properly size struct emplacements for Vulkan Runtime Effects ( flutter/engine#49768 )
...
This was introduced in the runtime effects PR.
This bug sometimes causes a segfault when we go to `memmove` latter with
an incorrect length/size/num parameter.
2024-01-12 15:35:28 -08:00
Zachary Anderson
5f893e5dff
Fix linux_android_emulator_api_33 build config for rbe ( flutter/engine#49776 )
...
Following up from https://github.com/flutter/engine/pull/49660 . Missed this `bringup: true` shard.
2024-01-12 23:33:11 +00:00
Tong Mu
f15bc4cb13
[Linux] Remove the usage of std::function in FlKeyEmbedderResponder ( flutter/engine#49293 )
...
Fixes https://github.com/flutter/flutter/issues/140183
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-12 23:08:52 +00:00
gaaclarke
85d2ba69cf
[Impeller]: new blur - adds mips for backdrop filters ( flutter/engine#49607 )
...
If the new blur flag is on and a blur is used as a backdrop filter, the
rendered texture will now have mipmaps which will make the downscaling
step of the blur have more signal (and thus be less shimmery).
issue: https://github.com/flutter/flutter/issues/140193
fixes: https://github.com/flutter/flutter/issues/140949
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-01-12 14:18:06 -08:00
Jonah Williams
1e3b95a400
[Impeller] move TrackedObjectsVK to separate file. ( flutter/engine#49773 )
...
I've been thinking about making object tracking per-frame instead of per cmd pass. To make that easier to experiment with, I'd like to move this to its own file.
2024-01-12 22:14:06 +00:00
keyonghan
7f10aa5957
Add gclient_variables back for linux_license and fix the excluded files ( flutter/engine#49775 )
...
Last piece to fix: https://github.com/flutter/flutter/issues/141461
2024-01-12 22:12:00 +00:00
Jonah Williams
0d31627223
[Impeller] Descriptor pool incremental allocation. ( flutter/engine#49686 )
...
This returns descriptor set allocation to the previously used strategy of incrementally allocating descriptors and maintaing a vec of pools. This is required to remove deferred command encoding as part of https://github.com/flutter/flutter/issues/140804
There are some potential further improvements: we may be able to share the descriptor pool across a frame, which would reduce allocation time slightly.
2024-01-12 21:56:17 +00:00
Zachary Anderson
74eb0981de
Relands: Refactors RBE support ( flutter/engine#49660 )
...
Relands https://github.com/flutter/engine/pull/49416
2024-01-12 13:25:58 -08:00
Jonah Williams
6a1ac6c14a
[Impeller] finish migration to new render pass API. ( flutter/engine#49740 )
...
Part of https://github.com/flutter/flutter/issues/140804
Migrate the rest of the commands in impeller to use the new API. Hide RenderPass::AddCommand. On subsequent changes I will be able to begin making some of these methods virtual so we can add more direct pass through. Though the vulkan backend will be blocked on changes to descriptor sets: https://github.com/flutter/engine/pull/49686
2024-01-12 21:13:19 +00:00
Jonah Williams
06ee89691e
[Impeller] remove Buffer type and associated abstractions. ( flutter/engine#49702 )
...
Now that the HostBuffer isn't implementing Buffer, there is really no reason to have a Buffer/DeviceBuffer split. make BufferViews use a DeviceBuffer, and remove the data ptr from buffer views (as we can always reach into the device buffer).
Makes some other cleanups too, since we always use a std::shared_ptr<DeviceBuffer>, then we can eliminated the shared_from_this call for AsBufferView by making this a static method.
2024-01-12 20:22:11 +00:00
keyonghan
0d8738a2fa
Remove gclient_variables from linux_license.json ( flutter/engine#49766 )
...
The `gclient_variables` has never been used and this is to unblock a recipes CL: https://flutter-review.googlesource.com/c/recipes/+/53902
Part of https://github.com/flutter/flutter/issues/141461
2024-01-12 20:07:06 +00:00
auto-submit[bot]
b174774059
Reverts "[Fuchsia] Use chromium test-scripts to download images and execute tests" ( flutter/engine#49772 )
...
Reverts flutter/engine#49650
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
This change requires https://github.com/flutter/buildroot/pull/811 , and can be executed from buildroot by
```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```
Bug: https://github.com/flutter/flutter/issues/140179
- [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description above.
- [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-12 19:30:29 +00:00
skia-flutter-autoroll
c6c71245bb
Roll Skia from 2bc5d2ee9896 to 31309ff09537 (1 revision) ( flutter/engine#49764 )
...
https://skia.googlesource.com/skia.git/+log/2bc5d2ee9896..31309ff09537
2024-01-12 brianosman@google.com Remove template from scatter_masked
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 18:03:29 +00:00
skia-flutter-autoroll
e75da409b5
Roll Dart SDK from 042dbc146a37 to d6c08fa9bb54 (2 revisions) ( flutter/engine#49763 )
...
https://dart.googlesource.com/sdk.git/+log/042dbc146a37..d6c08fa9bb54
2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-24.0.dev
2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-23.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 17:48:25 +00:00
zijiehe@
cc3c0eeca9
[Fuchsia] Use chromium test-scripts to download images and execute tests ( flutter/engine#49650 )
...
This change requires https://github.com/flutter/buildroot/pull/811 , and can be executed from buildroot by
```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```
Bug: https://github.com/flutter/flutter/issues/140179
- [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description above.
- [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-12 17:04:31 +00:00
skia-flutter-autoroll
543c4d8a45
Roll Skia from 7484d4a2514e to e04ca400c5d8 (2 revisions) ( flutter/engine#49759 )
...
https://skia.googlesource.com/skia.git/+log/7484d4a2514e..e04ca400c5d8
2024-01-12 johnstiles@google.com Add output file from new test.
2024-01-12 johnstiles@google.com Report top-level local variables that shadow parameters in SkSL.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 15:55:10 +00:00
skia-flutter-autoroll
47301fc0ab
Roll Skia from 22fa87f32944 to 7484d4a2514e (1 revision) ( flutter/engine#49757 )
...
https://skia.googlesource.com/skia.git/+log/22fa87f32944..7484d4a2514e
2024-01-12 johnstiles@google.com Remove FunctionDefinition::parameterSymbolTable.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 15:11:01 +00:00
skia-flutter-autoroll
e319fc02d8
Roll Dart SDK from bff80f6c56de to f61f7d2f57c5 (1 revision) ( flutter/engine#49748 )
...
https://dart.googlesource.com/sdk.git/+log/bff80f6c56de..f61f7d2f57c5
2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-21.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 07:54:23 +00:00
skia-flutter-autoroll
51c619538a
Roll Skia from e9de42588e54 to 2bef4f0f8058 (2 revisions) ( flutter/engine#49745 )
...
https://skia.googlesource.com/skia.git/+log/e9de42588e54..2bef4f0f8058
2024-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 17922a334064 to 1de9b3d66634 (4 revisions)
2024-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e3230c2ab314 to 1de9b3d66634
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 05:39:22 +00:00
skia-flutter-autoroll
949ddfd3c2
Roll Dart SDK from 3245b92a5930 to bff80f6c56de (4 revisions) ( flutter/engine#49744 )
...
https://dart.googlesource.com/sdk.git/+log/3245b92a5930..bff80f6c56de
2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-20.0.dev
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-19.0.dev
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-18.0.dev
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-17.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-12 04:05:23 +00:00
Matan Lurey
5a61efcfff
Add SurfaceTextureSurfaceProducer ( flutter/engine#49653 )
...
Unblocks https://github.com/flutter/flutter/issues/139702 .
The next step will be local validation that this API works for at least a few of our internal plugins (video_player, camera).
2024-01-11 23:32:54 +00:00
skia-flutter-autoroll
036fa47d94
Roll Skia from b63e5a3c14e1 to d65d18ac1e8d (1 revision) ( flutter/engine#49735 )
...
https://skia.googlesource.com/skia.git/+log/b63e5a3c14e1..d65d18ac1e8d
2024-01-11 johnstiles@google.com Add support for SkSL Graphite ES2 program kinds.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 23:20:04 +00:00
Jonah Williams
7b95690be2
[Impeller] Begin migrating to RenderPass command recording API. ( flutter/engine#49480 )
...
Part of https://github.com/flutter/flutter/issues/140804 proposes removing the Command object. This demonstrates the new API without changing the implementation, which can be done separately per backend. This also doesn't change every single callsite for reasons...
2024-01-11 22:29:55 +00:00
Victoria Ashworth
ddd6db70ed
Run tests on macOS 13 only ( flutter/engine#49722 )
...
Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-11 22:16:16 +00:00
Jonah Williams
12f4ae6d56
[Impeller] dont accidentally copy shared ptr. ( flutter/engine#49731 )
...
Copying the shared ptr when we don't need to results in us incrementing/decrementing the ref count which isn't free.
2024-01-11 22:05:22 +00:00
skia-flutter-autoroll
232ab95af3
Roll Skia from 56f28f137507 to b63e5a3c14e1 (1 revision) ( flutter/engine#49733 )
...
https://skia.googlesource.com/skia.git/+log/56f28f137507..b63e5a3c14e1
2024-01-11 johnstiles@google.com Add placeholder files for Graphite ES2 support.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 22:05:20 +00:00
Jason Simmons
36c6968075
Revert Dart SDK to 3245b92a5930 ( flutter/engine#49727 )
...
A recent Dart SDK roll included a regression affecting runs of "flutter analyze" on individual files
(see https://dart.googlesource.com/sdk/+/89bd370e95c0695250a4f0111be3134b9936eadd )
2024-01-11 21:57:23 +00:00
skia-flutter-autoroll
6bf9363bd3
Roll Fuchsia Linux SDK from gJuGKaWsKazIrvQeO... to Klxww53tA4-TG5pA9... ( flutter/engine#49730 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 21:34:43 +00:00
skia-flutter-autoroll
574f3471eb
Roll Skia from 440f5f849008 to 56f28f137507 (1 revision) ( flutter/engine#49723 )
...
https://skia.googlesource.com/skia.git/+log/440f5f849008..56f28f137507
2024-01-11 briansalomon@gmail.com [graphite] Don't call wgpu::ShaderModule::GetCompilationInfo on emsdk < 3.1.51
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 19:21:05 +00:00
Jesse Seales
4fa8327ffe
Osv-scanner integration ( flutter/engine#49470 )
...
This change integrates directly with osv-scanner rather than using the OSV API to query each dependency for vulnerabilities.
- use [lockfile format](https://github.com/flutter/engine/pull/49203 ) for third party deps rather than a flat file
- let osv-scanner do the work of checking for vulns rather than API calls to OSV database
- let osv-scanner create and populate the SARIF results
A successful run of the vulnerability scanner can be seen in the tests of this PR.
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-01-11 18:59:47 +00:00
Jason Simmons
4610aea866
[Impeller] Add DrawLine/DrawOval/ClipOval operations to the canvas recorder ( flutter/engine#49697 )
2024-01-11 18:44:03 +00:00
skia-flutter-autoroll
2fb99c5544
Roll Dart SDK from 7f3ea1c3bc27 to 6f5bd26b293d (1 revision) ( flutter/engine#49720 )
...
https://dart.googlesource.com/sdk.git/+log/7f3ea1c3bc27..6f5bd26b293d
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-18.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 17:49:57 +00:00
Dan Field
90ee2f7711
Try to get GLES tests running... ( flutter/engine#49701 )
...
I plan to fix the GLES fragment program reload issue, but first want to make sure this gets some failures for it.
Added a few skips for shaders that require an extension not available on CI (mipmap related ones).
Updated a couple tests that were failing.
2024-01-11 17:32:13 +00:00
skia-flutter-autoroll
00bd1367a9
Roll Skia from e80a6830eb4d to 5d4f12f3f12d (1 revision) ( flutter/engine#49706 )
...
https://skia.googlesource.com/skia.git/+log/e80a6830eb4d..5d4f12f3f12d
2024-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 939506789cfa to 17922a334064 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 06:54:37 +00:00
Dan Field
4681274469
[Impeller] Vulkan runtime effects/fragment program API ( flutter/engine#49543 )
...
Fixes https://github.com/flutter/flutter/issues/122823
Fixes https://github.com/flutter/flutter/issues/129659
Fixes https://github.com/flutter/flutter/issues/123741
This patch makes runtime stage/fragment program stuff work on Vulkan for Android.
It will need flutter/flutter#140976 for that to become a reality for flutter_tools users.
Compiling with relaxed Vulkan semantics still has an issue: shaders that use `sampler2D` with an explicitly set `location` on the `layout` will fail to compile with an error documented in https://github.com/flutter/flutter/issues/141219 .
I think there might still be some issues with fragment programs on Vulkan, but this should at least be a good starting point and unblocks ink_sparkle.frag usage in the framework.
I've deleted some runtime_stage related code that would never get used - for example, enum related code that indicates we might support a bunch of data types that we do not and probably never will support in this API.
2024-01-11 02:25:05 +00:00
skia-flutter-autoroll
c975e9b627
Roll Dart SDK from 9f5a6a2ccace to 3245b92a5930 (1 revision) ( flutter/engine#49700 )
...
https://dart.googlesource.com/sdk.git/+log/9f5a6a2ccace..3245b92a5930
2024-01-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-16.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 02:09:22 +00:00
skia-flutter-autoroll
eabf9d9cdb
Roll Skia from d1fbb9177115 to 596053dde5f0 (1 revision) ( flutter/engine#49694 )
...
https://skia.googlesource.com/skia.git/+log/d1fbb9177115..596053dde5f0
2024-01-10 herb@google.com Implement Myers' Sweep-Line algorithm
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 23:37:49 +00:00
skia-flutter-autoroll
5874720d60
Roll Skia from 2f254f5d41f2 to d1fbb9177115 (1 revision) ( flutter/engine#49692 )
...
https://skia.googlesource.com/skia.git/+log/2f254f5d41f2..d1fbb9177115
2024-01-10 jvanverth@google.com Revert "[graphite] Have Device submit parent uploads prior to its own."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 22:35:05 +00:00
Jonah Williams
c18d6e3a08
[Impeller] reland: write directly to device buffer. ( flutter/engine#49691 )
...
Reland of https://github.com/flutter/engine/pull/49505
---
part of https://github.com/flutter/flutter/issues/140804
We can't use the existing host buffer abstraction as that requires us to collect all allocations up front. By itself, this isn't sufficient for #140804 , because we'll need a way to mark ranges as dirty and/or flush if we don't have host coherent memory. But by itself this change should be beneficial as we'll create fewer device buffers and should do less allocation in general.
The size of the device buffers is 1024 Kb, somewhat arbitrarily chosen.
2024-01-10 22:10:03 +00:00
skia-flutter-autoroll
577ac81725
Roll Dart SDK from c2862d44e108 to 9f5a6a2ccace (1 revision) ( flutter/engine#49689 )
...
https://dart.googlesource.com/sdk.git/+log/c2862d44e108..9f5a6a2ccace
2024-01-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-15.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 22:08:04 +00:00
auto-submit[bot]
6236178dac
Reverts "[Impeller] have Hostbuffer write directly to block allocated device buffers." ( flutter/engine#49688 )
...
Reverts flutter/engine#49505
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
part of https://github.com/flutter/flutter/issues/140804
We can't use the existing host buffer abstraction as that requires us to collect all allocations up front. By itself, this isn't sufficient for #140804 , because we'll need a way to mark ranges as dirty and/or flush if we don't have host coherent memory. But by itself this change should be beneficial as we'll create fewer device buffers and should do less allocation in general.
The size of the device buffers is 1024 Kb, somewhat arbitrarily chosen.
2024-01-10 21:09:18 +00:00
skia-flutter-autoroll
9ec6040596
Roll Skia from 0443e02cdfd3 to 2f254f5d41f2 (1 revision) ( flutter/engine#49685 )
...
https://skia.googlesource.com/skia.git/+log/0443e02cdfd3..2f254f5d41f2
2024-01-10 brianosman@google.com Ensure that sk_unaligned_[load|store] and sk_bit_cast are safe on x86
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com ,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 21:01:11 +00:00
Jason Simmons
42b65dc4a5
[Impeller] Make the shaders loaded by the GLES playground consistent with other playgrounds ( flutter/engine#49684 )
2024-01-10 20:30:38 +00:00
skia-flutter-autoroll
bd168b26ba
Roll Fuchsia Linux SDK from pUQrgMfXgU8RmLuL4... to gJuGKaWsKazIrvQeO... ( flutter/engine#49682 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 20:21:49 +00:00
