Polina Cherkasova
0f2618ff4f
Fix or except leaks. ( #141081 )
...
Contributes to https://github.com/flutter/devtools/issues/6909 .
2024-01-10 00:17:33 +00:00
Michael Goderbauer
c4fda23393
Remove outdated ignores from framework ( #140465 )
...
These were not ignoring anything (anymore).
2023-12-20 22:05:29 +00:00
Bartek Pacia
a4388773bb
SemanticsProperties: default identifier and tooltip to null ( #140283 )
...
This PR applies [the suggestion made here](https://github.com/flutter/devtools/pull/6942#issuecomment-1852773200 ).
2023-12-18 19:38:05 +00:00
Bartek Pacia
8c02a22403
Use SemanticsUpdateBuilder again, remove all references to temporary SemanticsUpdateBuilderNew ( #139942 )
...
This PR removes all usages of the temporary `SemanticsUpdateBuilderNew` API in favor of `SemanticsUpdateBuilder`. These two APIs are the same as of now.
This is mainly targeted at https://github.com/flutter/flutter/issues/17988
Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
part 2: [flutter] use `SemanticsUpdateBuilderNew` https://github.com/flutter/flutter/pull/138331
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/48882
**part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again** <-- we are here
part 5: [engine] remove `SemanticsBuilderNew`
2023-12-16 15:23:24 +00:00
Polina Cherkasova
baf739c8e6
Remove usage of testWidgetsWithLeakTracking. ( #140239 )
2023-12-15 14:13:31 -08:00
Bartek Pacia
948523b80c
Add accessibility identifier to SemanticsProperties ( #138331 )
...
This PR adds `String? identifier` to `Semantics` and `SemanticsProperties`. The `identifier` will be exposed on Android as `resource-id` and on iOS as `accessibilityIdentifier`.
Mainly targeted at #17988
Initial Engine PR with Android support: https://github.com/flutter/engine/pull/47961
iOS Engine PR: https://github.com/flutter/engine/pull/48858
### Migration
This change breaks the SemanticsUpdateBuilder API which is on the Framework<-->Engine border. For more details see [engine PR](https://github.com/flutter/engine/pull/47961 ).
Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
**part 2: [flutter] use `SemanticsUpdateBuilderNew`** <-- we are here
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`*
part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again.
part 5: [engine] remove `SemanticsBuilderNew`
2023-12-11 18:03:07 +00:00
Binni Goel
684980e97d
SemanticOwner should dispatch creation and disposal events ( #138388 )
2023-11-15 09:27:55 -08:00
Kostia Sokolovskyi
c0b21b16ef
SemanticsHandle should dispatch creation and disposal events. ( #137960 )
2023-11-06 14:14:42 -08:00
LongCatIsLooong
7a3135b9c1
Make SemanticsNode.isMergedIntoParent Readonly ( #137304 )
...
Fixes https://github.com/flutter/flutter/issues/54665
2023-10-27 17:22:13 +00:00
derdilla
237db2bb2a
cover more tests with leak tracing ( #134834 )
2023-09-20 16:45:44 -07:00
Michael Goderbauer
55b6f049a6
Enable unreachable_from_main lint - it is stable now!!1 ( #129854 )
...
PLUS: clean-up of all the unreachable stuff.
2023-07-06 00:09:01 +00:00
Michael Goderbauer
17f86df8bd
Migrate SemanticsBinding to onSemanticsActionEvent ( #128254 )
...
Follow-up to https://github.com/flutter/engine/pull/42493 .
2023-06-05 18:16:06 +00:00
Jason Simmons
a3b38aa8f3
Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder into a base class ( #126570 )
...
See https://github.com/flutter/flutter/issues/123756
2023-05-16 16:41:11 +00:00
chunhtai
9884b5f55e
Fixes IgnorePointer and AbsorbPointer to only block user interactions… ( #120619 )
...
Fixes IgnorePointer and AbsorbPointer to only block user interactionsâ¦
2023-04-07 15:51:05 +00:00
Michael Goderbauer
6de42a70f1
Fix how tests count open SemanticsHandles ( #121571 )
...
Fix how tests count open SemanticsHandles
2023-02-28 23:55:58 +00:00
Michael Goderbauer
df66fecdcf
showOnScreen does not crash if target node doesn't exist anymore ( #121575 )
...
showOnScreen does not crash if target node doesn't exist anymore
2023-02-28 03:06:28 +00:00
Michael Goderbauer
b1b7284a72
Move semantic-related bindings to SemanticsBinding ( #121289 )
...
Move semantic-related bindings to SemanticsBinding
2023-02-24 19:30:57 +00:00
Lioness100
26b6c1bedd
Fix typos ( #121171 )
...
* Fix typos
* lowercase animated & opacity
* Undo typo fix
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Ian Hickson
07c548c698
Apply BindingBase.checkInstance to TestDefaultBinaryMessengerBinding ( #116937 )
2023-02-13 23:55:58 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real ( #119673 )
...
* Make Flex,Row,Column const for real
* dart fix --apply
* fix snippets
* fix integration test
* add comment
2023-02-02 19:33:57 +00:00
Alex Wallen
23d258df57
Remove deprecated updateSemantics API usage. ( #113382 )
2022-10-26 20:20:41 +00:00
nbayati
b5a36f03c6
Modify dataMap to include assertiveness only if it's not set to polite ( #108396 )
...
* Modify dataMap to include assertiveness only if it's not set to polite to prevent google3 tests from breaking
* small code style enhancement
2022-07-26 17:12:45 -07:00
Casey Hillers
178e444730
Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" ( #108262 )
2022-07-25 17:01:05 +00:00
nbayati
74ea7132be
Add optional flag to determine assertiveness level in aria announcement for flutter web ( #107568 )
2022-07-23 00:49:04 +00:00
Ian Hickson
265ef1efb8
Export SpellOutStringAttribute and LocaleStringAttribute ( #106682 )
2022-06-27 20:10:05 +00:00
Alexandre Ardhuin
526ca0d498
Export public API types from foundation/scheduler/gestures/semantics ( #106409 )
2022-06-24 21:21:05 +00:00
Pierre-Louis
a0248ebdf2
Use curly_braces_in_flow_control_structures for services, scheduler, semantics ( #104616 )
2022-05-25 19:58:22 +02:00
chunhtai
2ebc7bee9c
Adds tooltip to semantics node ( #87684 )
2022-04-21 12:14:09 -07:00
Michael Goderbauer
51bcdb9407
super parameters for framework ( #100905 )
2022-04-13 22:38:40 -07:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
Ian Hickson
23f7985e50
Improve how AttributedStrings are presented in the widget inspector ( #92450 )
2021-10-29 11:43:05 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
chunhtai
71948b72db
Enable soft transition for tooltip ( #88318 )
2021-08-17 16:07:03 -07:00
Sam Rawlins
960463e66d
Remove "unnecessary" imports. ( #85736 )
2021-07-28 16:19:04 -07:00
chunhtai
00ee2e59e7
Adds text attributes support for semantics ( #79599 )
...
* Adds label attributes
* fix test
* comments
* list equal
2021-06-17 09:45:34 -07:00
chunhtai
a4eb91aa43
Updates override of SemanticsUpdateBuilderSpy to enable soft transition ( #83434 )
2021-05-26 13:24:03 -07:00
Ian Hickson
5e0cc4cba4
Migrate to ChannelBuffers.push ( #82564 )
2021-05-21 15:09:03 -07:00
Ian Hickson
2ae1e39810
Revert "Migrate to ChannelBuffers.push ( #82057 )" ( #82525 )
2021-05-14 12:09:03 -07:00
Ian Hickson
b86d5c0094
Migrate to ChannelBuffers.push ( #82057 )
2021-05-13 14:34:04 -07:00
Ren You
7f1d1414cc
Revert "Migrate to ChannelBuffers.push ( #81235 )" ( #81829 )
...
This reverts commit 35ad43f20caa71ec051a97bc8bc8fec552fb4452.
2021-05-04 06:17:19 -07:00
Ian Hickson
35ad43f20c
Migrate to ChannelBuffers.push ( #81235 )
2021-05-03 17:14:03 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push ( #76288 )" ( #81226 )
...
This reverts commit c26ed03c8a77810136cc087ae60048ace062842d.
2021-04-26 12:57:17 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push ( #76288 )
...
* Migrate to ChannelBuffers.push
* Move TestDefaultBinaryMessenger to its own file
* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Alexandre Ardhuin
d36d5ae35d
add missing trailing commas ( #80995 )
2021-04-22 19:39:02 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test ( #77118 ) ( #78343 )
2021-03-16 13:58:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test ( #77118 )" ( #78329 )
...
This reverts commit 0cbe597540f6b51ab7157ab8747906e9923b79e4.
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test ( #77118 )
2021-03-15 16:28:02 -07:00
