DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,828 Commits 882 Branches 1,069 Tags
Commit Graph

26456 Commits

Author SHA1 Message Date
Zachary Anderson
636764e33e Use RBE for Fuchsia CI builds (flutter/engine#51675) 
I'm not seeing the failures I had seen in these builds previously. I
suspect in the meantime we've rolled reclient forward in CI.
 2024-03-26 10:19:59 -07:00
skia-flutter-autoroll
5157fd60b2 Roll Skia from 7ffd936a66df to 90cfbf5fb91e (15 revisions) (flutter/engine#51677) 
https://skia.googlesource.com/skia.git/+log/7ffd936a66df..90cfbf5fb91e

2024-03-26 sunnyps@chromium.org graphite: Process mapped client buffers in checkAsyncWorkCompletion
2024-03-26 kjlubick@google.com Fix Docker and SwiftShader builds
2024-03-26 double1kai@gmail.com Add vector support for LoongArch in SkRasterPipeline
2024-03-26 bungeman@google.com Update depot_tools, recipes-py; use vpython3
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from b573e0c2eee9 to c77c6203b5c8 (3 revisions)
2024-03-26 sky@chromium.org SkPath: reduces cost of addRect
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from e1d1c2a9f534 to 5de7eb219957 (4 revisions)
2024-03-26 49699333+dependabot[bot]@users.noreply.github.com Bump express from 4.17.3 to 4.19.2 in /tools/run-wasm-gm-tests
2024-03-26 49699333+dependabot[bot]@users.noreply.github.com Bump express from 4.18.2 to 4.19.2 in /tools/perf-canvaskit-puppeteer
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d2cef82a8fd3 to eacd6acdcb00 (40 revisions)
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3a33a92e0392 to f847b3c18c27 (19 revisions)
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3c18c5b7edc5 to c18c48f0aba5
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 992dea31b114 to e1d1c2a9f534 (13 revisions)
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2432e62f9cc1 to b573e0c2eee9 (9 revisions)
2024-03-26 michaelludwig@google.com [graphite] Add DrawTask stub

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 17:09:58 +00:00
Chris Bracken
6a902db197 [macOS] Disable FlutterEngineTest.CanOverrideBackgroundColor (flutter/engine#51669) 
This was re-enabled in https://github.com/flutter/flutter/issues/124677 after fixing leaks in https://github.com/flutter/engine/pull/50832. Since this test involves an NSWindow, there are separate fixes that should be landed to reduce flakes related to lack of NSWindow close calls in the tests. See related AppKit bug report filed at http://www.openradar.me/FB13291861.

Issue: https://github.com/flutter/flutter/issues/145728
Related issue: https://github.com/flutter/flutter/issues/124677

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-26 16:40:49 +00:00
skia-flutter-autoroll
737e34478d Roll Dart SDK from a783a4a043ec to 09e56db7d600 (2 revisions) (flutter/engine#51666) 
https://dart.googlesource.com/sdk.git/+log/a783a4a043ec..09e56db7d600

2024-03-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-270.0.dev
2024-03-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-269.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 15:47:22 +00:00
Srujan Gaddam
f55ed6aa70 Change JSBoxedDartObject to JSAny (flutter/engine#51634) 
Closes https://github.com/dart-lang/sdk/issues/55256

d7ce346fba added code to avoid the less performant boxing of JSBoxedDartObject and instead use backend-specific logic to externalize and internalize the UniqueRef until we get a better solution from dart:js_interop. On the JS backends, this relied on casting to and from JSAny, as its representation type is just Object. However, this callback that takes in the UniqueRef as an arg is still typed as accepting JSBoxedDartObject, leading to a cast failure on the JS backends, since the representation type is JSObject.

The fix is to use JSAny. On dart2wasm, this makes no difference, as the underlying representation type does not change.
 2024-03-26 15:41:23 +00:00
Zachary Anderson
dcd7089bab Revert "Disable cleaning up ImageReaders in memory pressure callback" (flutter/engine#51665) 
Reverts flutter/engine#51391

Reason for revert: b/330184547 - I believe there is a good chance that the investigation on that issue was not really adequate to justify this revert, but this change can be easily relanded if reverting this was the wrong choice.
 2024-03-25 23:00:00 +00:00
skia-flutter-autoroll
3ada24d137 Roll Fuchsia Linux SDK from ySBsQPn-0UgTQaXIw... to uu8lffXkeJQ9PC96I... (flutter/engine#51660) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 22:38:08 +00:00
skia-flutter-autoroll
0f0427c077 Roll Skia from 625d04f3a7c5 to 7ffd936a66df (7 revisions) (flutter/engine#51657) 
https://skia.googlesource.com/skia.git/+log/625d04f3a7c5..7ffd936a66df

2024-03-25 michaelludwig@google.com [graphite] TaskList uses TArray, no more prepending
2024-03-25 sunnyps@chromium.org graphite: Better memory instrumentation traces
2024-03-25 jvanverth@google.com Update iOS deployment support.
2024-03-25 double1kai@gmail.com Add vector support for LoongArch in SkBlitter_ARGB32.cpp
2024-03-25 brianosman@google.com Remove SkBlurDrawLooper
2024-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc3b098a5d9f to 2432e62f9cc1 (3 revisions)
2024-03-25 brianosman@google.com Remove SkDrawLooper::asABlurShadow

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 20:34:23 +00:00
lauren n. liberda
8e74e57981 font_subset tests: name correct variant in exception (flutter/engine#51492) 
font_subset tests now respect `--variant`, but the exception message hasn't been changed

*List which issues are fixed by this PR. You must list at least one issue.*
closes https://github.com/flutter/flutter/issues/145412

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-25 17:39:13 +00:00
skia-flutter-autoroll
e09fbfc91d Roll Skia from 8a587a10323f to 625d04f3a7c5 (5 revisions) (flutter/engine#51655) 
https://skia.googlesource.com/skia.git/+log/8a587a10323f..625d04f3a7c5

2024-03-25 kjlubick@google.com Enforce IWYU on src/gpu/ganesh/mock
2024-03-25 drott@chromium.org [Fontations-backend] Make Fontations understand named instance ttc index
2024-03-25 michaelludwig@google.com [graphite] Remove unnecessary Task declarations
2024-03-25 robertphillips@google.com [graphite] Improve PaintParamsKeyTest
2024-03-25 robertphillips@google.com [graphite] Add Alpha-only Image handling to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 17:23:05 +00:00
Jonah Williams
cac99a988a [Impeller] fix unbalanced restores. (flutter/engine#51648) 
Fixes https://github.com/flutter/flutter/issues/145528 by checking if the clip coverage stack is empty for restoring. Adds a protective empty check in clip replay.

I have a plan to pull the clip stack into something more testable to make this better, but opening this as a simpler fix first.
 2024-03-25 16:56:07 +00:00
skia-flutter-autoroll
7ffd143684 Roll Skia from e7ae039f5b1b to 8a587a10323f (1 revision) (flutter/engine#51654) 
https://skia.googlesource.com/skia.git/+log/e7ae039f5b1b..8a587a10323f

2024-03-25 lizeb@google.com [graphite] Free mapped buffers in submit() and performDeferredWork()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 15:12:22 +00:00
skia-flutter-autoroll
21ba588ee9 Roll Skia from 7f2e8320bbfe to e6dc16a6d82d (1 revision) (flutter/engine#51652) 
https://skia.googlesource.com/skia.git/+log/7f2e8320bbfe..e6dc16a6d82d

2024-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 653bfbb0555b to 3a33a92e0392 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 06:42:29 +00:00
Robert Ancell
ae2ac7f706 Add fl_standard_method_codec_new_with_message_codec() (flutter/engine#51599) 
Matches constructor in
https://api.flutter.dev/flutter/services/StandardMethodCodec-class.html
and is required to make method calls with custom value types.
 2024-03-25 14:06:27 +13:00
skia-flutter-autoroll
e2728c9e62 Roll Fuchsia Linux SDK from IPZvFWIGJFJnJ409e... to ySBsQPn-0UgTQaXIw... (flutter/engine#51649) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-24 21:32:22 +00:00
skia-flutter-autoroll
5e0fe41e50 Roll Dart SDK from 88f531b19ed5 to a783a4a043ec (1 revision) (flutter/engine#51647) 
https://dart.googlesource.com/sdk.git/+log/88f531b19ed5..a783a4a043ec

2024-03-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-268.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-24 18:01:16 +00:00
skia-flutter-autoroll
5abb2c2efc Roll Fuchsia Linux SDK from _uuBNUJ6KbprCDWmC... to IPZvFWIGJFJnJ409e... (flutter/engine#51643) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-23 19:29:37 +00:00
skia-flutter-autoroll
aef5775087 Roll Skia from 10a460af3308 to 2e99e3a5445c (1 revision) (flutter/engine#51632) 
https://skia.googlesource.com/skia.git/+log/10a460af3308..2e99e3a5445c

2024-03-22 michaelludwig@google.com Add move_back(TArray&)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-22 22:20:11 +00:00
skia-flutter-autoroll
5cc56155b6 Roll Dart SDK from a959c7def805 to ad26f4885bf4 (1 revision) (flutter/engine#51631) 
https://dart.googlesource.com/sdk.git/+log/a959c7def805..ad26f4885bf4

2024-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-262.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-22 22:09:12 +00:00
Harry Terkelsen
c94c54253a [web] Add ability to customize font fallback download URL (flutter/engine#51569) 
Gives developers the ability to change the base URL to download fallback
fonts from `fonts.gstatic.com` to a URL of their choosing.

Fixes https://github.com/flutter/flutter/issues/132689

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-22 14:58:39 -07:00
Jackson Gardner
047ea1efd4 [skwasm] Use test fonts while in debugEmulateFlutterTesterEnvironment mode (flutter/engine#51630) 
This brings the behavior in line with the other renderers. The framework sets this bit to make sure we render only using the Ahem font.
 2024-03-22 21:56:53 +00:00
skia-flutter-autoroll
8bb8f16804 Roll Skia from eb6976fc57cc to 10a460af3308 (3 revisions) (flutter/engine#51629) 
https://skia.googlesource.com/skia.git/+log/eb6976fc57cc..10a460af3308

2024-03-22 scroggo@google.com Remove useless `neon:` clause.
2024-03-22 sky@chromium.org SkPathRef: fixes bug in resetToSizes()
2024-03-22 jvanverth@google.com [iOS] Clean up comments in WindowContexts.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-22 20:27:19 +00:00
Jackson Gardner
f79cfcc0d3 [Skwasm] Respect the debugDisableFallbackFonts flag. (flutter/engine#51626) 
Skwasm needs to respect the `debugDisableFallbackFonts` flag, which is used by framework tests.
 2024-03-22 19:22:22 +00:00
skia-flutter-autoroll
419e281a4e Roll Skia from 6484a450c457 to eb6976fc57cc (1 revision) (flutter/engine#51627) 
https://skia.googlesource.com/skia.git/+log/6484a450c457..eb6976fc57cc

2024-03-22 michaelludwig@google.com [graphite] Rename TaskGraph to TaskList

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-22 19:22:20 +00:00
Jackson Gardner
2b1f29dcdc [skwasm] Throw when gradient color stops are invalid in debug mode. (flutter/engine#51624) 
One of many unit test failures that are appearing when running framework tests against skwasm.
 2024-03-22 18:48:58 +00:00
skia-flutter-autoroll
6b70a8b31f Roll Fuchsia Linux SDK from AW70sjrQKy2sSXpUA... to _uuBNUJ6KbprCDWmC... (flutter/engine#51625) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-22 18:23:25 +00:00
Jason Simmons
08c9653756 [Impeller] Check for empty sizes when creating render targets in RenderTargetCache (flutter/engine#51597) 
Using an empty size will result in an invalid RenderTarget. Calling IsValid on that target can produce Impeller validation warnings.
 2024-03-22 17:53:57 +00:00
skia-flutter-autoroll
949b0a5014 Roll Skia from 14c5a8540691 to 6484a450c457 (19 revisions) (flutter/engine#51623) 
https://skia.googlesource.com/skia.git/+log/14c5a8540691..6484a450c457

2024-03-22 double1kai@gmail.com Add vector support for LoongArch in SkVx.h
2024-03-22 double1kai@gmail.com Add vector support for LoongArch in SkBlitRow_D32.cpp
2024-03-22 jvanverth@google.com [graphite] Add GraphiteMetalWindowContext_ios
2024-03-22 double1kai@gmail.com Add build parameters and SkCpu support for LoongArch
2024-03-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bd8f4975de15 to 33e1b3c05ed9 (7 revisions)
2024-03-22 kjlubick@google.com Remove legacy GrDirectContext::MakeMetal functions
2024-03-22 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 5e77806559bf to 76f1e9715c82 (6 revisions)
2024-03-22 robertphillips@google.com [graphite] Add WorkingColorSpaceShader to the Precompilation system
2024-03-22 bungeman@google.com Use MappingIndex to speed up onCharsToGlyphs
2024-03-22 bungeman@google.com Fontations to pass TypefaceStyle test
2024-03-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 653bfbb0555b to 7993ffda4464
2024-03-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 02591b50d089 to 653bfbb0555b (15 revisions)
2024-03-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 294864f9e0b4 to 5e77806559bf (5 revisions)
2024-03-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c7cd640a7b33 to bd8f4975de15 (4 revisions)
2024-03-21 robertphillips@google.com [graphite] Propagate isConstant through LocalMatrix and CTM Shaders
2024-03-21 armansito@google.com [graphite] Reusable memory for GPU-private storage buffers
2024-03-21 robertphillips@google.com [graphite] Update LocalMatrix and ColorFilter factories to take SkSpans
2024-03-21 robertphillips@google.com [graphite] Make PrecompileLocalMatrixShader optionally elide itself
2024-03-21 michaelludwig@google.com [graphite] Move task classes into task/ subdir

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-22 16:38:04 +00:00
skia-flutter-autoroll
e65179f8eb Roll Dart SDK from b89d2de510d1 to a959c7def805 (4 revisions) (flutter/engine#51622) 
https://dart.googlesource.com/sdk.git/+log/b89d2de510d1..a959c7def805

2024-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-261.0.dev
2024-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-260.0.dev
2024-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-259.0.dev
2024-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-258.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-22 16:17:58 +00:00
Loïc Sharma
575fc2b3d3 [Embedder API] Add helper to create viewport metrics (flutter/engine#51562) 
_This is a refactoring with no semantic changes._

In a subsequent change, an `FlutterEngineAddView` embedder API will be introduced to add views. This API will need to create the view's initial engine viewport metrics, so this splits out the logic from `FlutterEngineSendWindowMetricsEvent` into a helper.

Follow-up change that uses this new helper: https://github.com/flutter/engine/pull/51523

Design doc: https://flutter.dev/go/multi-view-embedder-apis

Prepares for: https://github.com/flutter/flutter/issues/144806

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-22 15:53:11 +00:00
Loïc Sharma
850ae52067 [Windows] Allow view controllers to not own the engine (flutter/engine#51570) 
Adds `FlutterDesktopEngineCreateViewController` to the Windows embedder's C API. Example usage:

```cpp
// Create the engine.
FlutterDesktopEngineProperties engine_properties = {};
auto engine = FlutterDesktopEngineCreate(&engine_properties);

// Create a views controller.
FlutterDesktopViewControllerProperties properties = {};
properties.width = 400;
properties.height = 400;

auto controller = FlutterDesktopEngineCreateViewController(engine, &properties);

// Run app...

// Destroy the view controller. This does not destroy the engine. 
FlutterDesktopViewControllerDestroy(controller);

// Destroy the engine.
FlutterDesktopEngineDestroy(engine);
```

This new API creates a view controller that does **not** own the engine, unlike the existing `FlutterDesktopEngineCreateViewController`. In the future, this new API will allow a Windows app to have multiple views that share a single engine.

This API is in the `flutter_windows_internal.h`, making it "pubternal". This API is not in the public Windows header files, however, one can link against this API for testing purposes. This API will be promoted to the public Windows header files once the Windows embedder is ready to have multiple views.

Relevant design documents:
1. https://flutter.dev/go/desktop-multi-view-runner-apis
1. http://flutter.dev/go/windows-multi-view-ownership-updates

Relevant issues:
1. https://github.com/flutter/flutter/issues/143767
1. https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-22 15:53:08 +00:00
K Lubick
ef9af8f3d2 Update one more use of deprecated GrDirectContext::MakeMetal (flutter/engine#51619) 
In #51537 I missed one call to `GrDirectContext::MakeMetal` which is
going away.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-22 11:09:38 -04:00
Jason Simmons
171221580e Post Dart message handling tasks directly to the platform task runner for isolates running on the platform thread (flutter/engine#51573) 
Some embedders use a custom platform task runner that does not support fml::MessageLoopTaskQueues and may not have an fml::MessageLoop.

To support those embedders, DartIsolate::SetMessageHandlingTaskRunner will not use fml::MessageLoopTaskQueues for platform isolates.

See https://github.com/flutter/engine/pull/48551#issuecomment-1962190896
 2024-03-22 14:33:03 +00:00
Rulong Chen（陈汝龙）
a697f6e769 [Android] Fix the issue of blank or frozen pages in shared engine scenarios (flutter/engine#50947) 
Consider this scenario: In an add-to-app context, where multiple Flutter activities share the same engine, a situation occurs. When navigating from FlutterActivity1 to FlutterActivity2, the Flutter view associated with FlutterActivity1 is detached from the engine. Then, the Flutter view of FlutterActivity2 is attached. Upon navigating back to FlutterActivity1, its Flutter view is re-attached to the shared engine.

The expected behavior is: When a Flutter view detaches from the shared engine, the associated surface should be released. When the Flutter view re-attaches, a new surface should be created.

After #47358, no new surface is created when the Flutter view is attached again. This results in the Flutter view having no underlying surface, which causes the page to appear blank or freeze without responding.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-22 03:38:35 +00:00
hellohuanlin
9c54875efc [ios][platform_view][performance] overlay intersection (flutter/engine#50637) 
Address the performance of platform view due to an extra overlay. This overlay was added due to the following rounding problem: 

> For example, if we interleave flutter widget and platform view in a list, and let's say we have a flutter widget (top = 0, bottom = 100.1), and a platform view below that widget (top = 100.1, bottom = 200). They are NOT supposed to be overlapping. However, after rounding out, we will get flutter widget (top = 0, bottom = 101), and platform view (top = 100, bottom 200). This will result in 1 pixel overlap as long as there's a floating point in the coord.

(Quote myself from the discussion below). 

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/143420

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-21 23:48:34 +00:00
Gray Mackall
48710ab05d Make the et feature request link properly add the github label (flutter/engine#51594) 
The label has a space in it, so it doesn't get properly added with the current link.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-21 23:34:06 +00:00
Loïc Sharma
2526347a83 [Fuchsia] Assert renders are only to the implicit view (flutter/engine#51559) 
Fuchsia does not support multiple view rendering yet. This asserts only the implicit view is rendered to, to mirror the existing Android and iOS assertion.

Prepares for:
1. https://github.com/flutter/flutter/issues/144806
1. https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-21 21:09:04 +00:00
Loïc Sharma
454af9a350 [Embedder API] Fix test helper's present callback registration (flutter/engine#51560) 
https://github.com/flutter/engine/pull/51293 added a new present callback that supports multiple views. However, the test helper incorrectly inversed the single-view and multi-view present callbacks. This didn't affect the existing tests as we don't any multi-view tests yet.

Prepares for https://github.com/flutter/flutter/issues/144810

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-21 21:07:27 +00:00
Ian Hickson
9d1537ccb8 Add a breadcrumb from FlutterView to PlatformDispatcher. (flutter/engine#51504) 2024-03-21 20:53:12 +00:00
skia-flutter-autoroll
9a2eed091a Roll Dart SDK from 5724c0dc7846 to b89d2de510d1 (1 revision) (flutter/engine#51584) 
https://dart.googlesource.com/sdk.git/+log/5724c0dc7846..b89d2de510d1

2024-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-257.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 18:05:10 +00:00
skia-flutter-autoroll
087525b39d Roll Skia from 72875d47dbc3 to 14c5a8540691 (1 revision) (flutter/engine#51583) 
https://skia.googlesource.com/skia.git/+log/72875d47dbc3..14c5a8540691

2024-03-21 drott@chromium.org [Fontations-backend] Address some clippy suggestions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 18:00:08 +00:00
Jason Simmons
762d37fd2e Move //buildtools to //flutter/buildtools (flutter/engine#51526) 2024-03-21 17:06:44 +00:00
skia-flutter-autoroll
a6f055f17e Roll Skia from 2ed0d31938e3 to 72875d47dbc3 (1 revision) (flutter/engine#51582) 
https://skia.googlesource.com/skia.git/+log/2ed0d31938e3..72875d47dbc3

2024-03-21 drott@chromium.org [Fontations-backend] Implement getGlyphToUnicodeMap()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 16:59:05 +00:00
skia-flutter-autoroll
bc0477868d Roll Skia from 5f32b063a869 to 2ed0d31938e3 (1 revision) (flutter/engine#51581) 
https://skia.googlesource.com/skia.git/+log/5f32b063a869..2ed0d31938e3

2024-03-21 nscobie@google.com [graphite] Expose Caps::maxTextureSize() through Context

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 15:32:24 +00:00
skia-flutter-autoroll
8c520b5457 Roll Dart SDK from 5e825c7fcf59 to 5724c0dc7846 (1 revision) (flutter/engine#51580) 
https://dart.googlesource.com/sdk.git/+log/5e825c7fcf59..5724c0dc7846

2024-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-256.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 14:02:05 +00:00
skia-flutter-autoroll
837c1da93e Roll Dart SDK from 43662466cee8 to 5e825c7fcf59 (2 revisions) (flutter/engine#51577) 
https://dart.googlesource.com/sdk.git/+log/43662466cee8..5e825c7fcf59

2024-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-255.0.dev
2024-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-254.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 06:53:04 +00:00
skia-flutter-autoroll
38c30e3d25 Roll Skia from 1d0a90ac5a64 to 9c0e0b553c02 (2 revisions) (flutter/engine#51578) 
https://skia.googlesource.com/skia.git/+log/1d0a90ac5a64..9c0e0b553c02

2024-03-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 02591b50d089 to 07cfa8579a88
2024-03-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e0eeaffcaaab to 02591b50d089 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 06:41:05 +00:00
skia-flutter-autoroll
f570601b28 Roll Fuchsia Linux SDK from uINhDrQ3fkTE08_he... to AW70sjrQKy2sSXpUA... (flutter/engine#51575) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 05:50:22 +00:00
skia-flutter-autoroll
78d87b264e Roll Skia from 0091e089fb24 to 300e58020707 (3 revisions) (flutter/engine#51574) 
https://skia.googlesource.com/skia.git/+log/0091e089fb24..300e58020707

2024-03-20 briansalomon@gmail.com [graphite] Add Context and Recorder cache budget getters
2024-03-20 hitawala@chromium.org Add YCgCo color space support for multiplanar formats.
2024-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1169094061ce to 7b1d1c4867a6 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-21 03:26:21 +00:00
skia-flutter-autoroll
181f001bab Roll Skia from 3ffa395f8fbc to 0091e089fb24 (2 revisions) (flutter/engine#51564) 
https://skia.googlesource.com/skia.git/+log/3ffa395f8fbc..0091e089fb24

2024-03-20 jlavrova@google.com Reland "SkUnicode refactor"
2024-03-20 nicolettep@google.com Update comment documentation for layer
padding

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-20 19:21:12 -07:00