DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
318 Commits 882 Branches 1,069 Tags
Commit Graph

33 Commits

Author SHA1 Message Date
Ojan Vafai
eec7ede796 Remove assorted dead code from RenderBox. 
-overrideContainingBlock sizes were only used by RenderGrid.
-percendicular containing blocks were a vertical writing mode feature.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/704413008
 2014-11-10 19:43:04 -08:00
Ojan Vafai
637d077ba2 Remove some straggling zoom-related code. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/714783003
 2014-11-10 19:17:32 -08:00
Ojan Vafai
275c5e291c Remove zoom() and effectiveZoom(). 
No change in behavior since we already removed the zoom setters.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/711203002
 2014-11-10 17:32:52 -08:00
Rafael Weinstein
c0ffe6fb23 remove updateTouchEventTargetRectsIfNeeded 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/713073003
 2014-11-10 13:08:21 -08:00
Ojan Vafai
1fad59d33b Remove OverlayScrollbarSizeRelevancy. 
It doesn't do anything anymore.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/715453002
 2014-11-07 18:13:42 -08:00
Ojan Vafai
b44392daf4 Remove scrollbar width/height computations from layout. 
Scrollbars never take up layout space or participate in hit-testing.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/707233006
 2014-11-07 17:54:41 -08:00
Rafael Weinstein
f6b3a8cb02 Remove usesCompositedScrolling 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/712573003
 2014-11-07 13:59:11 -08:00
Ojan Vafai
2793661b5a Remove scroll corners and resizers. 
We never paint scroll corners. The only thing we need them
for is so that the vertical and horizontal scrollbars don't
overlap each other. So, that's the only place left that
still computes a scroll corner rect.

We don't support resizers. Remove the code for them as well
as the CSS resize property.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/689283003
 2014-11-07 09:46:16 -08:00
Ojan Vafai
94ca1025cb Remove -webkit-auto, -webkit-center, -webkit-left, -webkit-right. 
These are values for text-align that align blocks in addition to
inline content. You can get the same centering affect with margin:auto.
If we want this functionality, we should implement it with the
same alignment APIs that we use for flexbox.

Delete unused methods/arguments from RenderBlockFlow.

No change in behavior. Just deleting dead code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/708843002
 2014-11-06 11:55:49 -08:00
Ojan Vafai
aae0aab814 Delete unused methods/arguments from RenderBlockFlow. 
No change in behavior. Just deleting dead code.
Removes hit testing and paint phase for floats. They
bottomed out into empty functions.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/706953003
 2014-11-06 11:17:20 -08:00
Ojan Vafai
4ecaa91c6c Remove margin collapsing. 
Margin collapsing is a document-oriented feature. For applications
it just causes confusion and slowness.

margins.sky has failure output because offsetTop is returning the
wrong values. That's not new with this patch though. When I look
at it visually in skydb, everything seems to be in the right place.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700743002
 2014-11-03 21:30:40 -08:00
Elliott Sprehn
59454159a3 Remove shape-outside. 
Since we don't have floats this doesn't do anything now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/703563002
 2014-11-03 18:01:57 -08:00
Ojan Vafai
29ff7e21fd Remove more float machinery. 
Also removed the clear property since it's only purpose was
to clear floats.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700703002
 2014-11-03 17:00:27 -08:00
Ojan Vafai
ab8e1f98d5 Remove more support for floats from RenderBlockFlow. 
This doesn't change any behavior. Floats were already removed.
This is just removing effectively noop code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/692563004
 2014-11-03 12:40:09 -08:00
Ojan Vafai
ed0c01cdca Remove CSS Grid Layout and grid media queries. 
The two are unrelated, but it was easier to just grep for grid
and remove them all. Aside from the media query change, there
isn't any change in behavior since grid was behind a flag.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689853003
 2014-10-31 16:40:03 -07:00
Ojan Vafai
20dd8466c7 Remove border-fit. 
This just lets you size an element to it's content. We should
do this in a more generic way or let you override layout
and do it yourself.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/698613002
 2014-10-31 10:59:40 -07:00
Elliott Sprehn
c384b62ef1 Remove lots of dead virtuals from Element. 
Mostly form related things we don't need now.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/694703002
 2014-10-30 23:03:02 -04:00
Ojan Vafai
86ed666dc2 Get rid of isWritingModeRoot. 
This function always returns false now that we don't have writing modes.

TBR=esprehn@chromium.org

Remove flipForWritingMode.

It's a noop now that we don't have writing modes.

Review URL: https://codereview.chromium.org/688223002
 2014-10-29 19:53:05 -07:00
Ojan Vafai
13ffe46a43 Remove flipForWritingMode. 
It's a noop now that we don't have writing modes.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684393002
 2014-10-29 19:45:15 -07:00
Ojan Vafai
3b628f7d39 Delete a ton more dead vertical writing mode code. 
No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684383002
 2014-10-29 19:08:09 -07:00
Ojan Vafai
afa0148e0b First pass at removing dead vertical writing mode code. 
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.

The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688213002
 2014-10-29 19:06:59 -07:00
Ojan Vafai
8b0d9e8ac9 First past at removing writing mode. 
This removes the parsing and the enum. This leaves a bunch of
dead code around to fix in a followup.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689743002
 2014-10-29 12:17:11 -07:00
Ojan Vafai
ce9aa787cb Remove more frame-level scrolling machinery. 
This is all dead code. No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/678193005
 2014-10-28 19:27:52 -07:00
Ojan Vafai
423d08cc86 More cleanup of dead code now that we don't have frame-level scrolling. 
No change in behavior. The overflowchanged event was never fired.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687783003
 2014-10-28 16:53:47 -07:00
Ojan Vafai
42ea48b379 Remove a bunch of fixed position dead code. 
There is not change in behavior here. Just removing dead
code now that we no longer support position:fixed.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686653002
 2014-10-28 09:34:19 -07:00
Ojan Vafai
9423819dcc First pass at removing position:fixed. 
The root is never scrollable, so position:fixed doesn't
do anything anymore.

Also remove some dead frame-level scrolling code that interacted
with fixed position things.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/686633002
 2014-10-27 19:42:46 -07:00
Ojan Vafai
995c857ce6 Remove a bunch of frame-level scrolling machinery. 
This just removing dead/noop code. No change in behavior.

R=abarth@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/681023002
 2014-10-27 13:10:04 -07:00
Ojan Vafai
57a45f79ff Remove pinch viewports. 
Sky doesn't have concept of pinch zoom.

Remove more frame-level scrolling machinery.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/681583002
 2014-10-25 10:11:22 -07:00
Ojan Vafai
be4206ab28 Remove more frame-level scrolling machinery. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/680703002
 2014-10-24 23:31:45 -07:00
Elliott Sprehn
8106700a04 Remove most of visited link support. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/667003003
 2014-10-24 23:22:02 -07:00
Ojan Vafai
1728572222 Remove some more frame-level scrolling machinery. 
This includes removing a bunch of scrolling methods and
accessors on Window.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/677223002
 2014-10-24 23:16:28 -07:00
Adam Barth
e8c9ecc556 Use override and final instead of OVERRIDE and FINAL 2014-10-24 15:15:13 -07:00
Adam Barth
ae72930937 Open the Sky 2014-10-23 11:17:19 -07:00