1750 Commits

Author SHA1 Message Date
Mouad Debbar
ee8a5e9bd0 [web] Fix url updates when using Router (flutter/engine#24798) 2021-03-05 17:34:01 -08:00
chunhtai
92d11213ff Adds set text action for voice access (flutter/engine#24734) 2021-03-04 17:44:01 -08:00
Chris Bracken
a15f44a9e2 Revert "[web] Fix painting of last placeholder in paragraph (#24716)" (flutter/engine#24773)
This broke the Linux Web Tests target in the framework tests.

Example failure:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tests/11335/overview

Failure log:
```
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: WidgetSpan calculate correct intrinsic heights [E]
  Test failed. See exception logs above.
  The test description was: WidgetSpan calculate correct intrinsic heights

01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
Assertion failed: file:///b/s/w/ir/k/flutter/packages/flutter/lib/src/rendering/box.dart:2237:16
!RenderObject.debugCheckingIntrinsics
is not true

The relevant error-causing widget was:
  Text file:///b/s/w/ir/k/flutter/packages/flutter_test/lib/src/binding.dart:567:12

When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49  throw_
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3    assertFailed
../packages/flutter/src/rendering/layer.dart.js 4485:79                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4551:26                          debugAssertDoesMeetConstraints
../packages/flutter/src/rendering/layer.dart.js 4380:14                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4382:26                          set size
../packages/flutter/src/rendering/paragraph.dart.js 786:17                       performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/shifted_box.dart.js 451:36                     performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/layer.dart.js 4875:58                          performLayout
../packages/flutter/src/rendering/layer.dart.js 3279:14                          [_layoutWithoutResize]
../packages/flutter/src/rendering/layer.dart.js 6876:107                         flushLayout
../packages/flutter_test/src/_matchers_web.dart.js 3990:30                       drawFrame
../packages/flutter/src/rendering/layer.dart.js 6128:12                          [_handlePersistentFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 764:9                          [_invokeFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 732:37                         handleDrawFrame
../packages/flutter_test/src/_matchers_web.dart.js 3954:12                       scheduleWarmUpFrame
../packages/flutter/src/widgets/widget_span.dart.js 52123:11                     <fn>
../packages/flutter/src/widgets/widget_span.dart.js 52125:7                      runApp
../packages/flutter_test/src/_matchers_web.dart.js 3647:18                       _runTestBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54            runBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5            _async
../packages/flutter_test/src/_matchers_web.dart.js 3644:20                       [_runTestBody]
../dart-sdk/lib/async/zone.dart 1386:13                                          _rootRunBinary
../dart-sdk/lib/async/zone.dart 1272:19                                          runBinary
../packages/flutter_test/src/_matchers_web.dart.js 3636:16                       [_runTest]
../packages/flutter_test/src/_matchers_web.dart.js 4072:44                       <fn>
../packages/fake_async/fake_async.dart.js 141:96                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/clock/src/stopwatch.dart.js 364:18                                   withClock
../packages/fake_async/fake_async.dart.js 141:55                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/fake_async/fake_async.dart.js 141:20                                 run
../packages/flutter_test/src/_matchers_web.dart.js 4067:17                       runTest
../packages/flutter_test/src/_matchers_web.dart.js 5312:24                       <fn>
../packages/test_api/src/frontend/async_matcher.dart.js 862:17                   <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50            <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 179:98              <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 179:80              <fn>
../dart-sdk/lib/async/zone.dart 1362:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1265:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 155:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 707:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 736:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 406:9                                     <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 170:71              <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1162:7                                           runGuarded
../dart-sdk/lib/async/zone.dart 1202:23                                          callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11                              _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5                               _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15           <fn>

The following RenderObject was being processed when the exception was fired: RenderParagraph#e6e8f relayoutBoundary=up1 NEEDS-PAINT:
  creator: RichText ← Text ← Center ← Container-[#9a020] ← [root]
  parentData: offset=Offset(0.0, 0.0) (can use size)
  constraints: BoxConstraints(0.0<=w<=800.0, 0.0<=h<=600.0)
  size: Size(640.0, 40.0)
  textAlign: start
  textDirection: ltr
  softWrap: wrapping at box width
  overflow: clip
  maxLines: unlimited
This RenderObject had the following child:
    text: TextSpan
```

This reverts commit bcba78b6829849ffe7c4638bd69b3ceeb7631666.
2021-03-03 22:27:07 -08:00
Mouad Debbar
7e1da11b95 [web] Fix pointer events for Wacom pen (flutter/engine#24719) 2021-03-02 10:47:41 -08:00
Mouad Debbar
bcba78b682 [web] Fix painting of last placeholder in paragraph (flutter/engine#24716) 2021-03-02 10:30:21 -08:00
Yegor
ba5ca8be29 Revert "remove _getRRect: fixes assertion error (#24688)" (flutter/engine#24718)
This reverts commit 3a5c7654ab16d35c26e43f49eba437a537361585.

The commit broke golden tests.
2021-03-01 15:08:56 -08:00
LongCatIsLooong
deec3a0d07 Reland "TextStyle level leadingDistribution (#24025)" reverted in #24665 (flutter/engine#24668) 2021-03-01 14:55:03 -08:00
Yegor
3a5c7654ab remove _getRRect: fixes assertion error (flutter/engine#24688) 2021-03-01 12:12:50 -08:00
Jason Simmons
274b163520 Declare a constant for the bit index of the force_strut_height flag value (flutter/engine#24675) 2021-02-27 10:01:01 -08:00
LongCatIsLooong
b82a309954 Revert "TextStyle level leadingDistribution (#24025)" (flutter/engine#24665) 2021-02-26 12:41:01 -08:00
xxrl
c8fa179207 remove useless code (flutter/engine#24546) 2021-02-26 11:36:01 -08:00
Ferhat
a3eec1815c [web] Add xcode-symlinks flag to felt tool (flutter/engine#24556) 2021-02-25 14:26:41 -08:00
LongCatIsLooong
e10becadf3 TextStyle level leadingDistribution (flutter/engine#24025) 2021-02-25 11:46:02 -08:00
Ferhat
c694e1d965 [web] Implement Canvas.drawPicture (flutter/engine#24574) 2021-02-24 13:01:44 -08:00
Ferhat
5298568b15 skip shadermask test for webkit (flutter/engine#24602) 2021-02-24 12:01:14 -08:00
Jim Graham
e3b2cc8ce9 backdrop filter layer should report cull_rect as its paint bounds (flutter/engine#24489) 2021-02-23 18:02:49 -08:00
Mouad Debbar
a3117e9445 [web] Fix placeholder-only paragraphs (flutter/engine#24572) 2021-02-23 17:16:01 -08:00
Michael Reed
5d1c5e1c51 Restore call to setFilterQuality (flutter/engine#24542) 2021-02-22 09:21:02 -08:00
Ferhat
639f8a2474 NNBD cleanup (flutter/engine#24529) 2021-02-19 16:45:51 -08:00
Ferhat
f6c8fa6910 Refactor gradient renderer to produce image. Implement gradient based Shadermask (flutter/engine#24029) 2021-02-19 16:45:23 -08:00
Michael Reed
101770680d Default to bilerp for layers (flutter/engine#24519) 2021-02-19 14:31:01 -08:00
Yegor
47a1f0571d fix missing CJK and symbol glyphs, font precedence, fallback reset (flutter/engine#24470)
* fix missing CJK and symbol glyphs
* Cache known covered code units

Co-authored-by: Harry Terkelsen <het@google.com>
2021-02-19 13:49:16 -08:00
Harry Terkelsen
4954a033ec Roll CanvasKit to 0.24. (flutter/engine#24498)
* Update tests for new API

* Update goldens and respond to comment
2021-02-18 16:53:49 -08:00
Matej Knopp
7de5184eb9 Add DiffContext (flutter/engine#21824) 2021-02-18 14:41:01 -08:00
Ferhat
f7e217bf0d [web] Fix origin for repeated linear gradients (flutter/engine#24354) 2021-02-17 15:52:59 -08:00
George Wright
06f90534f2 Update goldens to 578ecb91ea33004cd0ba0af513884cc28ba88cf4 (flutter/engine#24465) 2021-02-17 14:51:38 -08:00
Michael Reed
3390011c3d Defer making skshader until we know quality (flutter/engine#24376) 2021-02-17 13:56:02 -08:00
George Wright
c81c25f172 Revert "Roll CanvasKit to 0.23" (flutter/engine#24461)
* Revert "Roll CanvasKit to 0.23 (#24249)"

This reverts commit f23e42d3f625b5d4da5651372d26103152f0f3ae.

* Update goldens to reverted master
2021-02-17 13:19:31 -08:00
Mouad Debbar
50f7900d7b [web] Fix right click issue when dragging (flutter/engine#24447) 2021-02-17 10:36:01 -08:00
chunhtai
3685fe8a97 Fixes hot restart correctly reset the browser history (flutter/engine#24377) 2021-02-16 23:46:01 -08:00
Yegor
04067ddd57 fix infinite loop in findMinimumFontsForCodeunits (flutter/engine#24441) 2021-02-16 14:38:03 -08:00
Harry Terkelsen
f23e42d3f6 Roll CanvasKit to 0.23 (flutter/engine#24249) 2021-02-16 13:56:12 -08:00
Yegor
4d15dc5ae2 [canvaskit] fix Path.from (flutter/engine#24382) 2021-02-12 16:01:19 -08:00
Yegor
efa24d8bd0 [canvaskit] support adding leaf layers w/o container layers (flutter/engine#24357) 2021-02-12 11:03:56 -08:00
Yegor
d37c9eb651 report failures after running all shards (flutter/engine#24355) 2021-02-11 16:59:35 -08:00
Jason Simmons
b27a922c38 Propagate image decode errors to the future returned by Codec.getNextFrame (flutter/engine#24336) 2021-02-11 14:51:03 -08:00
Ferhat
29f55bb772 [web] Fix svg stroke when style is not provided (flutter/engine#24153) 2021-02-10 17:35:29 -08:00
Mouad Debbar
477a63ab3d [web] Fix text rendering issue when paragraph style is ginormous (flutter/engine#24159) 2021-02-10 14:07:05 -08:00
Mouad Debbar
aebb258346 [web] Fix text selection from right to left (flutter/engine#24214) 2021-02-04 16:11:02 -08:00
Yegor
9a1d6e4434 [canvaskit] update CSS size of the canvas when device-pixel ratio changes (flutter/engine#24160) 2021-02-03 11:22:59 -08:00
Ferhat
9b870e3556 [web] Fix RRect scaleRadii for negative width/height (flutter/engine#24140) 2021-02-02 17:34:33 -08:00
Mouad Debbar
bcbb6a1ce0 [web] Fix exception when using a keyboard (flutter/engine#24150) 2021-02-02 17:11:02 -08:00
Michael Reed
ac61cb770b Update to sampling versions (flutter/engine#24125)
Co-authored-by: Mike Reed <reed@google.com>
2021-02-02 06:43:54 -08:00
Michael Reed
7ef5d67e1b Use sampling instead of (deprecated) filter-quality (flutter/engine#24101) 2021-02-01 00:16:02 -08:00
Mouad Debbar
7bbf7d6d0c [web] Fix text alignment when transform + tight constraints + DOM rendering (flutter/engine#24036) 2021-01-29 18:56:02 -08:00
Yegor
e88c847bbc [canvaskit] remove the DOM node of unrendered platform view (flutter/engine#24001) 2021-01-28 19:45:56 -08:00
Mouad Debbar
acfdf8ddd0 [web] Implement CanvasParagraph.getLineBoundary (flutter/engine#24037) 2021-01-28 17:39:02 -08:00
Harry Terkelsen
2e704056d8 Use runes to get code units in CanvasKit. (flutter/engine#24024) 2021-01-28 17:29:03 -08:00
Tong Mu
ee1cc9f5ab Hardware keyboard: Web, embedder, and dart:ui (flutter/engine#23466) 2021-01-28 17:19:02 -08:00
Ferhat
bbfa7ea309 [web] Fix drawVertices rendering when colors array is null and style is fill (flutter/engine#23995) 2021-01-28 09:37:57 -08:00