Chris Bracken
ee313fa40f
Move //third_party/glfw to //flutter/third_party/glfw ( flutter/engine#46733 )
...
As part of eliminating the Flutter buildroot (#67373 ), we are moving all
third-party dependencies from //third_party to //flutter/third_party.
This is the engine-side follow-up to flutter/buildroot#777 .
Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.
Issue: https://github.com/flutter/flutter/issues/136284
No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
2023-10-10 18:21:54 -07:00
skia-flutter-autoroll
e433db253c
Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) ( flutter/engine#46748 )
...
https://skia.googlesource.com/skia.git/+log/06145491fd17..4935bed4260d
2023-10-11 lovisolo@google.com [bazel] Move test runners under //tools/testrunners.
2023-10-10 vigneshv@google.com SkAvifCodec: Do not use libavif internal headers
2023-10-10 johnstiles@google.com Move SwizzleComponent::Type into Swizzle header.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 00:58:16 +00:00
Brandon DeRosier
e8e13de094
[Impeller] Guard calls to extension proc DebugMessageControlKHR. ( flutter/engine#46747 )
...
Quick fix to unblock the `impeller-cmake-example` build. Calls to ES3 and extension procs need to be guarded.
2023-10-11 00:53:33 +00:00
Jonah Williams
e76a91f169
[Impeller] log specific framebuffer incomplete error. ( flutter/engine#46692 )
...
This is much easier to debug if we know the actual error code.
2023-10-10 23:04:13 +00:00
Brandon DeRosier
30fe68f402
[Impeller] Don't cull readbacks outside the damage rect. ( flutter/engine#46705 )
...
Resolves https://github.com/flutter/flutter/issues/136058 .
The damage rect properly expands to include the backdrop filter readback area to a certain extent, but it suddenly gets excluded once it no longer partially overlaps with the damage rect. This caused the illusion of EntityPass improperly culling the backdrop entity, leading me into a bit of a wild goose chase.
Before:
https://github.com/flutter/engine/assets/919017/94b8c077-0945-4a2c-96e0-27230d980c38
After:
https://github.com/flutter/engine/assets/919017/f1c78365-6e9b-46cb-9e69-33472d488831
2023-10-10 20:55:05 +00:00
John McCutchan
d9469ed169
Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget ( flutter/engine#46724 )
...
The root bug (b/300627634) was that we were holding onto HardwareBuffers
after the owning Image was closed. This CL refactors the C++ code to
properly hold a reference to the Image until it is safe to dispose of.
This CL also refactors the Impeller GL and Skia GL code paths to share
more code.
2023-10-10 13:36:56 -07:00
Matan Lurey
be5446426c
Prepare to move new folders into third_party/ by adding a .gitignore. ( flutter/engine#46729 )
...
As part of https://github.com/flutter/flutter/issues/67373 , we'll be
adding, for example `third_party/glfw`.
This PR will by default ignore folders, except for ones that have
internal repo-sourced code (which are unlikely to change much, if at all
during this transition).
_/cc @Hixie, @chinmaygarde FYI only_.
2023-10-10 13:36:43 -07:00
godofredoc
0a8ed0b821
Use x86 machines for ios builds. ( flutter/engine#46726 )
...
This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.
Bug: https://github.com/flutter/flutter/issues/136219
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-10-10 20:28:52 +00:00
Chinmay Garde
b66daf88a6
Remove workaround for older versions of MSVC. ( flutter/engine#46689 )
...
We don't use the MSVC frontend now anyway. And haven't for a while.
2023-10-10 13:11:51 -07:00
skia-flutter-autoroll
252a54ac58
Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) ( flutter/engine#46728 )
...
https://skia.googlesource.com/skia.git/+log/475286f0f6f1..06145491fd17
2023-10-10 jvanverth@google.com [graphite] Add caching for RasterPathAtlas.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 19:31:20 +00:00
Jonah Williams
724d1ae6fc
[Impeller] Implement framebuffer fetch support for OpenGLES. ( flutter/engine#46585 )
...
https://github.com/flutter/flutter/issues/120223 for OpenGLES. Checks for support of the framebuffer fetch extension: https://registry.khronos.org/OpenGL/extensions/EXT/EXT_shader_framebuffer_fetch.txt . This is supported on a Pixel 6 at least, we should double check the distribution of the extension.
2023-10-10 19:10:11 +00:00
skia-flutter-autoroll
5acb13d768
Roll Skia from f0653c4a2df5 to 475286f0f6f1 (2 revisions) ( flutter/engine#46721 )
...
https://skia.googlesource.com/skia.git/+log/f0653c4a2df5..475286f0f6f1
2023-10-10 nigeltao@google.com SkWuffsCodec: add another "Roll third_party/wuffs" workaround
2023-10-10 johnstiles@google.com Fix fuzzer-discovered assertion in WGSL code generator.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 18:22:49 +00:00
Jim Graham
b2234c9c0c
use TextFrame calls for Impeller in rendertests ( flutter/engine#46696 )
...
Switch the impeller testing in rendertests to use TextFrame objects rather than TextBlob objects when drawing to an Impeller-managed destination.
Previously the DrawText tests would generate over 200 errors because none of the attribute variants would render anything at all. After this fix the number of failures in the DrawText calls is down to 1 which points out that wrapping a DrawTextFrame call in a nothing saveLayer somehow affects the glyph positioning (in a not very appealing manner).
2023-10-10 17:12:48 +00:00
skia-flutter-autoroll
425f0ce670
Roll Skia from c634411c51e6 to f0653c4a2df5 (1 revision) ( flutter/engine#46716 )
...
https://skia.googlesource.com/skia.git/+log/c634411c51e6..f0653c4a2df5
2023-10-10 johnstiles@google.com Remove GMVerifier class from DM.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 16:52:59 +00:00
gaaclarke
de5300d6df
[Impeller] made window size parametric in playground/golden tests ( flutter/engine#46682 )
...
In https://github.com/flutter/flutter/issues/136058#issuecomment-1751507094 it was seen that some bugs manifest only with viewports of certain sizes. This allows writers of tests to adjust the window size for playgrounds and golden image tests.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-10-10 16:10:12 +00:00
skia-flutter-autoroll
d04f82ecb8
Roll Skia from c497dae2fedb to c634411c51e6 (1 revision) ( flutter/engine#46714 )
...
https://skia.googlesource.com/skia.git/+log/c497dae2fedb..c634411c51e6
2023-10-10 lokokung@google.com [webgpu-headers] Add macros to prepare for removing signalValue arg.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 16:10:09 +00:00
skia-flutter-autoroll
ff360adbf3
Roll Skia from ea839690b97d to 6cfbb3a0809e (2 revisions) ( flutter/engine#46710 )
...
https://skia.googlesource.com/skia.git/+log/ea839690b97d..6cfbb3a0809e
2023-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4039a4c6188f to 457fc7591f3c (6 revisions)
2023-10-10 kjlubick@google.com Remove SkBase64 from public API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 13:53:23 +00:00
skia-flutter-autoroll
3ba450b17e
Roll Skia from c969e4aff32c to ea839690b97d (1 revision) ( flutter/engine#46708 )
...
https://skia.googlesource.com/skia.git/+log/c969e4aff32c..ea839690b97d
2023-10-10 kjlubick@google.com Remove GrSurfaceInfo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 12:52:22 +00:00
dependabot[bot]
63012c8bfa
Bump ossf/scorecard-action from 2.1.3 to 2.3.0 ( flutter/engine#46701 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.1.3 to 2.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases ">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.11.0 to v4.13.0 by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1270 ">ossf/scorecard-action#1270</a>
<ul>
<li>For a full changelist of what this includes, see the <a href="https://github.com/ossf/scorecard/releases/tag/v4.12.0 ">v4.12.0</a> and <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.0 ">v4.13.0</a> release notes</li>
</ul>
</li>
<li>✨ Send rekor tlog index to webapp when publishing results by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1169 ">ossf/scorecard-action#1169</a></li>
<li>🐛 Prevent url clipping for GHES instances by <a href="https://github.com/rajbos "><code>@ârajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1225 ">ossf/scorecard-action#1225</a></li>
</ul>
<h3>Documentation</h3>
<ul>
<li>📖 Update access rights needed to see the results in code scanning by <a href="https://github.com/rajbos "><code>@ârajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1229 ">ossf/scorecard-action#1229</a></li>
<li>📖 Add package comments. by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1221 ">ossf/scorecard-action#1221</a></li>
<li>📖 Add SECURITY.md file by <a href="https://github.com/david-a-wheeler "><code>@âdavid-a-wheeler</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250 ">ossf/scorecard-action#1250</a></li>
<li>📖 Fix typo in token input docs by <a href="https://github.com/aabouzaid "><code>@âaabouzaid</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258 ">ossf/scorecard-action#1258</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/david-a-wheeler "><code>@âdavid-a-wheeler</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250 ">ossf/scorecard-action#1250</a></li>
<li><a href="https://github.com/aabouzaid "><code>@âaabouzaid</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258 ">ossf/scorecard-action#1258</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0 ">https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0 </a></p>
<h2>v2.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1192 ">ossf/scorecard-action#1192</a></li>
</ul>
<h2>Scorecard Result Viewer</h2>
<p>Thanks to contributions from <a href="https://github.com/cynthia-sg "><code>@âcynthia-sg</code></a> and <a href="https://github.com/tegioz "><code>@âtegioz</code></a> at <a href="https://github.com/cncf/clomonitor ">CLOMonitor</a>, there is a new Scorecard Result visualization page at <code>https://securityscorecards.dev/viewer/?uri=<project-url> ;</code>.</p>
<ul>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/406 ">ossf/scorecard-webapp#406</a></li>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/422 ">ossf/scorecard-webapp#422</a></li>
</ul>
<p>As an example, you can see our own score visualized <a href="https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard ">here</a>
Checkout our <a href="08b4669551/README.md (scorecard-badge)08b4669551/README.md (workflow-restrictions)https://redirect.github.com/ossf/scorecard-action/pull/1156 ">ossf/scorecard-action#1156</a>, resolved <a href="https://redirect.github.com/ossf/scorecard-action/issues/1150 ">ossf/scorecard-action#1150</a>)</li>
<li>Scorecard action will retry when signing results and submitting them to our web API. This should help with flakiness from connection failures. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1191 ">ossf/scorecard-action#1191</a>)</li>
</ul>
<h2>Docs</h2>
<ul>
<li>ð Update README to accept fine-grained tokens by <a href="https://github.com/pnacht "><code>@âpnacht</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175 ">ossf/scorecard-action#1175</a></li>
<li>ð Update installation instructions to match current GitHub UI by <a href="https://github.com/joycebrum "><code>@âjoycebrum</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1153 ">ossf/scorecard-action#1153</a></li>
<li>ð Document the GitHub action workflow restrictions when publishing results. by <a href="https://github.com/spencerschrock "><code>@âspencerschrock</code></a> in</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/bobcallaway "><code>@âbobcallaway</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1140 ">ossf/scorecard-action#1140</a></li>
<li><a href="https://github.com/pnacht "><code>@âpnacht</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175 ">ossf/scorecard-action#1175</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0 ">https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="483ef80eb9🌱 Bump docker tag for v2.3.0 release. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1271 ">#1271</a>)</li>
<li><a href="5d3591303e🌱 Bump github.com/ossf/scorecard/v4 from v4.11.0 to v4.13.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1270 ">#1270</a>)</li>
<li><a href="49787a6922🌱 Bump distroless/base from <code>46c5b9b</code> to <code>a35b652</code> (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1269 ">#1269</a>)</li>
<li><a href="4283c75015🌱 Bump github/codeql-action from 2.21.8 to 2.21.9 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1268 ">#1268</a>)</li>
<li><a href="709ecd0815🌱 Bump golang from <code>6974950</code> to <code>c416cee</code> (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1266 ">#1266</a>)</li>
<li><a href="25bb02cd47🌱 Bump actions/checkout from 4.0.0 to 4.1.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1267 ">#1267</a>)</li>
<li><a href="b687393d23🌱 Bump github/codeql-action from 2.21.5 to 2.21.8 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1265 ">#1265</a>)</li>
<li><a href="6a1c21f537🌱 Bump golang from <code>cffaba7</code> to <code>6974950</code> (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1264 ">#1264</a>)</li>
<li><a href="2dee8c185e🌱 Bump github.com/sigstore/cosign/v2 from 2.1.1 to 2.2.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1254 ">#1254</a>)</li>
<li><a href="e79dcb6112🌱 Upgrade to go 1.20 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1262 ">#1262</a>)</li>
<li>Additional commits viewable in <a href="80e868c13c...483ef80eb9https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.1.3&new-version=2.3.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-10-10 06:02:15 +00:00
skia-flutter-autoroll
e2ac598da8
Roll Fuchsia Linux SDK from 3JmrIr49bTV2DIWsW... to dCjN58uZQBmAFWSxN... ( flutter/engine#46700 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 05:48:15 +00:00
skia-flutter-autoroll
2eadc2e15e
Roll Skia from f4f3c909993d to 4378ce41f461 (1 revision) ( flutter/engine#46699 )
...
https://skia.googlesource.com/skia.git/+log/f4f3c909993d..4378ce41f461
2023-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2e3e38a84286 to f9f3328bcef8 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 05:30:55 +00:00
skia-flutter-autoroll
97803f90d7
Roll Dart SDK from 078162ecf493 to a471147f6237 (1 revision) ( flutter/engine#46695 )
...
https://dart.googlesource.com/sdk.git/+log/078162ecf493..a471147f6237
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-4.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 01:30:13 +00:00
skia-flutter-autoroll
3939588f34
Roll Dart SDK from a6e43b0b9e0c to 078162ecf493 (1 revision) ( flutter/engine#46691 )
...
https://dart.googlesource.com/sdk.git/+log/a6e43b0b9e0c..078162ecf493
2023-10-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-3.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 21:35:14 +00:00
skia-flutter-autoroll
71ec5b83b0
Roll Skia from e56387226035 to f45ac4569300 (1 revision) ( flutter/engine#46690 )
...
https://skia.googlesource.com/skia.git/+log/e56387226035..f45ac4569300
2023-10-09 herb@google.com Add slope comparison for Segments
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 21:33:31 +00:00
Chinmay Garde
e53f10f782
Remove obsolete tests that were time sensitive. ( flutter/engine#46686 )
...
These were always filtered away. On Fuchsia, where the filters were not
in place, there was an ifdef guard.
Followup to
https://github.com/flutter/flutter/issues/80457#issuecomment-1753419263
---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2023-10-09 13:39:21 -07:00
skia-flutter-autoroll
b4579a5fb3
Roll Skia from bd77f099b4f9 to e56387226035 (1 revision) ( flutter/engine#46687 )
...
https://skia.googlesource.com/skia.git/+log/bd77f099b4f9..e56387226035
2023-10-09 kjlubick@google.com Remove #ifdef SK_VULKAN from GrDirectContext by moving MakeVulkan factories
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 20:37:17 +00:00
skia-flutter-autoroll
0762396b58
Roll Skia from 26d70e6999f6 to bd77f099b4f9 (3 revisions) ( flutter/engine#46685 )
...
https://skia.googlesource.com/skia.git/+log/26d70e6999f6..bd77f099b4f9
2023-10-09 johnstiles@google.com Revert "Disable color type RG_88 on Apple M1 GPUs."
2023-10-09 johnstiles@google.com Disable color type RG_88 on Apple M1 GPUs.
2023-10-09 johnstiles@google.com Disable indirect draws in ANGLE + D3D.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 19:49:11 +00:00
Jim Graham
c97916810d
[Impeller] Run DisplayList render tests. ( flutter/engine#46422 )
...
Revisiting this project as it may help with [attribute] X [rendering op] matrix testing of Impeller. It's not an exhaustive combinatorial test of all combinations of rendering attributes, but it attempts each op with each attribute both default and non-default.
For Impeller it only tests that the rendering produced output (i.e wasn't a NOP due to missing implementation), that the output changed if the given attribute was supposed to change the output, and that it rendered within the computed bounds that the rest of the engine will be assuming.
These changes will not result in any automatic CI testing of Impeller as is since they are only run on the Metal backend which is not enabled by default. Running `out/host_[variant]/display_list_rendertests --enable-metal` manually on a Mac host, though, will run the tests through Impeller and there will be a lot of error output. Also, there is one known crash as reported in https://github.com/flutter/flutter/issues/135766
2023-10-09 19:10:05 +00:00
skia-flutter-autoroll
92590c5464
Roll Skia from ef4c093143d2 to 26d70e6999f6 (1 revision) ( flutter/engine#46684 )
...
https://skia.googlesource.com/skia.git/+log/ef4c093143d2..26d70e6999f6
2023-10-09 kjlubick@google.com Move third_party/vulkanmemoryallocator -> src/gpu/vk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 19:03:13 +00:00
ColdPaleLight
4411d278fc
[Impeller] Optionally support SamplerAddressMode::kDecal on the OpenGLES backend ( flutter/engine#46650 )
...
fix https://github.com/flutter/flutter/issues/129358
2023-10-09 17:21:30 +00:00
skia-flutter-autoroll
f33ddd1e3f
Roll Skia from 4135182b6a56 to ef4c093143d2 (2 revisions) ( flutter/engine#46680 )
...
https://skia.googlesource.com/skia.git/+log/4135182b6a56..ef4c093143d2
2023-10-09 nscobie@google.com Force RRectEffect to always use scale when in reduced shader mode
2023-10-09 robertphillips@google.com [graphite] Update remaining childless Blocks to be AddBlock-style
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 17:13:24 +00:00
skia-flutter-autoroll
a819caa9ed
Roll Skia from c5541e2bd213 to 4135182b6a56 (1 revision) ( flutter/engine#46677 )
...
https://skia.googlesource.com/skia.git/+log/c5541e2bd213..4135182b6a56
2023-10-09 michaelludwig@google.com [skif] Refactor Functors,ContextInfo,Context into virtual Backend, and Context
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 15:38:07 +00:00
skia-flutter-autoroll
09e1503ca9
Roll Dart SDK from a88ed8cafd27 to a6e43b0b9e0c (1 revision) ( flutter/engine#46674 )
...
https://dart.googlesource.com/sdk.git/+log/a88ed8cafd27..a6e43b0b9e0c
2023-10-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-2.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 13:32:18 +00:00
skia-flutter-autoroll
003ff93577
Roll Skia from 0507cc73ca2a to c844143823fb (1 revision) ( flutter/engine#46664 )
...
https://skia.googlesource.com/skia.git/+log/0507cc73ca2a..c844143823fb
2023-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8d9cef29be25 to 2e3e38a84286 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 06:04:51 +00:00
Jonah Williams
a92072c571
[Impeller] Add IMPELLER_DEBUG around group. ( flutter/engine#46642 )
...
These tracing functions aren't free!
2023-10-07 15:32:05 +00:00
skia-flutter-autoroll
f0db641850
Roll Skia from 6ce883877068 to 99d9d571f4dd (1 revision) ( flutter/engine#46652 )
...
https://skia.googlesource.com/skia.git/+log/6ce883877068..99d9d571f4dd
2023-10-07 yangguang@jwzg.com support compression textures in webgl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 14:44:09 +00:00
skia-flutter-autoroll
4db91398d4
Roll Fuchsia Linux SDK from a-BbzDtY3w8UXYgbK... to nX88TgPdoM6PK1wBq... ( flutter/engine#46651 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 14:32:20 +00:00
skia-flutter-autoroll
0b33d42515
Roll Dart SDK from 46bad70d0f7e to 7ba556c43d35 (1 revision) ( flutter/engine#46645 )
...
https://dart.googlesource.com/sdk.git/+log/46bad70d0f7e..7ba556c43d35
2023-10-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-0.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 04:54:21 +00:00
skia-flutter-autoroll
f9f09134d6
Roll Fuchsia Linux SDK from K7K76tME-CSGhYlFm... to a-BbzDtY3w8UXYgbK... ( flutter/engine#46641 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 01:47:00 +00:00
skia-flutter-autoroll
cdae151167
Roll Dart SDK from 368fd3846df0 to 46bad70d0f7e (7 revisions) ( flutter/engine#46639 )
...
https://dart.googlesource.com/sdk.git/+log/368fd3846df0..46bad70d0f7e
2023-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-238.0.dev
2023-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-237.0.dev
2023-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-236.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-235.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-234.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-233.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-232.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 01:02:06 +00:00
skia-flutter-autoroll
90cad5e5d4
Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions) ( flutter/engine#46636 )
...
Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions)
https://skia.googlesource.com/skia.git/+log/d86da2a029d8..2f67f1f18562
2023-10-06 kjlubick@google.com Add dedicated function to calculate length of Base64 encoded string
2023-10-06 bungeman@google.com [pathops] Simplify trivial paths to empty
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 44a79902f2c1 to 01742293d0f2 (11 revisions)
2023-10-06 johnstiles@google.com Add fuzzer for SkSL-to-WGSL.
2023-10-06 johnstiles@google.com Add fuzzer for runtime blenders.
2023-10-06 johnstiles@google.com Add fuzzer for runtime color filters.
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a42cebae4e42 to ac72499c0a8a (91 revisions)
2023-10-06 kjlubick@google.com Split codec-related parts out of tools/Resources.h
2023-10-06 drott@chromium.org [Fontations] Borrow glyph mask flag implementation from FreeType
2023-10-06 jvanverth@google.com Try to fix Dawn roll again.
2023-10-06 drott@chromium.org [Fontations] FFI Interface for accessing CPAL and COLRv0 info
2023-10-06 jvanverth@google.com Disable Tint's use of //build directory to fix Dawn roll
2023-10-06 johnstiles@google.com Add workaround for dropped clear in VKDMSAA.
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3d75b794df0f to 8c341cfdef74 (3 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46c5d45d5955 to 44a79902f2c1 (15 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e12f70e0a324 to 8d9cef29be25 (3 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 535363447183 to 8d9cef29be25
2023-10-06 jvanverth@google.com [graphite] Revise PathAtlas::onAddShape interface.
2023-10-05 lovisolo@google.com [bazel] BazelBenchmarkRunner.cpp: Write results.json output file in Perf's new JSON format.
2023-10-05 johnstiles@google.com Factor out FuzzCreateValidInputsForRuntimeEffect to FuzzCommon.
2023-10-05 johnstiles@google.com Disable broken GMs on Adreno 5xx/6xx + Vulkan.
2023-10-05 kjlubick@google.com Split ToolUtils into a few files for easier modularization
2023-10-05 kjlubick@google.com Enforce IWYU on ToolUtils.h
2023-10-05 bungeman@google.com Revert "[pdf] Simplify filled paths"
2023-10-05 johnstiles@google.com Outset the rect passed to SkMesh::MakeIndexed.
2023-10-05 kjlubick@google.com Use buildifier to reformat all Bazel files
2023-10-05 robertphillips@google.com [graphite] Short circuit key generation for simple paints
2023-10-05 johnstiles@google.com Add saturate to list of supported WGSL intrinsics.
2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 404a76d9bf0e to 46c5d45d5955 (1 revision)
2023-10-05 bungeman@google.com [pdf] Simplify filled paths
2023-10-05 kjlubick@google.com Make SkReadBuffer *not* call SkImages::DeferredFromEncodedData by default
2023-10-05 armansito@google.com [graphite][dawn][viewer] Support turning vsync off
2023-10-05 lovisolo@google.com [bazel] BazelBenchmarkRunner.cpp: Add more flags and better validation.
2023-10-05 robertphillips@google.com [graphite] Add CoeffBlenderBlock::AddBlock
2023-10-05 robertphillips@google.com [graphite] Add ColorSpaceTransformBlock::AddBlock
2023-10-05 johnstiles@google.com Enable child effects in SkMesh programs.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
...
2023-10-06 23:30:23 +00:00
skia-flutter-autoroll
1a2c32d8fe
Roll Skia from 0f2af25f15ee to d86da2a029d8 (7 revisions) ( flutter/engine#46587 )
...
https://skia.googlesource.com/skia.git/+log/0f2af25f15ee..d86da2a029d8
2023-10-05 brianosman@google.com Fix link errors in shared-library
builds when using SkRuntimeEffect inner classes
2023-10-05 johnstiles@google.com Incorporate child effects into the mesh
key and proxy handlers.
2023-10-05 johnstiles@google.com Set up texture bindings for SkMesh
child effects.
2023-10-05 johnstiles@google.com Emit shader code and uniforms for a
mesh's child processors.
2023-10-05 rmistry@google.com Sync depot_tools to HEAD to fix
RecreateSKPs bot sync failures
2023-10-05 jvanverth@google.com [graphite] Progress towards caching
rasterPathAtlas masks.
2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
vulkan-deps from ff2054861dc4 to 404a76d9bf0e (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-06 15:25:01 -07:00
Alexander Aprelev
eb374b3881
[fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version ( flutter/engine#46629 )
...
Use sdk version from imported package pubspec.yaml instead.
This unblocks dart->engine roll that currently is failing
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Fuchsia/83386/overview .
2023-10-06 14:01:28 -07:00
Kevin Lubick
5d70f10ebb
Add Base64::EncodedSize to tidy up allocations ( flutter/engine#46624 )
...
As a follow-up to #46543 , this adds a dedicated function to compute the
size of the buffer needed to encode data using Base64 instead of calling
the encode function with nullptr.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-06 16:50:20 -04:00
Jonah Williams
f29ce2aa7a
[Impeller] Ensure known geometry has simple bounds computation. ( flutter/engine#46623 )
...
Computing the bounds of an RRect can be really slow if you don't actually know that it is an RRect, and shows up in the traces for flutter gallery on wembly. This change should be semantically equivalent and is only an optimization to avoid recomputing the same value we already know.
2023-10-06 20:49:08 +00:00
Jonah Williams
fe78d18716
[Impeller] Refactor CapabilitiesGLES into a Capabilties. ( flutter/engine#46621 )
...
From https://github.com/flutter/engine/pull/46585
For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.
2023-10-06 19:03:11 +00:00
Brandon DeRosier
096c45ad3f
[Impeller] Track clip coverage per-pass when not collapsing. ( flutter/engine#46597 )
...
Resolves https://github.com/flutter/flutter/issues/135916 .
Big credits to @gaaclarke for the repros and investigation around this.
Moves back to tracking clip coverage per-pass when not collapsing. This is especially important for SaveLayers with MatrixImageFilters, which can transform the rendered layer texture and thereby move elements inside or outside of existing parent clips.
This should have little to no performance impact, since we should already be generating correct minimal subpass textures based on correct subpass coverage computation.
Before:
<img width="679" alt="Screenshot 2023-10-05 at 1 25 29 PM" src="https://github.com/flutter/engine/assets/919017/fe63808a-6353-4969-8225-120fd5ee0949 ">
https://github.com/flutter/engine/assets/919017/9284f055-bee1-40cd-8b7e-f478b00d01da
After:
<img width="679" alt="Screenshot 2023-10-05 at 1 24 17 PM" src="https://github.com/flutter/engine/assets/919017/066b1e25-9611-4e14-a383-cc3a866dbe36 ">
https://github.com/flutter/engine/assets/919017/0fbd1f96-8920-472c-bb0e-4414187fc72d
2023-10-06 16:05:20 +00:00
skia-flutter-autoroll
8fe1f0c054
Roll Fuchsia Linux SDK from eI_FBTaRgvoBQaK5n... to K7K76tME-CSGhYlFm... ( flutter/engine#46614 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-06 10:19:22 +00:00
skia-flutter-autoroll
3f74b956bd
Roll Fuchsia Linux SDK from bnd4FFub2R9Q4mlAC... to eI_FBTaRgvoBQaK5n... ( flutter/engine#46599 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 21:28:15 +00:00
skia-flutter-autoroll
d5c45015f9
Roll Skia from 09c71755bc6c to 0f2af25f15ee (2 revisions) ( flutter/engine#46586 )
...
https://skia.googlesource.com/skia.git/+log/09c71755bc6c..0f2af25f15ee
2023-10-05 robertphillips@google.com [graphite] Add BlendModeBlenderBlock::AddBlock
2023-10-05 michaelludwig@google.com Reland "Reland "[skif] Draw FilterResults directly for layer restoration""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 14:57:24 +00:00
