DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,907 Commits 882 Branches 1,069 Tags
Commit Graph

27339 Commits

Author SHA1 Message Date
John McDole
edeabda41b Remove RBE crud compile_commands.json (flutter/engine#53135) 
Removes reported errors in VSCode when using `clangd`

* Parsing a 21MB json string is not performant
* RegExp replacing all occurrences in said 21MB string is (~61ms)
* Fixes #147767
 2024-05-31 21:20:51 +00:00
skia-flutter-autoroll
54818ec2d6 Roll Skia from f1f13534b0c2 to 7193eec6a492 (3 revisions) (flutter/engine#53153) 
https://skia.googlesource.com/skia.git/+log/f1f13534b0c2..7193eec6a492

2024-05-31 michaelludwig@google.com [graphite] Use explicit key for analytic rect blur table
2024-05-31 michaelludwig@google.com [graphite] Support explicit UniqueKeys in ProxyCache
2024-05-31 egdaniel@google.com Fix mag, min, chrome filters for Ganesh Ycbcr.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 20:44:21 +00:00
Michael Ludwig
90b9b7a455 Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag (flutter/engine#49563) 
Update SaveLayerConsolidation unit tests to allow 1px differences due to rounding differences when Skia elides image filter passes and can calculate the CF and opacity in full float without an intermediate conversion to 8-bit color.

This is the last remaining use of the staging that will allow closing https://g-issues.skia.org/issues/40042615.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-31 20:38:32 +00:00
Jonah Williams
8613caf1d2 Remove complexity calculator with Slimpeller (flutter/engine#53140) 
Will it blend?
 2024-05-31 20:10:20 +00:00
skia-flutter-autoroll
40ff614a26 Roll Skia from 208469d270b7 to f1f13534b0c2 (1 revision) (flutter/engine#53152) 
https://skia.googlesource.com/skia.git/+log/208469d270b7..f1f13534b0c2

2024-05-31 robertphillips@google.com [graphite] Add matrix convolution ImageFilter to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 19:41:55 +00:00
skia-flutter-autoroll
070a66721e Roll Skia from ce975ddfd9fb to 208469d270b7 (1 revision) (flutter/engine#53150) 
https://skia.googlesource.com/skia.git/+log/ce975ddfd9fb..208469d270b7

2024-05-31 drott@chromium.org [Fontations-backend] Hinting mode switching compat for comparison test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 18:12:59 +00:00
Reid Baker
02d2b7c8e1 Google java format relocation and formatting update (flutter/engine#53118) 
Fixes https://github.com/flutter/flutter/issues/149319
Caused by https://github.com/flutter/engine/pull/52582

Follow up required to add a flag that fails on missing jar files instead of skipping missing jar files.
 2024-05-31 18:09:23 +00:00
skia-flutter-autoroll
f2471ff7d9 Manual roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53149) 
Manual roll requested by jacksongardner@google.com

https://dart.googlesource.com/sdk.git/+log/ef405fbe3917..2976c1694eed

2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-209.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-208.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-207.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-206.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-205.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-204.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 17:53:21 +00:00
skia-flutter-autoroll
f042e6bfa2 Roll Skia from b1e59e25696a to ce975ddfd9fb (1 revision) (flutter/engine#53147) 
https://skia.googlesource.com/skia.git/+log/b1e59e25696a..ce975ddfd9fb

2024-05-31 nathanasanchez@google.com Optimize conical gradient negations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 16:58:15 +00:00
skia-flutter-autoroll
824adfbcc8 Roll Skia from ddc7ed3f0767 to b1e59e25696a (1 revision) (flutter/engine#53146) 
https://skia.googlesource.com/skia.git/+log/ddc7ed3f0767..b1e59e25696a

2024-05-31 jvanverth@google.com Re-reland: "Fix text 565 to RGBA conversion on BGRA-based systems."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 15:50:39 +00:00
skia-flutter-autoroll
2a04ff26b7 Roll Skia from 8cc93368482b to ddc7ed3f0767 (1 revision) (flutter/engine#53145) 
https://skia.googlesource.com/skia.git/+log/8cc93368482b..ddc7ed3f0767

2024-05-31 robertphillips@google.com [graphite] Add displacement ImageFilter to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 14:18:31 +00:00
skia-flutter-autoroll
6777433af2 Roll Skia from 9930cf1449fd to 47bbc9c6d5f5 (3 revisions) (flutter/engine#53142) 
https://skia.googlesource.com/skia.git/+log/9930cf1449fd..47bbc9c6d5f5

2024-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 30e89cc94007 to 4e5420fc5c0d
2024-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1c59100bb494 to 30e89cc94007 (3 revisions)
2024-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 80bb115da95a to 9bf7c8c67a58 (24 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 06:58:21 +00:00
Jonah Williams
8afa79a341 Remove assorted bad logs. (flutter/engine#53139) 
Fixes https://github.com/flutter/flutter/issues/149376
Fixes https://github.com/flutter/flutter/issues/147081

Lets not log Skia on macOS or anything about transfer queues.
 2024-05-31 04:28:19 +00:00
skia-flutter-autoroll
97b59fdbc5 Roll Skia from c6cf8be050c0 to b34e5dd89e9d (1 revision) (flutter/engine#53133) 
https://skia.googlesource.com/skia.git/+log/c6cf8be050c0..b34e5dd89e9d

2024-05-30 jvanverth@google.com Revert "Reland "Fix text 565 to RGBA conversion on BGRA-based systems.""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-31 00:12:22 +00:00
skia-flutter-autoroll
4f30aaeb61 Roll Skia from a058f601e1fb to c6cf8be050c0 (2 revisions) (flutter/engine#53132) 
https://skia.googlesource.com/skia.git/+log/a058f601e1fb..c6cf8be050c0

2024-05-30 egdaniel@google.com [Graphites] Use SkTo in recent Vulkan DescSet change.
2024-05-30 egdaniel@google.com [Graphite] Fix crashes in Dawn Viewer context destruction.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 23:02:00 +00:00
Yegor
17f50b3a8a [semantics] fix dartdoc grammar (flutter/engine#53121) 
Courtesy of @gspencergoog: "which widget" is korrecter than "what widget".
 2024-05-30 22:22:19 +00:00
Byoungchan Lee
f1844ade00 Replace several NSAssert with FML_CHECK/DCHECK to unblock the build (flutter/engine#53048) 
In https://github.com/flutter/buildroot/pull/860, disabling `NSAssert` in release build was added, and https://github.com/flutter/engine/pull/53005 tries to roll the change into the engine. However, the change is blocked due to several compilation errors in the engine.

This is due to the fact that Google's `DCHECK`(in flutter engine, `FML_DCHECK`) does not make unused variable warning even in release build, while traditional assertion macro like `assert` or `NSAssert` does. For example, the following code will be expanded like this:
code:
```c++
FML_DCHECK(status == kCVReturnSuccess && pxbuffer != nullptr) <<
   "Failed to create pixel buffer";
```
expanded code:
```c++
true || (status == kCVReturnSuccess && pxbuffer != nullptr)
    ? (void)0 ::
    : fml::LogMessageVoidify() &
          ::fml::LogMessage(::fml::kLogFatal, 0, 0, nullptr).stream()
```

However, equivalent code with `NSAssert` will make unused variable warning, since the expanded code doesn't have any reference to the variable:
code:
```c++
NSAssert(status == kCVReturnSuccess && pxbuffer != NULL, @"Failed to create pixel buffer.");
```

expanded code:
```c++
do {
} while (0)
```
To unblock the build, this CL replaces several `NSAssert` with `FML_DCHECK` in the engine codebase. This CL isn't aimed to replace all `NSAssert` with `FML_DCHECK` since discussions in https://github.com/flutter/buildroot/pull/860 are not finalized whether to replace all `NSAssert` with `FML_DCHECK` or not.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-30 21:21:20 +00:00
gaaclarke
419275bce0 [Impeller] make sure buffers are 4 aligned for foreground color blending (flutter/engine#53077) 
fixes https://github.com/flutter/flutter/issues/149216

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-30 21:02:53 +00:00
Jim Graham
2d3cfa1e4c DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104) 
The DisplayListBuilder now tracks the blend mode(s) used for its contents and whether it contains a child SaveLayer that uses a backdrop filter - both conditions that could require the graphics engine to use a different type of layer to satisfy the requests.

blend modes are tracked as the "highest" blend mode enum used by any content (defaults to kClear) as the enum values tend to be ordered so that larger values will tend to require more complicated render-target accesses.

The root layer of the DisplayList can be queried for both conditions on the root layer using methods on the DisplayList class.
 2024-05-30 20:39:10 +00:00
skia-flutter-autoroll
ef7f67b710 Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127) 
https://skia.googlesource.com/skia.git/+log/7cfb0898ac15..188ad395c3e7

2024-05-30 nathanasanchez@google.com Change graphite conical gradient implementation
2024-05-30 egdaniel@google.com [Graphite] Fix key creation for vulkan uniform desc sets.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 20:31:17 +00:00
auto-submit[bot]
17253b1266 Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (#53119)" (flutter/engine#53128) 
Reverts: flutter/engine#53119
Initiated by: zanderso
Reason for reverting: Macros package version issues blocking the roll to the framework https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746489765266754081/+/u/flutter_config_--clear-features/stdout
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/ef405fbe3917..2976c1694eed

2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-209.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-208.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-207.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-206.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-205.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-204.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 19:53:46 +00:00
skia-flutter-autoroll
4cf135148f Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126) 
https://skia.googlesource.com/skia.git/+log/75cf7d351b02..7cfb0898ac15

2024-05-30 jvanverth@google.com Reland "Fix text 565 to RGBA conversion on BGRA-based systems."
2024-05-30 nicolettep@google.com [graphite] Rm unused attribute and correct format logic
2024-05-30 kjlubick@google.com Fix duplicated sources in ganesh_vulkan rule

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 19:06:23 +00:00
Jonny Wang
cbe5184edf Fuchsia api level 18 (flutter/engine#53115) 
b/335285098
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-05-30 19:26:47 +01:00
auto-submit[bot]
bc569c90b0 Reverts "[Impeller] enable Impeller by default on Android. (#53099)" (flutter/engine#53125) 
Reverts: flutter/engine#53099
Initiated by: jonahwilliams
Reason for reverting: manifest opt out doens't work.
Original PR Author: jonahwilliams

Reviewed By: {bdero, zanderso, chinmaygarde}

This change reverts the following previous change:
All plugin migrations have landed. Enable impeller by default on Android.
 2024-05-30 18:15:47 +00:00
auto-submit[bot]
d2efc934df Reverts "Disable Impeller when the manifest explicitly disables it (#53108)" (flutter/engine#53124) 
Reverts: flutter/engine#53108
Initiated by: jonahwilliams
Reason for reverting: Probably --no-enable-impeller isn't working
Original PR Author: jiahaog

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
After https://github.com/flutter/engine/pull/53099, impeller is always enabled, even if the manifest disables it using `io.flutter.embedding.android.EnableImpeller`. 

This PR causes it to respect the manifest value if it is explicitly disabled.

Fixes b/343603270

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-30 18:10:25 +00:00
skia-flutter-autoroll
426f423ef7 Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120) 
https://skia.googlesource.com/skia.git/+log/eadc654480ed..75cf7d351b02

2024-05-30 robertphillips@google.com Revert "[Ganesh] Make GL Protectedness behave more like Vulkan Protectedness"
2024-05-30 michaelludwig@google.com [graphite] Remove mipmapping from ProxyCache

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 18:05:12 +00:00
skia-flutter-autoroll
75ab39cbb5 Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119) 
https://dart.googlesource.com/sdk.git/+log/ef405fbe3917..2976c1694eed

2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-209.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-208.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-207.0.dev
2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-206.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-205.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-204.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 17:22:52 +00:00
Yegor
d3b6b1be14 add SemanticsAction.focus (flutter/engine#53094) 
Add `SemanticsAction.focus`. This PR just adds the new enum value without any logic. Adding the enum value first to unblock work that needs to be done on both the engine and framework side that will actually implement all the necessary logic.

This is PR 1 out of ~3 for https://github.com/flutter/flutter/issues/83809
 2024-05-30 17:15:53 +00:00
skia-flutter-autoroll
1c8a7f0cd3 Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117) 
https://skia.googlesource.com/skia.git/+log/693d9362f0f6..eadc654480ed

2024-05-30 egdaniel@google.com [Graphite] Add descriptor set cache for Vulkan uniforms.
2024-05-30 kjlubick@google.com Add link deps to lowest skia_cc_library
2024-05-30 michaelludwig@google.com Reland "[skif] Take advantage of PixelBoundary in rescale()"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 16:58:43 +00:00
Brandon DeRosier
4a98184140 [Flutter GPU] Upload flutter_gpu.zip upon successful completion of ci/android_debug. (flutter/engine#53107) 
Part of https://github.com/flutter/flutter/issues/131711.

Also, stops distributing `flutter_gpu` as part of the host artifacts, since it's not target-specific.

This enables us to use the same distribution mechanism as the `sky_engine` package.

Corresponding framework PR: https://github.com/flutter/flutter/pull/149299
 2024-05-30 16:08:44 +00:00
skia-flutter-autoroll
fc2f2e7c18 Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114) 
https://skia.googlesource.com/skia.git/+log/949b8cefbf87..693d9362f0f6

2024-05-30 jvanverth@google.com Revert "Fix text 565 to RGBA conversion on BGRA-based systems."
2024-05-30 michaelludwig@google.com [skif] Disable padding on dithered FilterResults

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 15:52:04 +00:00
Jia Hao
f037e0db1b Disable Impeller when the manifest explicitly disables it (flutter/engine#53108) 
After https://github.com/flutter/engine/pull/53099, impeller is always enabled, even if the manifest disables it using `io.flutter.embedding.android.EnableImpeller`. 

This PR causes it to respect the manifest value if it is explicitly disabled.

Fixes b/343603270

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-30 15:03:52 +00:00
skia-flutter-autoroll
2e394ba987 Roll Skia from 8da05c8d40af to 949b8cefbf87 (3 revisions) (flutter/engine#53113) 
https://skia.googlesource.com/skia.git/+log/8da05c8d40af..949b8cefbf87

2024-05-30 kjlubick@google.com Enforce IWYU on src/gpu/vk
2024-05-30 kjlubick@google.com Remove stub VulkanAMDMemoryAllocator::Make
2024-05-30 johnstiles@google.com Fix rvalue reference handling of hash table swap().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 14:50:58 +00:00
skia-flutter-autoroll
d12468912a Roll Skia from e256482ed29c to 8da05c8d40af (1 revision) (flutter/engine#53112) 
https://skia.googlesource.com/skia.git/+log/e256482ed29c..8da05c8d40af

2024-05-30 robertphillips@google.com [Ganesh] Make GL Protectedness behave more like Vulkan Protectedness

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 13:47:22 +00:00
Kaylee Lubick
a4db5f1ce4 Replace several calls to GrGLMakeNativeInterface with more direct APIs (flutter/engine#53064) 
We are restructuring Skia and plan to remove GrGLMakeNativeInterface at
some point. This updates as many places as possible to use the direct
and explicit instantiation instead of having "Skia guess". This should
ideally not be changing behavior - if it does, then the PR should be
modified.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-05-30 08:14:53 -04:00
skia-flutter-autoroll
e3f663eec1 Roll Skia from f23183f041fe to 59dc6975523c (3 revisions) (flutter/engine#53106) 
https://skia.googlesource.com/skia.git/+log/f23183f041fe..59dc6975523c

2024-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1c59100bb494 to e143b8f7ca37
2024-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 10a4da735e37 to 80bb115da95a (40 revisions)
2024-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 57354f93e99c to 1c59100bb494 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-30 06:33:34 +00:00
Jonah Williams
ca435f46c9 [Impeller] enable Impeller by default on Android. (flutter/engine#53099) 
All plugin migrations have landed. Enable impeller by default on Android.
 2024-05-30 01:16:22 +00:00
John McDole
83a97eeaf1 Update CONTRIBUTING.md links (flutter/engine#53043) 
`engine_dev_setup` moved to markdown

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-29 22:36:43 +00:00
skia-flutter-autoroll
a7cacf5852 Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) (flutter/engine#53100) 
https://skia.googlesource.com/skia.git/+log/32746679f7be..aecf76e8eb9a

2024-05-29 johnstiles@google.com Add uvecN type to the built-in types.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 22:11:22 +00:00
skia-flutter-autoroll
86521543e6 Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) (flutter/engine#53097) 
https://skia.googlesource.com/skia.git/+log/b18b7d6af6e8..32746679f7be

2024-05-29 johnstiles@google.com Remove guard flag for mad() in raster pipeline.
2024-05-29 armansito@google.com Manually roll Dawn and abseil-cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 21:11:31 +00:00
Jonah Williams
0847b349a7 [Impeller] revert changes to IO thread upload scheduling. (flutter/engine#53096) 
Fixes https://github.com/flutter/flutter/issues/147429

Turns out we need the I/O thread for all backends still to limit uploads otherwise we compete with the raster thread.
 2024-05-29 20:59:16 +00:00
Jonah Williams
4512c9eb76 [Impeller] fix barriers prior to mip generation. (flutter/engine#53082) 
This fixes the flickering and rendering errors when running on Android seen in https://github.com/flutter/flutter/issues/148412 .

The problem is the barriers proceding mip generation do not account for the input text having been the output of a render pass. Unfortunately no validation errors on this, and no Idea how to test it.
 2024-05-29 20:46:05 +00:00
skia-flutter-autoroll
5f55364a1a Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) (flutter/engine#53095) 
https://skia.googlesource.com/skia.git/+log/e11a5c5b402e..b18b7d6af6e8

2024-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9fbe42f1f959 to 8f291de2f5be (6 revisions)
2024-05-29 jvanverth@google.com Fix text 565 to RGBA conversion on BGRA-based systems.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 20:14:05 +00:00
Michael Goderbauer
c7f659ac91 Switch to FilterQuality.medium for images (flutter/engine#52984) 
https://github.com/flutter/flutter/issues/148253
 2024-05-29 20:02:17 +00:00
skia-flutter-autoroll
b3b2f46853 Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) (flutter/engine#53092) 
https://skia.googlesource.com/skia.git/+log/a4f58c9dabc3..e11a5c5b402e

2024-05-29 jvanverth@google.com Reland "[ganesh] Support vertical LCD with SDF text"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 18:48:08 +00:00
skia-flutter-autoroll
b1f4a1e7a6 Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) (flutter/engine#53091) 
https://skia.googlesource.com/skia.git/+log/ca77972f659e..a4f58c9dabc3

2024-05-29 drott@chromium.org [Fontations-backend] Homogenize test results for COLRv1 test
2024-05-29 robertphillips@google.com [graphite] Add lighting ImageFilters to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 17:37:22 +00:00
Jonah Williams
25d9c64162 [Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. (flutter/engine#53083) 
The flickering in https://github.com/flutter/flutter/issues/148412 is caused by us switching between the RRect fast path and a gaussian blur. The reason is that the SkRect.isSimple check doesn't handle fp precision very well. On one of the frames the difference was :

```
D/skia (18362): SkRect::MakeLTRB(74, 179.666672f, 374, 479.666656f);
D/skia (18362): const SkPoint corners[] = {
D/skia (18362): { 150, 149.999969f },
D/skia (18362): { 150, 150 },
D/skia (18362): { 150, 149.999969f },
D/skia (18362): { 150, 150 },
D/skia (18362): };
```

So lets used a relaxed check for RRect.isSimple instead.

Fixes https://github.com/flutter/flutter/issues/148412
 2024-05-29 16:45:22 +00:00
skia-flutter-autoroll
66e443eb6b Manual roll Dart SDK from 641d61332238 to ef405fbe3917 (12 revisions) (flutter/engine#53089) 
Manual roll requested by jacksongardner@google.com

https://dart.googlesource.com/sdk.git/+log/641d61332238..ef405fbe3917

2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-203.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-202.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-201.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-200.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-199.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-198.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-197.0.dev
2024-05-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-196.0.dev
2024-05-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-195.0.dev
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-194.0.dev
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-193.0.dev
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-192.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 16:29:03 +00:00
skia-flutter-autoroll
60b6efc9da Roll Skia from 99966843c23f to 2fe794827c51 (1 revision) (flutter/engine#53087) 
https://skia.googlesource.com/skia.git/+log/99966843c23f..2fe794827c51

2024-05-29 robertphillips@google.com Revert "[skif] Take advantage of PixelBoundary in rescale()"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 14:20:06 +00:00
skia-flutter-autoroll
669fac0182 Roll Skia from eedef8763102 to 9ea5a1dd5270 (1 revision) (flutter/engine#53084) 
https://skia.googlesource.com/skia.git/+log/eedef8763102..9ea5a1dd5270

2024-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6cab40b89cc8 to 57354f93e99c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-29 05:46:23 +00:00