5873 Commits

Author SHA1 Message Date
Justin McCandless
ed9509697c
Docs explaining how to avoid the problem of height toggling with error (#29811)
Documentation that explains a common use case seen in Github issues where users were surprised by TextFormField growth to accommodate validation messages.
2019-03-27 09:52:23 -07:00
LongCatIsLooong
673e989230
Remove unwanted gap between navigation bar and safe area's child (#29943)
Remove the additional top padding from CupertinoPageScaffold's MediaQuery when the navigation bar is opaque (as the padding was already consumed by the navigation bar).

Related Issue: #29136
2019-03-27 12:30:46 -04:00
Dwayne Slater
393521defe Allow PointerEnterEvent and PointerExitEvents to be created from any PointerEvent (#28602)
Avoids an implicit downcast + crash in MouseTracker, since the last
pointer event can be a Move or Down event, in addition to Hover.
2019-03-27 09:26:28 -07:00
rami-a
64a28e3685
Fix issue with account drawer header arrow rotating when setState is called (#29980)
The UserAccountsDrawerHeader had a bug with the arrow rotating whenever setState was called on its parent. This change makes sure that we check that the state actually changed before allowing the animation to trigger.

Fixes #25801
2019-03-27 11:19:22 -04:00
Kate Lovett
204eceea93
Linking Higher & Lower Class Docs (#29758)
* Adding linking between higher and lower level classes in the API Docs. ref:#22859

* Fixed links between classes.
2019-03-26 10:05:30 -07:00
Amir Hardon
f652f01890
Limit the semantic nodes ID range to 2^16 (#29928)
This PR limits the framework generated semantic node IDs to be smaller than 2^16, this allows to safely generate semantic node in the engine with IDs >= 2^16 avoiding ID collision (which is done in flutter/engine#8250).
2019-03-26 09:37:27 -07:00
hyjfine
6e50ccc803 Let CupertinoTextField's clear button also call onChanged (#29474) 2019-03-26 00:26:13 -07:00
liyuqian
42443f6631
Remove tranparent paint hack from BackdropFilter (#29929)
We can remove the hack because https://github.com/flutter/engine/pull/8183
has been rolled into the framework.
2019-03-25 17:09:39 -07:00
Jonah Williams
9bc85d7e54
wrap Timeline calls in assert (#29861) 2019-03-25 09:42:57 -07:00
Mouad Debbar
7675a6ea94
Add support for text selection via mouse to Cupertino text fields (#29769) 2019-03-22 16:04:55 -07:00
Alexandre Ardhuin
bfa1d25bf9
some formatting of map, parameters and spaces (#29760) 2019-03-23 00:02:21 +01:00
Luka Knezic
fa2fd11275 Update CupertinoTextField (#29008) 2019-03-22 11:21:06 -07:00
xster
8e7e435706
Add heart shapes to CupertinoIcons (#29630) 2019-03-21 15:31:46 -07:00
Rubens de Melo
a8c1960fc2 Include brackets on OutlineButton doc (#29654) 2019-03-21 15:28:51 -07:00
Mouad Debbar
c80366a160
Avoid flickering while dragging to select text (#29563) 2019-03-21 13:25:29 -07:00
Shayne Kelly II
db096cdfd8 Update DropdownButton underline to be customizable (#29138) 2019-03-21 10:32:43 -07:00
Dan Field
5c258366d4
Reland composite physical layers for all platforms (#29701)
* Composite physical layers even if elevation is 0
2019-03-20 17:37:47 -07:00
Anthony
bdf582fd15
[Material] Create a FloatingActionButton ThemeData and honor it within the FloatingActionButton (#28735)
Adds a FloatingActionButtonThemeData so that FABs can be themed at the Theme level and independently. The properties that are now on the theme must be defaulted at the build level, in order to respect any contributing theme properties. Because of this, some tests had to be modified to look at properties after they are built. Also, since default behaviors are now tested in the FAB Theme test, some default tests in the FAB test no longer applied and were removed.

The themable properties are:
-backgroundColor
-foregroundColor
-elevation
-disabledElevation
-highlightElevation
-shape
2019-03-20 19:43:56 -04:00
Alexandre Ardhuin
a6af422874
some spaces formatting (#29452)
* some space formattings

* always use blocks in if-else if a block is used

* format spaces in for and while

* allow multiline if conditions

* fix missing space
2019-03-20 23:23:31 +01:00
Marco Scannadinari
4418ec467b Adjust remaining Cupertino route animations to match native (#28597) 2019-03-20 14:53:22 -07:00
Shi-Hao Hong
cf12c31465
DropdownButton Icon customizability (#29572) 2019-03-20 13:38:40 -07:00
Dan Field
5764aee67c
Revert "Reland composite physical layers on all platforms (#29532)" (#29623)
This reverts commit 803b15e0db9606f6f4c84925f9c6cb369be72394.
2019-03-19 15:17:05 -07:00
Phil Quitslund
8707f1f335
make literals const for @immutable constructors (#29619) 2019-03-19 14:17:37 -07:00
Hans Muller
b3046a6c67
Update progress indicator API docs (#29564) 2019-03-19 14:13:11 -07:00
liyuqian
79e3bf4ad3
Manually roll engine to 5088735e5 (#29566)
Need this manual roll because of golden changes.

flutter/engine@5088735e5 Clip to clip_rect instead of paint bounds (flutter/engine#8183)
flutter/engine@8818a6c41 Roll src/third_party/skia 2c043c288169..4a522b7e916c (3 commits) (flutter/engine#8201)
flutter/engine@048d70bc0 Support dartdevc, dart2js with shared source files, dartdevc sdk (flutter/engine#8105)
flutter/engine@e0782dec7 Roll src/third_party/skia 576b2a5596bc..2c043c288169 (2 commits) (flutter/engine#8200)
2019-03-18 17:34:20 -07:00
Filip Hracek
644f499ab7
Add sample to forEachTween (#29195)
The current documentation for `AnimatedWidgetBaseState.forEachTween` is exhaustive but a little hard to grok. This dartdoc example provides some clarity.
2019-03-18 14:37:57 -07:00
Dan Field
803b15e0db
Reland composite physical layers on all platforms (#29532)
Reland composite physical layers and update tests
2019-03-18 12:30:02 -07:00
Francisco Magdaleno
c163ed9618
Adds macOS raw keyboard mapping (#29231) 2019-03-18 11:12:04 -07:00
Ivan Schütz
bd697d4b5a Improve Navigator documentation (#29540) 2019-03-18 10:31:02 -07:00
liyuqian
0bf0f5c1da
Add doc about MediaQuery to Chip (#29445)
Fixes https://github.com/flutter/flutter/issues/21232
2019-03-15 22:03:13 -07:00
Shi-Hao Hong
2a21c1a188
add assert if length of TabController and number of tabs do not match (#29332) 2019-03-15 14:25:56 -07:00
Anthony
87e6beecad Fix Flex class docs by replacing 'vertical space' with 'space on its main axis' so that the language fits both column and row. (#29057) 2019-03-15 13:33:51 -07:00
Kate Lovett
71bd5d4f55
Sample code for Align class. ref:#13637 (#29442) 2019-03-15 13:32:03 -07:00
Mouad Debbar
5787fc3ae2
Fix text selection when user is dragging in the opposite direction (#29395) 2019-03-15 13:09:27 -07:00
xster
fa149eea9b
Cupertino localization step 1: add an English arb file (#29200) 2019-03-15 12:10:35 -07:00
liyuqian
0067efca61 No shrinking for BackdropFilter's cull rect (#28174)
* No shrinking for BackdropFilter's cull rect

This will be a breaking change. Our old behavior may generate confusions
for a sample app like our added golden test: Skia will shrink the cull
rect (and thus the filtered area) to the text. The new behavior will
fill the BackdropFilter to its parent/ancestor clip. This is more
in align with our clip behaviors (no clip by default).

If this breaks your app, wrap the BackdropFilter with a ClipRect.

[wip] The golden images are not uploaded yet. I'll wait for the initial
round of review to approve the golden test before uploading them.

* Statically define the callback

* Add TODO to remind the hacking code removal

* Nit fix

* Update goldens
2019-03-15 09:42:11 -07:00
Edman P. Anjos
bd50007f16 Paint backgroundColor in CircularProgressIndicator (#28004) 2019-03-15 09:26:39 -07:00
Mike Leonhard
d6cc949970 [cupertino_icons] Add circle and circle_filled, for radio buttons. (#29407) 2019-03-15 08:57:45 -07:00
Efthymis Sarmpanis
955e004a13 Throw assertion error when a Hero has a Hero child. (#28470) 2019-03-15 08:55:27 -07:00
Brian Wilkerson
439fbbe69e
Update SDK constraints to reflect the fact that set literals are being used (#29389) 2019-03-15 07:53:27 -07:00
Jonah Williams
73fb457cae
Disable widget inspector scroll test (#29403) 2019-03-14 23:51:18 -07:00
Dan Field
a29906d5f5
Roll engine to 403337ebb893380101d1fa9cc435ce9b6cfeb22c (#29377)
* Manual engine roll with goldens
2019-03-14 19:06:23 -07:00
Justin McCandless
6d8f539971
Text field height attempt 2 (#29250)
Adds the `minLines` and `expands` parameters for controlling text height.  The original PR was reverted, so this one contains a few extra fixes for the tests that were broken.
2019-03-14 18:01:11 -07:00
Jonah Williams
b74b960356
Skip Dialog interaction test (#29385) 2019-03-14 14:43:20 -07:00
Jonah Williams
8d5cb658fb
Revert "Manual engine roll with goldens (#29363)" (#29374)
This reverts commit c2e08913c063dea04f21b3e2db777146862c2f15.
2019-03-14 13:07:06 -07:00
Dan Field
c2e08913c0
Manual engine roll with goldens (#29363) 2019-03-14 11:35:01 -07:00
Shi-Hao Hong
c942ed4813
Implement labelPadding configuration in TabBarTheme (#29183) 2019-03-14 09:26:44 -07:00
Hans Muller
4e84256642
Error message when TextSelectionOverlay finds no Overlay (#29329) 2019-03-14 09:19:47 -07:00
rami-a
4feefa3c9a
[Material] Fix radio ink ripple to be centered (#28845) 2019-03-14 10:21:03 -04:00
Dan Field
7ac2486a4c Revert "Always composite PhysicalModels (#28919)" (#29314)
This reverts commit 58fb183298643bb0c57acd0b50b2480e9d1d5779.
2019-03-13 22:19:31 -04:00