Michael Klimushyn
ed88d0a44d
Change SemanticsNode#children lists to be non-null ( #10952 )
...
Prevents NPEs and simplifies the code needed to handle these collections. There doesn't seem to have been a meaningful difference between null and empty collection here. The specific crash was happening when `object.scrollChildren > 0` while `object.childrenInHitTestOrder == null`, which looks like it may be a bug on its own and probably needs further investigation.
2019-08-12 17:16:59 -07:00
Mouad Debbar
8849d3092d
Add multi-line flag to semantics ( #9850 )
2019-07-17 09:51:09 -07:00
chunhtai
9ab6550b45
Introduce read only text field semantics ( #9281 )
2019-06-19 09:42:23 -07:00
Dan Field
069e38a0b9
Document AccessibilityBridge.java ( #9237 )
2019-06-07 16:00:38 -07:00
Dan Field
5d1c1a027e
Remove more asserts and fix a11y check ( #8896 )
2019-05-08 01:19:24 -07:00
Dan Field
5a045dd1f7
Log instead of throwing ( #8881 )
2019-05-07 11:08:38 -07:00
Dan Field
7ce2666e54
Guard Android logs ( #8824 )
2019-05-03 14:32:29 -07:00
Dan Field
480844608c
Remove asserts and add BuildConfig ( #8821 )
2019-05-02 17:30:19 -07:00
Amir Hardon
345ae7d373
Delegate a11y events and action to/from embedded Android platform views. ( #8250 )
...
Delegate a11y events and action to/from embedded Android platfrom views.
This handles delegation of:
* AccessibilityNodeProvider#performAction
* ViewGroup#requestSendAccessibilityEvent
* View#onHoverEvent
Additionally updates the currently input accessibility focused node state that is
tracked by the a11y bridge when an embedded view's node is focused.
2019-03-25 14:26:49 -07:00
Amir Hardon
06635d38a9
Mirror Android platform views a11y tree in the Flutter a11y tree. ( #8237 )
...
This PR mirrors virtual a11y tree of embedded platform views in the Flutter
a11y tree.
Non virtual hierarchies are not currently supported.
Only works on Android versions earlier than Android P as it relies on
reflection access to hidden system APIs which cannot be done starting
Android P.
A11y is not yet working as we also need to delegate a11y events from the
platform view to the FlutterView. This will be done in a following PR to
keep the change size a little saner.
2019-03-21 15:26:44 -07:00
Matt Carroll
188adf7e5e
Removed Activity reference from AccessibilityBridge by using a View for insets instead of the Activity ( #18115 ) ( #8231 )
2019-03-20 14:18:34 -07:00
Amir Hardon
6a8a45fc4f
Have the AccessibilityBridge attach/detach itself to the ( #8229 )
...
PlatformViewsDelegate.
Since onDetachedFromWindow can be called after the activity was
destroyed, the previous call to detach the accessibility bridge could
have crash as the NativeFlutterView was already null.
2019-03-20 12:26:30 -07:00
Amir Hardon
45f69ac471
Plumb a reference of PlatformViewsController and AccessibilityBridge to each other ( #8208 )
...
This is in preparation for implementing platform views a11y on Android.
And e2e working prototype is available here: https://github.com/amirh/engine/tree/a11y_hacks
flutter/flutter#19418
2019-03-19 15:48:45 -07:00
Matt Carroll
09db84fad6
Android Embedding PR 19: Add accessibility to new FlutterView. ( #8109 )
2019-03-14 14:24:49 -07:00
Michael Goderbauer
bd0f9085e5
Adds a platfromViewId to SemanticsNode ( #8055 )
2019-03-11 11:30:35 -07:00
Jonah Williams
4e54bc93ca
Guard initialization of touch exploration listener ( #8103 )
2019-03-09 15:07:26 -08:00
Matt Carroll
718329ce6e
Android Embedding PR 17: Clarify AccessibilityBridge and move logic out of FlutterView. ( #8061 )
2019-03-08 18:09:04 -08:00
Michael Klimushyn
1d10e0eb67
Guard against NewAPI failures ( #8048 )
...
Adds minimum SDK checks around minimum APIs.
flutter/flutter#28848
2019-03-08 13:33:58 -08:00
Matt Carroll
2f4a38dbd3
Android embedding refactor pr3 add remaining systemchannels ( #7892 )
...
Merging back in after reversion. Fixed some messaging issues in FlutterNativeView and corrected some message parsing.
2019-02-20 17:05:31 -08:00
Dan Field
6d7eb52185
Revert "Android embedding refactor pr3 add remaining systemchannels ( #7874 )" ( #7886 )
...
This reverts commit f4fba6d7110338caf3878cf42e26e17744108d00.
2019-02-20 11:18:12 -08:00
Matt Carroll
f4fba6d711
Android embedding refactor pr3 add remaining systemchannels ( #7874 )
2019-02-19 15:51:13 -08:00
Chris Bracken
163a2fd5e1
Revert "Android embedding refactor pr3 add remaining systemchannels ( #7738 )" ( #7849 )
...
From build log:
```
../../flutter/shell/platform/android/io/flutter/view/FlutterView.java:95: error: cannot find symbol
private final LocalizationChannel localizationChannel;
^
symbol: class LocalizationChannel
location: class FlutterView
../../flutter/shell/platform/android/io/flutter/view/FlutterView.java:172: error: cannot find symbol
localizationChannel = new LocalizationChannel(dartExecutor);
^
symbol: class LocalizationChannel
location: class FlutterView
2 errors
```
This reverts commit 256db4bc23b7931509233df0dc04e44e16608229.
2019-02-15 15:03:19 -08:00
Matt Carroll
256db4bc23
Android embedding refactor pr3 add remaining systemchannels ( #7738 )
2019-02-15 13:45:24 -08:00
Dan Field
5ca8aadaa2
Announce in/out of list ( #6918 )
...
* Support in/out of list announcements on Android
2019-01-07 13:36:20 -08:00
Todd Volkert
f79f7f6312
Allow inferred types using diamond syntax ( #7237 )
2018-12-17 16:35:10 -08:00
Jimmy Casey
f986a12e20
Correct spelling in doc comments ( #7179 )
...
Applies spelling corrections to accessibility-related doc comments and in the
license tool.
2018-12-16 12:51:00 -08:00
Dan Field
ea4bbbd440
Avoid announcing text field when it lacks a11y focus ( #6830 )
...
* Avoid announcing text field when it lacks a11y focus
2018-11-12 16:08:59 -08:00
Michael Goderbauer
70a1106b50
Unify copyright lines ( #6757 )
2018-11-07 12:24:35 -08:00
Jonah Williams
cf75289b68
TextField is only a live region when it has input focus ( #6649 )
2018-10-25 08:37:49 -07:00
Jonah Williams
436f9707b9
Add version check for dismissable ( #6522 )
2018-10-12 15:47:11 -07:00
Jonah Williams
647302a287
Correct issues in visible children determination ( #6455 )
...
* fix off by one
* add documentation on counting for setToIndex
2018-10-08 11:05:09 -07:00
liyuqian
90b1023c84
Remove unused imports and variables ( #6437 )
...
This is discovered in the new Google3 checks. It should not block our
roll but it's nice to fix them.
2018-10-04 16:01:49 -07:00
Jonah Williams
ae4db4469f
Ensure setViewIdResourceName has the correct version guard ( #6404 )
2018-10-03 17:44:32 -07:00
Jonah Williams
a785b25f4a
do not count Hidden nodes at the beginning of the scrollable ( #6381 )
2018-10-01 11:15:22 -07:00
Jonah Williams
77c30caddf
make sure we dont set live regionin api level < 18 ( #6375 )
2018-09-27 23:24:54 -07:00
Gary Qian
f3d51b0cfb
Fix Top, Left, and Right padding for fullscreen android apps. ( #6282 )
...
* Fix Top, Left, and Right padding for fullscreen apps.
* Fix minor nits and comments, simple logic inversion
2018-09-19 18:09:10 -07:00
Jonah Williams
272be27f70
update live region to trigger on label change, remove manual trigger ( #6248 )
2018-09-14 09:10:59 -07:00
Jonah Williams
abd918eb61
Add scrollIndex and scrollChildren to semantics, add Android implementation ( #6239 )
2018-09-13 10:28:27 -07:00
Jonah Williams
c867305c30
Unconditionally set resource id to empty string ( #6096 )
2018-08-27 10:54:07 -07:00
Jonah Williams
c23690f0d7
use setContentDescription for controls on Android ( #6050 )
2018-08-20 09:30:13 -07:00
Todd Volkert
7f083e54fe
Don't implicitly fall through in switch statement ( #5964 )
2018-08-07 13:18:26 -07:00
Jonah Williams
c7ce6dd69c
Apply translation to accessibility tree when in landscape ( #5950 )
2018-08-07 13:09:18 -07:00
Jonah Williams
a5215ce500
Add hasImplicitScrolling SemanticFlag and support in Android bridge ( #5941 )
2018-08-06 13:57:00 -07:00
Jonah Williams
236d633a49
Add word movement granularities to android ( #5902 )
2018-07-30 17:53:17 -07:00
Jonah Williams
d559afb320
Support customizing standard accessibility actions on Android. ( #5823 )
2018-07-25 15:26:02 -07:00
Jonah Williams
96f5f5b96c
Semantics framework updates ( #5601 )
2018-07-20 11:17:59 -07:00
Jonah Williams
48d6e1f891
Custom accessibility (local context) action support for iOS and Android. ( #5597 )
2018-07-11 10:27:50 -07:00
amirh
51785d244d
Remove unused Java imports ( #5663 )
2018-07-03 09:21:03 -07:00
Mehmet Fidanboylu
d7e3f2d6e7
Fix lint errors to prepare for building Android files in Google ( #5440 )
2018-06-01 10:16:50 -07:00
Michael Goderbauer
47f4a2aad4
Remove assert for unsupported SemanticsEvents ( #5349 )
...
Not all platforms are expected to handle all SemanticsEvents. Therefore, it is ok to just drop unsupported events on the floor.
2018-05-23 16:05:15 -07:00
